mm/page_alloc: mark pages freed by __free_pages_core() as not tagged
PATCH v2 1/1 mm/page_alloc: mark pages freed by __free_pages_core() as not tagged
From: "Zenghui Yu (Huawei)" <[email protected]>
Onlining hotplugged memory (e.g., a dev_dax device bound to kmem) with CONFIG_MEM_ALLOC_PROFILING_DEBUG triggers:
alloc_tag was not set
WARNING: ./include/linux/alloc_tag.h:166 at __pgalloc_tag_sub+0x1fc/0x254 Call trace: __pgalloc_tag_sub+0x1fc/0x254 (P) __free_pages_ok+0x14c/0x6ac __free_pages_core+0xa8/0x188 generic_online_page+0x14/0x20 online_pages+0x220/0x3b0 memory_subsys_online+0xfc/0x198 device_online+0x58/0xe0 state_store+0xf0/0xf8
Pages entering the buddy through __free_pages_core() have never been allocated, so their allocation tag references are NULL. The free path, __free_pages_prepare() -> pgalloc_tag_sub(), expects a valid tag or a CODETAG_EMPTY mark and warns otherwise. Paths feeding never-allocated pages into the buddy are therefore expected to mark them with clear_page_tag_ref() first, like init_cma_reserved_pageblock() and free_reserved_pages() do; of __free_pages_core()'s callers only memblock_free_pages() clears the tag ref itself, and the hotplug onlining path was missed.
Since all __free_pages_core() callers free never-allocated pages, mark the head page as not tagged in __free_pages_core() itself instead of relying on each caller, and drop the now-redundant clearing from memblock_free_pages().
---
* From v1 [1]:
- Clear the tag ref once on the head page in __free_pages_core() for both meminit contexts, instead of once per page in the MEMINIT_HOTPLUG loop (Sashiko)
[1] https://lore.kernel.org/[email protected]
mm/mm_init.c | 2 -- mm/page_alloc.c | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-)
mm/mm_init.c +0 -2
@@ -2475,8 +2475,6 @@ void __init memblock_free_pages(unsigned long pfn, unsigned int order)return ; } -/* pages were reserved and not allocated */ -clear_page_tag_ref (page);__free_pages_core (page, order,MEMINIT_EARLY ); }
mm/page_alloc.c +3 -0
@@ -1617,6 +1617,9 @@ void __meminit __free_pages_core(struct page *page, unsigned int order,atomic_long_add (nr_pages, &page_zone (page)->managed_pages); } +/* pages were never allocated */ +clear_page_tag_ref (page); +if (page_contains_unaccepted (page, order)) {if (order ==MAX_PAGE_ORDER &&__free_unaccepted (page))return ;
Signature · 1 line
2.56.0
Quoted 27 lines · Zenghui Yu
From: "Zenghui Yu (Huawei)" <[email protected]>
Onlining hotplugged memory (e.g., a
dev_daxdevice bound to kmem) withCONFIG_MEM_ALLOC_PROFILING_DEBUGtriggers:
alloc_tagwas not setWARNING: ./include/linux/alloc_tag.h:166 at __pgalloc_tag_sub+0x1fc/0x254 Call trace: __pgalloc_tag_sub+0x1fc/0x254 (P) __free_pages_ok+0x14c/0x6ac __free_pages_core+0xa8/0x188 generic_online_page+0x14/0x20 online_pages+0x220/0x3b0 memory_subsys_online+0xfc/0x198 device_online+0x58/0xe0 state_store+0xf0/0xf8Pages entering the buddy through
__free_pages_core()have never been allocated, so their allocation tag references are NULL. The free path,__free_pages_prepare()->pgalloc_tag_sub(), expects a valid tag or aCODETAG_EMPTYmark and warns otherwise. Paths feeding never-allocated pages into the buddy are therefore expected to mark them withclear_page_tag_ref()first, likeinit_cma_reserved_pageblock()andfree_reserved_pages()do; of __free_pages_core()'s callers onlymemblock_free_pages()clears the tag ref itself, and the hotplug onlining path was missed.
Quoted 6 lines
Since all
__free_pages_core()callers free never-allocated pages, mark the head page as not tagged in__free_pages_core()itself instead of relying on each caller, and drop the now-redundant clearing frommemblock_free_pages().Signed-off-by Zenghui Yu (Huawei) <[email protected]>