Skip to contentSkip to conversation

dt-bindings: input: mediatek,mt6779-keypad: add the MT8173 keypad

PATCH Applied Ryan Brue 5 participants 6 messages Sep 16 – Nov 2

Subsystems (5)
lore
Share & tools
lore

Ryan Brue

author
#0 lore raw

PATCH 1/1 dt-bindings: input: mediatek,mt6779-keypad: add the MT8173 keypad

MT8173's keypad controller is the same block this driver already handles. Its register map agrees offset for offset with the MT6779 one -- STA 0x00, MEM1..MEM5 0x04..0x14, DEBOUNCE 0x18, SEL 0x20, EN 0x24 -- and mt6779-keypad drives it with no code change, so the node only needs the fallback compatible in second position. Add the mt8173 string to the existing enum, which is what mt6873, mt8183, mt8365 and mt8516 already do.

Verified on an MT8173 board (Amazon Fire HD 10 2017): the volume rocker reports through mt6779-keypad with no driver modification.

Assisted-by LLM

---
This is the binding half only. The board device tree that uses it, an Amazon Fire HD 10 (2017), is not upstream yet and comes with the rest of that board's nodes later; adding the compatible first keeps that submission from carrying a forward reference.

No driver change goes with it. mt6779-keypad matches on the fallback, which is how mt8183, mt8365 and mt8516 bind today -- only mt6779 and mt6873 are in the driver's own match table.

---
 Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml +1 -0
index 914dd3283df3..b45dbf805ac8 100644
@@ -27,6 +27,7 @@ properties:
       - items:
           - enum:
               - mediatek,mt6873-keypad
+              - mediatek,mt8173-keypad
               - mediatek,mt8183-keypad
               - mediatek,mt8365-keypad
               - mediatek,mt8516-keypad

---
base-commit: fd73f4a6659897191fa0d40695fe370925dd3780
change-id: 20260914-rbrue-suez-upstreaming-mt8173-keypad-fddc316ae098

Best regards,

Signature · 1 line
Ryan Brue <[email protected]>
maintainer Reviewed-by on v1 1/1
#1 lore raw

Hi Ryan,

Thank you for the patch.

Quoted 7 lines · Ryan Brue

MT8173's keypad controller is the same block this driver already handles. Its register map agrees offset for offset with the MT6779 one -- STA 0x00, MEM1..MEM5 0x04..0x14, DEBOUNCE 0x18, SEL 0x20, EN 0x24 -- and mt6779-keypad drives it with no code change, so the node only needs the fallback compatible in second position. Add the mt8173 string to the existing enum, which is what mt6873, mt8183, mt8365 and mt8516 already do.

Quoted 5 lines

Verified on an MT8173 board (Amazon Fire HD 10 2017): the volume rocker reports through mt6779-keypad with no driver modification.

Assisted-by LLM
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Ryan Brue
Quoted 7 lines · Ryan Brue

MT8173's keypad controller is the same block this driver already handles. Its register map agrees offset for offset with the MT6779 one -- STA 0x00, MEM1..MEM5 0x04..0x14, DEBOUNCE 0x18, SEL 0x20, EN 0x24 -- and mt6779-keypad drives it with no code change, so the node only needs the fallback compatible in second position. Add the mt8173 string to the existing enum, which is what mt6873, mt8183, mt8365 and mt8516 already do.

Quoted 5 lines

Verified on an MT8173 board (Amazon Fire HD 10 2017): the volume rocker reports through mt6779-keypad with no driver modification.

Assisted-by LLM
Quoted 33 lines

---
This is the binding half only. The board device tree that uses it, an Amazon Fire HD 10 (2017), is not upstream yet and comes with the rest of that board's nodes later; adding the compatible first keeps that submission from carrying a forward reference.

No driver change goes with it. mt6779-keypad matches on the fallback, which is how mt8183, mt8365 and mt8516 bind today -- only mt6779 and mt6873 are in the driver's own match table.

---
  Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml | 1 +
  1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml +1 -1
index 914dd3283df3..b45dbf805ac8 100644
@@ -27,6 +27,7 @@ properties:
        - items:
            - enum:
                - mediatek,mt6873-keypad
+              - mediatek,mt8173-keypad
                - mediatek,mt8183-keypad
                - mediatek,mt8365-keypad
                - mediatek,mt8516-keypad
 
---

base-commit: fd73f4a6659897191fa0d40695fe370925dd3780
change-id: 20260914-rbrue-suez-upstreaming-mt8173-keypad-fddc316ae098

Best regards,
--
Ryan Brue <[email protected]>

maintainer Acked-by on v1 1/1
#3 lore raw
In reply to Ryan Brue
Quoted 18 lines · Ryan Brue

MT8173's keypad controller is the same block this driver already handles. Its register map agrees offset for offset with the MT6779 one -- STA 0x00, MEM1..MEM5 0x04..0x14, DEBOUNCE 0x18, SEL 0x20, EN 0x24 -- and mt6779-keypad drives it with no code change, so the node only needs the fallback compatible in second position. Add the mt8173 string to the existing enum, which is what mt6873, mt8183, mt8365 and mt8516 already do.

Verified on an MT8173 board (Amazon Fire HD 10 2017): the volume rocker reports through mt6779-keypad with no driver modification.

Assisted-by LLM

---
This is the binding half only. The board device tree that uses it, an Amazon Fire HD 10 (2017), is not upstream yet and comes with the rest of that board's nodes later; adding the compatible first keeps that submission from carrying a forward reference.

Quoted 7 lines

No driver change goes with it. mt6779-keypad matches on the fallback, which is how mt8183, mt8365 and mt8516 bind today -- only mt6779 and mt6873 are in the driver's own match table.

---
 Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml | 1 +
 1 file changed, 1 insertion(+)
author
#4 lore raw
In reply to Ryan Brue

Hi Dmitry,

Gentle ping on this one. It has an ack from Rob and reviews from Mattijr and AngeloGioacchino. The device tree for the Amazon Fire HD 10 (2017) that I'm posting for 7.5 uses it for the volume keys. The patch should apply to input/next with a three-way merge. I can resend it rebased if that's easier.

Thank you, best regards,

Ryan Brue

maintainer Applied
#5 lore raw

Hi Ryan,

Quoted 6 lines · Ryan Brue

Hi Dmitry,

Gentle ping on this one. It has an ack from Rob and reviews from Mattijr and AngeloGioacchino. The device tree for the Amazon Fire HD 10 (2017) that I'm posting for 7.5 uses it for the volume keys. The patch should apply to input/next with a three-way merge. I can resend it rebased if that's easier.

Applied, sorry for the delay.

Signature · 1 line
Dmitry