staging: axis-fifo: fix integer underflow in TX size check
PATCH 1/1 staging: axis-fifo: fix integer underflow in TX size check
fifo->tx_fifo_depth is an unsigned int parsed from the devicetree property "xlnx,tx-fifo-depth" with no lower-bound validation. The write() packet-size check subtracts 4 from it:
words_to_write > (fifo->tx_fifo_depth - 4)
If tx_fifo_depth is less than 4, this subtraction underflows and wraps around to a value near UINT_MAX, so the check that is supposed to reject oversized writes never triggers, regardless of how large words_to_write actually is.
Reject the write up front when tx_fifo_depth is below the minimum required by the hardware, before the subtraction can underflow.
--- drivers/staging/axis-fifo/axis-fifo.c | 1 + 1 file changed, 1 insertion(+)
drivers/staging/axis-fifo/axis-fifo.c +1 -0
@@ -228,6 +228,7 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,* raised, which requires a reset of the TX circuit to recover. */ if (!words_to_write || (len %sizeof (u32)) || + fifo->tx_fifo_depth <4 || (words_to_write > (fifo->tx_fifo_depth -4 )))return -EINVAL ;
Signature · 1 line
2.43.0
Quoted 12 lines · Maritu Hone
fifo->tx_fifo_depthis an unsigned int parsed from the devicetree property "xlnx,tx-fifo-depth" with no lower-bound validation. Thewrite()packet-size check subtracts 4 from it:words_to_write > (fifo->tx_fifo_depth - 4)If
tx_fifo_depthis less than 4, this subtraction underflows and wraps around to a value nearUINT_MAX, so the check that is supposed to reject oversized writes never triggers, regardless of how largewords_to_writeactually is.
Quoted 6 lines
Reject the write up front when
tx_fifo_depthis below the minimum required by the hardware, before the subtraction can underflow.Fixes 52ff2b840bc7 ("staging: axis-fifo: fix maximum TX packet length check")Signed-off-by Maritu Hone <[email protected]>---
This patch has been rejected many times before. Best to do a search on lore.kernel.org before sending patches.
Device trees are trusted. I wonder if the AI is actually searching the device trees and not finding anything, so it thinks maybe the device tree is wrong?
$ git grep xlnx,tx-fifo-depth | cat drivers/staging/axis-fifo/axis-fifo.c: ret = of_property_read_u32(node, "xlnx,tx-fifo-depth", drivers/staging/axis-fifo/axis-fifo.txt:- xlnx,tx-fifo-depth: Depth of TX FIFO in words drivers/staging/axis-fifo/axis-fifo.txt: xlnx,tx-fifo-depth = <0x8000>;
regards,
dan carpenter