staging: greybus: audio_manager: add newline to sysfs_emit formats
Subsystems (3)
PATCH 1/1 staging: greybus: audio_manager: add newline to sysfs_emit formats
According to sysfs guidelines and checkpatch SYSFS_EMIT rule, sysfs show functions should terminate outputs with a newline. The show functions in audio_manager_module.c omit the newline character from their sysfs_emit() format strings.
Add a terminating newline to all sysfs_emit() format strings in gb_audio_module_*_show() functions.
--- drivers/staging/greybus/audio_manager_module.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/greybus/audio_manager_module.c +6 -6
@@ -75,7 +75,7 @@ static void gb_audio_module_release(struct kobject *kobj)static ssize_t gb_audio_module_name_show (struct gb_audio_manager_module *module,struct gb_audio_manager_module_attribute *attr,char *buf) { -return sysfs_emit (buf,"%s" , module->desc.name); +return sysfs_emit (buf,"%s\n" , module->desc.name); } static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute =
@@ -84,7 +84,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute =static ssize_t gb_audio_module_vid_show (struct gb_audio_manager_module *module,struct gb_audio_manager_module_attribute *attr,char *buf) { -return sysfs_emit (buf,"%d" , module->desc.vid); +return sysfs_emit (buf,"%d\n" , module->desc.vid); } static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute =
@@ -93,7 +93,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute =static ssize_t gb_audio_module_pid_show (struct gb_audio_manager_module *module,struct gb_audio_manager_module_attribute *attr,char *buf) { -return sysfs_emit (buf,"%d" , module->desc.pid); +return sysfs_emit (buf,"%d\n" , module->desc.pid); } static struct gb_audio_manager_module_attribute gb_audio_module_pid_attribute =
@@ -103,7 +103,7 @@ static ssize_t gb_audio_module_intf_id_show(struct gb_audio_manager_module *modustruct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.intf_id); + return sysfs_emit(buf, "%d\n", module->desc.intf_id); } static struct gb_audio_manager_module_attribute
@@ -114,7 +114,7 @@ static ssize_t gb_audio_module_ip_devices_show(struct gb_audio_manager_module *mstruct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.ip_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.ip_devices); } static struct gb_audio_manager_module_attribute
@@ -125,7 +125,7 @@ static ssize_t gb_audio_module_op_devices_show(struct gb_audio_manager_module *mstruct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.op_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.op_devices); } static struct gb_audio_manager_module_attribute
Signature · 1 line
2.34.1
Quoted 10 lines · Rishiraj Rajgor
According to sysfs guidelines and checkpatch
SYSFS_EMITrule, sysfs show functions should terminate outputs with a newline. The show functions inaudio_manager_module.comit the newline character from theirsysfs_emit()format strings.Add a terminating newline to all
sysfs_emit()format strings in gb_audio_module_*_show() functions.Signed-off-by Rishiraj Rajgor <[email protected]>---
No, see the mail archives for why.
regards,
dan carpenter