Skip to contentSkip to conversation

menuconfig color sanity

PATCH In review jeff gerard 9 participants 9 messages Jan 8, 2003

lore
Share & tools
lore

jeff gerard

author
#0 lore raw

PATCH 1/1 menuconfig color sanity

hi,

using yellow and green text with a "white" background in menuconfig works all right on console, but it looks like crap under xterm, rxvt, etc. no matter whose fault that is, the trivial patch below makes things more readable without any major change in appearance. applies to 2.4 and 2.5.

now you can stop wondering about support for "lug and play", "mateur radio", and "elephony" in the linux kernel.

jeff

scripts/lxdialog/colors.h +6 -6
@@ -41 +41 @@
-#define TITLE_FG                     COLOR_YELLOW
+#define TITLE_FG                     COLOR_RED

@@ -93 +93 @@
-#define POSITION_INDICATOR_FG        COLOR_YELLOW
+#define POSITION_INDICATOR_FG        COLOR_RED

@@ -113 +113 @@
-#define TAG_FG                       COLOR_YELLOW
+#define TAG_FG                       COLOR_MAGENTA

@@ -121 +121 @@
-#define TAG_KEY_FG                   COLOR_YELLOW
+#define TAG_KEY_FG                   COLOR_MAGENTA

@@ -137 +137 @@
-#define UARROW_FG                    COLOR_GREEN
+#define UARROW_FG                    COLOR_RED

@@ -141 +141 @@
-#define DARROW_FG                    COLOR_GREEN
+#define DARROW_FG                    COLOR_RED
#1 lore raw

On Wednesday 08 January 2003 11:47, jeff gerard wrote:

Hi Jeff,

Quoted 6 lines

using yellow and green text with a "white" background in menuconfig works all right on console, but it looks like crap under xterm, rxvt, etc. no matter whose fault that is, the trivial patch below makes things more readable without any major change in appearance. applies to 2.4 and 2.5. now you can stop wondering about support for "lug and play", "mateur radio", and "elephony" in the linux kernel.

huh? I can see Plug and Play, Amateur Radio and Telephony very well also in a XTERM etc. I don't know where you have any problems with those colors.

Prolly your xterm etc. are faulty ;)

ciao, Marc

#2 lore raw
Quoted 9 lines · Marc-Christian Petersen
Quoted 6 lines

using yellow and green text with a "white" background in menuconfig works all right on console, but it looks like crap under xterm, rxvt, etc. no matter whose fault that is, the trivial patch below makes things more readable without any major change in appearance. applies to 2.4 and 2.5. now you can stop wondering about support for "lug and play", "mateur radio", and "elephony" in the linux kernel.

huh? I can see Plug and Play, Amateur Radio and Telephony very well also in a XTERM etc. I don't know where you have any problems with those colors. Prolly your xterm etc. are faulty ;)

Different monitors, different graphic cards, different eyes. All these things offer variation in colour, and yellow text on a light grey background wasn't exactly a wise choice from a readability point of view.

Dave

Signature · 1 line
| Dave Jones.        http://www.codemonkey.org.uk
#3 lore raw
In reply to jeff gerard
Quoted 9 lines · jeff gerard

hi,

using yellow and green text with a "white" background in menuconfig works all right on console, but it looks like crap under xterm, rxvt, etc. no matter whose fault that is, the trivial patch below makes things more readable without any major change in appearance. applies to 2.4 and 2.5.

now you can stop wondering about support for "lug and play", "mateur radio", and "elephony" in the linux kernel.

Try that on a mono monitor before merging it

#4 lore raw
In reply to jeff gerard
Quoted 7 lines · jeff gerard

using yellow and green text with a "white" background in menuconfig works all right on console, but it looks like crap under xterm, rxvt, etc. no matter whose fault that is, the trivial patch below makes things more readable without any major change in appearance. applies to 2.4 and 2.5.

now you can stop wondering about support for "lug and play", "mateur radio", and "elephony" in the linux kernel.

Man, did you look at this on a console? That is uglier than a hedgehog's asshole! Good idea, poor implementation. Please retry, the default colors are not as bad on an xterm as the new colors on a console. And with small memory machines I sure don't build kernels using X!

Signature · 3 lines
bill davidsen <[email protected]>
  CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.
#5 lore raw

Re: [PATCH][TRIVIAL] menuconfig color sanityExpires:

Followup to:  <[email protected]>
By author:    Bill Davidsen <[email protected]>
In newsgroup: linux.dev.kernel
Quoted 6 lines

Man, did you look at this on a console? That is uglier than a hedgehog's asshole! Good idea, poor implementation. Please retry, the default colors are not as bad on an xterm as the new colors on a console. And with small memory machines I sure don't build kernels using X!

Also, whatever color set is chosen: make sure it works on a 512-character font console, which doesn't have the high-intensity colors.

-hpa

Signature · 3 lines
<[email protected]> at work, <[email protected]> in private!
"Unix gives you enough rope to shoot yourself in the foot."
http://www.zytor.com/~hpa/puzzle.txt	<[email protected]>
#6 lore raw
In reply to jeff gerard
Quoted 2 lines

using yellow and green text with a "white" background in menuconfig works all right on console, but it looks like crap under xterm, rxvt, etc. no

It looks fine on Eterm, the only real X terminal :)

Regards
Josh

#7 lore raw
Quoted 2 lines

using yellow and green text with a "white" background in menuconfig works all right on console

I have seen the original problem, where the first letter is not visible in an xterm.

Just add a colour/monochrome toggle, that way people can choose which they prefer.

John.

#8 lore raw
Quoted 8 lines · John Bradford
Quoted 2 lines

using yellow and green text with a "white" background in menuconfig works all right on console

I have seen the original problem, where the first letter is not visible in an xterm.

Just add a colour/monochrome toggle, that way people can choose which they prefer.

'export TERM=xterm-mono' works fine here

j.

Signature · 1 line
toyota power: http://indigoid.net/