net/ena: fix false indication of bad L4 Rx csums
PATCH 1/1 net/ena: fix false indication of bad L4 Rx csums
Add checking of l4_csum_checked and frag flags before checking the l4_csum_error flag.
In case of IP fragment/unchecked L4 csum - add PKT_RX_L4_CKSUM_UNKNOWN flag to the indicated mbuf.
--- drivers/net/ena/ena_ethdev.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/net/ena/ena_ethdev.c +8 -2
@@ -272,9 +272,14 @@ static inline void ena_rx_mbuf_prepare(struct rte_mbuf *mbuf,else if (ena_rx_ctx->l3_proto ==ENA_ETH_IO_L3_PROTO_IPV6 ) packet_type |=RTE_PTYPE_L3_IPV6 ; -if (unlikely (ena_rx_ctx->l4_csum_err)) - ol_flags |=PKT_RX_L4_CKSUM_BAD ; +if (!ena_rx_ctx->l4_csum_checked) + ol_flags |=PKT_RX_L4_CKSUM_UNKNOWN ; +else +if (unlikely (ena_rx_ctx->l4_csum_err) && !ena_rx_ctx->frag) + ol_flags |=PKT_RX_L4_CKSUM_BAD ; +else + ol_flags |=PKT_RX_L4_CKSUM_UNKNOWN ; +if (unlikely (ena_rx_ctx->l3_csum_err)) ol_flags |=PKT_RX_IP_CKSUM_BAD ;
Signature · 1 line
2.20.1
PATCH v2 1/1 net/ena: fix false indication of bad L4 Rx csums
From: Igor Chauskin <[email protected]>
Add checking of l4_csum_checked and frag flags before checking the l4_csum_error flag.
In case of IP fragment/unchecked L4 csum - add PKT_RX_L4_CKSUM_UNKNOWN flag to the indicated mbuf.
---
v2:
* Update ENA PMD version to the v2.0.2
drivers/net/ena/ena_ethdev.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/net/ena/ena_ethdev.c +9 -3
@@ -27,7 +27,7 @@#define DRV_MODULE_VER_MAJOR 2#define DRV_MODULE_VER_MINOR 0 -#define DRV_MODULE_VER_SUBMINOR 1 +#define DRV_MODULE_VER_SUBMINOR 2#define ENA_IO_TXQ_IDX (q) (2 * (q))#define ENA_IO_RXQ_IDX (q) (2 * (q) + 1)
@@ -272,8 +272,14 @@ static inline void ena_rx_mbuf_prepare(struct rte_mbuf *mbuf,else if (ena_rx_ctx->l3_proto ==ENA_ETH_IO_L3_PROTO_IPV6 ) packet_type |=RTE_PTYPE_L3_IPV6 ; -if (unlikely (ena_rx_ctx->l4_csum_err)) - ol_flags |=PKT_RX_L4_CKSUM_BAD ; +if (!ena_rx_ctx->l4_csum_checked) + ol_flags |=PKT_RX_L4_CKSUM_UNKNOWN ; +else +if (unlikely (ena_rx_ctx->l4_csum_err) && !ena_rx_ctx->frag) + ol_flags |=PKT_RX_L4_CKSUM_BAD ; +else + ol_flags |=PKT_RX_L4_CKSUM_UNKNOWN ; +if (unlikely (ena_rx_ctx->l3_csum_err)) ol_flags |=PKT_RX_IP_CKSUM_BAD ;
Signature · 1 line
2.20.1
Ferruh Yigit
AppliedQuoted 8 lines · Michal Krawczyk
From: Igor Chauskin <[email protected]>
Add checking of
l4_csum_checkedand frag flags before checking thel4_csum_errorflag.In case of IP fragment/unchecked L4 csum - add
PKT_RX_L4_CKSUM_UNKNOWNflag to the indicated mbuf.
Quoted 6 lines
Fixes 1173fca25af9 ("ena: add polling-mode driver")Signed-off-by Igor Chauskin <[email protected]>Reviewed-by Maciej Bielski <[email protected]>Reviewed-by Michal Krawczyk <[email protected]>
Applied to dpdk-next-net/master, thanks.