Skip to contentSkip to conversation

device property: Fix documentation for fwnode_get_next_parent()

PATCH In review Miaoqian Lin 6 participants 6 messages Dec 7, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 device property: Fix documentation for fwnode_get_next_parent()

Use fwnode_handle_put() on the node pointer to release the refcount. Change fwnode_handle_node() to fwnode_handle_put().

Fixes 233872585de1 ("device property: Add fwnode_get_next_parent()")
---
 drivers/base/property.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/base/property.c +1 -1
index 2a5a37fcd998..daa1e379762b 100644
@@ -601,7 +601,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_parent);
  * node's parents.
  *
  * Returns a node pointer with refcount incremented, use
- * fwnode_handle_node() on it when done.
+ * fwnode_handle_put() on it when done.
  */
 struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode)
 {
Signature · 1 line
2.25.1
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Miaoqian Lin

Use fwnode_handle_put() on the node pointer to release the refcount. Change fwnode_handle_node() to fwnode_handle_put().

Looks correct to me, thanks!

Quoted 22 lines
Fixes 233872585de1 ("device property: Add fwnode_get_next_parent()")
---
 drivers/base/property.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/base/property.c +1 -1
index 2a5a37fcd998..daa1e379762b 100644
@@ -601,7 +601,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_parent);
  * node's parents.
  *
  * Returns a node pointer with refcount incremented, use
- * fwnode_handle_node() on it when done.
+ * fwnode_handle_put() on it when done.
  */
 struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode)
 {
Signature · 1 line
2.25.1
Signature · 2 lines
With Best Regards,
Andy Shevchenko
reviewer Reviewed-by
#2 lore raw
Quoted 5 lines · Andy Shevchenko
Quoted 2 lines · Miaoqian Lin

Use fwnode_handle_put() on the node pointer to release the refcount. Change fwnode_handle_node() to fwnode_handle_put().

Looks correct to me, thanks!

And to me too:

Quoted 23 lines
Quoted 23 lines
Fixes 233872585de1 ("device property: Add fwnode_get_next_parent()")
---
 drivers/base/property.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/base/property.c +1 -1
index 2a5a37fcd998..daa1e379762b 100644
@@ -601,7 +601,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_parent);
  * node's parents.
  *
  * Returns a node pointer with refcount incremented, use
- * fwnode_handle_node() on it when done.
+ * fwnode_handle_put() on it when done.
  */
 struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode)
 {
Signature · 1 line
2.25.1
reviewer Acked-by on v1 1/1
#3 lore raw
In reply to Miaoqian Lin
Quoted 5 lines · Miaoqian Lin

Use fwnode_handle_put() on the node pointer to release the refcount. Change fwnode_handle_node() to fwnode_handle_put().

Fixes 233872585de1 ("device property: Add fwnode_get_next_parent()")

Thanks!

Quoted 17 lines
---
 drivers/base/property.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/base/property.c +1 -1
index 2a5a37fcd998..daa1e379762b 100644
@@ -601,7 +601,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_parent);
  * node's parents.
  *
  * Returns a node pointer with refcount incremented, use
- * fwnode_handle_node() on it when done.
+ * fwnode_handle_put() on it when done.
  */
 struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode)
 {
Signature · 3 lines
Kind regards,

Sakari Ailus
#4 lore raw
Quoted 11 lines · Sakari Ailus
Quoted 5 lines · Miaoqian Lin

Use fwnode_handle_put() on the node pointer to release the refcount. Change fwnode_handle_node() to fwnode_handle_put().

Fixes 233872585de1 ("device property: Add fwnode_get_next_parent()")

Thanks!

So I'm assuming that Greg will pick up this one or please let me know otherwise.

Quoted 19 lines
Quoted 9 lines
---
 drivers/base/property.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/base/property.c +0 -0
index 2a5a37fcd998..daa1e379762b 100644

drivers/base/property.c EXPORT_SYMBOL_GPL(fwnode_get_parent); · line 607

Quoted 8 lines
drivers/base/property.c +1 -1
@@ -601,7 +601,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_parent);
  * node's parents.
  *
  * Returns a node pointer with refcount incremented, use
- * fwnode_handle_node() on it when done.
+ * fwnode_handle_put() on it when done.
  */
 struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode)
 {

--

#5 lore raw
Quoted 7 lines · Rafael J. Wysocki
Quoted 5 lines · Sakari Ailus
Quoted 3 lines · Miaoqian Lin

Use fwnode_handle_put() on the node pointer to release the refcount. Change fwnode_handle_node() to fwnode_handle_put().

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Fixes 233872585de1 ("device property: Add fwnode_get_next_parent()")

Thanks!

So I'm assuming that Greg will pick up this one or please let me know otherwise.

I'll grab it now, thanks.

greg k-h