mips: cmd: go: Flush cache before jumping to app/image
PATCH v3 1/1 mips: cmd: go: Flush cache before jumping to app/image
It has been noticed on MT7628/88 platforms, that booting the RAM image does not work reliably. Sometimes it works and sometimes not. Debugging showed that this "might" be a cache related issue as very strange errors occurred (e.g. output corrupted etc).
This patch adds a cache flush for the complete SDRAM area to the go cmd before jumping to the entry point for the MIPS architecture. The complete area is flushed as we don't know at this point, how big the area of the "application" really is.
---
v3:
- Use gd->ram_top instead of gd->bd->bi_memsize for memory size calculation as suggested by Daniel
v2:
- Moved cache flush into weak do_go_exec() to make this changed mips only
arch/mips/lib/Makefile | 1 + arch/mips/lib/boot.c | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+) create mode 100644 arch/mips/lib/boot.c
arch/mips/lib/Makefile +1 -0
@@ -11,5 +11,6 @@ obj-y += stack.o obj-y += traps.o obj-$(CONFIG_CMD_BOOTM) += bootm.o +obj-$(CONFIG_CMD_GO) += boot.o lib-$(CONFIG_USE_PRIVATE_LIBGCC) += ashldi3.o ashrdi3.o lshrdi3.o
arch/mips/lib/boot.c new file +23 -0
@@ -0,0 +1,23 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Copyright (C) 2020 Stefan Roese <[email protected]> +*/ + +#include <common.h> +#include <command.h> +#include <cpu_func.h> + +DECLARE_GLOBAL_DATA_PTR ; + +unsigned long do_go_exec (ulong (*entry)(int ,char *const []), +int argc,char *const argv[]) +{ +/* +* Flush cache before jumping to application. Let's flush the +* whole SDRAM area, since we don't know the size of the image +* that was loaded. +*/ +flush_cache (gd->bd->bi_memstart, gd->ram_top - gd->bd->bi_memstart); + +return entry (argc, argv); +}
Signature · 1 line
2.25.0
PATCH v3 1/1 mips: cmd: go: Flush cache before jumping to app/image
Hi Daniel,
Quoted 10 lines · Stefan Roese
It has been noticed on MT7628/88 platforms, that booting the RAM image does not work reliably. Sometimes it works and sometimes not. Debugging showed that this "might" be a cache related issue as very strange errors occurred (e.g. output corrupted etc).
This patch adds a cache flush for the complete SDRAM area to the go cmd before jumping to the entry point for the MIPS architecture. The complete area is flushed as we don't know at this point, how big the area of the "application" really is.
Quoted 6 lines
Signed-off-by Stefan Roese <[email protected]>Reviewed-by Daniel Schwierzeck <[email protected]>Tested-by Mauro Condarelli <[email protected]>Cc Daniel Schwierzeck <[email protected]>Cc Mauro Condarelli <[email protected]>Cc Weijie Gao <[email protected]>
Just checking. What is the status of this patch? I don't see it in your "next" branch.
Thanks,
Stefan
Quoted 45 lines
---
v3:
- Usegd->ram_topinstead ofgd->bd->bi_memsizefor memory size calculation as suggested by Danielv2:
- Moved cache flush into weakdo_go_exec()to make this changed mips onlyarch/mips/lib/Makefile | 1 + arch/mips/lib/boot.c | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+)create mode 100644
arch/mips/lib/boot.carch/mips/lib/Makefile +1
-0@@ -11,5 +11,6 @@ obj-y += stack.o obj-y += traps.o obj-$(CONFIG_CMD_BOOTM) += bootm.o +obj-$(CONFIG_CMD_GO) += boot.o lib-$(CONFIG_USE_PRIVATE_LIBGCC) += ashldi3.o ashrdi3.o lshrdi3.oarch/mips/lib/boot.c new file +13
-0@@ -0,0 +1,23 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Copyright (C) 2020 Stefan Roese <[email protected]> +*/ + +#include <common.h> +#include <command.h> +#include <cpu_func.h> + +DECLARE_GLOBAL_DATA_PTR ; + +unsigned long do_go_exec (ulong (*entry)(int ,char *const []), +int argc,char *const argv[])
arch/mips/lib/boot.c line 23
Quoted 10 lines
arch/mips/lib/boot.c new file +10
-0+{ +/* +* Flush cache before jumping to application. Let's flush the +* whole SDRAM area, since we don't know the size of the image +* that was loaded. +*/ +flush_cache (gd->bd->bi_memstart, gd->ram_top - gd->bd->bi_memstart); + +return entry (argc, argv); +}
Viele Gr??e,
Stefan
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
PATCH v3 1/1 mips: cmd: go: Flush cache before jumping to app/image
Hi Stefan,
Am 06.04.20 um 12:06 schrieb Stefan Roese:
Quoted 20 lines
Hi Daniel,
Quoted 10 lines · Stefan Roese
It has been noticed on MT7628/88 platforms, that booting the RAM image does not work reliably. Sometimes it works and sometimes not. Debugging showed that this "might" be a cache related issue as very strange errors occurred (e.g. output corrupted etc).
This patch adds a cache flush for the complete SDRAM area to the go cmd before jumping to the entry point for the MIPS architecture. The complete area is flushed as we don't know at this point, how big the area of the "application" really is.
Quoted 6 lines
Signed-off-by Stefan Roese <[email protected]>Reviewed-by Daniel Schwierzeck <[email protected]>Tested-by Mauro Condarelli <[email protected]>Cc Daniel Schwierzeck <[email protected]>Cc Mauro Condarelli <[email protected]>Cc Weijie Gao <[email protected]>
Quoted 3 lines
Just checking. What is the status of this patch? I don't see it in your "next" branch.
sorry for the inactivity, but for the last six weeks I was quite busy with business travel and day job. I'll rebuild the next branch and go through patchwork when the merge window opens. I guess it's to late for 2020.04 to squeeze some fixes in ;)
Signature · 1 line
- Daniel
PATCH v3 1/1 mips: cmd: go: Flush cache before jumping to app/image
Hi Daniel,
Quoted 18 lines · Daniel Schwierzeck
Quoted 18 lines · Stefan Roese
Quoted 16 lines
It has been noticed on MT7628/88 platforms, that booting the RAM image does not work reliably. Sometimes it works and sometimes not. Debugging showed that this "might" be a cache related issue as very strange errors occurred (e.g. output corrupted etc).
This patch adds a cache flush for the complete SDRAM area to the go cmd before jumping to the entry point for the MIPS architecture. The complete area is flushed as we don't know at this point, how big the area of the "application" really is.
Signed-off-by Stefan Roese <[email protected]>Reviewed-by Daniel Schwierzeck <[email protected]>Tested-by Mauro Condarelli <[email protected]>Cc Daniel Schwierzeck <[email protected]>Cc Mauro Condarelli <[email protected]>Cc Weijie Gao <[email protected]>
Quoted 6 lines
Quoted 3 lines
Just checking. What is the status of this patch? I don't see it in your "next" branch.
sorry for the inactivity, but for the last six weeks I was quite busy with business travel and day job.
No problem. I was just checking. ;)
Quoted 3 lines
I'll rebuild the next branch and go
through patchwork when the merge window opens. I guess it's to late for 2020.04 to squeeze some fixes in ;)
I don't have a hard need for this patch in the upcoming 2020.04 release. So feel free to include it in the next merge window instead.
Thanks,
Stefan
PATCH v3 1/1 mips: cmd: go: Flush cache before jumping to app/image
In reply to Stefan RoeseAm 13.02.20 um 07:04 schrieb Stefan Roese:
Quoted 21 lines
It has been noticed on MT7628/88 platforms, that booting the RAM image does not work reliably. Sometimes it works and sometimes not. Debugging showed that this "might" be a cache related issue as very strange errors occurred (e.g. output corrupted etc).
This patch adds a cache flush for the complete SDRAM area to the go cmd before jumping to the entry point for the MIPS architecture. The complete area is flushed as we don't know at this point, how big the area of the "application" really is.
Signed-off-by Stefan Roese <[email protected]>Reviewed-by Daniel Schwierzeck <[email protected]>Tested-by Mauro Condarelli <[email protected]>Cc Daniel Schwierzeck <[email protected]>Cc Mauro Condarelli <[email protected]>Cc Weijie Gao <[email protected]>---
v3:
- Usegd->ram_topinstead ofgd->bd->bi_memsizefor memory size calculation as suggested by Daniel
Quoted 9 lines
v2:
- Moved cache flush into weakdo_go_exec()to make this changed mips onlyarch/mips/lib/Makefile | 1 + arch/mips/lib/boot.c | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+) create mode 100644 arch/mips/lib/boot.c
applied to u-boot-mips/next, thanks.
Signature · 1 line
- Daniel