mt8395/mt6359: Fix several dtb-check errors
Subsystems (7)
cover mt8395/mt6359: Fix several dtb-check errors
Hi,
This patch series addresses several dtb-check errors reported for the mt8395-genio-1200-evk.dtb and mt8395-radxa-nio-12l.dtb device trees.
The fixes include:
- Adding the missing #sound-dai-cells property in the mt6397 binding.
- Allowing up to 5 interrupts in the MediaTek IOMMU binding to support MT8395 properly.
- Defining the required compatible property in the regulators node of the mt6359.dtsi.
- Renaming the rtc node to match expected schema naming.
---
Julien Massot (4):
dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property
dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts
arm64: dts: mt6359: Add missing 'compatible' property to regulators node
arm64: dts: mt6359: Rename RTC node to match binding expectations
Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 3 ++- Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 3 +++ arch/arm64/boot/dts/mediatek/mt6359.dtsi | 4 +++- 3 files changed, 8 insertions(+), 2 deletions(-)
---
base-commit: 407f60a151df3c44397e5afc0111eb9b026c38d3
change-id: 20250505-mt8395-dtb-errors-0847ffc12f44
Best regards,
Signature · 1 line
Julien Massot <[email protected]>
PATCH 1/4 dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property
The 'mt6359.dtsi' file already uses the '#sound-dai-cells' property. Add the corresponding property to the binding to fix the following dtb-check error:
mediatek/mt8395-radxa-nio-12l.dtb: pmic: '#sound-dai-cells', 'mt6359rtc' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml#
--- Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml +3 -0
@@ -53,6 +53,9 @@ properties: "#interrupt-cells": const: 2 + '#sound-dai-cells': + const: 1 + rtc: type: object $ref: /schemas/rtc/rtc.yaml#
Signature · 1 line
2.49.0
Re: [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property
Il 05/05/25 15:23, Julien Massot ha scritto:
Quoted 9 lines
The '
mt6359.dtsi' file already uses the '#sound-dai-cells' property. Add the corresponding property to the binding to fix the following dtb-check error:mediatek/mt8395-radxa-nio-12l.dtb: pmic: '#sound-dai-cells', 'mt6359rtc' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml#
Fixes 9bc8353be720 ("arm64: dts: mt6359: Add #sound-dai-cells property")Signed-off-by Julien Massot <[email protected]>
Re: [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property
In reply to Julien MassotQuoted 9 lines · Julien Massot
The '
mt6359.dtsi' file already uses the '#sound-dai-cells' property. Add the corresponding property to the binding to fix the following dtb-check error:mediatek/mt8395-radxa-nio-12l.dtb: pmic: '#sound-dai-cells', 'mt6359rtc' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml#
Fixes 9bc8353be720 ("arm64: dts: mt6359: Add #sound-dai-cells property")Signed-off-by Julien Massot <[email protected]>
Thanks,
Nícolas
Re: [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property
In reply to Julien MassotQuoted 3 lines · Julien Massot
The '
mt6359.dtsi' file already uses the '#sound-dai-cells' property. Add the corresponding property to the binding to fix the following dtb-check error:
If this is a DAI, then you miss dai-common reference. If not, you need to explain it in commit msg.
Best regards,
Krzysztof
Re: [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property
Hi Krzysztof,
Quoted 6 lines · Krzysztof Kozlowski
Quoted 3 lines · Julien Massot
The '
mt6359.dtsi' file already uses the '#sound-dai-cells' property. Add the corresponding property to the binding to fix the following dtb-check error:If this is a DAI, then you miss dai-common reference. If not, you need to explain it in commit msg.
Thanks for the review, I will add the missing dai-common reference in the v2.
Regards,
Julien
PATCH 2/4 dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts
In reply to Julien MassotSome Mediatek IOMMU can have up to five interrupts so increase the 'maxItems' to 5.
Fix the following dtb-check error:
mediatek/mt8395-radxa-nio-12l.dtb: infra-iommu@10315000: interrupts:
[[0, 795, 4, 0], [0, 796, 4, 0], [0, 797, 4, 0], [0, 798, 4, 0], [0, 799, 4, 0]] is too long
--- Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml +2 -1
@@ -97,7 +97,8 @@ properties: maxItems: 1 interrupts: - maxItems: 1 + minItems: 1 + maxItems: 5 clocks: items:
Signature · 1 line
2.49.0
AngeloGioacchino Del Regno
maintainerRe: [PATCH 2/4] dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts
Il 05/05/25 15:23, Julien Massot ha scritto:
Quoted 19 lines
Some Mediatek IOMMU can have up to five interrupts so increase the 'maxItems' to 5.
Fix the following dtb-check error:
mediatek/mt8395-radxa-nio-12l.dtb: infra-iommu@10315000: interrupts:
[[0, 795, 4, 0], [0, 796, 4, 0], [0, 797, 4, 0], [0, 798, 4, 0], [0, 799, 4, 0]] is too longFixes 3b5838d1d82e3 ("arm64: dts: mt8195: Add iommu and smi nodes")Signed-off-by Julien Massot <[email protected]>--- Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml +0
-0
Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml properties: · line 100
Quoted 5 lines
Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml +1
-1@@ -97,7 +97,8 @@ properties: maxItems: 1 interrupts: - maxItems: 1 + minItems: 1
Isn't minItems already implicitly 1? :-)
Cheers,
Angelo
Quoted 5 lines
Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml +1
-0+ maxItems: 5 clocks: items:
Re: [PATCH 2/4] dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts
Hi Angelo,
Quoted 29 lines · AngeloGioacchino Del Regno
Il 05/05/25 15:23, Julien Massot ha scritto:
Quoted 20 lines
Some Mediatek IOMMU can have up to five interrupts so increase the 'maxItems' to 5.
Fix the following dtb-check error:
mediatek/mt8395-radxa-nio-12l.dtb: infra-iommu@10315000: interrupts:
[[0, 795, 4, 0], [0, 796, 4, 0], [0, 797, 4, 0], [0, 798, 4, 0], [0, 799, 4, 0]] is too longFixes 3b5838d1d82e3 ("arm64: dts: mt8195: Add iommu and smi nodes")Signed-off-by Julien Massot <[email protected]>---
Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml| 3 ++-1 file changed, 2 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml +0
-0@@ -97,7 +97,8 @@ properties:Quoted 5 lines
maxItems: 1
interrupts:
- maxItems: 1
+ minItems: 1Isn't minItems already implicitly 1? :-)
Quoted 1 line
Looks not, from my understanding if 'minItems' is omitted then
dt-schema is setting it to 'maxItems'.
https://github.com/devicetree-org/dt-schema/blob/v2025.02/dtschema/fixups.py#L129
And you will have an error for a one item interrupts:Documentation/devicetree/bindings/iommu/mediatek,iommu.example.dtb: iommu@10205000: interrupts: [[0, 139, 8]] is too short
Regards,
Julien
Re: [PATCH 2/4] dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts
Il 06/05/25 12:03, Julien Massot ha scritto:
Quoted 32 lines
Hi Angelo,
Quoted 29 lines · AngeloGioacchino Del Regno
Il 05/05/25 15:23, Julien Massot ha scritto:
Quoted 20 lines
Some Mediatek IOMMU can have up to five interrupts so increase the 'maxItems' to 5.
Fix the following dtb-check error:
mediatek/mt8395-radxa-nio-12l.dtb: infra-iommu@10315000: interrupts:
[[0, 795, 4, 0], [0, 796, 4, 0], [0, 797, 4, 0], [0, 798, 4, 0], [0, 799, 4, 0]] is too longFixes 3b5838d1d82e3 ("arm64: dts: mt8195: Add iommu and smi nodes")Signed-off-by Julien Massot <[email protected]>--- Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml +0
-0Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml properties: · line 100
Quoted 5 lines
Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml +1
-1@@ -97,7 +97,8 @@ properties: maxItems: 1 interrupts: - maxItems: 1 + minItems: 1Isn't minItems already implicitly 1? :-)
Quoted 8 lines
Quoted 1 line
Looks not, from my understanding if 'minItems' is omitted then
dt-schema is setting it to 'maxItems'.
https://github.com/devicetree-org/dt-schema/blob/v2025.02/dtschema/fixups.py#L129And you will have an error for a one item interrupts:
Documentation/devicetree/bindings/iommu/mediatek,iommu.example.dtb: iommu@10205000: interrupts: [[0, 139, 8]] is too short
Whoops, you're right.
Re: [PATCH 2/4] dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts
In reply to Julien MassotQuoted 12 lines · Julien Massot
Fixes 3b5838d1d82e3 ("arm64: dts: mt8195: Add iommu and smi nodes")Signed-off-by Julien Massot <[email protected]>--- Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml +0
-0
Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml properties: · line 102
Quoted 7 lines
Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml +2
-1@@ -97,7 +97,8 @@ properties: maxItems: 1 interrupts: - maxItems: 1 + minItems: 1 + maxItems: 5
Every iommu or just some (as described in commit msg) can have 5 interrupts? Looks you miss here proper constraints per variant.
Best regards,
Krzysztof
AngeloGioacchino Del Regno
maintainerRe: [PATCH 2/4] dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts
Il 08/05/25 08:03, Krzysztof Kozlowski ha scritto:
Quoted 15 lines · Julien Massot
Quoted 14 lines
Fixes 3b5838d1d82e3 ("arm64: dts: mt8195: Add iommu and smi nodes")Signed-off-by Julien Massot <[email protected]>--- Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml +0
-0@@ -97,7 +97,8 @@ properties: maxItems: 1
Quoted 8 lines
Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml properties: · line 102
Quoted 5 lines
Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml +2
-1interrupts: - maxItems: 1 + minItems: 1 + maxItems: 5Every iommu or just some (as described in commit msg) can have 5 interrupts? Looks you miss here proper constraints per variant.
Technically, all of the IOMMUs can have more than one interrupt - but it's not clear which one and why, as documentation is lacking.
Let's restrict this discussion to MT8195 anyway, as it's the only one declaring those 5 interrupts...
...all of the IOMMUs declare just one, and mediatek,mt8195-iommu-infra declares 5.
P.S.: Nice catch!
Cheers,
Angelo
Re: [PATCH 2/4] dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts
Hi Krzysztof, Angelo,
Quoted 26 lines · AngeloGioacchino Del Regno
Il 08/05/25 08:03, Krzysztof Kozlowski ha scritto:
Quoted 8 lines · Julien Massot
Quoted 7 lines
Fixes 3b5838d1d82e3 ("arm64: dts: mt8195: Add iommu and smi nodes")Signed-off-by Julien Massot <[email protected]>---
Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml| 3 ++-1 file changed, 2 insertions(+), 1 deletion(-)Quoted 17 lines
Quoted 7 lines
Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml +0
-0100644
Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml +0
-0@@ -97,7 +97,8 @@ properties:Quoted 7 lines
maxItems: 1
interrupts:
- maxItems: 1
+ minItems: 1
+ maxItems: 5Every iommu or just some (as described in commit msg) can have 5 interrupts? Looks you miss here proper constraints per variant.
Quoted 6 lines
Technically, all of the IOMMUs can have more than one interrupt - but it's not clear which one and why, as documentation is lacking.
Let's restrict this discussion to MT8195 anyway, as it's the only one declaring those 5 interrupts...
...all of the IOMMUs declare just one, and mediatek,mt8195-iommu-infra declares 5.
Setting 5 interrupts will be restricted to mt8195 infra iommu in the v2.
Regards,
Julien
PATCH 3/4 arm64: dts: mt6359: Add missing 'compatible' property to regulators node
In reply to Julien MassotThe 'compatible' property is required by the 'mfd/mediatek,mt6397.yaml' binding. Add it to fix the following dtb-check error:
mediatek/mt8395-radxa-nio-12l.dtb: pmic: regulators:
'compatible' is a required property
--- arch/arm64/boot/dts/mediatek/mt6359.dtsi | 2 ++ 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/mediatek/mt6359.dtsi +2 -0
@@ -20,6 +20,8 @@ mt6359codec: audio-codec { }; regulators { + compatible = "mediatek,mt6359-regulator"; + mt6359_vs1_buck_reg: buck_vs1 { regulator-name = "vs1"; regulator-min-microvolt = <800000>;
Signature · 1 line
2.49.0
Re: [PATCH 3/4] arm64: dts: mt6359: Add missing 'compatible' property to regulators node
Il 05/05/25 15:23, Julien Massot ha scritto:
Quoted 8 lines
The 'compatible' property is required by the '
mfd/mediatek,mt6397.yaml' binding. Add it to fix the following dtb-check error:
mediatek/mt8395-radxa-nio-12l.dtb: pmic: regulators:
'compatible' is a required propertyFixes 3b7d143be4b7 ("arm64: dts: mt6359: add PMIC MT6359 related nodes")Signed-off-by Julien Massot <[email protected]>
PATCH 4/4 arm64: dts: mt6359: Rename RTC node to match binding expectations
In reply to Julien MassotRename the node 'mt6359rtc' to 'rtc', as required by the binding.
Fix the following dtb-check error:
mediatek/mt8395-radxa-nio-12l.dtb: pmic: 'mt6359rtc' do not match any of the regexes: 'pinctrl-[0-9]+'
--- arch/arm64/boot/dts/mediatek/mt6359.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/mediatek/mt6359.dtsi +1 -1
@@ -300,7 +300,7 @@ mt6359_vsram_others_sshub_ldo: ldo_vsram_others_sshub { }; }; - mt6359rtc: mt6359rtc { + mt6359rtc: rtc { compatible = "mediatek,mt6358-rtc"; }; };
Signature · 1 line
2.49.0
AngeloGioacchino Del Regno
maintainerRe: [PATCH 4/4] arm64: dts: mt6359: Rename RTC node to match binding expectations
Il 05/05/25 15:23, Julien Massot ha scritto:
Quoted 8 lines
Rename the node 'mt6359rtc' to 'rtc', as required by the binding.
Fix the following dtb-check error:
mediatek/mt8395-radxa-nio-12l.dtb: pmic: 'mt6359rtc' do not match any of the regexes: 'pinctrl-[0-9]+'
Fixes 3b7d143be4b7 ("arm64: dts: mt6359: add PMIC MT6359 related nodes")
Your S-o-B is missing....
Cheers,
Angelo
Re: (subset) [PATCH 0/4] mt8395/mt6359: Fix several dtb-check errors
In reply to Julien MassotQuoted 9 lines · Julien Massot
This patch series addresses several dtb-check errors reported for the mt8395-genio-1200-evk.dtb and mt8395-radxa-nio-12l.dtb device trees.
The fixes include:
- Adding the missing #sound-dai-cells property in the mt6397 binding.
- Allowing up to 5 interrupts in the MediaTek IOMMU binding to support MT8395 properly.
- Defining the required compatible property in the regulators node of themt6359.dtsi.
- Renaming the rtc node to match expected schema naming.[...]
Applied to v6.15-next/dts64, thanks!
[3/4] arm64: dts: mt6359: Add missing 'compatible' property to regulators node
commit: 1fe38d2a19950fa6dbc384ee8967c057aef9faf4
Cheers,
Angelo