Skip to contentSkip to conversation

nfsd: Use seq_putc() in seq_quote_mem()

PATCH In review Markus Elfring 1 participant 2 messages Jul 13, 2024 – Jul 18

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfsd: Use seq_putc() in seq_quote_mem()

From: Markus Elfring <[email protected]>
Date: Sat, 13 Jul 2024 21:07:09 +0200

Double quotation characters should be put into a sequence around other data.
Thus use the function “seq_putc” accordingly.

This issue was transformed by using the Coccinelle software.

---
 fs/nfsd/nfs4state.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/nfsd/nfs4state.c +2 -2
index a20c2c9d7d45..1d15165a15cf 100644
@@ -2636,9 +2636,9 @@ static struct nfs4_client *get_nfsdfs_clp(struct inode *inode)
 
 static void seq_quote_mem(struct seq_file *m, char *data, int len)
 {
-	seq_puts(m, "\"");
+	seq_putc(m, '"');
 	seq_escape_mem(m, data, len, ESCAPE_HEX | ESCAPE_NAP | ESCAPE_APPEND, "\"\\");
-	seq_puts(m, "\"");
+	seq_putc(m, '"');
 }
 
 static const char *cb_state2str(int state)

--
2.45.2

#1 lore raw
Quoted 7 lines

Date: Sat, 13 Jul 2024 21:07:09 +0200

Double quotation characters should be put into a sequence around other data.
Thus use the function “seq_putc” accordingly.

This issue was transformed by using the Coccinelle software.

Why is the information “State Rejected” presented by a known communication interface
for such a development idea?
https://patchwork.kernel.org/project/linux-nfs/patch/[email protected]/

Remaining update candidate:
https://elixir.bootlin.com/linux/v7.2-rc3/source/fs/nfsd/nfs4state.c#L2886-L2891

Regards,
Markus