xfs: fix exchange-range reflink flag clearing issue with INO1_WRITTEN
Subsystems (2)
PATCH v2 1/1 xfs: fix exchange-range reflink flag clearing issue with INO1_WRITTEN
When exchanging two full-file ranges, xmi_can_exchange_reflink_flags() can move the reflink inode flag from the file that currently has it to the other file, as long as exactly one side is marked. This assumes that the file contents, and therefore all shared extents, are exchanged.
That assumption is not true when XFS_EXCHMAPS_INO1_WRITTEN is set. xfs_exchmaps_can_skip_mapping() can skip hole and unwritten mappings from file1, so an exchange can complete without moving every mapping that the earlier flag-swap decision accounted for. In that case the post-operation cleanup can clear the reflink flag from an inode that still owns shared written extents. Later writes then take the non-reflink write path and may update blocks that should still have been protected by CoW, which shows up as data corruption between reflink-related files.
Fix this by disabling the reflink flag exchange whenever XFS_EXCHMAPS_INO1_WRITTEN is requested. The contents exchange can still proceed; the conservative outcome is that both inodes keep the reflink flag. The regular reflink flag cleanup path can drop the extra flag later once the inode no longer has shared extents.
--- fs/xfs/libxfs/xfs_exchmaps.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
fs/xfs/libxfs/xfs_exchmaps.c +10 -0
@@ -959,6 +959,16 @@ xmi_can_exchange_reflink_flags( {struct xfs_mount *mp = req->ip1->i_mount; +/* +* The INO1_WRITTEN optimization can skip exchanging hole and +* unwritten mappings, which means we cannot guarantee that all +* shared extents actually moved to the other file. Clearing the +* reflink flag of an inode that still holds shared extents breaks +* the CoW write path, so refuse to exchange the flags in that case. +*/ +if (req->flags &XFS_EXCHMAPS_INO1_WRITTEN ) +return false; +if (hweight32 (reflink_state) !=1 )return false;if (req->startoff1 !=0 || req->startoff2 !=0 )
Signature · 1 line
2.50.1 (Apple Git-155)
Quoted 15 lines · Lin Jiapeng
When exchanging two full-file ranges,
xmi_can_exchange_reflink_flags()can move the reflink inode flag from the file that currently has it to the other file, as long as exactly one side is marked. This assumes that the file contents, and therefore all shared extents, are exchanged.That assumption is not true when
XFS_EXCHMAPS_INO1_WRITTENis set.xfs_exchmaps_can_skip_mapping()can skip hole and unwritten mappings from file1, so an exchange can complete without moving every mapping that the earlier flag-swap decision accounted for. In that case the post-operation cleanup can clear the reflink flag from an inode that still owns shared written extents. Later writes then take the non-reflink write path and may update blocks that should still have been protected by CoW, which shows up as data corruption between reflink-related files.
Quoted 5 lines
Fix this by disabling the reflink flag exchange whenever
XFS_EXCHMAPS_INO1_WRITTENis requested. The contents exchange can still proceed; the conservative outcome is that both inodes keep the reflink flag. The regular reflink flag cleanup path can drop the extra flag later once the inode no longer has shared extents.
The fix looks good:
Can you add a test case to fstests for this?
Quoted 22 lines · Christoph Hellwig
Quoted 15 lines · Lin Jiapeng
When exchanging two full-file ranges,
xmi_can_exchange_reflink_flags()can move the reflink inode flag from the file that currently has it to the other file, as long as exactly one side is marked. This assumes that the file contents, and therefore all shared extents, are exchanged.That assumption is not true when
XFS_EXCHMAPS_INO1_WRITTENis set.xfs_exchmaps_can_skip_mapping()can skip hole and unwritten mappings from file1, so an exchange can complete without moving every mapping that the earlier flag-swap decision accounted for. In that case the post-operation cleanup can clear the reflink flag from an inode that still owns shared written extents. Later writes then take the non-reflink write path and may update blocks that should still have been protected by CoW, which shows up as data corruption between reflink-related files.Quoted 5 lines
Fix this by disabling the reflink flag exchange whenever
XFS_EXCHMAPS_INO1_WRITTENis requested. The contents exchange can still proceed; the conservative outcome is that both inodes keep the reflink flag. The regular reflink flag cleanup path can drop the extra flag later once the inode no longer has shared extents.
Quoted 6 lines
The fix looks good:
Reviewed-by Christoph Hellwig <[email protected]>Can you add a test case to fstests for this?
Thanks for the review. Sure, I'll add an fstests regression test and send it separately.