net: phy: smsc: use device-managed clock API
Subsystems (3)
Heiner Kallweit
maintainerPATCH 1/1 net: phy: smsc: use device-managed clock API
Simplify the code by using the device-managed clock API.
Signed-off-by Heiner Kallweit <[email protected]>
--- drivers/net/phy/smsc.c | 30 +++++------------------------- 1 file changed, 5 insertions(+), 25 deletions(-)
drivers/net/phy/smsc.c +5 -25
@@ -46,7 +46,6 @@ static struct smsc_hw_stat smsc_hw_stats[] = {struct smsc_phy_priv {u16 intmask;bool energy_enable; -struct clk *refclk; };static int smsc_phy_ack_interrupt (struct phy_device *phydev)
@@ -285,20 +284,12 @@ static void smsc_get_stats(struct phy_device *phydev, data[i] =smsc_get_stat (phydev, i); } -static void smsc_phy_remove (struct phy_device *phydev) -{ -struct smsc_phy_priv *priv = phydev->priv; - -clk_disable_unprepare (priv->refclk); -clk_put (priv->refclk); -} -static int smsc_phy_probe (struct phy_device *phydev) {struct device *dev = &phydev->mdio.dev;struct device_node *of_node = dev->of_node;struct smsc_phy_priv *priv; -int ret; +struct clk *refclk; priv =devm_kzalloc (dev,sizeof (*priv),GFP_KERNEL );if (!priv)
@@ -312,22 +303,12 @@ static int smsc_phy_probe(struct phy_device *phydev) phydev->priv = priv;/* Make clk optional to keep DTB backward compatibility. */ - priv->refclk =clk_get_optional (dev,NULL ); -if (IS_ERR (priv->refclk)) -return dev_err_probe (dev,PTR_ERR (priv->refclk), + refclk =devm_clk_get_optional_enabled (dev,NULL ); +if (IS_ERR (refclk)) +return dev_err_probe (dev,PTR_ERR (refclk),"Failed to request clock\n" ); - ret =clk_prepare_enable (priv->refclk); -if (ret) -return ret; - - ret =clk_set_rate (priv->refclk,50 *1000 *1000 ); -if (ret) { -clk_disable_unprepare (priv->refclk); -return ret; - } - -return 0 ; +return clk_set_rate (refclk,50 *1000 *1000 ); }static struct phy_driver smsc_phy_driver[] = {
@@ -429,7 +410,6 @@ static struct phy_driver smsc_phy_driver[] = {/* PHY_BASIC_FEATURES */ .probe = smsc_phy_probe, - .remove = smsc_phy_remove,/* basic functions */ .read_status = lan87xx_read_status,
Signature · 1 line
2.37.2
Quoted 3 lines · Heiner Kallweit
Simplify the code by using the device-managed clock API.
Signed-off-by Heiner Kallweit <[email protected]>
Reviewed-by Andrew Lunn <[email protected]>
Andrew
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 6 lines · On Sun, 28 Aug 2022 19:26:55 +0200 you wrote:
Simplify the code by using the device-managed clock API.
Signed-off-by Heiner Kallweit <[email protected]>--- drivers/net/phy/smsc.c | 30 +++++------------------------- 1 file changed, 5 insertions(+), 25 deletions(-)
Here is the summary with links:
- [net-next] net: phy: smsc: use device-managed clock API
https://git.kernel.org/netdev/net-next/c/8af1a9afe100
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html