Skip to contentSkip to conversation

Add display panels to gt5 devices

PATCH Applied Nikita Travkin 3 participants 7 messages Jul 25, 2023 – Sep 19, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover Add display panels to gt5 devices

This series adds display panels to Samsung Galaxy Tab A (2015) tablets.

Both gt58 and gt510 gain display support and backlight is controlled with the DCS commands.

While at it, also enable touch-keys on gt510.

---
Jasper Korten (1):

      arm64: dts: qcom: msm8916-samsung-gt510: Add display panel

Nikita Travkin (1):
arm64: dts: qcom: msm8916-samsung-gt510: Add capacitive keys

Siddharth Manthan (1):
arm64: dts: qcom: msm8916-samsung-gt58: Add display panel

 arch/arm64/boot/dts/qcom/msm8916-samsung-gt510.dts | 86 ++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts  | 64 ++++++++++++++++
 2 files changed, 150 insertions(+)

---
base-commit: 5f8e7fdfa482f56c9c884b5c41f40f8f5923d9c4
change-id: 20230725-gt5-panel-448377da7aca

Best regards,

Signature · 1 line
Nikita Travkin <[email protected]>
#1 lore raw

PATCH 1/3 arm64: dts: qcom: msm8916-samsung-gt510: Add display panel

From: Jasper Korten <[email protected]>

The device has a 9.7 inch ltl101at01 display. Add it to the device tree.

---
 arch/arm64/boot/dts/qcom/msm8916-samsung-gt510.dts | 84 ++++++++++++++++++++++
 1 file changed, 84 insertions(+)
arch/arm64/boot/dts/qcom/msm8916-samsung-gt510.dts +84 -0
index 48111c6a2c78..a73cc7565bfb 100644
@@ -19,6 +19,19 @@ clk_pwm: pwm {
 		pinctrl-names = "default";
 	};
 
+	reg_lcd_vmipi: regulator-lcd-vmipi {
+		compatible = "regulator-fixed";
+		regulator-name = "lcd_vmipi";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+
+		gpio = <&tlmm 8 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&lcd_en_default>;
+		pinctrl-names = "default";
+	};
+
 	reg_motor_vdd: regulator-motor-vdd {
 		compatible = "regulator-fixed";
 		regulator-name = "motor_vdd";
@@ -55,6 +68,19 @@ reg_tsp_3p3v: regulator-tsp-3p3v {
 		enable-active-high;
 	};
 
+	reg_vlcd_5p4v: regulator-vlcd-5p4v {
+		compatible = "regulator-fixed";
+		regulator-name = "vlcd_5p4v";
+		regulator-min-microvolt = <5400000>;
+		regulator-max-microvolt = <5400000>;
+
+		gpio = <&tlmm 51 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&buckbooster_en_default>;
+		pinctrl-names = "default";
+	};
+
 	vibrator {
 		compatible = "pwm-vibrator";
 
@@ -84,7 +110,44 @@ touchscreen@4a {
 	};
 };
 
+&mdss {
+	status = "okay";
+};
+
+&mdss_dsi0 {
+	pinctrl-0 = <&mdss_default>;
+	pinctrl-1 = <&mdss_sleep>;
+	pinctrl-names = "default", "sleep";
+
+	panel@0 {
+		compatible = "samsung,ltl101at01", "samsung,s6d7aa0";
+		reg = <0>;
+
+		power-supply = <&reg_vlcd_5p4v>;
+		vmipi-supply = <&reg_lcd_vmipi>;
+		reset-gpios = <&tlmm 97 GPIO_ACTIVE_LOW>;
+
+		port {
+			panel_in: endpoint {
+				remote-endpoint = <&mdss_dsi0_out>;
+			};
+		};
+	};
+};
+
+&mdss_dsi0_out {
+	data-lanes = <0 1 2 3>;
+	remote-endpoint = <&panel_in>;
+};
+
 &tlmm {
+	buckbooster_en_default: buckbooster-en-default-state {
+		pins = "gpio51";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-disable;
+	};
+
 	motor_en_default: motor-en-default-state {
 		pins = "gpio76";
 		function = "gpio";
@@ -97,6 +160,27 @@ motor_pwm_default: motor-pwm-default-state {
 		function = "gcc_gp2_clk_a";
 	};
 
+	lcd_en_default: lcd-en-default-state {
+		pins = "gpio8";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-disable;
+	};
+
+	mdss_default: mdss-default-state {
+		pins = "gpio97";
+		function = "gpio";
+		drive-strength = <8>;
+		bias-disable;
+	};
+
+	mdss_sleep: mdss-sleep-state {
+		pins = "gpio97";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-pull-down;
+	};
+
 	tsp_en_default: tsp-en-default-state {
 		pins = "gpio73";
 		function = "gpio";
Signature · 1 line
2.41.0
#3 lore raw

PATCH 2/3 arm64: dts: qcom: msm8916-samsung-gt58: Add display panel

In reply to Nikita Travkin

From: Siddharth Manthan <[email protected]>

The device has a 8 inch lsl080al03 display. Add it to the device tree.

---
 arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts | 64 +++++++++++++++++++++++
 1 file changed, 64 insertions(+)
arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts +64 -0
index 98ceaad7fcea..11359bcc27b3 100644
@@ -9,6 +9,19 @@ / {
 	compatible = "samsung,gt58", "qcom,msm8916";
 	chassis-type = "tablet";
 
+	reg_5p4v: regulator-5p4v {
+		compatible = "regulator-fixed";
+		regulator-name = "vlcd_5p4v";
+		regulator-min-microvolt = <5400000>;
+		regulator-max-microvolt = <5400000>;
+
+		gpio = <&tlmm 8 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&buckbooster_en_default>;
+		pinctrl-names = "default";
+	};
+
 	reg_vdd_tsp: regulator-vdd-tsp {
 		compatible = "regulator-fixed";
 		regulator-name = "vdd_tsp";
@@ -51,7 +64,58 @@ touchscreen@20 {
 	};
 };
 
+&mdss {
+	status = "okay";
+};
+
+&mdss_dsi0 {
+	pinctrl-0 = <&mdss_default>;
+	pinctrl-1 = <&mdss_sleep>;
+	pinctrl-names = "default", "sleep";
+
+	panel@0 {
+		compatible = "samsung,lsl080al03", "samsung,s6d7aa0";
+		reg = <0>;
+
+		power-supply = <&reg_5p4v>;
+		vmipi-supply = <&pm8916_l5>;
+		reset-gpios = <&tlmm 97 GPIO_ACTIVE_LOW>;
+
+		port {
+			panel_in: endpoint {
+				remote-endpoint = <&mdss_dsi0_out>;
+			};
+		};
+	};
+};
+
+&mdss_dsi0_out {
+	data-lanes = <0 1 2 3>;
+	remote-endpoint = <&panel_in>;
+};
+
 &tlmm {
+	buckbooster_en_default: buckbooster-en-default-state {
+		pins = "gpio8";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-disable;
+	};
+
+	mdss_default: mdss-default-state {
+		pins = "gpio97";
+		function = "gpio";
+		drive-strength = <8>;
+		bias-disable;
+	};
+
+	mdss_sleep: mdss-sleep-state {
+		pins = "gpio97";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-pull-down;
+	};
+
 	reg_tsp_en_default: reg-tsp-en-default-state {
 		pins = "gpio73";
 		function = "gpio";
Signature · 1 line
2.41.0
#5 lore raw

PATCH 3/3 arm64: dts: qcom: msm8916-samsung-gt510: Add capacitive keys

In reply to Nikita Travkin

gt510 has two capacitive keys on the bottom. Define keycodes to enable them.

---
 arch/arm64/boot/dts/qcom/msm8916-samsung-gt510.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/qcom/msm8916-samsung-gt510.dts +2 -0
index a73cc7565bfb..75c4854ecd64 100644
@@ -107,6 +107,8 @@ touchscreen@4a {
 
 		pinctrl-0 = <&tsp_int_rst_default>;
 		pinctrl-names = "default";
+
+		linux,keycodes = <KEY_APPSELECT KEY_BACK>;
 	};
 };
 
Signature · 1 line
2.41.0
maintainer Applied
#6 lore raw
In reply to Nikita Travkin
Quoted 8 lines · Nikita Travkin

This series adds display panels to Samsung Galaxy Tab A (2015) tablets.

Both gt58 and gt510 gain display support and backlight is controlled with the DCS commands.

While at it, also enable touch-keys on gt510.

[...]

Applied, thanks!

[1/3] arm64: dts: qcom: msm8916-samsung-gt510: Add display panel

      commit: 4389a650323afe947900f631322fa4db4993d356
[2/3] arm64: dts: qcom: msm8916-samsung-gt58: Add display panel
      commit: 43525a7a96acad0648577770b84894af8dcb10d2
[3/3] arm64: dts: qcom: msm8916-samsung-gt510: Add capacitive keys
      commit: 20ef4f6445681217c0cb49dc21402cb2836b22aa

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>