Skip to contentSkip to conversation

pci: add PCI_EXT_CAP_ID_PL_32GT define

PATCH Applied Ben Dooks 3 participants 4 messages May 31, 2023 – Jun 2, 2023 PCI

lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH v2 1/1 pci: add PCI_EXT_CAP_ID_PL_32GT define

From: Ben Dooks <[email protected]>

Add the define for PCI_EXT_CAP_ID_PL_32GT for drivers that will want this whilst doing Gen5/Gen6 accesses.

--
v2:
- fixed tabs

---
 include/uapi/linux/pci_regs.h | 1 +
 1 file changed, 1 insertion(+)
include/uapi/linux/pci_regs.h +1 -0
index dc2000e0fe3a..e5f558d96493 100644
@@ -738,6 +738,7 @@
 #define PCI_EXT_CAP_ID_DVSEC	0x23	/* Designated Vendor-Specific */
 #define PCI_EXT_CAP_ID_DLF	0x25	/* Data Link Feature */
 #define PCI_EXT_CAP_ID_PL_16GT	0x26	/* Physical Layer 16.0 GT/s */
+#define PCI_EXT_CAP_ID_PL_32GT  0x2A    /* Physical Layer 32.0 GT/s */
 #define PCI_EXT_CAP_ID_DOE	0x2E	/* Data Object Exchange */
 #define PCI_EXT_CAP_ID_MAX	PCI_EXT_CAP_ID_DOE
 
Signature · 1 line
2.39.2
#1 lore raw
Quoted 7 lines · Ben Dooks

From: Ben Dooks <[email protected]>

Add the define for PCI_EXT_CAP_ID_PL_32GT for drivers that will want this whilst doing Gen5/Gen6 accesses.

I applied this to pci/enumeration for v6.5, thanks.

But I'm very curious about where you expect this to be used.

Quoted 22 lines

--
v2:
- fixed tabs

---
 include/uapi/linux/pci_regs.h | 1 +
 1 file changed, 1 insertion(+)
include/uapi/linux/pci_regs.h +1 -0
index dc2000e0fe3a..e5f558d96493 100644
@@ -738,6 +738,7 @@
 #define PCI_EXT_CAP_ID_DVSEC	0x23	/* Designated Vendor-Specific */
 #define PCI_EXT_CAP_ID_DLF	0x25	/* Data Link Feature */
 #define PCI_EXT_CAP_ID_PL_16GT	0x26	/* Physical Layer 16.0 GT/s */
+#define PCI_EXT_CAP_ID_PL_32GT  0x2A    /* Physical Layer 32.0 GT/s */
 #define PCI_EXT_CAP_ID_DOE	0x2E	/* Data Object Exchange */
 #define PCI_EXT_CAP_ID_MAX	PCI_EXT_CAP_ID_DOE
 
Signature · 1 line
2.39.2
#2 lore raw
Quoted 6 lines · Bjorn Helgaas
Quoted 5 lines · Ben Dooks

From: Ben Dooks <[email protected]>

Add the define for PCI_EXT_CAP_ID_PL_32GT for drivers that will want this whilst doing Gen5/Gen6 accesses.

Quoted 6 lines
Quoted 2 lines

I applied this to pci/enumeration for v6.5, thanks.

But I'm very curious about where you expect this to be used.

We have an upcoming driver that has gen5 phy and config requirements.

#3 lore raw
Quoted 7 lines · Ben Dooks
Quoted 6 lines · Bjorn Helgaas
Quoted 5 lines · Ben Dooks

From: Ben Dooks <[email protected]>

Add the define for PCI_EXT_CAP_ID_PL_32GT for drivers that will want this whilst doing Gen5/Gen6 accesses.

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

I applied this to pci/enumeration for v6.5, thanks.

But I'm very curious about where you expect this to be used.

We have an upcoming driver that has gen5 phy and config requirements.

I guess a better question would have been whether PCI_EXT_CAP_ID_PL_32GT is best used in individual drivers or in the PCI core. Since it's in the PCIe base spec and doesn't look like it should be device-specific, it might be a candidate for supporting in the PCI core somehow so it doesn't get reimplemented in several places.

Bjorn