bpftool: Fix missing pids during link show
Yonghong Song
reviewerPATCH 1/1 bpftool: Fix missing pids during link show
Current 'bpftool link' command does not show pids, e.g.,
$ tools/build/bpftool/bpftool link
...
4: tracing prog 23
prog_type lsm attach_type lsm_mac
target_obj_id 1 target_btf_id 31320Hack the following change to enable normal libbpf debug output,
--- a/tools/bpf/bpftool/pids.c
+++ b/tools/bpf/bpftool/pids.c
@@ -121,9 +121,9 @@ int build_obj_refs_table(struct hashmap **map, enum bpf_obj_type type)
/* we don't want output polluted with libbpf errors if bpf_iter is not
* supported
*/
- default_print = libbpf_set_print(libbpf_print_none);
+ /* default_print = libbpf_set_print(libbpf_print_none); */
err = pid_iter_bpf__load(skel); - libbpf_set_print(default_print);
+ /* libbpf_set_print(default_print); */
Rerun the above bpftool command:
$ tools/build/bpftool/bpftool link libbpf: prog 'iter': BPF program load failed: Permission denied libbpf: prog 'iter': -- BEGIN PROG LOAD LOG -- 0: R1=ctx() R10=fp0 ; struct task_struct *task = ctx->task; @ pid_iter.bpf.c:69 0: (79) r6 = *(u64 *)(r1 +8) ; R1=ctx() R6_w=ptr_or_null_task_struct(id=1) ; struct file *file = ctx->file; @ pid_iter.bpf.c:68 ... ; struct bpf_link *link = (struct bpf_link *) file->private_data; @ pid_iter.bpf.c:103 80: (79) r3 = *(u64 *)(r8 +432) ; R3_w=scalar() R8=ptr_file() ; if (link->type == bpf_core_enum_value(enum bpf_link_type___local, @ pid_iter.bpf.c:105 81: (61) r1 = *(u32 *)(r3 +12) R3 invalid mem access 'scalar' processed 39 insns (limit 1000000) max_states_per_insn 0 total_states 3 peak_states 3 mark_read 2 -- END PROG LOAD LOG -- libbpf: prog 'iter': failed to load: -13 ...
The 'file->private_data' returns a 'void' type and this caused subsequent 'link->type' (insn #81) failed in verification.
To fix the issue, do a type cast from 'void *' to 'struct bpf_link *' for file->private_data as in this patch, and the 'bpftool link' runs successfully with 'pids'.
$ tools/build/bpftool/bpftool link
...
4: tracing prog 23
prog_type lsm attach_type lsm_mac
target_obj_id 1 target_btf_id 31320
pids systemd(1)--- tools/bpf/bpftool/skeleton/pid_iter.bpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/bpf/bpftool/skeleton/pid_iter.bpf.c +1 -1
@@ -100,7 +100,7 @@ int iter(struct bpf_iter__task_file *ctx)if (obj_type ==BPF_OBJ_LINK && bpf_core_enum_value_exists(enum bpf_link_type___local, BPF_LINK_TYPE_PERF_EVENT___local)) { -struct bpf_link *link = (struct bpf_link *) file->private_data; + struct bpf_link *link = bpf_core_cast(file->private_data, struct bpf_link); if (link->type == bpf_core_enum_value(enum bpf_link_type___local, BPF_LINK_TYPE_PERF_EVENT___local)) {
Signature · 1 line
2.43.0
Quoted 64 lines · Yonghong Song
Current 'bpftool link' command does not show pids, e.g.,
$ tools/build/bpftool/bpftool link ... 4: tracing prog 23 prog_type lsm attach_type lsm_mac target_obj_id 1 target_btf_id 31320Hack the following change to enable normal libbpf debug output,
---a/tools/bpf/bpftool/pids.c
+++b/tools/bpf/bpftool/pids.c
@@ -121,9 +121,9 @@ intbuild_obj_refs_table(struct hashmap **map, enum bpf_obj_type type)/* we don't want output polluted with libbpf errors if bpf_iter is not * supported */ - default_print = libbpf_set_print(libbpf_print_none); + /* default_print = libbpf_set_print(libbpf_print_none); */ err = pid_iter_bpf__load(skel);-
libbpf_set_print(default_print);
+ /*libbpf_set_print(default_print); */Rerun the above bpftool command:
$ tools/build/bpftool/bpftool link libbpf: prog 'iter': BPF program load failed: Permission denied libbpf: prog 'iter': -- BEGIN PROG LOAD LOG -- 0: R1=ctx() R10=fp0 ; struct task_struct *task = ctx->task; @ pid_iter.bpf.c:69 0: (79) r6 = *(u64 *)(r1 +8) ; R1=ctx() R6_w=ptr_or_null_task_struct(id=1) ; struct file *file = ctx->file; @ pid_iter.bpf.c:68 ... ; struct bpf_link *link = (struct bpf_link *) file->private_data; @ pid_iter.bpf.c:103 80: (79) r3 = *(u64 *)(r8 +432) ; R3_w=scalar() R8=ptr_file() ; if (link->type == bpf_core_enum_value(enum bpf_link_type___local, @ pid_iter.bpf.c:105 81: (61) r1 = *(u32 *)(r3 +12) R3 invalid mem access 'scalar' processed 39 insns (limit 1000000) max_states_per_insn 0 total_states 3 peak_states 3 mark_read 2 -- END PROG LOAD LOG -- libbpf: prog 'iter': failed to load: -13 ...The '
file->private_data' returns a 'void' type and this caused subsequent 'link->type' (insn #81) failed in verification.To fix the issue, do a type cast from 'void *' to 'struct
bpf_link*' forfile->private_dataas in this patch, and the 'bpftool link' runs successfully with 'pids'.$ tools/build/bpftool/bpftool link ... 4: tracing prog 23 prog_type lsm attach_type lsm_mac target_obj_id 1 target_btf_id 31320 pids systemd(1)Fixes 44ba7b30e84f ("bpftool: Use a local copy of BPF_LINK_TYPE_PERF_EVENT in pid_iter.bpf.c")Cc Quentin Monnet <[email protected]>Signed-off-by Yonghong Song <[email protected]>--- tools/bpf/bpftool/skeleton/pid_iter.bpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/bpf/bpftool/skeleton/pid_iter.bpf.c +0
-0
tools/bpf/bpftool/skeleton/pid_iter.bpf.c int iter(struct bpf_iter__task_file *ctx) · line 103
Quoted 5 lines
tools/bpf/bpftool/skeleton/pid_iter.bpf.c +1
-1@@ -100,7 +100,7 @@ int iter(struct bpf_iter__task_file *ctx)if (obj_type ==BPF_OBJ_LINK && bpf_core_enum_value_exists(enum bpf_link_type___local, BPF_LINK_TYPE_PERF_EVENT___local)) { -struct bpf_link *link = (struct bpf_link *) file->private_data; + struct bpf_link *link = bpf_core_cast(file->private_data, struct bpf_link);
bpf_core_cast() (i.e., bpf_rdonly_cast()) is newer feature, so relying on it in bpftool will make PID printing not work on older kernels that generally do support iter/task_file iterators.
tools/bpf/bpftool/skeleton/pid_iter.bpf.c int iter(struct bpf_iter__task_file *ctx) · line 105
Quoted 2 lines
tools/bpf/bpftool/skeleton/pid_iter.bpf.c +0
-0if (link->type == bpf_core_enum_value(enum bpf_link_type___local,
the problem is that we dropped BPF_CORE_READ() here and went with link->type. Should we restore BPF_CORE_READ(link, type) here and solve the problem, while also supporting this feature on wider set of kernels? Quentin?
Quoted 4 lines
tools/bpf/bpftool/skeleton/pid_iter.bpf.c +0
-1BPF_LINK_TYPE_PERF_EVENT___local)) { --2.43.0
Yonghong Song
reviewerQuoted 73 lines · Andrii Nakryiko
Quoted 63 lines · Yonghong Song
Current 'bpftool link' command does not show pids, e.g.,
$ tools/build/bpftool/bpftool link ... 4: tracing prog 23 prog_type lsm attach_type lsm_mac target_obj_id 1 target_btf_id 31320Hack the following change to enable normal libbpf debug output,
---a/tools/bpf/bpftool/pids.c
+++b/tools/bpf/bpftool/pids.c
@@ -121,9 +121,9 @@ intbuild_obj_refs_table(struct hashmap **map, enum bpf_obj_type type)/* we don't want output polluted with libbpf errors if bpf_iter is not * supported */ - default_print = libbpf_set_print(libbpf_print_none); + /* default_print = libbpf_set_print(libbpf_print_none); */ err = pid_iter_bpf__load(skel);-
libbpf_set_print(default_print);
+ /*libbpf_set_print(default_print); */Rerun the above bpftool command:
$ tools/build/bpftool/bpftool link libbpf: prog 'iter': BPF program load failed: Permission denied libbpf: prog 'iter': -- BEGIN PROG LOAD LOG -- 0: R1=ctx() R10=fp0 ; struct task_struct *task = ctx->task; @ pid_iter.bpf.c:69 0: (79) r6 = *(u64 *)(r1 +8) ; R1=ctx() R6_w=ptr_or_null_task_struct(id=1) ; struct file *file = ctx->file; @ pid_iter.bpf.c:68 ... ; struct bpf_link *link = (struct bpf_link *) file->private_data; @ pid_iter.bpf.c:103 80: (79) r3 = *(u64 *)(r8 +432) ; R3_w=scalar() R8=ptr_file() ; if (link->type == bpf_core_enum_value(enum bpf_link_type___local, @ pid_iter.bpf.c:105 81: (61) r1 = *(u32 *)(r3 +12) R3 invalid mem access 'scalar' processed 39 insns (limit 1000000) max_states_per_insn 0 total_states 3 peak_states 3 mark_read 2 -- END PROG LOAD LOG -- libbpf: prog 'iter': failed to load: -13 ...The '
file->private_data' returns a 'void' type and this caused subsequent 'link->type' (insn #81) failed in verification.To fix the issue, do a type cast from 'void *' to 'struct
bpf_link*' forfile->private_dataas in this patch, and the 'bpftool link' runs successfully with 'pids'.$ tools/build/bpftool/bpftool link ... 4: tracing prog 23 prog_type lsm attach_type lsm_mac target_obj_id 1 target_btf_id 31320 pids systemd(1)Fixes 44ba7b30e84f ("bpftool: Use a local copy of BPF_LINK_TYPE_PERF_EVENT in pid_iter.bpf.c")Cc Quentin Monnet <[email protected]>Signed-off-by Yonghong Song <[email protected]>--- tools/bpf/bpftool/skeleton/pid_iter.bpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/bpf/bpftool/skeleton/pid_iter.bpf.c +0
-0tools/bpf/bpftool/skeleton/pid_iter.bpf.c int iter(struct bpf_iter__task_file *ctx) · line 103
Quoted 5 lines
tools/bpf/bpftool/skeleton/pid_iter.bpf.c +1
-1@@ -100,7 +100,7 @@ int iter(struct bpf_iter__task_file *ctx)if (obj_type ==BPF_OBJ_LINK && bpf_core_enum_value_exists(enum bpf_link_type___local, BPF_LINK_TYPE_PERF_EVENT___local)) { -struct bpf_link *link = (struct bpf_link *) file->private_data; + struct bpf_link *link = bpf_core_cast(file->private_data, struct bpf_link);
bpf_core_cast()(i.e.,bpf_rdonly_cast()) is newer feature, so relying on it in bpftool will make PID printing not work on older kernels that generally do support iter/task_file iterators.
Quoted 5 lines
tools/bpf/bpftool/skeleton/pid_iter.bpf.c int iter(struct bpf_iter__task_file *ctx) · line 105
Quoted 1 line
tools/bpf/bpftool/skeleton/pid_iter.bpf.c +0
-0if (link->type == bpf_core_enum_value(enum bpf_link_type___local,the problem is that we dropped
BPF_CORE_READ()here and went withlink->type. Should we restoreBPF_CORE_READ(link, type)here and solve the problem, while also supporting this feature on wider set of kernels? Quentin?
Good point. Using the latest fancy feature might not be the best way as old kernels won't work and this is a strong argument. I will change to use BPF_CORE_READ in v2.
Quoted 5 lines
Quoted 5 lines
tools/bpf/bpftool/skeleton/pid_iter.bpf.c +0
-1BPF_LINK_TYPE_PERF_EVENT___local)) { --2.43.0
2024-03-11 23:30 UTC+0000 ~ Yonghong Song <[email protected]>
Quoted 11 lines · Andrii Nakryiko
Quoted 9 lines
Quoted 7 lines · Yonghong Song
Current 'bpftool link' command does not show pids, e.g.,
$ tools/build/bpftool/bpftool link ... 4: tracing prog 23 prog_type lsm attach_type lsm_mac target_obj_id 1 target_btf_id 31320
Quoted 14 lines
Quoted 6 lines
Quoted 6 lines
Hack the following change to enable normal libbpf debug output, ---
a/tools/bpf/bpftool/pids.c
+++b/tools/bpf/bpftool/pids.c
@@ -121,9 +121,9 @@ intbuild_obj_refs_table(struct hashmap **map, enum bpf_obj_type type)
/* we don't want output polluted with libbpf errors ifQuoted 8 lines
Quoted 8 lines
bpf_iteris not
* supported
*/
-default_print=libbpf_set_print(libbpf_print_none); + /*default_print=libbpf_set_print(libbpf_print_none); */ err =pid_iter_bpf__load(skel);
-libbpf_set_print(default_print);
+ /*libbpf_set_print(default_print); */
I'm taking note to make these logs available when users pass the --debug flag (https://github.com/libbpf/bpftool/issues/137), there's no reason to hide them in that case.
Quoted 66 lines
Quoted 66 lines
Quoted 52 lines
Rerun the above bpftool command:
$ tools/build/bpftool/bpftool link libbpf: prog 'iter': BPF program load failed: Permission denied libbpf: prog 'iter': -- BEGIN PROG LOAD LOG -- 0: R1=ctx() R10=fp0 ; struct task_struct *task = ctx->task; @ pid_iter.bpf.c:69 0: (79) r6 = *(u64 *)(r1 +8) ; R1=ctx() R6_w=ptr_or_null_task_struct(id=1) ; struct file *file = ctx->file; @ pid_iter.bpf.c:68 ... ; struct bpf_link *link = (struct bpf_link *) file->private_data; @ pid_iter.bpf.c:103 80: (79) r3 = *(u64 *)(r8 +432) ; R3_w=scalar() R8=ptr_file() ; if (link->type == bpf_core_enum_value(enum bpf_link_type___local, @ pid_iter.bpf.c:105 81: (61) r1 = *(u32 *)(r3 +12) R3 invalid mem access 'scalar' processed 39 insns (limit 1000000) max_states_per_insn 0 total_states 3 peak_states 3 mark_read 2 -- END PROG LOAD LOG -- libbpf: prog 'iter': failed to load: -13 ...The '
file->private_data' returns a 'void' type and this caused subsequent 'link->type'
(insn #81) failed in verification.To fix the issue, do a type cast from 'void *' to 'struct
bpf_link*' forfile->private_data
as in this patch, and the 'bpftool link' runs successfully with 'pids'.$ tools/build/bpftool/bpftool link ... 4: tracing prog 23 prog_type lsm attach_type lsm_mac target_obj_id 1 target_btf_id 31320 pids systemd(1)Fixes 44ba7b30e84f ("bpftool: Use a local copy of
BPF_LINK_TYPE_PERF_EVENTinpid_iter.bpf.c")Cc Quentin Monnet <[email protected]>Signed-off-by Yonghong Song <[email protected]>---
tools/bpf/bpftool/skeleton/pid_iter.bpf.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)tools/bpf/bpftool/skeleton/pid_iter.bpf.c +0
-0@@ -100,7 +100,7 @@ int iter(struct bpf_iter__task_file *ctx)Quoted 8 lines
if (
obj_type==BPF_OBJ_LINK&& bpf_core_enum_value_exists(enumbpf_link_type___local,BPF_LINK_TYPE_PERF_EVENT___local)) {
- structbpf_link*link = (structbpf_link*)file->private_data;
+ structbpf_link*link =bpf_core_cast(file->private_data, struct bpf_link);
bpf_core_cast()(i.e.,bpf_rdonly_cast()) is newer feature, so relying on it in bpftool will make PID printing not work on older kernels that generally do support iter/task_file iterators.Quoted 2 lines
if (
link->type== bpf_core_enum_value(enumbpf_link_type___local,
Quoted 8 lines
Quoted 4 lines
the problem is that we dropped
BPF_CORE_READ()here and went withlink->type. Should we restoreBPF_CORE_READ(link, type)here and solve the problem, while also supporting this feature on wider set of kernels? Quentin?Good point. Using the latest fancy feature might not be the best way as old kernels won't work and this is a strong argument. I will change to use
BPF_CORE_READin v2.
Agreed, the whole point of commit 44ba7b30e84f that introduced the issue was to make bpftool work with older kernels. BPF_CORE_READ sounds like the right approach, thank you!
Yonghong Song
reviewerQuoted 25 lines · Quentin Monnet
2024-03-11 23:30 UTC+0000 ~ Yonghong Song <[email protected]>
Quoted 10 lines · Andrii Nakryiko
Quoted 9 lines
Quoted 7 lines · Yonghong Song
Current 'bpftool link' command does not show pids, e.g.,
$ tools/build/bpftool/bpftool link ... 4: tracing prog 23 prog_type lsm attach_type lsm_mac target_obj_id 1 target_btf_id 31320Quoted 14 lines
Quoted 6 lines
Quoted 6 lines
Hack the following change to enable normal libbpf debug output,
---a/tools/bpf/bpftool/pids.c
+++b/tools/bpf/bpftool/pids.c
@@ -121,9 +121,9 @@ int build_obj_refs_table(struct hashmap **map,
enumbpf_obj_typetype)
/* we don't want output polluted with libbpf errors ifQuoted 8 lines
Quoted 8 lines
bpf_iteris not
* supported
*/
-default_print=libbpf_set_print(libbpf_print_none); + /*default_print=libbpf_set_print(libbpf_print_none); */ err =pid_iter_bpf__load(skel);
-libbpf_set_print(default_print);
+ /*libbpf_set_print(default_print); */
Quoted 3 lines
I'm taking note to make these logs available when users pass the --debug flag (https://github.com/libbpf/bpftool/issues/137), there's no reason to hide them in that case.
Totally make sense as most kernels used in production should already have bpf_link and bpf_iter support already.
[...]