Skip to contentSkip to conversation

Keep scripts/create-pull-request and send-pull-request ?

DISCUSSION Michael Opdenacker 6 participants 9 messages Aug 10, 2023

lore
Share & tools
lore
#0 lore raw

Greetings,

I'm reviewing https://docs.yoctoproject.org/next/contributor-guide/submit-change.html#using-scripts-to-push-a-change-upstream-and-request-a-pull and trying to simplify it.

Do people still use scripts/create-pull-request and send-pull-request? I see some obsolete URLs in the first script, and mostly old commits to their code.

I'm also asking because I'm wondering whether it's better to document how to create and send pull requests from standard git tools. This way, people also learn how to submit pull requests to other upstreams.

What do you think?

Thanks in advance
Michael.

Signature · 3 lines
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#1 lore raw

Hi Michael,

Em qui., 10 de ago. de 2023 às 11:04, Michael Opdenacker via lists.openembedded.org <[email protected]> escreveu:

Quoted 11 lines

Greetings,

I'm reviewing
https://docs.yoctoproject.org/next/contributor-guide/submit-change.html#using-scripts-to-push-a-change-upstream-and-request-a-pull
and trying to simplify it.

Do people still use scripts/create-pull-request and send-pull-request? I see some obsolete URLs in the first script, and mostly old commits to their code.

Quoted 5 lines

I'm also asking because I'm wondering whether it's better to document how to create and send pull requests from standard git tools. This way, people also learn how to submit pull requests to other upstreams.

What do you think?

I completely agree that documenting standard git tools is a great idea. This way, people will learn how to submit pull requests to other upstreams, which is always a valuable skill to have.

Best regards,

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750
#2 lore raw
In reply to Michael Opdenacker
Quoted 10 lines · Michael Opdenacker via lists.yoctoproject.org

Greetings,

I'm reviewing
https://docs.yoctoproject.org/next/contributor-guide/submit-change.html#using-scripts-to-push-a-change-upstream-and-request-a-pull
and trying to simplify it.

Do people still use scripts/create-pull-request and send-pull-request? I see some obsolete URLs in the first script, and mostly old commits to their code.

I use create-pull-request for all my series, so the scripts still do work and are in at least in use here.

But I send with git send-email directly.

Bruce

Quoted 24 lines

I'm also asking because I'm wondering whether it's better to document how to create and send pull requests from standard git tools. This way, people also learn how to submit pull requests to other upstreams.

What do you think?

Thanks in advance
Michael.

--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#4135): https://lists.yoctoproject.org/g/docs/message/4135
Mute This Topic: https://lists.yoctoproject.org/mt/100663723/1050810
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/docs/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
#3 lore raw

Hi Bruce

Quoted 9 lines · Bruce Ashfield
Quoted 6 lines · Michael Opdenacker via lists.yoctoproject.org

Greetings,

I'm reviewing
https://docs.yoctoproject.org/next/contributor-guide/submit-change.html#using-scripts-to-push-a-change-upstream-and-request-a-pull
and trying to simplify it.

Quoted 7 lines
Quoted 3 lines

Do people still use scripts/create-pull-request and send-pull-request? I see some obsolete URLs in the first script, and mostly old commits to their code.

I use create-pull-request for all my series, so the scripts still do work and are in at least in use here.

But I send with git send-email directly.

Good to know, thanks!
So, we need to keep at least the first one. I'll send a patch to it then.

I'm not saying we should keep documenting them though ;-)

Thanks
Michael.

Signature · 3 lines
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw
Quoted 19 lines · Michael Opdenacker

Hi Bruce

Quoted 15 lines · Bruce Ashfield
Quoted 9 lines · Michael Opdenacker via lists.yoctoproject.org

Greetings,

I'm reviewing
https://docs.yoctoproject.org/next/contributor-guide/submit-change.html#using-scripts-to-push-a-change-upstream-and-request-a-pull
and trying to simplify it.

Do people still use scripts/create-pull-request and send-pull-request? I see some obsolete URLs in the first script, and mostly old commits to their code.

I use create-pull-request for all my series, so the scripts still do work and are in at least in use here.

Quoted 7 lines
Quoted 1 line

But I send with git send-email directly.

Good to know, thanks!
So, we need to keep at least the first one. I'll send a patch to it then.

I'm not saying we should keep documenting them though ;-)

Agreed!

Bruce

Quoted 9 lines

Thanks
Michael.

--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
#5 lore raw
In reply to Bruce Ashfield

Le jeu. 10 août 2023, 16:09, Bruce Ashfield <[email protected]> a écrit :

Quoted 11 lines
Quoted 5 lines · Michael Opdenacker via lists.yoctoproject.org

Greetings,

I'm reviewing

https://docs.yoctoproject.org/next/contributor-guide/submit-change.html#using-scripts-to-push-a-change-upstream-and-request-a-pull

Quoted 2 lines

and trying to simplify it.

Quoted 9 lines
Quoted 3 lines

Do people still use scripts/create-pull-request and send-pull-request? I see some obsolete URLs in the first script, and mostly old commits to their code.

I use create-pull-request for all my series, so the scripts still do work and are in at least in use here.

But I send with git send-email directly.

Same here, I use the both scripts for patch series but I can perfectly use git tools directly with some documentations (or if I opened those scripts)

Quoted 39 lines

Bruce

Quoted 7 lines

I'm also asking because I'm wondering whether it's better to document how to create and send pull requests from standard git tools. This way, people also learn how to submit pull requests to other upstreams.

What do you think?

Quoted 11 lines

Thanks in advance
Michael.

--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#4136):
https://lists.yoctoproject.org/g/docs/message/4136
Mute This Topic: https://lists.yoctoproject.org/mt/100663723/6213388
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/docs/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#6 lore raw
In reply to Michael Opdenacker
Quoted 1 line · Michael Opdenacker via lists.openembedded.org

I'm wondering whether it's better to document how to create and send pull requests from standard git tools.

+1

Cliff

#7 lore raw

Hello,

Quoted 6 lines · Cliff Brake
Quoted 1 line · Michael Opdenacker via lists.openembedded.org

I'm wondering whether it's better to document how to create and send pull requests from standard git tools.

+1

Cliff

All things considered, since scripts/create-pull-request is still in use, in particular by Steve and Bruce, I'm leaning towards documenting both variants:

* Creating a simple pull request using the standard git tools, as several of us are doing. Richard doesn't seem to mind. At least in my case, this applies to changes I previously submitted through the lists.
* Creating a more elaborate pull request from a branch containing commits that haven't been shared yet, typically like what Steve does. This way, people can review each patch individually by e-mail.

Unless we want to standardize our pull requests, and make sure each commit is submitted (sometimes once again) as a separate patch. In that case, we'd only document the use of scripts/create-pull-request.

Cheers
Michael.

Signature · 3 lines
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#8 lore raw
Quoted 12 lines · Michael Opdenacker via lists.yoctoproject.org

All things considered, since scripts/create-pull-request is still in use, in particular by Steve and Bruce, I'm leaning towards documenting both variants:

* Creating a simple pull request using the standard git tools, as several of us are doing. Richard doesn't seem to mind. At least in my case, this applies to changes I previously submitted through the lists.
* Creating a more elaborate pull request from a branch containing commits that haven't been shared yet, typically like what Steve does. This way, people can review each patch individually by e-mail.

Quoted 3 lines

Unless we want to standardize our pull requests, and make sure each commit is submitted (sometimes once again) as a separate patch. In that case, we'd only document the use of scripts/create-pull-request.

FWIW, I haven't used either tool for years, and I do send large patchsets. Standard git tooling is fully adequate, except for management of cover letters which I'd like to get help with.

Alex