arm64: dts: qcom: talos-evk: Add ADV7535 DSI-to-HDMI bridge
PATCH 1/1 arm64: dts: qcom: talos-evk: Add ADV7535 DSI-to-HDMI bridge
Hook up the ADV7535 DSI-to-HDMI bridge on the QCS615 Talos EVK board. This provides HDMI output through the external DSI-to-HDMI converter.
--- arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 21 ++++++ arch/arm64/boot/dts/qcom/talos-evk.dts | 76 +++++++++++++++++++++ 2 files changed, 97 insertions(+)
arch/arm64/boot/dts/qcom/talos-evk-som.dtsi +21 -0
@@ -244,6 +244,27 @@ eeprom@5f { }; }; +&mdss { + status = "okay"; +}; + +&mdss_dsi0 { + vdda-supply = <&vreg_l11a>; + + status = "okay"; +}; + +&mdss_dsi0_out { + remote-endpoint = <&adv7535_in>; + data-lanes = <0 1 2 3>; +}; + +&mdss_dsi0_phy { + vdds-supply = <&vreg_l5a>; + + status = "okay"; +}; + &pcie { perst-gpios = <&tlmm 101 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 100 GPIO_ACTIVE_HIGH>;
arch/arm64/boot/dts/qcom/talos-evk.dts +76 -0
82 lines not on this page · raw message
Signature · 1 line
2.34.1
Quoted 77 lines · Sudarshan Shetty
Hook up the ADV7535 DSI-to-HDMI bridge on the QCS615 Talos EVK board. This provides HDMI output through the external DSI-to-HDMI converter.
Signed-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 21 ++++++ arch/arm64/boot/dts/qcom/talos-evk.dts | 76 +++++++++++++++++++++ 2 files changed, 97 insertions(+)arch/arm64/boot/dts/qcom/talos-evk-som.dtsi +21
-0@@ -244,6 +244,27 @@ eeprom@5f { }; }; +&mdss { + status = "okay"; +}; + +&mdss_dsi0 { + vdda-supply = <&vreg_l11a>; + + status = "okay"; +}; + +&mdss_dsi0_out { + remote-endpoint = <&adv7535_in>; + data-lanes = <0 1 2 3>; +}; + +&mdss_dsi0_phy { + vdds-supply = <&vreg_l5a>; + + status = "okay"; +}; + &pcie { perst-gpios = <&tlmm 101 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 100 GPIO_ACTIVE_HIGH>;arch/arm64/boot/dts/qcom/talos-evk.dts +28
-0@@ -14,6 +14,82 @@ / { aliases { mmc1 = &sdhc_2; }; + + hdmi-out { + compatible = "hdmi-connector"; + type = "d"; + + port { + hdmi_con_out: endpoint { + remote-endpoint = <&adv7535_out>; + }; + }; + }; + + vreg_v1p2_out: regulator-v1p2-out { + compatible = "regulator-fixed"; + regulator-name = "vreg-v1p2-out"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + regulator-boot-on; + regulator-always-on; + }; + + vreg_v1p8_out: regulator-v1p8-out { + compatible = "regulator-fixed"; + regulator-name = "vreg-v1p8-out"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on;
arch/arm64/boot/dts/qcom/talos-evk.dts / { · line 54
Quoted 10 lines
arch/arm64/boot/dts/qcom/talos-evk.dts +10
-0+ }; + + vreg_v3p3_out: regulator-v3p3-out { + compatible = "regulator-fixed"; + regulator-name = "vreg-v3p3-out"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + };
Please describe the power grid. Are these regulators being fed by nothing and generating energy from the thin air?
Quoted 6 lines
arch/arm64/boot/dts/qcom/talos-evk.dts +6
-0+}; + +&i2c1 { + clock-frequency = <400000>; + + status = "okay";
arch/arm64/boot/dts/qcom/talos-evk.dts / { · line 70
Quoted 10 lines
arch/arm64/boot/dts/qcom/talos-evk.dts +10
-0+ + adv7535: adv7535@3d { + compatible = "adi,adv7535"; + reg = <0x3d>; + avdd-supply = <&vreg_v1p8_out>; + dvdd-supply = <&vreg_v1p8_out>; + pvdd-supply = <&vreg_v1p8_out>; + a2vdd-supply = <&vreg_v1p8_out>; + v3p3-supply = <&vreg_v3p3_out>; + v1p2-supply = <&vreg_v1p2_out>;
I think this is not correct. Please consult your schematics isntead of adding dummy regulators.
Signature · 2 lines
With best wishes Dmitry
Quoted 83 lines · Dmitry Baryshkov
Quoted 82 lines · Sudarshan Shetty
Hook up the ADV7535 DSI-to-HDMI bridge on the QCS615 Talos EVK board. This provides HDMI output through the external DSI-to-HDMI converter.
Signed-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 21 ++++++ arch/arm64/boot/dts/qcom/talos-evk.dts | 76 +++++++++++++++++++++ 2 files changed, 97 insertions(+)arch/arm64/boot/dts/qcom/talos-evk-som.dtsi +21
-0@@ -244,6 +244,27 @@ eeprom@5f { }; }; +&mdss { + status = "okay"; +}; + +&mdss_dsi0 { + vdda-supply = <&vreg_l11a>; + + status = "okay"; +}; + +&mdss_dsi0_out { + remote-endpoint = <&adv7535_in>; + data-lanes = <0 1 2 3>; +}; + +&mdss_dsi0_phy { + vdds-supply = <&vreg_l5a>; + + status = "okay"; +}; + &pcie { perst-gpios = <&tlmm 101 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 100 GPIO_ACTIVE_HIGH>;arch/arm64/boot/dts/qcom/talos-evk.dts +33
-0@@ -14,6 +14,82 @@ / { aliases { mmc1 = &sdhc_2; }; + + hdmi-out { + compatible = "hdmi-connector"; + type = "d"; + + port { + hdmi_con_out: endpoint { + remote-endpoint = <&adv7535_out>; + }; + }; + }; + + vreg_v1p2_out: regulator-v1p2-out { + compatible = "regulator-fixed"; + regulator-name = "vreg-v1p2-out"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + regulator-boot-on; + regulator-always-on; + }; + + vreg_v1p8_out: regulator-v1p8-out { + compatible = "regulator-fixed"; + regulator-name = "vreg-v1p8-out"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + vreg_v3p3_out: regulator-v3p3-out { + compatible = "regulator-fixed"; + regulator-name = "vreg-v3p3-out";
Quoted 8 lines
arch/arm64/boot/dts/qcom/talos-evk.dts / { · line 54
Quoted 5 lines
arch/arm64/boot/dts/qcom/talos-evk.dts +5
-0+ regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + };Please describe the power grid. Are these regulators being fed by nothing and generating energy from the thin air?
Thanks for the feedback.
You are right — in the previous patch, the regulators appeared to have no source, which was incorrect.
To clarify the hardware design:
The 3.3 V and 1.8 V supplies to the HDMI controller are not coming from the PMIC. They are generated on the carrier board as follows:
20 V (USBC_VBUS_IN) → 5 V rail (V5P0_OUT)
→ 3.3 V buck regulator (RAA211250) and 1.8 V LDO (TPS7A9101).
The 5 V rail (V5P0_OUT) acts as the input supply for both regulators. Both regulators are always on.
example:
v5p0_out: regulator-v5p0-out {
compatible = "regulator-fixed";
regulator-name = "v5p0_out";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
regulator-always-on;
regulator-boot-on;
};v3p3_out: regulator-v3p3-out {
compatible = "regulator-fixed";
regulator-name = "v3p3_out";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
vin-supply = <&v5p0_out>;
regulator-always-on;
regulator-boot-on;
};v1p8_out: regulator-v1p8-out {
compatible = "regulator-fixed";
regulator-name = "v1p8_out";
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
vin-supply = <&v5p0_out>;
regulator-always-on;
regulator-boot-on;
};These reflect the actual power grid of the board. The 20 V input is not modeled since it’s a raw external supply and not managed by Linux.
Please let me know if this structure looks acceptable, Thanks again for the review and guidance!
Quoted 12 lines
Quoted 12 lines
arch/arm64/boot/dts/qcom/talos-evk.dts +11
-0+}; + +&i2c1 { + clock-frequency = <400000>; + + status = "okay"; + + adv7535: adv7535@3d { + compatible = "adi,adv7535"; + reg = <0x3d>; + avdd-supply = <&vreg_v1p8_out>;
Quoted 8 lines
arch/arm64/boot/dts/qcom/talos-evk.dts / { · line 70
Quoted 5 lines
arch/arm64/boot/dts/qcom/talos-evk.dts +5
-0+ dvdd-supply = <&vreg_v1p8_out>; + pvdd-supply = <&vreg_v1p8_out>; + a2vdd-supply = <&vreg_v1p8_out>; + v3p3-supply = <&vreg_v3p3_out>; + v1p2-supply = <&vreg_v1p2_out>;I think this is not correct. Please consult your schematics isntead of adding dummy regulators.
Will take care in v2 patch.
Quoted 2 lines
Quoted 139 lines · Tessolve Upstream
Quoted 83 lines · Dmitry Baryshkov
Quoted 82 lines · Sudarshan Shetty
Hook up the ADV7535 DSI-to-HDMI bridge on the QCS615 Talos EVK board. This provides HDMI output through the external DSI-to-HDMI converter.
Signed-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 21 ++++++ arch/arm64/boot/dts/qcom/talos-evk.dts | 76 +++++++++++++++++++++ 2 files changed, 97 insertions(+)arch/arm64/boot/dts/qcom/talos-evk-som.dtsi +21
-0@@ -244,6 +244,27 @@ eeprom@5f { }; }; +&mdss { + status = "okay"; +}; + +&mdss_dsi0 { + vdda-supply = <&vreg_l11a>; + + status = "okay"; +}; + +&mdss_dsi0_out { + remote-endpoint = <&adv7535_in>; + data-lanes = <0 1 2 3>; +}; + +&mdss_dsi0_phy { + vdds-supply = <&vreg_l5a>; + + status = "okay"; +}; + &pcie { perst-gpios = <&tlmm 101 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 100 GPIO_ACTIVE_HIGH>;arch/arm64/boot/dts/qcom/talos-evk.dts +33
-0@@ -14,6 +14,82 @@ / { aliases { mmc1 = &sdhc_2; }; + + hdmi-out { + compatible = "hdmi-connector"; + type = "d"; + + port { + hdmi_con_out: endpoint { + remote-endpoint = <&adv7535_out>; + }; + }; + }; + + vreg_v1p2_out: regulator-v1p2-out { + compatible = "regulator-fixed"; + regulator-name = "vreg-v1p2-out"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + regulator-boot-on; + regulator-always-on; + }; + + vreg_v1p8_out: regulator-v1p8-out { + compatible = "regulator-fixed"; + regulator-name = "vreg-v1p8-out"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + vreg_v3p3_out: regulator-v3p3-out { + compatible = "regulator-fixed"; + regulator-name = "vreg-v3p3-out";Quoted 8 lines
arch/arm64/boot/dts/qcom/talos-evk.dts / { · line 54
Quoted 5 lines
arch/arm64/boot/dts/qcom/talos-evk.dts +5
-0+ regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + };Please describe the power grid. Are these regulators being fed by nothing and generating energy from the thin air?
Thanks for the feedback.
You are right — in the previous patch, the regulators appeared to have no source, which was incorrect.To clarify the hardware design:
The 3.3 V and 1.8 V supplies to the HDMI controller are not coming from the PMIC. They are generated on the carrier board as follows:20 V (
USBC_VBUS_IN) → 5 V rail (V5P0_OUT)
→ 3.3 V buck regulator (RAA211250) and 1.8 V LDO (TPS7A9101).The 5 V rail (
V5P0_OUT) acts as the input supply for both regulators. Both regulators are always on.example:
v5p0_out: regulator-v5p0-out { compatible = "regulator-fixed"; regulator-name = "v5p0_out"; regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>; regulator-always-on; regulator-boot-on; };v3p3_out: regulator-v3p3-out { compatible = "regulator-fixed"; regulator-name = "v3p3_out"; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; vin-supply = <&v5p0_out>; regulator-always-on; regulator-boot-on; };v1p8_out: regulator-v1p8-out { compatible = "regulator-fixed"; regulator-name = "v1p8_out"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; vin-supply = <&v5p0_out>; regulator-always-on; regulator-boot-on; };
Quoted 6 lines
These reflect the actual power grid of the board. The 20 V input is not modeled since it’s a raw external supply and not managed by Linux.
Please let me know if this structure looks acceptable, Thanks again for the review and guidance!
I think this is perfectly fine, especially if you add the "powered by system 20V rail" comment to the 5V regulator.
Quoted 25 lines
Quoted 12 lines
Quoted 12 lines
arch/arm64/boot/dts/qcom/talos-evk.dts +11
-0+}; + +&i2c1 { + clock-frequency = <400000>; + + status = "okay"; + + adv7535: adv7535@3d { + compatible = "adi,adv7535"; + reg = <0x3d>; + avdd-supply = <&vreg_v1p8_out>;Quoted 8 lines
arch/arm64/boot/dts/qcom/talos-evk.dts / { · line 70
Quoted 5 lines
arch/arm64/boot/dts/qcom/talos-evk.dts +5
-0+ dvdd-supply = <&vreg_v1p8_out>; + pvdd-supply = <&vreg_v1p8_out>; + a2vdd-supply = <&vreg_v1p8_out>; + v3p3-supply = <&vreg_v3p3_out>; + v1p2-supply = <&vreg_v1p2_out>;I think this is not correct. Please consult your schematics isntead of adding dummy regulators.
Will take care in v2 patch.
Quoted 2 lines
Signature · 2 lines
With best wishes Dmitry
Quoted 144 lines · Dmitry Baryshkov
Quoted 143 lines · Tessolve Upstream
Quoted 83 lines · Dmitry Baryshkov
Quoted 82 lines · Sudarshan Shetty
Hook up the ADV7535 DSI-to-HDMI bridge on the QCS615 Talos EVK board. This provides HDMI output through the external DSI-to-HDMI converter.
Signed-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 21 ++++++ arch/arm64/boot/dts/qcom/talos-evk.dts | 76 +++++++++++++++++++++ 2 files changed, 97 insertions(+)arch/arm64/boot/dts/qcom/talos-evk-som.dtsi +21
-0@@ -244,6 +244,27 @@ eeprom@5f { }; }; +&mdss { + status = "okay"; +}; + +&mdss_dsi0 { + vdda-supply = <&vreg_l11a>; + + status = "okay"; +}; + +&mdss_dsi0_out { + remote-endpoint = <&adv7535_in>; + data-lanes = <0 1 2 3>; +}; + +&mdss_dsi0_phy { + vdds-supply = <&vreg_l5a>; + + status = "okay"; +}; + &pcie { perst-gpios = <&tlmm 101 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 100 GPIO_ACTIVE_HIGH>;arch/arm64/boot/dts/qcom/talos-evk.dts +33
-0@@ -14,6 +14,82 @@ / { aliases { mmc1 = &sdhc_2; }; + + hdmi-out { + compatible = "hdmi-connector"; + type = "d"; + + port { + hdmi_con_out: endpoint { + remote-endpoint = <&adv7535_out>; + }; + }; + }; + + vreg_v1p2_out: regulator-v1p2-out { + compatible = "regulator-fixed"; + regulator-name = "vreg-v1p2-out"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + regulator-boot-on; + regulator-always-on; + }; + + vreg_v1p8_out: regulator-v1p8-out { + compatible = "regulator-fixed"; + regulator-name = "vreg-v1p8-out"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + vreg_v3p3_out: regulator-v3p3-out { + compatible = "regulator-fixed"; + regulator-name = "vreg-v3p3-out";Quoted 8 lines
arch/arm64/boot/dts/qcom/talos-evk.dts / { · line 54
Quoted 5 lines
arch/arm64/boot/dts/qcom/talos-evk.dts +5
-0+ regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + };Please describe the power grid. Are these regulators being fed by nothing and generating energy from the thin air?
Thanks for the feedback.
You are right — in the previous patch, the regulators appeared to have no source, which was incorrect.To clarify the hardware design:
The 3.3 V and 1.8 V supplies to the HDMI controller are not coming from the PMIC. They are generated on the carrier board as follows:20 V (
USBC_VBUS_IN) → 5 V rail (V5P0_OUT)
→ 3.3 V buck regulator (RAA211250) and 1.8 V LDO (TPS7A9101).The 5 V rail (
V5P0_OUT) acts as the input supply for both regulators. Both regulators are always on.example:
v5p0_out: regulator-v5p0-out { compatible = "regulator-fixed"; regulator-name = "v5p0_out"; regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>; regulator-always-on; regulator-boot-on; };v3p3_out: regulator-v3p3-out { compatible = "regulator-fixed"; regulator-name = "v3p3_out"; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; vin-supply = <&v5p0_out>; regulator-always-on; regulator-boot-on; };v1p8_out: regulator-v1p8-out { compatible = "regulator-fixed"; regulator-name = "v1p8_out"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; vin-supply = <&v5p0_out>; regulator-always-on; regulator-boot-on; };These reflect the actual power grid of the board. The 20 V input is not modeled since it’s a raw external supply and not managed by Linux.
Quoted 5 lines
Quoted 2 lines
Please let me know if this structure looks acceptable, Thanks again for the review and guidance!
I think this is perfectly fine, especially if you add the "powered by system 20V rail" comment to the 5V regulator.
Thanks!
Will update in v2 patch.
Quoted 27 lines
Quoted 26 lines
Quoted 13 lines
Quoted 13 lines
arch/arm64/boot/dts/qcom/talos-evk.dts +11
-0+}; + +&i2c1 { + clock-frequency = <400000>; + + status = "okay"; + + adv7535: adv7535@3d { + compatible = "adi,adv7535"; + reg = <0x3d>; + avdd-supply = <&vreg_v1p8_out>;Quoted 8 lines
arch/arm64/boot/dts/qcom/talos-evk.dts / { · line 70
Quoted 5 lines
arch/arm64/boot/dts/qcom/talos-evk.dts +5
-0+ dvdd-supply = <&vreg_v1p8_out>; + pvdd-supply = <&vreg_v1p8_out>; + a2vdd-supply = <&vreg_v1p8_out>; + v3p3-supply = <&vreg_v3p3_out>; + v1p2-supply = <&vreg_v1p2_out>;I think this is not correct. Please consult your schematics isntead of adding dummy regulators.
Will take care in v2 patch.
Quoted 2 lines
Quoted 8 lines · Sudarshan Shetty
Hook up the ADV7535 DSI-to-HDMI bridge on the QCS615 Talos EVK board. This provides HDMI output through the external DSI-to-HDMI converter.
Signed-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 21 ++++++ arch/arm64/boot/dts/qcom/talos-evk.dts | 76 +++++++++++++++++++++ 2 files changed, 97 insertions(+)
There is no such file.
You need to squash it into original posting.
Best regards,
Krzysztof
Quoted 10 lines · Krzysztof Kozlowski
Quoted 8 lines · Sudarshan Shetty
Hook up the ADV7535 DSI-to-HDMI bridge on the QCS615 Talos EVK board. This provides HDMI output through the external DSI-to-HDMI converter.
Signed-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 21 ++++++ arch/arm64/boot/dts/qcom/talos-evk.dts | 76 +++++++++++++++++++++ 2 files changed, 97 insertions(+)
Quoted 3 lines
There is no such file.
You need to squash it into original posting.
Thanks for the review and guidance!
Understood! I will squash it into original post.
Quoted 3 lines
Best regards,
Krzysztof