Skip to contentSkip to conversation

net: dsa: ksz8795: use correct number of physical ports

PATCH In review Sven Van Asbroeck 4 participants 5 messages Dec 3, 2020 – Dec 5, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: dsa: ksz8795: use correct number of physical ports

From: Sven Van Asbroeck <[email protected]>

The ksz8795 has five physical ports, but the driver assumes it has only four. This prevents the driver from working correctly.

Fix by indicating the correct number of physical ports.

Fixes e66f840c08a23 ("net: dsa: ksz: Add Microchip KSZ8795 DSA driver")

---

Tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git # 39e367766fe1

To: Woojung Huh <[email protected]>
To: Andrew Lunn <[email protected]>
To: Vivien Didelot <[email protected]>
To: Florian Fainelli <[email protected]>
To: Vladimir Oltean <[email protected]>
To: "David S. Miller" <[email protected]>
To: Jakub Kicinski <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: Tristram Ha <[email protected]>
Cc: Microchip Linux Driver Support <[email protected]>
Cc: [email protected]
Cc: [email protected] (open list)

 drivers/net/dsa/microchip/ksz8795.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/dsa/microchip/ksz8795.c +1 -1
index 1e101ab56cea..367cebe37ae6 100644
@@ -1194,7 +1194,7 @@ static const struct ksz_chip_data ksz8795_switch_chips[] = {
 		.num_alus = 0,
 		.num_statics = 8,
 		.cpu_ports = 0x10,	/* can be configured as cpu port */
-		.port_cnt = 4,		/* total physical port count */
+		.port_cnt = 5,		/* total physical port count */
 	},
 	{
 		.chip_id = 0x8794,
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Sven Van Asbroeck

From: Sven Van Asbroeck <[email protected]>

The ksz8795 has five physical ports, but the driver assumes it has only four. This prevents the driver from working correctly.

Fix by indicating the correct number of physical ports.

Fixes e66f840c08a23 ("net: dsa: ksz: Add Microchip KSZ8795 DSA driver")
Signature · 1 line
Florian
maintainer
#2 lore raw
In reply to Sven Van Asbroeck
Quoted 10 lines · On Thu, 3 Dec 2020 16:46:45 -0500 Sven Van Asbroeck wrote:

From: Sven Van Asbroeck <[email protected]>

The ksz8795 has five physical ports, but the driver assumes it has only four. This prevents the driver from working correctly.

Fix by indicating the correct number of physical ports.

Fixes e66f840c08a23 ("net: dsa: ksz: Add Microchip KSZ8795 DSA driver")

All the port counts here are -1 compared to datasheets, so I'm assuming the are not supposed to include the host facing port or something?

Can you describe the exact problem you're trying to solve?

DSA devices are not supposed to have a netdev for the host facing port on the switch (sorry for stating the obvious).

Quoted 13 lines
drivers/net/dsa/microchip/ksz8795.c +1 -1
index 1e101ab56cea..367cebe37ae6 100644
@@ -1194,7 +1194,7 @@ static const struct ksz_chip_data ksz8795_switch_chips[] = {
 		.num_alus = 0,
 		.num_statics = 8,
 		.cpu_ports = 0x10,	/* can be configured as cpu port */
-		.port_cnt = 4,		/* total physical port count */
+		.port_cnt = 5,		/* total physical port count */
 	},
 	{
 		.chip_id = 0x8794,
maintainer
#3 lore raw
Quoted 12 lines · Jakub Kicinski
Quoted 10 lines · On Thu, 3 Dec 2020 16:46:45 -0500 Sven Van Asbroeck wrote:

From: Sven Van Asbroeck <[email protected]>

The ksz8795 has five physical ports, but the driver assumes it has only four. This prevents the driver from working correctly.

Fix by indicating the correct number of physical ports.

Fixes e66f840c08a23 ("net: dsa: ksz: Add Microchip KSZ8795 DSA driver")
Quoted 7 lines

All the port counts here are -1 compared to datasheets, so I'm assuming the are not supposed to include the host facing port or something?

Can you describe the exact problem you're trying to solve?

DSA devices are not supposed to have a netdev for the host facing port on the switch (sorry for stating the obvious).

Hi Jakub

It is the DSA core layer which takes care of that creating/not creating netdevs. The switch should declare all the ports it has.

There has been issues with the ksz collection of drivers having different meanings for port_cnt. There recently was some changes in this area, maybe it broke something?

Andrew

#4 lore raw

Jakub, Andrew,

Quoted 6 lines · Jakub Kicinski

All the port counts here are -1 compared to datasheets, so I'm assuming the are not supposed to include the host facing port or something?

Can you describe the exact problem you're trying to solve?

The ksz8795 driver refuses to accept my devicetree (see below). It doesn't like the presence of the cpu node. But I really need a cpu node, because phy-mode is crucially important to my application: without phy-mode = "rgmii-id", the ksz8795's ingress bit does not get set, and communication fails.

I was already suspicious of my fix: why would such an important chip property be wrong? But changing it was very seductive: after all, the ksz8795's headline is "Integrated 5-Port 10/100-Managed Ethernet Switch", and the driver code says this:

.port_cnt = 4, /* total physical port count */

I can see now that this should be fixed more generally. The of parsing code is using the wrong port count variable. I'll submit that shortly.

That said, when I look at this driver, I get very confused between port_cnt, num_ports, and whether they include or exclude the cpu port. Until this gets cleaned up, maybe the comment above can be improved, so developers don't get too confused at least? I'll submit a patch for that too.

ethernet-switch@0 {
        compatible = "microchip,ksz8795";
        spi-max-frequency = <1000000>;
        reg = <0>;

        ports {
                #address-cells = <1>;
                #size-cells = <0>;
                port@0 {
                        reg = <0>;
                        label = "lan1";
                };
                port@1 {
                        reg = <1>;
                        label = "lan2";
                };
                port@2 {
                        reg = <2>;
                        label = "lan3";
                };
                port@3 {
                        reg = <3>;
                        label = "lan4";
                };
                port@4 {
                        /* driver errors out because
                         * reg >= dev->port_cnt (4)
                         */
                        reg = <4>;
                        label = "cpu";
                        ethernet = <&something>;
                        phy-mode = "rgmii-id";
                        fixed-link {
                                speed = <1000>;
                                full-duplex;
                        };
                };
        };
};