Skip to contentSkip to conversation

drm/komeda: add NV12 format to support writeback layer type

PATCH In review baozhu.liu 2 participants 4 messages Aug 29, 2023 – Sep 12, 2023

Subsystems (4)
lore
Share & tools
lore

baozhu.liu

author
#0 lore raw

PATCH 1/1 drm/komeda: add NV12 format to support writeback layer type

When testing the d71 writeback layer function,
the output format is set to NV12, and the following error message is displayed:

[drm:komeda_fb_is_layer_supported] Layer TYPE: 4 doesn't support fb FMT: NV12 little-endian (0x3231564e) with modifier: 0x0..

Check the d71 data manual, writeback layer output formats includes NV12 format.

---
 drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c +1 -1
index 6c56f5662bc7..80973975bfdb 100644
@@ -521,7 +521,7 @@ static struct komeda_format_caps d71_format_caps_table[] = {
 	{__HW_ID(5, 1),	DRM_FORMAT_YUYV,	RICH,		Rot_ALL_H_V,	LYT_NM, AFB_TH}, /* afbc */
 	{__HW_ID(5, 2),	DRM_FORMAT_YUYV,	RICH,		Flip_H_V,		0, 0},
 	{__HW_ID(5, 3),	DRM_FORMAT_UYVY,	RICH,		Flip_H_V,		0, 0},
-	{__HW_ID(5, 6),	DRM_FORMAT_NV12,	RICH,		Flip_H_V,		0, 0},
+	{__HW_ID(5, 6),	DRM_FORMAT_NV12,	RICH_WB,	Flip_H_V,		0, 0},
 	{__HW_ID(5, 6),	DRM_FORMAT_YUV420_8BIT,	RICH,		Rot_ALL_H_V,	LYT_NM, AFB_TH}, /* afbc */
 	{__HW_ID(5, 7),	DRM_FORMAT_YUV420,	RICH,		Flip_H_V,		0, 0},
 	/* YUV 10bit*/
Signature · 1 line
2.17.1
#1 lore raw

Hi all,

Do you have any suggestions for the patch I submitted? Please also let me know, thank you!

Best Regards,
baozhu.liu
-----邮件原件-----
发件人: baozhu.liu <[email protected]>
发送时间: 2023年8月29日 17:30
收件人: [email protected]; [email protected]; [email protected]
抄送: [email protected]; [email protected]; Liu Lucas/刘保柱 <[email protected]> 主题: [PATCH] drm/komeda: add NV12 format to support writeback layer type

When testing the d71 writeback layer function, the output format is set to NV12, and the following error message is displayed:

[drm:komeda_fb_is_layer_supported] Layer TYPE: 4 doesn't support fb FMT: NV12 little-endian (0x3231564e) with modifier: 0x0..

Check the d71 data manual, writeback layer output formats includes NV12 format.

---
 drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c +1 -1
index 6c56f5662bc7..80973975bfdb 100644
@@ -521,7 +521,7 @@ static struct komeda_format_caps d71_format_caps_table[] = {
 	{__HW_ID(5, 1),	DRM_FORMAT_YUYV,	RICH,		Rot_ALL_H_V,	LYT_NM, AFB_TH}, /* afbc */
 	{__HW_ID(5, 2),	DRM_FORMAT_YUYV,	RICH,		Flip_H_V,		0, 0},
 	{__HW_ID(5, 3),	DRM_FORMAT_UYVY,	RICH,		Flip_H_V,		0, 0},
-	{__HW_ID(5, 6),	DRM_FORMAT_NV12,	RICH,		Flip_H_V,		0, 0},
+	{__HW_ID(5, 6),	DRM_FORMAT_NV12,	RICH_WB,	Flip_H_V,		0, 0},
 	{__HW_ID(5, 6),	DRM_FORMAT_YUV420_8BIT,	RICH,		Rot_ALL_H_V,	LYT_NM, AFB_TH}, /* afbc */
 	{__HW_ID(5, 7),	DRM_FORMAT_YUV420,	RICH,		Flip_H_V,		0, 0},
 	/* YUV 10bit*/

--
2.17.1

maintainer Acked-by
#2 lore raw

Hi Liu,

Sorry about the delay, I was on holiday until 28th and while cleaning up the backlog I've accidentally marked the email as read and did not reply.

Quoted 13 lines · Liu Lucas/刘保柱

Hi all,

Do you have any suggestions for the patch I submitted? Please also let me know, thank you!

Best Regards,
baozhu.liu
-----邮件原件-----
发件人: baozhu.liu <[email protected]>
发送时间: 2023年8月29日 17:30
收件人: [email protected]; [email protected]; [email protected]
抄送: [email protected]; [email protected]; Liu Lucas/刘保柱 <[email protected]> 主题: [PATCH] drm/komeda: add NV12 format to support writeback layer type

Quoted 7 lines

When testing the d71 writeback layer function, the output format is set to NV12, and the following error message is displayed:

[drm:komeda_fb_is_layer_supported] Layer TYPE: 4 doesn't support fb FMT: NV12 little-endian (0x3231564e) with modifier: 0x0..

Check the d71 data manual, writeback layer output formats includes NV12 format.

I will push the patch this week into drm-misc-next.

Best regards,
Liviu

Quoted 20 lines
---
 drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c +1 -2
index 6c56f5662bc7..80973975bfdb 100644
@@ -521,7 +521,7 @@ static struct komeda_format_caps d71_format_caps_table[] = {
 	{__HW_ID(5, 1),	DRM_FORMAT_YUYV,	RICH,		Rot_ALL_H_V,	LYT_NM, AFB_TH}, /* afbc */
 	{__HW_ID(5, 2),	DRM_FORMAT_YUYV,	RICH,		Flip_H_V,		0, 0},
 	{__HW_ID(5, 3),	DRM_FORMAT_UYVY,	RICH,		Flip_H_V,		0, 0},
-	{__HW_ID(5, 6),	DRM_FORMAT_NV12,	RICH,		Flip_H_V,		0, 0},
+	{__HW_ID(5, 6),	DRM_FORMAT_NV12,	RICH_WB,	Flip_H_V,		0, 0},
 	{__HW_ID(5, 6),	DRM_FORMAT_YUV420_8BIT,	RICH,		Rot_ALL_H_V,	LYT_NM, AFB_TH}, /* afbc */
 	{__HW_ID(5, 7),	DRM_FORMAT_YUV420,	RICH,		Flip_H_V,		0, 0},
 	/* YUV 10bit*/
--

2.17.1

Signature · 8 lines
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
author Acked-by Liviu Dudau
#3 lore raw

Hi Liviu,

Thank you so much for reviewing this patch! I expect this patch to be merged.

Best Regards,
baozhu.liu

-----邮件原件-----
发件人: [email protected] <[email protected]>
发送时间: 2023年9月11日 22:46
收件人: Liu Lucas/刘保柱 <[email protected]>
抄送: [email protected]; [email protected]; [email protected]; [email protected] 主题: Re: 回复: [PATCH] drm/komeda: add NV12 format to support writeback layer type

Hi Liu,

Sorry about the delay, I was on holiday until 28th and while cleaning up the backlog I've accidentally marked the email as read and did not reply.

Quoted 15 lines · Liu Lucas/刘保柱

Hi all,

Do you have any suggestions for the patch I submitted? Please also let me know, thank you!

Best Regards,
baozhu.liu
-----邮件原件-----
发件人: baozhu.liu <[email protected]>
发送时间: 2023年8月29日 17:30
收件人: [email protected]; [email protected]; [email protected] 抄送: [email protected]; [email protected]; Liu Lucas/刘保柱 <[email protected]>
主题: [PATCH] drm/komeda: add NV12 format to support writeback layer type

Quoted 7 lines

When testing the d71 writeback layer function, the output format is set to NV12, and the following error message is displayed:

[drm:komeda_fb_is_layer_supported] Layer TYPE: 4 doesn't support fb FMT: NV12 little-endian (0x3231564e) with modifier: 0x0..

Check the d71 data manual, writeback layer output formats includes NV12 format.

I will push the patch this week into drm-misc-next.

Best regards,
Liviu

Quoted 19 lines
---
 drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c +1 -2
index 6c56f5662bc7..80973975bfdb 100644
@@ -521,7 +521,7 @@ static struct komeda_format_caps d71_format_caps_table[] = {
 	{__HW_ID(5, 1),	DRM_FORMAT_YUYV,	RICH,		Rot_ALL_H_V,	LYT_NM, AFB_TH}, /* afbc */
 	{__HW_ID(5, 2),	DRM_FORMAT_YUYV,	RICH,		Flip_H_V,		0, 0},
 	{__HW_ID(5, 3),	DRM_FORMAT_UYVY,	RICH,		Flip_H_V,		0, 0},
-	{__HW_ID(5, 6),	DRM_FORMAT_NV12,	RICH,		Flip_H_V,		0, 0},
+	{__HW_ID(5, 6),	DRM_FORMAT_NV12,	RICH_WB,	Flip_H_V,		0, 0},
 	{__HW_ID(5, 6),	DRM_FORMAT_YUV420_8BIT,	RICH,		Rot_ALL_H_V,	LYT_NM, AFB_TH}, /* afbc */
 	{__HW_ID(5, 7),	DRM_FORMAT_YUV420,	RICH,		Flip_H_V,		0, 0},
 	/* YUV 10bit*/
--
Quoted 2 lines

2.17.1

--
====================

| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯