Skip to contentSkip to conversation

app/testpmd: fix offloads default set error

PATCH Applied Wei Zhao 3 participants 8 messages Jun 10, 2019 – Jul 2, 2019

lore
Share & tools
lore

Wei Zhao

author
#0 lore raw

PATCH 1/1 app/testpmd: fix offloads default set error

There is no need to use default offloads configuration if offloads configuration has been pass down from uplayer.

Fixes 5e91aeef218c ("app/testpmd: fix offload flags after port config")
---
 app/test-pmd/testpmd.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
app/test-pmd/testpmd.c +4 -2
index 0148b0a..b5f5801 100644
@@ -2815,7 +2815,8 @@ rxtx_port_config(struct rte_port *port)
 	for (qid = 0; qid < nb_rxq; qid++) {
 		offloads = port->rx_conf[qid].offloads;
 		port->rx_conf[qid] = port->dev_info.default_rxconf;
-		port->rx_conf[qid].offloads |= offloads;
+		if (offloads)
+			port->rx_conf[qid].offloads = offloads;
 
 		/* Check if any Rx parameters have been passed */
 		if (rx_pthresh != RTE_PMD_PARAM_UNSET)
@@ -2839,7 +2840,8 @@ rxtx_port_config(struct rte_port *port)
 	for (qid = 0; qid < nb_txq; qid++) {
 		offloads = port->tx_conf[qid].offloads;
 		port->tx_conf[qid] = port->dev_info.default_txconf;
-		port->tx_conf[qid].offloads |= offloads;
+		if (offloads)
+			port->tx_conf[qid].offloads = offloads;
 
 		/* Check if any Tx parameters have been passed */
 		if (tx_pthresh != RTE_PMD_PARAM_UNSET)
Signature · 1 line
2.7.5
#1 lore raw
Quoted 3 lines · Wei Zhao

There is no need to use default offloads configuration if offloads configuration has been pass down from uplayer.

It doesn't seem like the right fix to me. It means if a user enable/disable one offload in the command line they are silently changing from the default behaviour of other offloads? I could understand if the user set all offloads in one go through a mask but not when they are set seemingly independent.

It looks like you need to track which ones have been enabled/disabled by the user, and use the default for for the other offloads.

Quoted 32 lines
Fixes 5e91aeef218c ("app/testpmd: fix offload flags after port config")
---
 app/test-pmd/testpmd.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
app/test-pmd/testpmd.c +4 -2
index 0148b0a..b5f5801 100644
@@ -2815,7 +2815,8 @@ rxtx_port_config(struct rte_port *port)
 	for (qid = 0; qid < nb_rxq; qid++) {
 		offloads = port->rx_conf[qid].offloads;
 		port->rx_conf[qid] = port->dev_info.default_rxconf;
-		port->rx_conf[qid].offloads |= offloads;
+		if (offloads)
+			port->rx_conf[qid].offloads = offloads;
 
 		/* Check if any Rx parameters have been passed */
 		if (rx_pthresh != RTE_PMD_PARAM_UNSET)
@@ -2839,7 +2840,8 @@ rxtx_port_config(struct rte_port *port)
 	for (qid = 0; qid < nb_txq; qid++) {
 		offloads = port->tx_conf[qid].offloads;
 		port->tx_conf[qid] = port->dev_info.default_txconf;
-		port->tx_conf[qid].offloads |= offloads;
+		if (offloads)
+			port->tx_conf[qid].offloads = offloads;
 
 		/* Check if any Tx parameters have been passed */
 		if (tx_pthresh != RTE_PMD_PARAM_UNSET)
author
#2 lore raw

Hi, Kevin Traynor
This patch is based on Yigit Ferruh's suggestion in the following mail.
https://mails.dpdk.org/archives/dev/2019-May/132178.html
If we take your propose, it means we do need any patch at all. Because the code implement now is just that scheme, we will do "or" for offloads. Hello Ferruh,What is your comment?

Quoted 54 lines

-----Original Message-----
From: Kevin Traynor [mailto:[email protected]]
Sent: Monday, June 10, 2019 6:10 PM
To: Zhao1, Wei <[email protected]>; [email protected]
Cc: [email protected]; Yigit, Ferruh <[email protected]>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

Quoted 3 lines · Wei Zhao

There is no need to use default offloads configuration if offloads configuration has been pass down from uplayer.

It doesn't seem like the right fix to me. It means if a user enable/disable one offload in the command line they are silently changing from the default behaviour of other offloads? I could understand if the user set all offloads in one go through a mask but not when they are set seemingly independent.

It looks like you need to track which ones have been enabled/disabled by the user, and use the default for for the other offloads.

Quoted 13 lines
Fixes 5e91aeef218c ("app/testpmd: fix offload flags after port

config")

---
 app/test-pmd/testpmd.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
app/test-pmd/testpmd.c index renamed from app/test-pmd/testpmd.c +0 -0

0148b0a..b5f5801 100644

app/test-pmd/testpmd.c rxtx_port_config(struct rte_port *port) · line 2822

Quoted 9 lines
app/test-pmd/testpmd.c +2 -1
@@ -2815,7 +2815,8 @@ rxtx_port_config(struct rte_port *port)
 	for (qid = 0; qid < nb_rxq; qid++) {
 		offloads = port->rx_conf[qid].offloads;
 		port->rx_conf[qid] = port->dev_info.default_rxconf;
-		port->rx_conf[qid].offloads |= offloads;
+		if (offloads)
+			port->rx_conf[qid].offloads = offloads;
 
 		/* Check if any Rx parameters have been passed */
 		if (rx_pthresh != RTE_PMD_PARAM_UNSET) @@ -2839,7

+2840,8 @@

Quoted 11 lines

rxtx_port_config(struct rte_port *port)

app/test-pmd/testpmd.c +2 -1
 	for (qid = 0; qid < nb_txq; qid++) {
 		offloads = port->tx_conf[qid].offloads;
 		port->tx_conf[qid] = port->dev_info.default_txconf;
-		port->tx_conf[qid].offloads |= offloads;
+		if (offloads)
+			port->tx_conf[qid].offloads = offloads;
 
 		/* Check if any Tx parameters have been passed */
 		if (tx_pthresh != RTE_PMD_PARAM_UNSET)
#3 lore raw
Quoted 6 lines · Wei

Hi, Kevin Traynor
This patch is based on Yigit Ferruh's suggestion in the following mail.
https://mails.dpdk.org/archives/dev/2019-May/132178.html
If we take your propose, it means we do need any patch at all. Because the code implement now is just that scheme, we will do "or" for offloads. Hello Ferruh,What is your comment?

My comment was if the user not set the queue offload use the default one, so I think we don't need to track individual offload options.

But also there is slightly difference between user not set the value and 'offloads' being zero. What if user set the offloads value to '0' to disable all offloads, it will use default values in this case.

Quoted 56 lines
Quoted 55 lines

-----Original Message-----
From: Kevin Traynor [mailto:[email protected]]
Sent: Monday, June 10, 2019 6:10 PM
To: Zhao1, Wei <[email protected]>; [email protected]
Cc: [email protected]; Yigit, Ferruh <[email protected]>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

Quoted 3 lines · Wei Zhao

There is no need to use default offloads configuration if offloads configuration has been pass down from uplayer.

It doesn't seem like the right fix to me. It means if a user enable/disable one offload in the command line they are silently changing from the default behaviour of other offloads? I could understand if the user set all offloads in one go through a mask but not when they are set seemingly independent.

It looks like you need to track which ones have been enabled/disabled by the user, and use the default for for the other offloads.

Quoted 13 lines
Fixes 5e91aeef218c ("app/testpmd: fix offload flags after port

config")

---
 app/test-pmd/testpmd.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
app/test-pmd/testpmd.c index renamed from app/test-pmd/testpmd.c +0 -0

0148b0a..b5f5801 100644

app/test-pmd/testpmd.c rxtx_port_config(struct rte_port *port) · line 2822

Quoted 9 lines
app/test-pmd/testpmd.c +2 -1
@@ -2815,7 +2815,8 @@ rxtx_port_config(struct rte_port *port)
 	for (qid = 0; qid < nb_rxq; qid++) {
 		offloads = port->rx_conf[qid].offloads;
 		port->rx_conf[qid] = port->dev_info.default_rxconf;
-		port->rx_conf[qid].offloads |= offloads;
+		if (offloads)
+			port->rx_conf[qid].offloads = offloads;
 
 		/* Check if any Rx parameters have been passed */
 		if (rx_pthresh != RTE_PMD_PARAM_UNSET) @@ -2839,7

+2840,8 @@

Quoted 11 lines

rxtx_port_config(struct rte_port *port)

app/test-pmd/testpmd.c +2 -1
 	for (qid = 0; qid < nb_txq; qid++) {
 		offloads = port->tx_conf[qid].offloads;
 		port->tx_conf[qid] = port->dev_info.default_txconf;
-		port->tx_conf[qid].offloads |= offloads;
+		if (offloads)
+			port->tx_conf[qid].offloads = offloads;
 
 		/* Check if any Tx parameters have been passed */
 		if (tx_pthresh != RTE_PMD_PARAM_UNSET)
author
#4 lore raw
Quoted 17 lines

-----Original Message-----
From: Yigit, Ferruh
Sent: Tuesday, June 11, 2019 10:42 PM
To: Zhao1, Wei <[email protected]>; Kevin Traynor <[email protected]>; [email protected]
Cc: [email protected]
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

Quoted 5 lines · Wei

Hi, Kevin Traynor
This patch is based on Yigit Ferruh's suggestion in the following mail.
https://mails.dpdk.org/archives/dev/2019-May/132178.html
If we take your propose, it means we do need any patch at all. Because the code implement now is just that scheme, we will do "or" for

offloads.

Quoted 9 lines
Quoted 1 line

Hello Ferruh,What is your comment?

My comment was if the user not set the queue offload use the default one, so I think we don't need to track individual offload options.

But also there is slightly difference between user not set the value and 'offloads' being zero. What if user set the offloads value to '0' to disable all offloads, it will use default values in this case.

Yes, we can not distinguish between not set the value and using 0 to disable it, so if the bit is 0 how can we Know the actual purpose of users? I think it is hard track individual offload as Kevin Traynor said.

Quoted 58 lines
Quoted 10 lines
Quoted 10 lines

-----Original Message-----
From: Kevin Traynor [mailto:[email protected]]
Sent: Monday, June 10, 2019 6:10 PM
To: Zhao1, Wei <[email protected]>; [email protected]
Cc: [email protected]; Yigit, Ferruh <[email protected]>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

On 10/06/2019 07:45, Wei Zhao wrote:

Quoted 8 lines
Quoted 8 lines
Quoted 3 lines

There is no need to use default offloads configuration if offloads configuration has been pass down from uplayer.

It doesn't seem like the right fix to me. It means if a user enable/disable one offload in the command line they are silently changing from the default behaviour of other offloads? I could understand if the user set all offloads in one go through a mask but not

when they are set seemingly independent.

Quoted 39 lines
Quoted 38 lines

It looks like you need to track which ones have been enabled/disabled by the user, and use the default for for the other offloads.

Quoted 13 lines
Fixes 5e91aeef218c ("app/testpmd: fix offload flags after port

config")

---
 app/test-pmd/testpmd.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
app/test-pmd/testpmd.c index renamed from app/test-pmd/testpmd.c +0 -0

0148b0a..b5f5801 100644

app/test-pmd/testpmd.c rxtx_port_config(struct rte_port *port) · line 2822

Quoted 9 lines
app/test-pmd/testpmd.c +2 -1
@@ -2815,7 +2815,8 @@ rxtx_port_config(struct rte_port *port)
 	for (qid = 0; qid < nb_rxq; qid++) {
 		offloads = port->rx_conf[qid].offloads;
 		port->rx_conf[qid] = port->dev_info.default_rxconf;
-		port->rx_conf[qid].offloads |= offloads;
+		if (offloads)
+			port->rx_conf[qid].offloads = offloads;
 
 		/* Check if any Rx parameters have been passed */
 		if (rx_pthresh != RTE_PMD_PARAM_UNSET) @@ -2839,7

+2840,8 @@

Quoted 11 lines

rxtx_port_config(struct rte_port *port)

app/test-pmd/testpmd.c +2 -1
 	for (qid = 0; qid < nb_txq; qid++) {
 		offloads = port->tx_conf[qid].offloads;
 		port->tx_conf[qid] = port->dev_info.default_txconf;
-		port->tx_conf[qid].offloads |= offloads;
+		if (offloads)
+			port->tx_conf[qid].offloads = offloads;
 
 		/* Check if any Tx parameters have been passed */
 		if (tx_pthresh != RTE_PMD_PARAM_UNSET)
Reviewed-by
#5 lore raw
Quoted 22 lines · Wei
Quoted 22 lines

-----Original Message-----
From: Yigit, Ferruh
Sent: Tuesday, June 11, 2019 10:42 PM
To: Zhao1, Wei <[email protected]>; Kevin Traynor <[email protected]>; [email protected]
Cc: [email protected]
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

Quoted 5 lines · Wei

Hi, Kevin Traynor
This patch is based on Yigit Ferruh's suggestion in the following mail.
https://mails.dpdk.org/archives/dev/2019-May/132178.html
If we take your propose, it means we do need any patch at all. Because the code implement now is just that scheme, we will do "or" for

offloads.

Quoted 1 line

Hello Ferruh,What is your comment?

My comment was if the user not set the queue offload use the default one, so I think we don't need to track individual offload options.

Quoted 7 lines
Quoted 4 lines

But also there is slightly difference between user not set the value and 'offloads' being zero. What if user set the offloads value to '0' to disable all offloads, it will use default values in this case.

Yes, we can not distinguish between not set the value and using 0 to disable it, so if the bit is 0 how can we Know the actual purpose of users? I think it is hard track individual offload as Kevin Traynor said.

Yes it is hard to track, and I believe this is better than the existing code, so:

Applied
#6 lore raw
Quoted 28 lines · Ferruh Yigit
Quoted 27 lines · Wei
Quoted 26 lines

-----Original Message-----
From: Yigit, Ferruh
Sent: Tuesday, June 11, 2019 10:42 PM
To: Zhao1, Wei <[email protected]>; Kevin Traynor <[email protected]>; [email protected]
Cc: [email protected]
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

Quoted 5 lines · Wei

Hi, Kevin Traynor
This patch is based on Yigit Ferruh's suggestion in the following mail.
https://mails.dpdk.org/archives/dev/2019-May/132178.html
If we take your propose, it means we do need any patch at all. Because the code implement now is just that scheme, we will do "or" for

offloads.

Quoted 1 line

Hello Ferruh,What is your comment?

My comment was if the user not set the queue offload use the default one, so I think we don't need to track individual offload options.

But also there is slightly difference between user not set the value and 'offloads' being zero. What if user set the offloads value to '0' to disable all offloads, it will use default values in this case.

Quoted 7 lines
Quoted 2 lines

Yes, we can not distinguish between not set the value and using 0 to disable it, so if the bit is 0 how can we Know the actual purpose of users? I think it is hard track individual offload as Kevin Traynor said.

Yes it is hard to track, and I believe this is better than the existing code, so:

Applied to dpdk-next-net/master, thanks.

author
#7 lore raw
In reply to Kevin Traynor

"If we take that propose, it means we do not need any patch at all." Sorry for typo.

Quoted 71 lines

-----Original Message-----
From: Zhao1, Wei
Sent: Tuesday, June 11, 2019 9:29 AM
To: 'Kevin Traynor' <[email protected]>; [email protected]
Cc: [email protected]; Yigit, Ferruh <[email protected]>
Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

Hi, Kevin Traynor
This patch is based on Yigit Ferruh's suggestion in the following mail.
https://mails.dpdk.org/archives/dev/2019-May/132178.html
If we take your propose, it means we do need any patch at all. Because the code implement now is just that scheme, we will do "or" for offloads.
Hello Ferruh,What is your comment?

Quoted 9 lines

-----Original Message-----
From: Kevin Traynor [mailto:[email protected]]
Sent: Monday, June 10, 2019 6:10 PM
To: Zhao1, Wei <[email protected]>; [email protected]
Cc: [email protected]; Yigit, Ferruh <[email protected]>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

On 10/06/2019 07:45, Wei Zhao wrote:

Quoted 8 lines
Quoted 3 lines

There is no need to use default offloads configuration if offloads configuration has been pass down from uplayer.

It doesn't seem like the right fix to me. It means if a user enable/disable one offload in the command line they are silently changing from the default behaviour of other offloads? I could understand if the user set all offloads in one go through a mask but not when

they are set seemingly independent.

Quoted 38 lines

It looks like you need to track which ones have been enabled/disabled by the user, and use the default for for the other offloads.

Quoted 13 lines
Fixes 5e91aeef218c ("app/testpmd: fix offload flags after port

config")

---
 app/test-pmd/testpmd.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
app/test-pmd/testpmd.c index renamed from app/test-pmd/testpmd.c +0 -0

0148b0a..b5f5801 100644

app/test-pmd/testpmd.c rxtx_port_config(struct rte_port *port) · line 2822

Quoted 9 lines
app/test-pmd/testpmd.c +2 -1
@@ -2815,7 +2815,8 @@ rxtx_port_config(struct rte_port *port)
 	for (qid = 0; qid < nb_rxq; qid++) {
 		offloads = port->rx_conf[qid].offloads;
 		port->rx_conf[qid] = port->dev_info.default_rxconf;
-		port->rx_conf[qid].offloads |= offloads;
+		if (offloads)
+			port->rx_conf[qid].offloads = offloads;
 
 		/* Check if any Rx parameters have been passed */
 		if (rx_pthresh != RTE_PMD_PARAM_UNSET) @@ -2839,7

+2840,8 @@

Quoted 11 lines

rxtx_port_config(struct rte_port *port)

app/test-pmd/testpmd.c +2 -1
 	for (qid = 0; qid < nb_txq; qid++) {
 		offloads = port->tx_conf[qid].offloads;
 		port->tx_conf[qid] = port->dev_info.default_txconf;
-		port->tx_conf[qid].offloads |= offloads;
+		if (offloads)
+			port->tx_conf[qid].offloads = offloads;
 
 		/* Check if any Tx parameters have been passed */
 		if (tx_pthresh != RTE_PMD_PARAM_UNSET)