Skip to contentSkip to conversation

staging: vt6655: remove redundant assignment to variable byData

PATCH In review Colin Ian King 2 participants 2 messages Mar 28, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: vt6655: remove redundant assignment to variable byData

Variable byData is being assigned a value that is never read, it is being re-assigned later on. The assignment is redundant and can be removed.

Cleans up clang scan build warning:
drivers/staging/vt6655/srom.c:67:2: warning: Value stored to 'byData' is never read [deadcode.DeadStores]

---
 drivers/staging/vt6655/srom.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/vt6655/srom.c +0 -1
index 1b89d401a7eb..e80556509c58 100644
@@ -64,7 +64,6 @@ unsigned char SROMbyReadEmbedded(void __iomem *iobase,
 	unsigned char byData;
 	unsigned char byOrg;
 
-	byData = 0xFF;
 	byOrg = ioread8(iobase + MAC_REG_I2MCFG);
 	/* turn off hardware retry for getting NACK */
 	iowrite8(byOrg & (~I2MCFG_NORETRY), iobase + MAC_REG_I2MCFG);
Signature · 1 line
2.39.2
Tested-by on v1 1/1
#1 lore raw
Quoted 18 lines · Colin Ian King

Variable byData is being assigned a value that is never read, it is being re-assigned later on. The assignment is redundant and can be removed.

Cleans up clang scan build warning:
drivers/staging/vt6655/srom.c:67:2: warning: Value stored to 'byData' is never read [deadcode.DeadStores]

---
  drivers/staging/vt6655/srom.c | 1 -
  1 file changed, 1 deletion(-)
drivers/staging/vt6655/srom.c +0 -0
index 1b89d401a7eb..e80556509c58 100644

drivers/staging/vt6655/srom.c unsigned char SROMbyReadEmbedded(void __iomem *iobase, · line 69

Quoted 7 lines
drivers/staging/vt6655/srom.c +0 -1
@@ -64,7 +64,6 @@ unsigned char SROMbyReadEmbedded(void __iomem *iobase,
  	unsigned char byData;
  	unsigned char byOrg;
 
-	byData = 0xFF;
  	byOrg = ioread8(iobase + MAC_REG_I2MCFG);
  	/* turn off hardware retry for getting NACK */
  	iowrite8(byOrg & (~I2MCFG_NORETRY), iobase + MAC_REG_I2MCFG);