Skip to contentSkip to conversation

arm64: allwinner: a64: add device tree for SoPine with clusterboard

PATCH Superseded [email protected] 4 participants 5 messages Nov 6, 2022 – Nov 8, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: allwinner: a64: add device tree for SoPine with clusterboard

The Pine64 clusterboard needs a to have the tx delay changed to 500ps for ethernet to work. This solution was described by multiple people on the Pine64 forum years ago and nobody has submitted it.

Add a device tree for SoPine with the clusterboard.

---
 arch/arm64/boot/dts/allwinner/Makefile                 |  1 +
 .../dts/allwinner/sun50i-a64-sopine-clusterboard.dts   | 10 ++++++++++
 2 files changed, 11 insertions(+)
 create mode 100644 

arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts

arch/arm64/boot/dts/allwinner/Makefile +1 -0
index 6a96494a2e0a..15b011d1aaea 100644
@@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.2.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab-early-adopter.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-clusterboard.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts new file +10 -0
new file mode 100644
index 000000000000..6f8020a22670
@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+// Copyright (c) 2022 Renze Nicolai <[email protected]>
+
+/dts-v1/;
+
+#include "sun50i-a64-sopine-baseboard.dts"
+
+&emac {
+       allwinner,tx-delay-ps = <500>;
+};
Signature · 6 lines
2.38.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw
Quoted 20 lines · On 06/11/2022 22:40, [email protected] wrote:

The Pine64 clusterboard needs a to have the tx delay changed to 500ps for ethernet to work. This solution was described by multiple people on the Pine64 forum years ago and nobody has submitted it.

Add a device tree for SoPine with the clusterboard.

---
  arch/arm64/boot/dts/allwinner/Makefile                 |  1 +
  .../dts/allwinner/sun50i-a64-sopine-clusterboard.dts   | 10 ++++++++++
  2 files changed, 11 insertions(+)

create mode 100644
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts

arch/arm64/boot/dts/allwinner/Makefile +0 -0
index 6a96494a2e0a..15b011d1aaea 100644
@@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += 
Quoted 5 lines

sun50i-a64-pinephone-1.2.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab-early-adopter.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-clusterboard.dtb

This does not look like matching indentation of other entries...

Quoted 11 lines

dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb

(quoted diff) +0 -0

a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts new file mode 100644
index 000000000000..6f8020a22670

arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts line 6

Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts new file +6 -0
@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+// Copyright (c) 2022 Renze Nicolai <[email protected]>
+
+/dts-v1/;
+
+#include "sun50i-a64-sopine-baseboard.dts"

You miss compatible and model. You need to document the compatible in bindings (just like other top-level).

arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts line 10

Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts new file +4 -0
+
+&emac {
+       allwinner,tx-delay-ps = <500>;
+};

Best regards,
Krzysztof

#2 lore raw

PATCH v2 1/1 arm64: allwinner: a64: add device tree for SoPine with clusterboard

Hello Krzysztof,

Thank you for your feedback! I've fixed the indentation and I've added the compatible and model elements.

Greetings,
Renze Nicolai

The Pine64 clusterboard needs a to have the tx delay changed to 500ps for ethernet to work. This solution was described by multiple people on the Pine64 forum years ago and nobody has submitted it.

Add a device tree for SoPine with the clusterboard.

---
 arch/arm64/boot/dts/allwinner/Makefile           |  1 +
 .../allwinner/sun50i-a64-sopine-clusterboard.dts | 16 ++++++++++++++++
 2 files changed, 17 insertions(+)
 create mode 100644 

arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts

arch/arm64/boot/dts/allwinner/Makefile +1 -0
index 6a96494a2e0a..15b011d1aaea 100644
@@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.2.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab-early-adopter.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-clusterboard.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts new file +16 -0
new file mode 100644
index 000000000000..f75325d43d76
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+// Copyright (c) 2022 Renze Nicolai <[email protected]>
+
+/dts-v1/;
+
+#include "sun50i-a64-sopine-baseboard.dts"
+
+/ {
+	model = "SoPine with clusterboard";
+	compatible = "pine64,sopine-clusterboard", "pine64,sopine",
+		     "allwinner,sun50i-a64";
+};
+
+&emac {
+	allwinner,tx-delay-ps = <500>;
+};
Signature · 1 line
2.38.1
maintainer
#3 lore raw

Dne ponedeljek, 07. november 2022 ob 21:55:04 CET je Renze Nicolai napisal(a):

Quoted 4 lines

Hello Krzysztof,

Thank you for your feedback! I've fixed the indentation and I've added the compatible and model elements.

You didn't document compatible in bindings as instructed by Krzysztof. That should be in a patch preceding this one.

Comments like this, which are not part of commit message, should be either in cover letter or right below --- line, so they are ignored when patch is applied. While above comment can be considered as changelog of sort, it's preferred to write it as list, point by point, in area which is ignored when applying patch.

I guess you don't use "git send-email" to send your patches? New versions should not be send in reply to old ones.

Quoted 8 lines

Greetings,
Renze Nicolai

The Pine64 clusterboard needs a to have the tx delay changed to 500ps for ethernet to work. This solution was described by multiple people on the Pine64 forum years ago and nobody has submitted it.

When you're adding new board, commit message should describe new board either by stating features or telling which board is similar and what are the differences. Something like that clusterboard is almost the same as baseboard except ethernet TX delay, which is 500 ps. Omit second part of second statement, it's not relevant.

Best regards,
Jernej

Quoted 51 lines

Add a device tree for SoPine with the clusterboard.

---
  arch/arm64/boot/dts/allwinner/Makefile           |  1 +
  .../allwinner/sun50i-a64-sopine-clusterboard.dts | 16 ++++++++++++++++
  2 files changed, 17 insertions(+)

create mode 100644
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts

arch/arm64/boot/dts/allwinner/Makefile +0 -0
index 6a96494a2e0a..15b011d1aaea 100644
@@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_SUNXI) +=

sun50i-a64-pinephone-1.2.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab-early-adopter.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-clusterboard.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts new file mode 100644
index 000000000000..f75325d43d76

arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts new file +16 -1
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+// Copyright (c) 2022 Renze Nicolai <[email protected]>
+
+/dts-v1/;
+
+#include "sun50i-a64-sopine-baseboard.dts"
+
+/ {
+	model = "SoPine with clusterboard";
+	compatible = "pine64,sopine-clusterboard", "pine64,sopine",
+		     "allwinner,sun50i-a64";
+};
+
+&emac {
+	allwinner,tx-delay-ps = <500>;
+};
--

2.38.1

#4 lore raw
In reply to Renze Nicolai
Quoted 5 lines · 在 2022-11-07星期一的 21:55 +0100,Renze Nicolai写道:

Hello Krzysztof,

Thank you for your feedback! I've fixed the indentation and I've added
the compatible and model elements.

One small issue, I think the clusterboard has one node that comes with eMMC, which is different from other nodes.

Should these have different DT's ?

Quoted 59 lines

Greetings,
Renze Nicolai

The Pine64 clusterboard needs a to have the tx delay changed to 500ps for ethernet to work. This solution was described by multiple people on the Pine64 forum years ago and nobody has submitted it.

Add a device tree for SoPine with the clusterboard.

---
  arch/arm64/boot/dts/allwinner/Makefile           |  1 + .../allwinner/sun50i-a64-sopine-clusterboard.dts | 16
++++++++++++++++

  2 files changed, 17 insertions(+)

  create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts

arch/arm64/boot/dts/allwinner/Makefile +0 -0
index 6a96494a2e0a..15b011d1aaea 100644
@@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += 

sun50i-a64-pinephone-1.2.dtb
  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab-early-adopter.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-clusterboard.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb

(quoted diff) +0 -0

a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts new file mode 100644
index 000000000000..f75325d43d76

arch/arm64/boot/dts/allwinner/sun50i-a64-sopine- new file +0 -0

clusterboard.dts

arch/arm64/boot/dts/allwinner/sun50i-a64-sopine- new file +16 -0
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+// Copyright (c) 2022 Renze Nicolai <[email protected]>
+
+/dts-v1/;
+
+#include "sun50i-a64-sopine-baseboard.dts"
+
+/ {
+       model = "SoPine with clusterboard";
+       compatible = "pine64,sopine-clusterboard", "pine64,sopine",
+                    "allwinner,sun50i-a64";
+};
+
+&emac {
+       allwinner,tx-delay-ps = <500>;
+};