checkpatch.pl: adapt to new Assisted-by: format
Subsystems (2)
PATCH 1/1 checkpatch.pl: adapt to new Assisted-by: format
There is a new format for the 'Assisted-by:' tag. Change checkpatch.pl to just check that it has a value rather than testing for a specific format.
---
This is a companion patch to the one to change the format in Documentation/. See:
https://lore.kernel.org/workflows/[email protected]/
--- scripts/checkpatch.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
scripts/checkpatch.pl +4 -3
@@ -3124,11 +3124,12 @@ sub process { } } - # Assisted-by uses AGENT_NAME:MODEL_VERSION format, not email + # Assisted-by uses a free-form value (e.g. "LLM"), not an + # email address, so skip the email format checks below. if ($sign_off =~ /^Assisted-by:/i) { - if ($email !~ /^\S+:\S+/) { + if ($email =~ /^\s*$/) { WARN("BAD_SIGN_OFF", - "Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format\n" . $herecurr); + "Assisted-by requires a value\n" . $herecurr); } next; }
---
base-commit: 848acc8ffe1b7cd5f1bf427b93069becfebc2c9d
change-id: 20260804-checkpatch-87402d649095
Best regards,
Signature · 1 line
Jeff Layton <[email protected]>
Joe Perches
maintainerQuoted 5 lines · Jeff Layton
There is a new format for the 'Assisted-by:' tag. Change checkpatch.pl to just check that it has a value rather than testing for a specific format.
Assisted-by LLM
Did an LLM really help produce this? Why?
Quoted 6 lines
---
This is a companion patch to the one to change the format inDocumentation/. See:
[]
scripts/checkpatch.pl
Quoted 1 line
scripts/checkpatch.pl +0
-0
[]
Quoted 7 lines
scripts/checkpatch.pl +1
-1@@ -3124,11 +3124,12 @@ sub process { } } - # Assisted-by uses AGENT_NAME:MODEL_VERSION format, not email + # Assisted-by uses a free-form value (e.g. "LLM"), not an
scripts/checkpatch.pl sub process { · line 3135
Quoted 10 lines
scripts/checkpatch.pl +3
-2+ # email address, so skip the email format checks below. if ($sign_off =~ /^Assisted-by:/i) {And - if ($email !~ /^\S+:\S+/) { + if ($email =~ /^\s*$/) { WARN("BAD_SIGN_OFF", - "Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format\n" . $herecurr); + "Assisted-by requires a value\n" . $herecurr); } next; }
[]
Quoted 1 line
Best regards,
Sure, whatever.
cheers
Quoted 9 lines · Joe Perches
Quoted 5 lines · Jeff Layton
There is a new format for the 'Assisted-by:' tag. Change checkpatch.pl to just check that it has a value rather than testing for a specific format.
Assisted-by LLMDid an LLM really help produce this? Why?
Why not? It was simple to have it do it, and my perl skills are a bit rusty. I don't love typing, fwiw...
Quoted 32 lines
Quoted 6 lines
---
This is a companion patch to the one to change the format inDocumentation/. See:[]
scripts/checkpatch.pl
Quoted 1 line
scripts/checkpatch.pl +0
-0[]
Quoted 7 lines
scripts/checkpatch.pl +1
-1@@ -3124,11 +3124,12 @@ sub process { } } - # Assisted-by uses AGENT_NAME:MODEL_VERSION format, not email + # Assisted-by uses a free-form value (e.g. "LLM"), not anscripts/checkpatch.pl sub process { · line 3135
Quoted 10 lines
scripts/checkpatch.pl +3
-2+ # email address, so skip the email format checks below. if ($sign_off =~ /^Assisted-by:/i) {And - if ($email !~ /^\S+:\S+/) { + if ($email =~ /^\s*$/) { WARN("BAD_SIGN_OFF", - "Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format\n" . $herecurr); + "Assisted-by requires a value\n" . $herecurr); } next; }[]
Quoted 1 line
Best regards,
Sure, whatever.
cheers
Signature · 1 line
Jeff Layton <[email protected]>
Quoted 6 lines · Jeff Layton
There is a new format for the 'Assisted-by:' tag. Change checkpatch.pl to just check that it has a value rather than testing for a specific format.
Assisted-by LLMSigned-off-by Jeff Layton <[email protected]>
Quoted 8 lines
---
This is a companion patch to the one to change the format inDocumentation/. See:https://lore.kernel.org/workflows/[email protected]/
--- scripts/checkpatch.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
Applied... we don't have a Sure-whatever-by tag, so I didn't add Joe's...
Thanks,
jon