arm64: dts: exynos: Add missing gpm6 and gpm7 nodes to Exynos850
Sam Protsenko
maintainerPATCH 1/1 arm64: dts: exynos: Add missing gpm6 and gpm7 nodes to Exynos850
gpm6 and gpm7 nodes are missing in Exynos850 device tree. Next errors are reported because of that:
Missing node for bank gpm6 - invalid DTB
Missing node for bank gpm7 - invalid DTB
Add missing nodes to make those available to use, and to fix boot errors.
---
NOTES:
- Recommend to apply this patch after "arm64: dts: exynos: align pinctrl with dtschema in Exynos850"
- This patch also brings back two interrupts removed in "arm64:
dts: exynos: drop incorrectly placed wakeup interrupts in Exynos850"
.../boot/dts/exynos/exynos850-pinctrl.dtsi | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+)
arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi +20 -0
@@ -194,6 +194,26 @@ gpm5: gpm5-gpio-bank { interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>; }; + gpm6: gpm6-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>; + }; + + gpm7: gpm7-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>; + }; + /* USI_CMGP0: HSI2C function */ hsi2c3_pins: hsi2c3-pins { samsung,pins = "gpm0-0", "gpm1-0";
Signature · 1 line
2.30.2
Quoted 9 lines · Sam Protsenko
gpm6 and gpm7 nodes are missing in Exynos850 device tree. Next errors are reported because of that:
Missing node for bank gpm6 - invalid DTB
Missing node for bank gpm7 - invalid DTBAdd missing nodes to make those available to use, and to fix boot errors.
Quoted 8 lines
Fixes e3493220fd3e ("arm64: dts: exynos: Add initial Exynos850 SoC support")Signed-off-by Sam Protsenko <[email protected]>---
NOTES:
- Recommend to apply this patch after "arm64: dts: exynos: align pinctrl with dtschema in Exynos850"
- This patch also brings back two interrupts removed in "arm64:
dts: exynos: drop incorrectly placed wakeup interrupts in Exynos850"
I'll take it after the merge window and apply it before my series (so without -gpio-bank suffix).
Quoted 26 lines
.../boot/dts/exynos/exynos850-pinctrl.dtsi | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+)arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi +13
-0@@ -194,6 +194,26 @@ gpm5: gpm5-gpio-bank { interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>; }; + gpm6: gpm6-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>; + }; + + gpm7: gpm7-gpio-bank { + gpio-controller; + #gpio-cells = <2>;
arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi gpm5: gpm5-gpio-bank { · line 219
Quoted 10 lines
arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi +7
-0+ + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>; + }; + /* USI_CMGP0: HSI2C function */ hsi2c3_pins: hsi2c3-pins { samsung,pins = "gpm0-0", "gpm1-0";
Best regards,
Krzysztof
Sam Protsenko
maintainerQuoted 20 lines · Krzysztof Kozlowski
Quoted 9 lines · Sam Protsenko
gpm6 and gpm7 nodes are missing in Exynos850 device tree. Next errors are reported because of that:
Missing node for bank gpm6 - invalid DTB
Missing node for bank gpm7 - invalid DTBAdd missing nodes to make those available to use, and to fix boot errors.
Quoted 8 lines
Fixes e3493220fd3e ("arm64: dts: exynos: Add initial Exynos850 SoC support")Signed-off-by Sam Protsenko <[email protected]>---
NOTES:
- Recommend to apply this patch after "arm64: dts: exynos: align pinctrl with dtschema in Exynos850"
- This patch also brings back two interrupts removed in "arm64:
dts: exynos: drop incorrectly placed wakeup interrupts in Exynos850"
Quoted 3 lines
I'll take it after the merge window and apply it before my series (so without -gpio-bank suffix).
Sure, whatever you think is best.
Quoted 40 lines
Quoted 26 lines
.../boot/dts/exynos/exynos850-pinctrl.dtsi | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+)arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi +13
-0@@ -194,6 +194,26 @@ gpm5: gpm5-gpio-bank { interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>; }; + gpm6: gpm6-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>; + }; + + gpm7: gpm7-gpio-bank { + gpio-controller; + #gpio-cells = <2>;arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi gpm5: gpm5-gpio-bank { · line 219
Quoted 10 lines
arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi +7
-0+ + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>; + }; + /* USI_CMGP0: HSI2C function */ hsi2c3_pins: hsi2c3-pins { samsung,pins = "gpm0-0", "gpm1-0";Best regards,
Krzysztof