Skip to contentSkip to conversation

dmaengine: ti: Fix refcount leak in ti_dra7_xbar_route_allocate

PATCH Superseded Miaoqian Lin 2 participants 2 messages Jun 1, 2022 – Jun 4, 2022

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dmaengine: ti: Fix refcount leak in ti_dra7_xbar_route_allocate

of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not needed anymore.

Add missing of_node_put() in to fix this.

Fixes ec9bfa1e1a79 ("dmaengine: ti-dma-crossbar: dra7: Use bitops instead of idr")

---
- split v1 into two patches.
v1 link: https://lore.kernel.org/r/[email protected]

---
 drivers/dma/ti/dma-crossbar.c | 1 +
 1 file changed, 1 insertion(+)
drivers/dma/ti/dma-crossbar.c +1 -0
index 71d24fc07c00..e34cfb50d241 100644
@@ -268,6 +268,7 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec,
 		mutex_unlock(&xbar->mutex);
 		dev_err(&pdev->dev, "Run out of free DMA requests\n");
 		kfree(map);
+		of_node_put(dma_spec->np);
 		return ERR_PTR(-ENOMEM);
 	}
 	set_bit(map->xbar_out, xbar->dma_inuse);
Signature · 1 line
2.25.1
Acked-by on v2 1/1
#1 lore raw
Quoted 4 lines · Miaoqian Lin

of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not needed anymore.

Add missing of_node_put() in to fix this.

Quoted 22 lines
Fixes ec9bfa1e1a79 ("dmaengine: ti-dma-crossbar: dra7: Use bitops instead of idr")

---
- split v1 into two patches.
v1 link: https://lore.kernel.org/r/[email protected]

---
 drivers/dma/ti/dma-crossbar.c | 1 +
 1 file changed, 1 insertion(+)
drivers/dma/ti/dma-crossbar.c +1 -0
index 71d24fc07c00..e34cfb50d241 100644
@@ -268,6 +268,7 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec,
 		mutex_unlock(&xbar->mutex);
 		dev_err(&pdev->dev, "Run out of free DMA requests\n");
 		kfree(map);
+		of_node_put(dma_spec->np);
 		return ERR_PTR(-ENOMEM);
 	}
 	set_bit(map->xbar_out, xbar->dma_inuse);
Signature · 1 line
Péter