dmaengine: ti: Fix refcount leak in ti_dra7_xbar_route_allocate
Subsystems (2)
PATCH v2 1/1 dmaengine: ti: Fix refcount leak in ti_dra7_xbar_route_allocate
of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not needed anymore.
Add missing of_node_put() in to fix this.
Fixes ec9bfa1e1a79 ("dmaengine: ti-dma-crossbar: dra7: Use bitops instead of idr")
Signed-off-by Miaoqian Lin <[email protected]>
---
- split v1 into two patches.
v1 link: https://lore.kernel.org/r/[email protected]
--- drivers/dma/ti/dma-crossbar.c | 1 + 1 file changed, 1 insertion(+)
drivers/dma/ti/dma-crossbar.c +1 -0
@@ -268,6 +268,7 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec,mutex_unlock (&xbar->mutex);dev_err (&pdev->dev,"Run out of free DMA requests\n" );kfree (map); +of_node_put (dma_spec->np);return ERR_PTR (-ENOMEM ); }set_bit (map->xbar_out, xbar->dma_inuse);
Signature · 1 line
2.25.1
Quoted 4 lines · Miaoqian Lin
of_parse_phandle()returns a node pointer with refcount incremented, we should useof_node_put()on it when not needed anymore.Add missing
of_node_put()in to fix this.
Acked-by Peter Ujfalusi <[email protected]>
Quoted 22 lines
Fixes ec9bfa1e1a79 ("dmaengine: ti-dma-crossbar: dra7: Use bitops instead of idr")Signed-off-by Miaoqian Lin <[email protected]>---
- split v1 into two patches.
v1 link: https://lore.kernel.org/r/[email protected]--- drivers/dma/ti/dma-crossbar.c | 1 + 1 file changed, 1 insertion(+)drivers/dma/ti/dma-crossbar.c +1
-0@@ -268,6 +268,7 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec,mutex_unlock (&xbar->mutex);dev_err (&pdev->dev,"Run out of free DMA requests\n" );kfree (map); +of_node_put (dma_spec->np);return ERR_PTR (-ENOMEM ); }set_bit (map->xbar_out, xbar->dma_inuse);
Signature · 1 line
Péter