Skip to contentSkip to conversation

drivers/misc/amd-sbi/Kconfig: select REGMAP_I2C

PATCH In review Max Kellermann 2 participants 2 messages Aug 29, 2025 – Sep 4, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/misc/amd-sbi/Kconfig: select REGMAP_I2C

Without CONFIG_REGMAP, rmi-i2c.c fails to build because struct regmap_config is not defined:

drivers/misc/amd-sbi/rmi-i2c.c: In function ‘sbrmi_i2c_probe’:
drivers/misc/amd-sbi/rmi-i2c.c:57:16: error: variable ‘sbrmi_i2c_regmap_config’ has initializer but incomplete type

    57 |         struct regmap_config sbrmi_i2c_regmap_config = {
       |                ^~~~~~~~~~~~~

Additionally, CONFIG_REGMAP_I2C is needed for devm_regmap_init_i2c():

ld: drivers/misc/amd-sbi/rmi-i2c.o: in function `sbrmi_i2c_probe':
drivers/misc/amd-sbi/rmi-i2c.c:69:(.text+0x1c0): undefined reference to `__devm_regmap_init_i2c'

Fixes 013f7e7131bd ("misc: amd-sbi: Use regmap subsystem")
---
 drivers/misc/amd-sbi/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/misc/amd-sbi/Kconfig +1 -0
index 4840831c84ca..4aae0733d0fc 100644
@@ -2,6 +2,7 @@
 config AMD_SBRMI_I2C
 	tristate "AMD side band RMI support"
 	depends on I2C
+	select REGMAP_I2C
 	help
 	  Side band RMI over I2C support for AMD out of band management.
 
Signature · 1 line
2.47.2
Tested-by Reviewed-by on v1 1/1
#1 lore raw
Quoted 36 lines · Max Kellermann

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.

Without CONFIG_REGMAP, rmi-i2c.c fails to build because struct regmap_config is not defined:

drivers/misc/amd-sbi/rmi-i2c.c: In function ‘sbrmi_i2c_probe’:
drivers/misc/amd-sbi/rmi-i2c.c:57:16: error: variable ‘sbrmi_i2c_regmap_config’ has initializer but incomplete type

     57 |         struct regmap_config sbrmi_i2c_regmap_config = {
        |                ^~~~~~~~~~~~~

Additionally, CONFIG_REGMAP_I2C is needed for devm_regmap_init_i2c():

ld: drivers/misc/amd-sbi/rmi-i2c.o: in function `sbrmi_i2c_probe':
drivers/misc/amd-sbi/rmi-i2c.c:69:(.text+0x1c0): undefined reference to `__devm_regmap_init_i2c'

Fixes 013f7e7131bd ("misc: amd-sbi: Use regmap subsystem")
---
  drivers/misc/amd-sbi/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/misc/amd-sbi/Kconfig +1 -1
index 4840831c84ca..4aae0733d0fc 100644
@@ -2,6 +2,7 @@
  config AMD_SBRMI_I2C
         tristate "AMD side band RMI support"
         depends on I2C
+       select REGMAP_I2C
         help
           Side band RMI over I2C support for AMD out of band management.
 
--
Quoted 1 line

2.47.2

Thank you for the patch.