Skip to contentSkip to conversation

x86/pv: Drop stale comment in dom0_construct_pv()

PATCH In review Andrew Cooper 2 participants 3 messages Oct 29, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/pv: Drop stale comment in dom0_construct_pv()

This comment has been around since c/s 1372bca0615 in 2004. It is stale, as it predates the introduction of struct vcpu.

It is not obvious that it was even correct at the time. Where a vcpu (domain at the time) has been configured to run is unrelated to construct the domain's initial pagetables, etc.

---
CC: Jan Beulich <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Wei Liu <[email protected]>

Almost... I'm not entirely sure NUMA memory allocation is plumbed through correctly, but even that still has nothing to do with v->processor

---
 xen/arch/x86/pv/dom0_build.c | 1 -
 1 file changed, 1 deletion(-)
xen/arch/x86/pv/dom0_build.c +0 -1
index d79503d6a9..f7165309a2 100644
@@ -616,7 +616,6 @@ int __init dom0_construct_pv(struct domain *d,
         v->arch.pv.event_callback_cs    = FLAT_COMPAT_KERNEL_CS;
     }
 
-    /* WARNING: The new domain must have its 'processor' field filled in! */
     if ( !is_pv_32bit_domain(d) )
     {
         maddr_to_page(mpt_alloc)->u.inuse.type_info = PGT_l4_page_table;
Signature · 1 line
2.11.0
Acked-by on v1 1/1
#1 lore raw
Quoted 2 lines · Andrew Cooper

This comment has been around since c/s 1372bca0615 in 2004. It is stale, as it predates the introduction of struct vcpu.

That commit only moved it around; it's 22a857bde9b8 afaics from early 2003 where it first appeared, where it had a reason:

    /*
     * WARNING: The new domain must have its 'processor' field
     * filled in by now !!
     */
    phys_l2tab = ALLOC_FRAME_FROM_DOMAIN();
    l2tab = map_domain_mem(phys_l2tab);
    memcpy(l2tab, idle_pg_table[p->processor], PAGE_SIZE);

But yes, the comment has been stale for a long time, and I've been wondering a number of times what it was supposed to tell me. (I think it was already stale at the point the comment first got altered, in 3072fef54df8.)

Quoted 5 lines

It is not obvious that it was even correct at the time. Where a vcpu (domain at the time) has been configured to run is unrelated to construct the domain's initial pagetables, etc.

Jan

#2 lore raw
Quoted 6 lines · Jan Beulich
Quoted 2 lines · Andrew Cooper

This comment has been around since c/s 1372bca0615 in 2004. It is stale, as it predates the introduction of struct vcpu.

That commit only moved it around; it's 22a857bde9b8 afaics from early 2003 where it first appeared, where it had a reason:

Quoted 7 lines
    /*
     * WARNING: The new domain must have its 'processor' field
     * filled in by now !!
     */
    phys_l2tab = ALLOC_FRAME_FROM_DOMAIN();
    l2tab = map_domain_mem(phys_l2tab);
    memcpy(l2tab, idle_pg_table[p->processor], PAGE_SIZE);

Oh yes - my simple search didn't spot the reformat.

Quoted 5 lines

But yes, the comment has been stale for a long time, and I've been wondering a number of times what it was supposed to tell me. (I think it was already stale at the point the comment first got altered, in 3072fef54df8.)

Looks like it became stale with 99db02d5097 "Remove CPU-dependent page-directory entries." which drops the per-cpu idle_pg_table.

Quoted 7 lines
Quoted 6 lines

It is not obvious that it was even correct at the time. Where a vcpu (domain at the time) has been configured to run is unrelated to construct the domain's initial pagetables, etc.

Thanks.  I'll update the commit message.

~Andrew