GFX9 KIQ
Subsystems (2)
cover GFX9 KIQ
These are the laste of the gfx9 KIQ patches that haven't landed yet. Can someone with gfx9 capable hw test this (vega10 or raven)? This is needed to enable powergating on gfx9.
Thanks,
Alex
Alex Deucher (5):
drm/amdgpu: split gfx_v9_0_kiq_init_queue into two drm/amdgpu/gfx9: wait once for all KCQs to be created drm/amdgpu/gfx9: move SET_RESOURCES into the same command stream drm/amdgpu/gfx9: fix resume of KIQ and KCQs (v2) drm/amdgpu/gfx9: Switch baremetal to use KIQ for compute ring
management. (v4)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 488 +++++++++------------------------- 1 file changed, 126 insertions(+), 362 deletions(-)
Signature · 6 lines
2.5.5 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1494527730-30128-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org
PATCH 1/5 drm/amdgpu: split gfx_v9_0_kiq_init_queue into two
One for KIQ and one for the KCQ. This simplifies the logic and allows for future optimizations.
--- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 63 +++++++++++++++++++++++------------ 1 file changed, 42 insertions(+), 21 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +42 -21
@@ -2833,25 +2833,18 @@ static int gfx_v9_0_kiq_init_register(struct amdgpu_ring *ring)static int gfx_v9_0_kiq_init_queue (struct amdgpu_ring *ring) {struct amdgpu_device *adev = ring->adev; -struct amdgpu_kiq *kiq = &adev->gfx.kiq;struct v9_mqd *mqd = ring->mqd_ptr; -bool is_kiq = (ring->funcs->type ==AMDGPU_RING_TYPE_KIQ );int mqd_idx =AMDGPU_MAX_COMPUTE_RINGS ;int r; -if (is_kiq) { -gfx_v9_0_kiq_setting (&kiq->ring); - }else { - mqd_idx = ring - &adev->gfx.compute_ring[0 ]; - } +gfx_v9_0_kiq_setting (ring);if (!adev->gfx.in_reset) {memset ((void *)mqd,0 ,sizeof (*mqd));mutex_lock (&adev->srbm_mutex);soc15_grbm_select (adev, ring->me, ring->pipe, ring->queue,0 );gfx_v9_0_mqd_init (ring); -if (is_kiq) -gfx_v9_0_kiq_init_register (ring); +gfx_v9_0_kiq_init_register (ring);soc15_grbm_select (adev,0 ,0 ,0 ,0 );mutex_unlock (&adev->srbm_mutex);
@@ -2866,19 +2859,47 @@ static int gfx_v9_0_kiq_init_queue(struct amdgpu_ring *ring) ring->wptr =0 ;amdgpu_ring_clear_ring (ring); -if (is_kiq) { -mutex_lock (&adev->srbm_mutex); -soc15_grbm_select (adev, ring->me, ring->pipe, ring->queue,0 ); -gfx_v9_0_kiq_init_register (ring); -soc15_grbm_select (adev,0 ,0 ,0 ,0 ); -mutex_unlock (&adev->srbm_mutex); - } +mutex_lock (&adev->srbm_mutex); +soc15_grbm_select (adev, ring->me, ring->pipe, ring->queue,0 ); +gfx_v9_0_kiq_init_register (ring); +soc15_grbm_select (adev,0 ,0 ,0 ,0 ); +mutex_unlock (&adev->srbm_mutex); } -if (is_kiq) - r =gfx_v9_0_kiq_enable (ring); -else - r =gfx_v9_0_map_queue_enable (&kiq->ring, ring); + r =gfx_v9_0_kiq_enable (ring); + +return r; +} + +static int gfx_v9_0_kcq_init_queue (struct amdgpu_ring *ring) +{ +struct amdgpu_device *adev = ring->adev; +struct amdgpu_kiq *kiq = &adev->gfx.kiq; +struct v9_mqd *mqd = ring->mqd_ptr; +int mqd_idx = ring - &adev->gfx.compute_ring[0 ]; +int r; + +if (!adev->gfx.in_reset) { +memset ((void *)mqd,0 ,sizeof (*mqd)); +mutex_lock (&adev->srbm_mutex); +soc15_grbm_select (adev, ring->me, ring->pipe, ring->queue,0 ); +gfx_v9_0_mqd_init (ring); +soc15_grbm_select (adev,0 ,0 ,0 ,0 ); +mutex_unlock (&adev->srbm_mutex); + +if (adev->gfx.mec.mqd_backup[mqd_idx]) +memcpy (adev->gfx.mec.mqd_backup[mqd_idx], mqd,sizeof (*mqd)); + }else {/* for GPU_RESET case */ +/* reset MQD to a clean status */ +if (adev->gfx.mec.mqd_backup[mqd_idx]) +memcpy (mqd, adev->gfx.mec.mqd_backup[mqd_idx],sizeof (*mqd)); + +/* reset ring buffer */ + ring->wptr =0 ; +amdgpu_ring_clear_ring (ring); + } + + r =gfx_v9_0_map_queue_enable (&kiq->ring, ring);return r; }
@@ -2914,7 +2935,7 @@ static int gfx_v9_0_kiq_resume(struct amdgpu_device *adev) goto done; r =amdgpu_bo_kmap (ring->mqd_obj, (void **)&ring->mqd_ptr);if (!r) { - r =gfx_v9_0_kiq_init_queue (ring); + r =gfx_v9_0_kcq_init_queue (ring);amdgpu_bo_kunmap (ring->mqd_obj); ring->mqd_ptr =NULL ; }
Signature · 6 lines
2.5.5 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 2/5 drm/amdgpu/gfx9: wait once for all KCQs to be created
In reply to a message not in the archiveRather than waiting for each queue.
--- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 60 +++++++++++++++++------------------ 1 file changed, 29 insertions(+), 31 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +29 -31
@@ -2530,11 +2530,9 @@ static int gfx_v9_0_kiq_enable(struct amdgpu_ring *ring)return r; } -static int gfx_v9_0_map_queue_enable (struct amdgpu_ring *kiq_ring, -struct amdgpu_ring *ring) +static int gfx_v9_0_map_queues_enable (struct amdgpu_device *adev) { -struct amdgpu_device *adev = kiq_ring->adev; -uint64_t mqd_addr, wptr_addr; +struct amdgpu_ring *kiq_ring = &adev->gfx.kiq.ring;uint32_t scratch, tmp =0 ;int r, i;
@@ -2545,33 +2543,36 @@ static int gfx_v9_0_map_queue_enable(struct amdgpu_ring *kiq_ring, }WREG32 (scratch,0xCAFEDEAD ); - r =amdgpu_ring_alloc (kiq_ring,10 ); + r =amdgpu_ring_alloc (kiq_ring, (7 * adev->gfx.num_compute_rings) +3 );if (r) {DRM_ERROR ("Failed to lock KIQ (%d).\n" , r);amdgpu_gfx_scratch_free (adev, scratch);return r; } - mqd_addr =amdgpu_bo_gpu_offset (ring->mqd_obj); - wptr_addr = adev->wb.gpu_addr + (ring->wptr_offs *4 ); - -amdgpu_ring_write (kiq_ring,PACKET3 (PACKET3_MAP_QUEUES ,5 )); -/* Q_sel:0, vmid:0, vidmem: 1, engine:0, num_Q:1*/ -amdgpu_ring_write (kiq_ring,/* Q_sel: 0, vmid: 0, engine: 0, num_Q: 1 */ -PACKET3_MAP_QUEUES_QUEUE_SEL (0 ) |/* Queue_Sel */ -PACKET3_MAP_QUEUES_VMID (0 ) |/* VMID */ -PACKET3_MAP_QUEUES_QUEUE (ring->queue) | -PACKET3_MAP_QUEUES_PIPE (ring->pipe) | -PACKET3_MAP_QUEUES_ME ((ring->me ==1 ?0 :1 )) | -PACKET3_MAP_QUEUES_QUEUE_TYPE (0 ) |/*queue_type: normal compute queue */ -PACKET3_MAP_QUEUES_ALLOC_FORMAT (1 ) |/* alloc format: all_on_one_pipe */ -PACKET3_MAP_QUEUES_ENGINE_SEL (0 ) |/* engine_sel: compute */ -PACKET3_MAP_QUEUES_NUM_QUEUES (1 ));/* num_queues: must be 1 */ -amdgpu_ring_write (kiq_ring,PACKET3_MAP_QUEUES_DOORBELL_OFFSET (ring->doorbell_index)); -amdgpu_ring_write (kiq_ring,lower_32_bits (mqd_addr)); -amdgpu_ring_write (kiq_ring,upper_32_bits (mqd_addr)); -amdgpu_ring_write (kiq_ring,lower_32_bits (wptr_addr)); -amdgpu_ring_write (kiq_ring,upper_32_bits (wptr_addr)); +for (i =0 ; i < adev->gfx.num_compute_rings; i++) { +struct amdgpu_ring *ring = &adev->gfx.compute_ring[i]; +uint64_t mqd_addr =amdgpu_bo_gpu_offset (ring->mqd_obj); +uint64_t wptr_addr = adev->wb.gpu_addr + (ring->wptr_offs *4 ); + +amdgpu_ring_write (kiq_ring,PACKET3 (PACKET3_MAP_QUEUES ,5 )); +/* Q_sel:0, vmid:0, vidmem: 1, engine:0, num_Q:1*/ +amdgpu_ring_write (kiq_ring,/* Q_sel: 0, vmid: 0, engine: 0, num_Q: 1 */ +PACKET3_MAP_QUEUES_QUEUE_SEL (0 ) |/* Queue_Sel */ +PACKET3_MAP_QUEUES_VMID (0 ) |/* VMID */ +PACKET3_MAP_QUEUES_QUEUE (ring->queue) | +PACKET3_MAP_QUEUES_PIPE (ring->pipe) | +PACKET3_MAP_QUEUES_ME ((ring->me ==1 ?0 :1 )) | +PACKET3_MAP_QUEUES_QUEUE_TYPE (0 ) |/*queue_type: normal compute queue */ +PACKET3_MAP_QUEUES_ALLOC_FORMAT (1 ) |/* alloc format: all_on_one_pipe */ +PACKET3_MAP_QUEUES_ENGINE_SEL (0 ) |/* engine_sel: compute */ +PACKET3_MAP_QUEUES_NUM_QUEUES (1 ));/* num_queues: must be 1 */ +amdgpu_ring_write (kiq_ring,PACKET3_MAP_QUEUES_DOORBELL_OFFSET (ring->doorbell_index)); +amdgpu_ring_write (kiq_ring,lower_32_bits (mqd_addr)); +amdgpu_ring_write (kiq_ring,upper_32_bits (mqd_addr)); +amdgpu_ring_write (kiq_ring,lower_32_bits (wptr_addr)); +amdgpu_ring_write (kiq_ring,upper_32_bits (wptr_addr)); + }/* write to scratch for completion */ amdgpu_ring_write (kiq_ring,PACKET3 (PACKET3_SET_UCONFIG_REG ,1 ));amdgpu_ring_write (kiq_ring, (scratch -PACKET3_SET_UCONFIG_REG_START ));
@@ -2874,10 +2875,8 @@ static int gfx_v9_0_kiq_init_queue(struct amdgpu_ring *ring)static int gfx_v9_0_kcq_init_queue (struct amdgpu_ring *ring) {struct amdgpu_device *adev = ring->adev; -struct amdgpu_kiq *kiq = &adev->gfx.kiq;struct v9_mqd *mqd = ring->mqd_ptr;int mqd_idx = ring - &adev->gfx.compute_ring[0 ]; -int r;if (!adev->gfx.in_reset) {memset ((void *)mqd,0 ,sizeof (*mqd));
@@ -2899,9 +2898,7 @@ static int gfx_v9_0_kcq_init_queue(struct amdgpu_ring *ring)amdgpu_ring_clear_ring (ring); } - r =gfx_v9_0_map_queue_enable (&kiq->ring, ring); - -return r; +return 0 ; }static int gfx_v9_0_kiq_resume (struct amdgpu_device *adev)
@@ -2944,13 +2941,14 @@ static int gfx_v9_0_kiq_resume(struct amdgpu_device *adev) goto done; } + r =gfx_v9_0_map_queues_enable (adev); done:return r; }static int gfx_v9_0_cp_resume (struct amdgpu_device *adev) { -int r,i; +int r, i;struct amdgpu_ring *ring;if (!(adev->flags &AMD_IS_APU ))
Signature · 6 lines
2.5.5 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 3/5 drm/amdgpu/gfx9: move SET_RESOURCES into the same command stream
In reply to a message not in the archiveAs the KCQ setup. This way we only have to wait once for the entire MEC.
--- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 73 +++++++---------------------------- 1 file changed, 14 insertions(+), 59 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +14 -59
@@ -2478,59 +2478,7 @@ static void gfx_v9_0_kiq_setting(struct amdgpu_ring *ring)WREG32_SOC15 (GC ,0 , mmRLC_CP_SCHEDULERS, tmp); } -static int gfx_v9_0_kiq_enable (struct amdgpu_ring *ring) -{ -struct amdgpu_device *adev = ring->adev; -uint32_t scratch, tmp =0 ; -int r, i; - - r =amdgpu_gfx_scratch_get (adev, &scratch); -if (r) { -DRM_ERROR ("Failed to get scratch reg (%d).\n" , r); -return r; - } -WREG32 (scratch,0xCAFEDEAD ); - - r =amdgpu_ring_alloc (ring,8 ); -if (r) { -DRM_ERROR ("Failed to lock KIQ (%d).\n" , r); -amdgpu_gfx_scratch_free (adev, scratch); -return r; - } -amdgpu_ring_alloc (ring,11 ); -/* set resources */ -amdgpu_ring_write (ring,PACKET3 (PACKET3_SET_RESOURCES ,6 )); -amdgpu_ring_write (ring,PACKET3_SET_RESOURCES_VMID_MASK (0 ) | -PACKET3_SET_RESOURCES_QUEUE_TYPE (0 ));/* vmid_mask:0 queue_type:0 (KIQ) */ -amdgpu_ring_write (ring,0x000000FF );/* queue mask lo */ -amdgpu_ring_write (ring,0 );/* queue mask hi */ -amdgpu_ring_write (ring,0 );/* gws mask lo */ -amdgpu_ring_write (ring,0 );/* gws mask hi */ -amdgpu_ring_write (ring,0 );/* oac mask */ -amdgpu_ring_write (ring,0 );/* gds heap base:0, gds heap size:0 */ -/* write to scratch for completion */ -amdgpu_ring_write (ring,PACKET3 (PACKET3_SET_UCONFIG_REG ,1 )); -amdgpu_ring_write (ring, (scratch -PACKET3_SET_UCONFIG_REG_START )); -amdgpu_ring_write (ring,0xDEADBEEF ); -amdgpu_ring_commit (ring); - -for (i =0 ; i < adev->usec_timeout; i++) { - tmp =RREG32 (scratch); -if (tmp ==0xDEADBEEF ) -break ; -DRM_UDELAY (1 ); - } -if (i >= adev->usec_timeout) { -DRM_ERROR ("KIQ enable failed (scratch(0x%04X)=0x%08X)\n" , - scratch, tmp); - r = -EINVAL ; - } -amdgpu_gfx_scratch_free (adev, scratch); - -return r; -} - -static int gfx_v9_0_map_queues_enable (struct amdgpu_device *adev) +static int gfx_v9_0_kiq_kcq_enable (struct amdgpu_device *adev) {struct amdgpu_ring *kiq_ring = &adev->gfx.kiq.ring;uint32_t scratch, tmp =0 ;
@@ -2543,13 +2491,23 @@ static int gfx_v9_0_map_queues_enable(struct amdgpu_device *adev) }WREG32 (scratch,0xCAFEDEAD ); - r =amdgpu_ring_alloc (kiq_ring, (7 * adev->gfx.num_compute_rings) +3 ); + r =amdgpu_ring_alloc (kiq_ring, (7 * adev->gfx.num_compute_rings) +11 );if (r) {DRM_ERROR ("Failed to lock KIQ (%d).\n" , r);amdgpu_gfx_scratch_free (adev, scratch);return r; } +/* set resources */ +amdgpu_ring_write (kiq_ring,PACKET3 (PACKET3_SET_RESOURCES ,6 )); +amdgpu_ring_write (kiq_ring,PACKET3_SET_RESOURCES_VMID_MASK (0 ) | +PACKET3_SET_RESOURCES_QUEUE_TYPE (0 ));/* vmid_mask:0 queue_type:0 (KIQ) */ +amdgpu_ring_write (kiq_ring,0x000000FF );/* queue mask lo */ +amdgpu_ring_write (kiq_ring,0 );/* queue mask hi */ +amdgpu_ring_write (kiq_ring,0 );/* gws mask lo */ +amdgpu_ring_write (kiq_ring,0 );/* gws mask hi */ +amdgpu_ring_write (kiq_ring,0 );/* oac mask */ +amdgpu_ring_write (kiq_ring,0 );/* gds heap base:0, gds heap size:0 */ for (i =0 ; i < adev->gfx.num_compute_rings; i++) {struct amdgpu_ring *ring = &adev->gfx.compute_ring[i];uint64_t mqd_addr =amdgpu_bo_gpu_offset (ring->mqd_obj);
@@ -2836,7 +2794,6 @@ static int gfx_v9_0_kiq_init_queue(struct amdgpu_ring *ring)struct amdgpu_device *adev = ring->adev;struct v9_mqd *mqd = ring->mqd_ptr;int mqd_idx =AMDGPU_MAX_COMPUTE_RINGS ; -int r;gfx_v9_0_kiq_setting (ring);
@@ -2867,9 +2824,7 @@ static int gfx_v9_0_kiq_init_queue(struct amdgpu_ring *ring)mutex_unlock (&adev->srbm_mutex); } - r =gfx_v9_0_kiq_enable (ring); - -return r; +return 0 ; }static int gfx_v9_0_kcq_init_queue (struct amdgpu_ring *ring)
@@ -2941,7 +2896,7 @@ static int gfx_v9_0_kiq_resume(struct amdgpu_device *adev) goto done; } - r =gfx_v9_0_map_queues_enable (adev); + r =gfx_v9_0_kiq_kcq_enable (adev); done:return r; }
Signature · 6 lines
2.5.5 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 4/5 drm/amdgpu/gfx9: fix resume of KIQ and KCQs (v2)
In reply to a message not in the archiveNo need to reset the wptr and clear the rings. The UNMAP_QUEUES packet writes the current MQD state back the MQD on suspend, so there is no need to reset it as well.
v2: fix from gfx8 (Rex)
--- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +15 -13
@@ -2797,18 +2797,7 @@ static int gfx_v9_0_kiq_init_queue(struct amdgpu_ring *ring)gfx_v9_0_kiq_setting (ring); -if (!adev->gfx.in_reset) { -memset ((void *)mqd,0 ,sizeof (*mqd)); -mutex_lock (&adev->srbm_mutex); -soc15_grbm_select (adev, ring->me, ring->pipe, ring->queue,0 ); -gfx_v9_0_mqd_init (ring); -gfx_v9_0_kiq_init_register (ring); -soc15_grbm_select (adev,0 ,0 ,0 ,0 ); -mutex_unlock (&adev->srbm_mutex); - -if (adev->gfx.mec.mqd_backup[mqd_idx]) -memcpy (adev->gfx.mec.mqd_backup[mqd_idx], mqd,sizeof (*mqd)); - }else {/* for GPU_RESET case */ +if (adev->gfx.in_reset) {/* for GPU_RESET case */ /* reset MQD to a clean status */ if (adev->gfx.mec.mqd_backup[mqd_idx])memcpy (mqd, adev->gfx.mec.mqd_backup[mqd_idx],sizeof (*mqd));
@@ -2822,6 +2811,17 @@ static int gfx_v9_0_kiq_init_queue(struct amdgpu_ring *ring)gfx_v9_0_kiq_init_register (ring);soc15_grbm_select (adev,0 ,0 ,0 ,0 );mutex_unlock (&adev->srbm_mutex); + }else { +memset ((void *)mqd,0 ,sizeof (*mqd)); +mutex_lock (&adev->srbm_mutex); +soc15_grbm_select (adev, ring->me, ring->pipe, ring->queue,0 ); +gfx_v9_0_mqd_init (ring); +gfx_v9_0_kiq_init_register (ring); +soc15_grbm_select (adev,0 ,0 ,0 ,0 ); +mutex_unlock (&adev->srbm_mutex); + +if (adev->gfx.mec.mqd_backup[mqd_idx]) +memcpy (adev->gfx.mec.mqd_backup[mqd_idx], mqd,sizeof (*mqd)); }return 0 ;
@@ -2843,7 +2843,7 @@ static int gfx_v9_0_kcq_init_queue(struct amdgpu_ring *ring)if (adev->gfx.mec.mqd_backup[mqd_idx])memcpy (adev->gfx.mec.mqd_backup[mqd_idx], mqd,sizeof (*mqd)); - }else {/* for GPU_RESET case */ + }else if (adev->gfx.in_reset) {/* for GPU_RESET case */ /* reset MQD to a clean status */ if (adev->gfx.mec.mqd_backup[mqd_idx])memcpy (mqd, adev->gfx.mec.mqd_backup[mqd_idx],sizeof (*mqd));
@@ -2851,6 +2851,8 @@ static int gfx_v9_0_kcq_init_queue(struct amdgpu_ring *ring)/* reset ring buffer */ ring->wptr =0 ;amdgpu_ring_clear_ring (ring); + }else { +amdgpu_ring_clear_ring (ring); }return 0 ;
Signature · 6 lines
2.5.5 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 5/5 drm/amdgpu/gfx9: Switch baremetal to use KIQ for compute ring management. (v4)
In reply to a message not in the archiveKIQ is the Kernel Interface Queue for managing the MEC. Rather than setting up rings via direct MMIO of ring registers, the rings are configured via special packets sent to the KIQ. The allows the MEC to better manage shared resources and certain power events. It also reduces the code paths in the driver to support and is required for MEC powergating.
v2: drop gfx_v9_0_cp_compute_fini() as well
v3: rebase on latest changes derived from gfx8, add unmap queues on hw_fini
v4: fix copy/paste typo in error message (Rex)
--- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 374 ++++++++-------------------------- 1 file changed, 81 insertions(+), 293 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +81 -293
@@ -1415,23 +1415,21 @@ static int gfx_v9_0_sw_init(void *handle)return r; } -if (amdgpu_sriov_vf (adev)) { - r =gfx_v9_0_kiq_init (adev); -if (r) { -DRM_ERROR ("Failed to init KIQ BOs!\n" ); -return r; - } + r =gfx_v9_0_kiq_init (adev); +if (r) { +DRM_ERROR ("Failed to init KIQ BOs!\n" ); +return r; + } - kiq = &adev->gfx.kiq; - r =gfx_v9_0_kiq_init_ring (adev, &kiq->ring, &kiq->irq); -if (r) -return r; + kiq = &adev->gfx.kiq; + r =gfx_v9_0_kiq_init_ring (adev, &kiq->ring, &kiq->irq); +if (r) +return r; -/* create MQD for all compute queues as wel as KIQ for SRIOV case */ - r =gfx_v9_0_compute_mqd_sw_init (adev); -if (r) -return r; - } +/* create MQD for all compute queues as wel as KIQ for SRIOV case */ + r =gfx_v9_0_compute_mqd_sw_init (adev); +if (r) +return r;/* reserve GDS, GWS and OA resource for gfx */ r = amdgpu_bo_create_kernel(adev, adev->gds.mem.gfx_partition_size,
@@ -1478,11 +1476,9 @@ static int gfx_v9_0_sw_fini(void *handle)for (i =0 ; i < adev->gfx.num_compute_rings; i++)amdgpu_ring_fini (&adev->gfx.compute_ring[i]); -if (amdgpu_sriov_vf (adev)) { -gfx_v9_0_compute_mqd_sw_fini (adev); -gfx_v9_0_kiq_free_ring (&adev->gfx.kiq.ring, &adev->gfx.kiq.irq); -gfx_v9_0_kiq_fini (adev); - } +gfx_v9_0_compute_mqd_sw_fini (adev); +gfx_v9_0_kiq_free_ring (&adev->gfx.kiq.ring, &adev->gfx.kiq.irq); +gfx_v9_0_kiq_fini (adev);gfx_v9_0_mec_fini (adev);gfx_v9_0_ngg_fini (adev);
@@ -2375,13 +2371,6 @@ static void gfx_v9_0_cp_compute_enable(struct amdgpu_device *adev, bool enable)udelay (50 ); } -static int gfx_v9_0_cp_compute_start (struct amdgpu_device *adev) -{ -gfx_v9_0_cp_compute_enable (adev, true); - -return 0 ; -} -static int gfx_v9_0_cp_compute_load_microcode (struct amdgpu_device *adev) {const struct gfx_firmware_header_v1_0 *mec_hdr;
@@ -2424,45 +2413,6 @@ static int gfx_v9_0_cp_compute_load_microcode(struct amdgpu_device *adev)return 0 ; } -static void gfx_v9_0_cp_compute_fini (struct amdgpu_device *adev) -{ -int i, r; - -for (i =0 ; i < adev->gfx.num_compute_rings; i++) { -struct amdgpu_ring *ring = &adev->gfx.compute_ring[i]; - -if (ring->mqd_obj) { - r =amdgpu_bo_reserve (ring->mqd_obj, true); -if (unlikely (r !=0 )) -dev_warn (adev->dev,"(%d) reserve MQD bo failed\n" , r); - -amdgpu_bo_unpin (ring->mqd_obj); -amdgpu_bo_unreserve (ring->mqd_obj); - -amdgpu_bo_unref (&ring->mqd_obj); - ring->mqd_obj =NULL ; - } - } -} - -static int gfx_v9_0_init_queue (struct amdgpu_ring *ring); - -static int gfx_v9_0_cp_compute_resume (struct amdgpu_device *adev) -{ -int i, r; -for (i =0 ; i < adev->gfx.num_compute_rings; i++) { -struct amdgpu_ring *ring = &adev->gfx.compute_ring[i]; -if (gfx_v9_0_init_queue (ring)) -dev_warn (adev->dev,"compute queue %d init failed!\n" , i); - } - - r =gfx_v9_0_cp_compute_start (adev); -if (r) -return r; - -return 0 ; -} -/* KIQ functions */ static void gfx_v9_0_kiq_setting (struct amdgpu_ring *ring) {
@@ -2553,6 +2503,56 @@ static int gfx_v9_0_kiq_kcq_enable(struct amdgpu_device *adev)return r; } +static int gfx_v9_0_kiq_kcq_disable (struct amdgpu_device *adev) +{ +struct amdgpu_ring *kiq_ring = &adev->gfx.kiq.ring; +uint32_t scratch, tmp =0 ; +int r, i; + + r =amdgpu_gfx_scratch_get (adev, &scratch); +if (r) { +DRM_ERROR ("Failed to get scratch reg (%d).\n" , r); +return r; + } +WREG32 (scratch,0xCAFEDEAD ); + + r =amdgpu_ring_alloc (kiq_ring,6 +3 ); +if (r) { +DRM_ERROR ("Failed to lock KIQ (%d).\n" , r); +amdgpu_gfx_scratch_free (adev, scratch); +return r; + } +/* unmap queues */ +amdgpu_ring_write (kiq_ring,PACKET3 (PACKET3_UNMAP_QUEUES ,4 )); +amdgpu_ring_write (kiq_ring, +PACKET3_UNMAP_QUEUES_ACTION (1 )|/* RESET_QUEUES */ +PACKET3_UNMAP_QUEUES_QUEUE_SEL (2 ));/* select all queues */ +amdgpu_ring_write (kiq_ring,0 ); +amdgpu_ring_write (kiq_ring,0 ); +amdgpu_ring_write (kiq_ring,0 ); +amdgpu_ring_write (kiq_ring,0 ); +/* write to scratch for completion */ +amdgpu_ring_write (kiq_ring,PACKET3 (PACKET3_SET_UCONFIG_REG ,1 )); +amdgpu_ring_write (kiq_ring, (scratch -PACKET3_SET_UCONFIG_REG_START )); +amdgpu_ring_write (kiq_ring,0xDEADBEEF ); +amdgpu_ring_commit (kiq_ring); + +for (i =0 ; i < adev->usec_timeout; i++) { + tmp =RREG32 (scratch); +if (tmp ==0xDEADBEEF ) +break ; +DRM_UDELAY (1 ); + } +if (i >= adev->usec_timeout) { +DRM_ERROR ("KCQ disable failed (scratch(0x%04X)=0x%08X)\n" , + scratch, tmp); + r = -EINVAL ; + } +amdgpu_gfx_scratch_free (adev, scratch); + +return r; +} +static int gfx_v9_0_mqd_init (struct amdgpu_ring *ring) {struct amdgpu_device *adev = ring->adev;
@@ -2833,7 +2833,7 @@ static int gfx_v9_0_kcq_init_queue(struct amdgpu_ring *ring)struct v9_mqd *mqd = ring->mqd_ptr;int mqd_idx = ring - &adev->gfx.compute_ring[0 ]; -if (!adev->gfx.in_reset) { +if (!adev->gfx.in_reset && !adev->gfx.in_suspend) {memset ((void *)mqd,0 ,sizeof (*mqd));mutex_lock (&adev->srbm_mutex);soc15_grbm_select (adev, ring->me, ring->pipe, ring->queue,0 );
@@ -2926,10 +2926,7 @@ static int gfx_v9_0_cp_resume(struct amdgpu_device *adev)if (r)return r; -if (amdgpu_sriov_vf (adev)) - r =gfx_v9_0_kiq_resume (adev); -else - r =gfx_v9_0_cp_compute_resume (adev); + r =gfx_v9_0_kiq_resume (adev);if (r)return r;
@@ -2939,6 +2936,13 @@ static int gfx_v9_0_cp_resume(struct amdgpu_device *adev) ring->ready = false;return r; } + + ring = &adev->gfx.kiq.ring; + ring->ready = true; + r =amdgpu_ring_test_ring (ring); +if (r) + ring->ready = false; +for (i =0 ; i < adev->gfx.num_compute_rings; i++) { ring = &adev->gfx.compute_ring[i];
@@ -2948,14 +2952,6 @@ static int gfx_v9_0_cp_resume(struct amdgpu_device *adev) ring->ready = false; } -if (amdgpu_sriov_vf (adev)) { - ring = &adev->gfx.kiq.ring; - ring->ready = true; - r =amdgpu_ring_test_ring (ring); -if (r) - ring->ready = false; - } -gfx_v9_0_enable_gui_idle_interrupt (adev, true);return 0 ;
@@ -3001,9 +2997,9 @@ static int gfx_v9_0_hw_fini(void *handle)pr_debug ("For SRIOV client, shouldn't do anything.\n" );return 0 ; } +gfx_v9_0_kiq_kcq_disable (adev);gfx_v9_0_cp_enable (adev, false);gfx_v9_0_rlc_stop (adev); -gfx_v9_0_cp_compute_fini (adev);return 0 ; }
@@ -3012,14 +3008,18 @@ static int gfx_v9_0_suspend(void *handle) {struct amdgpu_device *adev = (struct amdgpu_device *)handle; + adev->gfx.in_suspend = true;return gfx_v9_0_hw_fini (adev); }static int gfx_v9_0_resume (void *handle) {struct amdgpu_device *adev = (struct amdgpu_device *)handle; +int r; -return gfx_v9_0_hw_init (adev); + r =gfx_v9_0_hw_init (adev); + adev->gfx.in_suspend = false; +return r; }static bool gfx_v9_0_is_idle (void *handle)
@@ -4466,218 +4466,6 @@ static int gfx_v9_0_get_cu_info(struct amdgpu_device *adev,return 0 ; } -static int gfx_v9_0_init_queue (struct amdgpu_ring *ring) -{ -int r, j; -u32 tmp; -bool use_doorbell = true; -u64 hqd_gpu_addr; -u64 mqd_gpu_addr; -u64 eop_gpu_addr; -u64 wb_gpu_addr; -u32 *buf; -struct v9_mqd *mqd; -struct amdgpu_device *adev; - - adev = ring->adev; -if (ring->mqd_obj ==NULL ) { - r =amdgpu_bo_create (adev, -sizeof (struct v9_mqd ), -PAGE_SIZE ,true, -AMDGPU_GEM_DOMAIN_GTT ,0 ,NULL , -NULL , &ring->mqd_obj); -if (r) { -dev_warn (adev->dev,"(%d) create MQD bo failed\n" , r); -return r; - } - } - - r =amdgpu_bo_reserve (ring->mqd_obj, false); -if (unlikely (r !=0 )) { -gfx_v9_0_cp_compute_fini (adev); -return r; - } - - r =amdgpu_bo_pin (ring->mqd_obj,AMDGPU_GEM_DOMAIN_GTT , - &mqd_gpu_addr); -if (r) { -dev_warn (adev->dev,"(%d) pin MQD bo failed\n" , r); -gfx_v9_0_cp_compute_fini (adev); -return r; - } - r =amdgpu_bo_kmap (ring->mqd_obj, (void **)&buf); -if (r) { -dev_warn (adev->dev,"(%d) map MQD bo failed\n" , r); -gfx_v9_0_cp_compute_fini (adev); -return r; - } - -/* init the mqd struct */ -memset (buf,0 ,sizeof (struct v9_mqd )); - - mqd = (struct v9_mqd *)buf; - mqd->header =0xC0310800 ; - mqd->compute_pipelinestat_enable =0x00000001 ; - mqd->compute_static_thread_mgmt_se0 =0xffffffff ; - mqd->compute_static_thread_mgmt_se1 =0xffffffff ; - mqd->compute_static_thread_mgmt_se2 =0xffffffff ; - mqd->compute_static_thread_mgmt_se3 =0xffffffff ; - mqd->compute_misc_reserved =0x00000003 ; -mutex_lock (&adev->srbm_mutex); -soc15_grbm_select (adev, ring->me, - ring->pipe, - ring->queue,0 ); -/* disable wptr polling */ -WREG32_FIELD15 (GC ,0 ,CP_PQ_WPTR_POLL_CNTL ,EN ,0 ); - -/* write the EOP addr */ -BUG_ON (ring->me !=1 || ring->pipe !=0 );/* can't handle other cases eop address */ - eop_gpu_addr = adev->gfx.mec.hpd_eop_gpu_addr + (ring->queue *MEC_HPD_SIZE ); - eop_gpu_addr >>=8 ; - -WREG32_SOC15 (GC ,0 , mmCP_HQD_EOP_BASE_ADDR,lower_32_bits (eop_gpu_addr)); -WREG32_SOC15 (GC ,0 , mmCP_HQD_EOP_BASE_ADDR_HI,upper_32_bits (eop_gpu_addr)); - mqd->cp_hqd_eop_base_addr_lo =lower_32_bits (eop_gpu_addr); - mqd->cp_hqd_eop_base_addr_hi =upper_32_bits (eop_gpu_addr); - -/* set the EOP size, register value is 2^(EOP_SIZE+1) dwords */ - tmp =RREG32_SOC15 (GC ,0 , mmCP_HQD_EOP_CONTROL); - tmp =REG_SET_FIELD (tmp,CP_HQD_EOP_CONTROL ,EOP_SIZE , - (order_base_2 (MEC_HPD_SIZE /4 ) -1 )); -WREG32_SOC15 (GC ,0 , mmCP_HQD_EOP_CONTROL, tmp); - -/* enable doorbell? */ - tmp =RREG32_SOC15 (GC ,0 , mmCP_HQD_PQ_DOORBELL_CONTROL); -if (use_doorbell) - tmp =REG_SET_FIELD (tmp,CP_HQD_PQ_DOORBELL_CONTROL ,DOORBELL_EN ,1 ); -else - tmp =REG_SET_FIELD (tmp,CP_HQD_PQ_DOORBELL_CONTROL ,DOORBELL_EN ,0 ); - -WREG32_SOC15 (GC ,0 , mmCP_HQD_PQ_DOORBELL_CONTROL, tmp); - mqd->cp_hqd_pq_doorbell_control = tmp; - -/* disable the queue if it's active */ - ring->wptr =0 ; - mqd->cp_hqd_dequeue_request =0 ; - mqd->cp_hqd_pq_rptr =0 ; - mqd->cp_hqd_pq_wptr_lo =0 ; - mqd->cp_hqd_pq_wptr_hi =0 ; -if (RREG32_SOC15 (GC ,0 , mmCP_HQD_ACTIVE) &1 ) { -WREG32_SOC15 (GC ,0 , mmCP_HQD_DEQUEUE_REQUEST,1 ); -for (j =0 ; j < adev->usec_timeout; j++) { -if (!(RREG32_SOC15 (GC ,0 , mmCP_HQD_ACTIVE) &1 )) -break ; -udelay (1 ); - } -WREG32_SOC15 (GC ,0 , mmCP_HQD_DEQUEUE_REQUEST, mqd->cp_hqd_dequeue_request); -WREG32_SOC15 (GC ,0 , mmCP_HQD_PQ_RPTR, mqd->cp_hqd_pq_rptr); -WREG32_SOC15 (GC ,0 , mmCP_HQD_PQ_WPTR_LO, mqd->cp_hqd_pq_wptr_lo); -WREG32_SOC15 (GC ,0 , mmCP_HQD_PQ_WPTR_HI, mqd->cp_hqd_pq_wptr_hi); - } - -/* set the pointer to the MQD */ - mqd->cp_mqd_base_addr_lo = mqd_gpu_addr &0xfffffffc ; - mqd->cp_mqd_base_addr_hi =upper_32_bits (mqd_gpu_addr); -WREG32_SOC15 (GC ,0 , mmCP_MQD_BASE_ADDR, mqd->cp_mqd_base_addr_lo); -WREG32_SOC15 (GC ,0 , mmCP_MQD_BASE_ADDR_HI, mqd->cp_mqd_base_addr_hi); - -/* set MQD vmid to 0 */ - tmp =RREG32_SOC15 (GC ,0 , mmCP_MQD_CONTROL); - tmp =REG_SET_FIELD (tmp,CP_MQD_CONTROL ,VMID ,0 ); -WREG32_SOC15 (GC ,0 , mmCP_MQD_CONTROL, tmp); - mqd->cp_mqd_control = tmp; - -/* set the pointer to the HQD, this is similar CP_RB0_BASE/_HI */ - hqd_gpu_addr = ring->gpu_addr >>8 ; - mqd->cp_hqd_pq_base_lo = hqd_gpu_addr; - mqd->cp_hqd_pq_base_hi =upper_32_bits (hqd_gpu_addr); -WREG32_SOC15 (GC ,0 , mmCP_HQD_PQ_BASE, mqd->cp_hqd_pq_base_lo); -WREG32_SOC15 (GC ,0 , mmCP_HQD_PQ_BASE_HI, mqd->cp_hqd_pq_base_hi); - -/* set up the HQD, this is similar to CP_RB0_CNTL */ - tmp =RREG32_SOC15 (GC ,0 , mmCP_HQD_PQ_CONTROL); - tmp =REG_SET_FIELD (tmp,CP_HQD_PQ_CONTROL ,QUEUE_SIZE , - (order_base_2 (ring->ring_size /4 ) -1 )); - tmp =REG_SET_FIELD (tmp,CP_HQD_PQ_CONTROL ,RPTR_BLOCK_SIZE , - ((order_base_2 (AMDGPU_GPU_PAGE_SIZE /4 ) -1 ) <<8 )); -#ifdef __BIG_ENDIAN - tmp =REG_SET_FIELD (tmp,CP_HQD_PQ_CONTROL ,ENDIAN_SWAP ,1 ); -#endif - tmp =REG_SET_FIELD (tmp,CP_HQD_PQ_CONTROL ,UNORD_DISPATCH ,0 ); - tmp =REG_SET_FIELD (tmp,CP_HQD_PQ_CONTROL ,ROQ_PQ_IB_FLIP ,0 ); - tmp =REG_SET_FIELD (tmp,CP_HQD_PQ_CONTROL ,PRIV_STATE ,1 ); - tmp =REG_SET_FIELD (tmp,CP_HQD_PQ_CONTROL ,KMD_QUEUE ,1 ); -WREG32_SOC15 (GC ,0 , mmCP_HQD_PQ_CONTROL, tmp); - mqd->cp_hqd_pq_control = tmp; - -/* set the wb address wether it's enabled or not */ - wb_gpu_addr = adev->wb.gpu_addr + (ring->rptr_offs *4 ); - mqd->cp_hqd_pq_rptr_report_addr_lo = wb_gpu_addr &0xfffffffc ; - mqd->cp_hqd_pq_rptr_report_addr_hi = -upper_32_bits (wb_gpu_addr) &0xffff ; -WREG32_SOC15 (GC ,0 , mmCP_HQD_PQ_RPTR_REPORT_ADDR, - mqd->cp_hqd_pq_rptr_report_addr_lo); -WREG32_SOC15 (GC ,0 , mmCP_HQD_PQ_RPTR_REPORT_ADDR_HI, - mqd->cp_hqd_pq_rptr_report_addr_hi); - -/* only used if CP_PQ_WPTR_POLL_CNTL.CP_PQ_WPTR_POLL_CNTL__EN_MASK=1 */ - wb_gpu_addr = adev->wb.gpu_addr + (ring->wptr_offs *4 ); - mqd->cp_hqd_pq_wptr_poll_addr_lo = wb_gpu_addr &0xfffffffc ; - mqd->cp_hqd_pq_wptr_poll_addr_hi =upper_32_bits (wb_gpu_addr) &0xffff ; -WREG32_SOC15 (GC ,0 , mmCP_HQD_PQ_WPTR_POLL_ADDR, - mqd->cp_hqd_pq_wptr_poll_addr_lo); -WREG32_SOC15 (GC ,0 , mmCP_HQD_PQ_WPTR_POLL_ADDR_HI, - mqd->cp_hqd_pq_wptr_poll_addr_hi); - -/* enable the doorbell if requested */ -if (use_doorbell) { -WREG32_SOC15 (GC ,0 , mmCP_MEC_DOORBELL_RANGE_LOWER, - (AMDGPU_DOORBELL64_KIQ *2 ) <<2 ); -WREG32_SOC15 (GC ,0 , mmCP_MEC_DOORBELL_RANGE_UPPER, - (AMDGPU_DOORBELL64_MEC_RING7 *2 ) <<2 ); - tmp =RREG32_SOC15 (GC ,0 , mmCP_HQD_PQ_DOORBELL_CONTROL); - tmp =REG_SET_FIELD (tmp,CP_HQD_PQ_DOORBELL_CONTROL , -DOORBELL_OFFSET , ring->doorbell_index); - tmp =REG_SET_FIELD (tmp,CP_HQD_PQ_DOORBELL_CONTROL ,DOORBELL_EN ,1 ); - tmp =REG_SET_FIELD (tmp,CP_HQD_PQ_DOORBELL_CONTROL ,DOORBELL_SOURCE ,0 ); - tmp =REG_SET_FIELD (tmp,CP_HQD_PQ_DOORBELL_CONTROL ,DOORBELL_HIT ,0 ); - mqd->cp_hqd_pq_doorbell_control = tmp; - - }else { - mqd->cp_hqd_pq_doorbell_control =0 ; - } -WREG32_SOC15 (GC ,0 , mmCP_HQD_PQ_DOORBELL_CONTROL, - mqd->cp_hqd_pq_doorbell_control); - -/* reset read and write pointers, similar to CP_RB0_WPTR/_RPTR */ -WREG32_SOC15 (GC ,0 , mmCP_HQD_PQ_WPTR_LO, mqd->cp_hqd_pq_wptr_lo); -WREG32_SOC15 (GC ,0 , mmCP_HQD_PQ_WPTR_HI, mqd->cp_hqd_pq_wptr_hi); - -/* set the vmid for the queue */ - mqd->cp_hqd_vmid =0 ; -WREG32_SOC15 (GC ,0 , mmCP_HQD_VMID, mqd->cp_hqd_vmid); - - tmp =RREG32_SOC15 (GC ,0 , mmCP_HQD_PERSISTENT_STATE); - tmp =REG_SET_FIELD (tmp,CP_HQD_PERSISTENT_STATE ,PRELOAD_SIZE ,0x53 ); -WREG32_SOC15 (GC ,0 , mmCP_HQD_PERSISTENT_STATE, tmp); - mqd->cp_hqd_persistent_state = tmp; - -/* activate the queue */ - mqd->cp_hqd_active =1 ; -WREG32_SOC15 (GC ,0 , mmCP_HQD_ACTIVE, mqd->cp_hqd_active); - -soc15_grbm_select (adev,0 ,0 ,0 ,0 ); -mutex_unlock (&adev->srbm_mutex); - -amdgpu_bo_kunmap (ring->mqd_obj); -amdgpu_bo_unreserve (ring->mqd_obj); - -if (use_doorbell) -WREG32_FIELD15 (GC ,0 ,CP_PQ_STATUS ,DOORBELL_ENABLE ,1 ); - -return 0 ; -} -const struct amdgpu_ip_block_version gfx_v9_0_ip_block = { .type =AMD_IP_BLOCK_TYPE_GFX ,
Signature · 6 lines
2.5.5 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 5 lines · Alex Deucher
These are the laste of the gfx9 KIQ patches that haven't landed yet. Can someone with gfx9 capable hw test this (vega10 or raven)? This is needed to enable powergating on gfx9.
Thanks,
If nobody gets to it by morning I'll try it out first thing on my vega10 though my VBIOS might need updating...
Tom
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 40533e4c-7f8f-70a4-2e15-3540da60b2b0-5C7GfCeVMHo@public.gmane.org
Quoted 8 lines · Tom St Denis
Quoted 5 lines · Alex Deucher
These are the laste of the gfx9 KIQ patches that haven't landed yet. Can someone with gfx9 capable hw test this (vega10 or raven)? This is needed to enable powergating on gfx9.
Thanks,
If nobody gets to it by morning I'll try it out first thing on my vega10 though my VBIOS might need updating...
They don't apply on top of either 4.9 nor 4.11...
Tom
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): b4b2b241-d072-a227-9be4-a51ccd85d063-5C7GfCeVMHo@public.gmane.org
Quoted 11 lines · Tom St Denis
Quoted 10 lines · Tom St Denis
Quoted 6 lines · Alex Deucher
These are the laste of the gfx9 KIQ patches that haven't landed yet. Can someone with gfx9 capable hw test this (vega10 or raven)? This is needed to enable powergating on gfx9.
Thanks,
Quoted 6 lines
Quoted 2 lines
If nobody gets to it by morning I'll try it out first thing on my vega10 though my VBIOS might need updating...
They don't apply on top of either 4.9 nor 4.11...
Odd. They applied for me (at least to the 4.11 tree I had checked out when I left town). Attached again just in case.
Alex
Quoted 7 lines
Tom
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): CADnq5_O+kbGLTR6H+a+7RRUz2etK5gJQt1YVsXEr3RE+UpoqyQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Alex Deucher
Reviewed-by monk liuQuoted 17 lines · Alex Deucher
Quoted 16 lines · Tom St Denis
Quoted 12 lines · Tom St Denis
Quoted 6 lines · Alex Deucher
These are the laste of the gfx9 KIQ patches that haven't landed yet. Can someone with gfx9 capable hw test this (vega10 or raven)? This is needed to enable powergating on gfx9.
Thanks,
If nobody gets to it by morning I'll try it out first thing on my vega10 though my VBIOS might need updating...
Quoted 14 lines
Quoted 1 line
They don't apply on top of either 4.9 nor 4.11...
Odd. They applied for me (at least to the 4.11 tree I had checked out when I left town). Attached again just in case.
Alex
Quoted 7 lines
Tom
_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
From c053a709b9fcf8e3a2f99807e15d84c504a044e3 Mon Sep 17 00:00:00 2001
From: Alex Deucher <[email protected]>
Date: Mon, 17 Apr 2017 17:24:47 -0400
Subject: [PATCH 4/5] drm/amdgpu/gfx9: fix resume of KIQ and KCQs (v2)
No need to reset the wptr and clear the rings. The UNMAP_QUEUES packet writes the current MQD state back the MQD on suspend, so there is no need to reset it as well.
v2: fix from gfx8 (Rex)
--- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +15 -13
@@ -2797,18 +2797,7 @@ static int gfx_v9_0_kiq_init_queue(struct amdgpu_ring *ring)gfx_v9_0_kiq_setting (ring); -if (!adev->gfx.in_reset) { -memset ((void *)mqd,0 ,sizeof (*mqd)); -mutex_lock (&adev->srbm_mutex); -soc15_grbm_select (adev, ring->me, ring->pipe, ring->queue,0 ); -gfx_v9_0_mqd_init (ring); -gfx_v9_0_kiq_init_register (ring); -soc15_grbm_select (adev,0 ,0 ,0 ,0 ); -mutex_unlock (&adev->srbm_mutex); - -if (adev->gfx.mec.mqd_backup[mqd_idx]) -memcpy (adev->gfx.mec.mqd_backup[mqd_idx], mqd,sizeof (*mqd)); - }else {/* for GPU_RESET case */ +if (adev->gfx.in_reset) {/* for GPU_RESET case */ /* reset MQD to a clean status */ if (adev->gfx.mec.mqd_backup[mqd_idx])memcpy (mqd, adev->gfx.mec.mqd_backup[mqd_idx],sizeof (*mqd));
@@ -2822,6 +2811,17 @@ static int gfx_v9_0_kiq_init_queue(struct amdgpu_ring *ring)gfx_v9_0_kiq_init_register (ring);soc15_grbm_select (adev,0 ,0 ,0 ,0 );mutex_unlock (&adev->srbm_mutex); + }else { +memset ((void *)mqd,0 ,sizeof (*mqd)); +mutex_lock (&adev->srbm_mutex); +soc15_grbm_select (adev, ring->me, ring->pipe, ring->queue,0 ); +gfx_v9_0_mqd_init (ring); +gfx_v9_0_kiq_init_register (ring); +soc15_grbm_select (adev,0 ,0 ,0 ,0 ); +mutex_unlock (&adev->srbm_mutex); + +if (adev->gfx.mec.mqd_backup[mqd_idx]) +memcpy (adev->gfx.mec.mqd_backup[mqd_idx], mqd,sizeof (*mqd)); }return 0 ;
@@ -2843,7 +2843,7 @@ static int gfx_v9_0_kcq_init_queue(struct amdgpu_ring *ring)if (adev->gfx.mec.mqd_backup[mqd_idx])memcpy (adev->gfx.mec.mqd_backup[mqd_idx], mqd,sizeof (*mqd)); - }else {/* for GPU_RESET case */ + }else if (adev->gfx.in_reset) {/* for GPU_RESET case */ /* reset MQD to a clean status */ if (adev->gfx.mec.mqd_backup[mqd_idx])memcpy (mqd, adev->gfx.mec.mqd_backup[mqd_idx],sizeof (*mqd));
@@ -2851,6 +2851,8 @@ static int gfx_v9_0_kcq_init_queue(struct amdgpu_ring *ring)/* reset ring buffer */ ring->wptr =0 ;amdgpu_ring_clear_ring (ring); + }else { +amdgpu_ring_clear_ring (ring); }return 0 ;
Signature · 1 line
2.5.5
From 81da96f2dfb733480ee6cb5146d9e9d7c08e45ed Mon Sep 17 00:00:00 2001
From: Alex Deucher <[email protected]>
Date: Mon, 17 Apr 2017 17:10:11 -0400
Subject: [PATCH 3/5] drm/amdgpu/gfx9: move SET_RESOURCES into the same command
stream
As the KCQ setup. This way we only have to wait once for the entire MEC.
--- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 73 +++++++---------------------------- 1 file changed, 14 insertions(+), 59 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +14 -59
109 lines not on this page · raw message
Signature · 1 line
2.5.5
From 7f3fea3072ee0ba162cd17071c7439305c487ff1 Mon Sep 17 00:00:00 2001
From: Alex Deucher <[email protected]>
Date: Mon, 17 Apr 2017 17:51:00 -0400
Subject: [PATCH 5/5] drm/amdgpu/gfx9: Switch baremetal to use KIQ for compute
ring management. (v4)
KIQ is the Kernel Interface Queue for managing the MEC. Rather than setting up rings via direct MMIO of ring registers, the rings are configured via special packets sent to the KIQ. The allows the MEC to better manage shared resources and certain power events. It also reduces the code paths in the driver to support and is required for MEC powergating.
v2: drop gfx_v9_0_cp_compute_fini() as well
v3: rebase on latest changes derived from gfx8, add unmap queues on hw_fini
v4: fix copy/paste typo in error message (Rex)
--- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 374 ++++++++-------------------------- 1 file changed, 81 insertions(+), 293 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +81 -293
457 lines not on this page · raw message
Signature · 1 line
2.5.5
From dd08e1cd9bce840673abca36a3442ae0b6224db4 Mon Sep 17 00:00:00 2001
From: Alex Deucher <[email protected]>
Date: Mon, 17 Apr 2017 17:05:02 -0400
Subject: [PATCH 2/5] drm/amdgpu/gfx9: wait once for all KCQs to be created
Rather than waiting for each queue.
--- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 60 +++++++++++++++++------------------ 1 file changed, 29 insertions(+), 31 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +29 -31
105 lines not on this page · raw message
Signature · 1 line
2.5.5
From 9d4360cff930d34e53b69158bb364b7cf11e7ea3 Mon Sep 17 00:00:00 2001
From: Alex Deucher <[email protected]>
Date: Mon, 17 Apr 2017 16:39:13 -0400
Subject: [PATCH 1/5] drm/amdgpu: split gfx_v9_0_kiq_init_queue into two
One for KIQ and one for the KCQ. This simplifies the logic and allows for future optimizations.
--- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 63 +++++++++++++++++++++++------------ 1 file changed, 42 insertions(+), 21 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +42 -21
93 lines not on this page · raw message
Signature · 1 line
2.5.5
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): CADnq5_NSwLQW6A3pTVLR2CHBeyNDE4jWx5J3FVDwH-7h53F1mQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Quoted 18 lines · Alex Deucher
Quoted 17 lines · Alex Deucher
Quoted 16 lines · Tom St Denis
Quoted 12 lines · Tom St Denis
Quoted 6 lines · Alex Deucher
These are the laste of the gfx9 KIQ patches that haven't landed yet. Can someone with gfx9 capable hw test this (vega10 or raven)? This is needed to enable powergating on gfx9.
Thanks,
If nobody gets to it by morning I'll try it out first thing on my vega10 though my VBIOS might need updating...
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
They don't apply on top of either 4.9 nor 4.11...
Odd. They applied for me (at least to the 4.11 tree I had checked out when I left town). Attached again just in case.
This series applies fine and seems to work in basic tests (gnome + GL apps + uvd/vce apps) on my vega10.
Haven't tried on raven yet.
Tom
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): ae9e8d7c-ac6f-3fae-0986-0f74e106be09-5C7GfCeVMHo@public.gmane.org
Quoted 33 lines
-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Tom St Denis
Sent: Wednesday, May 24, 2017 7:50 AM
To: Alex Deucher
Cc: amd-gfx list
Subject: Re: [PATCH 0/5] GFX9 KIQQuoted 1 line · Alex Deucher
On Tue, May 23, 2017 at 5:31 PM, Alex Deucher <[email protected]>
Quoted 1 line · wrote:
Quoted 1 line
On Fri, May 12, 2017 at 7:11 AM, Tom St Denis <[email protected]>
Quoted 5 lines · wrote:
Quoted 5 lines
Quoted 5 lines · Tom St Denis
Quoted 4 lines · Alex Deucher
Quoted 2 lines
These are the laste of the gfx9 KIQ patches that haven't landed yet.
Can
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
someone with gfx9 capable hw test this (vega10 or raven)? This is
needed
Quoted 12 lines
Quoted 12 lines
Quoted 11 lines
Quoted 7 lines
Quoted 3 lines
to enable powergating on gfx9.
Thanks,
If nobody gets to it by morning I'll try it out first thing on my vega10 though my VBIOS might need updating...
They don't apply on top of either 4.9 nor 4.11...
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
Odd. They applied for me (at least to the 4.11 tree I had checked out when I left town). Attached again just in case.
This series applies fine and seems to work in basic tests (gnome + GL apps + uvd/vce apps) on my vega10.
Haven't tried on raven yet.
All the ring and IB tests pass?
Quoted 6 lines
Tom
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): BN6PR12MB1652617D3506D75744B56A55F7FE0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org
Quoted 36 lines · Alexander
Quoted 36 lines
-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Tom St Denis
Sent: Wednesday, May 24, 2017 7:50 AM
To: Alex Deucher
Cc: amd-gfx list
Subject: Re: [PATCH 0/5] GFX9 KIQQuoted 1 line · Alex Deucher
On Tue, May 23, 2017 at 5:31 PM, Alex Deucher <[email protected]>
Quoted 1 line · wrote:
Quoted 1 line
On Fri, May 12, 2017 at 7:11 AM, Tom St Denis <[email protected]>
Quoted 5 lines · wrote:
Quoted 5 lines
Quoted 5 lines · Tom St Denis
Quoted 4 lines · Alex Deucher
Quoted 2 lines
These are the laste of the gfx9 KIQ patches that haven't landed yet.
Can
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
someone with gfx9 capable hw test this (vega10 or raven)? This is
needed
Quoted 14 lines
Quoted 14 lines
Quoted 11 lines
Quoted 7 lines
Quoted 3 lines
to enable powergating on gfx9.
Thanks,
If nobody gets to it by morning I'll try it out first thing on my vega10 though my VBIOS might need updating...
They don't apply on top of either 4.9 nor 4.11...
Odd. They applied for me (at least to the 4.11 tree I had checked out when I left town). Attached again just in case.
Quoted 6 lines
Quoted 4 lines
This series applies fine and seems to work in basic tests (gnome + GL apps + uvd/vce apps) on my vega10.
Haven't tried on raven yet.
All the ring and IB tests pass?
Ya it boots up and I can run gnome + gl apps just fine.
Tom
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 8e2430e1-bca7-a40c-6a2e-dff13b7be18a-5C7GfCeVMHo@public.gmane.org
Quoted 48 lines
-----Original Message-----
From: StDenis, Tom
Sent: Wednesday, May 24, 2017 9:10 AM
To: Deucher, Alexander; Alex Deucher
Cc: amd-gfx list
Subject: Re: [PATCH 0/5] GFX9 KIQQuoted 2 lines · Alexander
Quoted 2 lines
-----Original Message-----
From: amd-gfx [mailto:[email protected]] OnBehalf
Quoted 8 lines
Quoted 8 lines
Of Tom St Denis
Sent: Wednesday, May 24, 2017 7:50 AM
To: Alex Deucher
Cc: amd-gfx list
Subject: Re: [PATCH 0/5] GFX9 KIQQuoted 1 line · Alex Deucher
On Tue, May 23, 2017 at 5:31 PM, Alex Deucher
Quoted 2 lines
Quoted 2 lines
Quoted 1 line · wrote:
Quoted 1 line
On Fri, May 12, 2017 at 7:11 AM, Tom St Denis
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines · wrote:
Quoted 5 lines
Quoted 5 lines · Tom St Denis
Quoted 4 lines · Alex Deucher
Quoted 2 lines
These are the laste of the gfx9 KIQ patches that haven't landed
yet.
Quoted 18 lines
Quoted 18 lines
Can
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
someone with gfx9 capable hw test this (vega10 or raven)? This is
needed
Quoted 14 lines
Quoted 14 lines
Quoted 11 lines
Quoted 7 lines
Quoted 3 lines
to enable powergating on gfx9.
Thanks,
If nobody gets to it by morning I'll try it out first thing on my vega10 though my VBIOS might need updating...
They don't apply on top of either 4.9 nor 4.11...
Odd. They applied for me (at least to the 4.11 tree I had checked out when I left town). Attached again just in case.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
This series applies fine and seems to work in basic tests (gnome + GL apps + uvd/vce apps) on my vega10.
Haven't tried on raven yet.
All the ring and IB tests pass?
Ya it boots up and I can run gnome + gl apps just fine.
Awesome. Anyone want to give me an r-b or a-b on the remaining patches?
Thanks,
Alex
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): BN6PR12MB1652BF6047A8C642635A7AA8F7FE0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org
Quoted 51 lines · Alexander
Quoted 51 lines
-----Original Message-----
From: StDenis, Tom
Sent: Wednesday, May 24, 2017 9:10 AM
To: Deucher, Alexander; Alex Deucher
Cc: amd-gfx list
Subject: Re: [PATCH 0/5] GFX9 KIQQuoted 2 lines · Alexander
Quoted 2 lines
-----Original Message-----
From: amd-gfx [mailto:[email protected]] OnBehalf
Quoted 8 lines
Quoted 8 lines
Of Tom St Denis
Sent: Wednesday, May 24, 2017 7:50 AM
To: Alex Deucher
Cc: amd-gfx list
Subject: Re: [PATCH 0/5] GFX9 KIQQuoted 1 line · Alex Deucher
On Tue, May 23, 2017 at 5:31 PM, Alex Deucher
Quoted 2 lines
Quoted 2 lines
Quoted 1 line · wrote:
Quoted 1 line
On Fri, May 12, 2017 at 7:11 AM, Tom St Denis
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines · wrote:
Quoted 5 lines
Quoted 5 lines · Tom St Denis
Quoted 4 lines · Alex Deucher
Quoted 2 lines
These are the laste of the gfx9 KIQ patches that haven't landed
yet.
Quoted 21 lines
Quoted 21 lines
Can
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
someone with gfx9 capable hw test this (vega10 or raven)? This is
needed
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 7 lines
Quoted 3 lines
to enable powergating on gfx9.
Thanks,
If nobody gets to it by morning I'll try it out first thing on my vega10 though my VBIOS might need updating...
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
They don't apply on top of either 4.9 nor 4.11...
Odd. They applied for me (at least to the 4.11 tree I had checked out when I left town). Attached again just in case.
This series applies fine and seems to work in basic tests (gnome + GL apps + uvd/vce apps) on my vega10.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Haven't tried on raven yet.
All the ring and IB tests pass?
Ya it boots up and I can run gnome + gl apps just fine.
Awesome. Anyone want to give me an r-b or a-b on the remaining patches?
Definitely so far as vega10 is concerned.
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
I don't have any test for KCQ , but KFD use the KIQ to invalidate_tlbs , I try to add some print message in the code to prove it go through the new code path , but seems I don't see any messages I added. I tried pr_info , pr_err and printk , DRM_ERROR and nothing works , anything changed in amdgpu side to prevent the message print ?
Regards
shaoyun.liu
-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Alex Deucher
Sent: Tuesday, May 23, 2017 5:31 PM
To: StDenis, Tom
Cc: amd-gfx list
Subject: Re: [PATCH 0/5] GFX9 KIQ
Quoted 11 lines · Tom St Denis
Quoted 10 lines · Tom St Denis
Quoted 6 lines · Alex Deucher
These are the laste of the gfx9 KIQ patches that haven't landed yet. Can someone with gfx9 capable hw test this (vega10 or raven)? This is needed to enable powergating on gfx9.
Thanks,
Quoted 6 lines
Quoted 2 lines
If nobody gets to it by morning I'll try it out first thing on my vega10 though my VBIOS might need updating...
They don't apply on top of either 4.9 nor 4.11...
Odd. They applied for me (at least to the 4.11 tree I had checked out when I left town). Attached again just in case.
Alex
Quoted 7 lines
Tom
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): DM5PR12MB117966B9DD5EE37CB9CB714DF4F90-2J9CzHegvk8p/[email protected]
Quoted 8 lines
-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Liu, Shaoyun
Sent: Tuesday, May 23, 2017 7:38 PM
To: Alex Deucher; StDenis, Tom
Cc: amd-gfx list
Subject: RE: [PATCH 0/5] GFX9 KIQ
Quoted 5 lines
I don't have any test for KCQ , but KFD use the KIQ to
invalidate_tlbs, I try to add some print message in the code to prove it go through the new code path , but seems I don't see any messages I added. I triedpr_info,pr_errand printk ,DRM_ERRORand nothing works , anything changed in amdgpu side to prevent the message print ?
Do you see the KIQ and compute ring and IB tests passing?
Alex
Quoted 44 lines
Regards
shaoyun.liu-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Alex Deucher
Sent: Tuesday, May 23, 2017 5:31 PM
To: StDenis, Tom
Cc: amd-gfx list
Subject: Re: [PATCH 0/5] GFX9 KIQQuoted 11 lines · Tom St Denis
Quoted 10 lines · Tom St Denis
Quoted 6 lines · Alex Deucher
These are the laste of the gfx9 KIQ patches that haven't landed yet. Can someone with gfx9 capable hw test this (vega10 or raven)? This is needed to enable powergating on gfx9.
Thanks,
Quoted 6 lines
Quoted 2 lines
If nobody gets to it by morning I'll try it out first thing on my vega10 though my VBIOS might need updating...
They don't apply on top of either 4.9 nor 4.11...
Odd. They applied for me (at least to the 4.11 tree I had checked out when I left town). Attached again just in case.
Alex
Quoted 7 lines
Tom
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 8 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): BN6PR12MB1652DE2A0E7837BC8E35395AF7FE0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org
HI , Alex
It turn out to be a wrong card I used for test .
With a correct Vega10 card , KIQ and other compute rings ring test and IB test passed. I also verified KFD can use the KIQ to submit the invalidate_tlbs successfully .
Regards
Shaoyun.liu
-----Original Message-----
From: Deucher, Alexander
Sent: Wednesday, May 24, 2017 7:14 AM
To: Liu, Shaoyun; Alex Deucher; StDenis, Tom
Cc: amd-gfx list
Subject: RE: [PATCH 0/5] GFX9 KIQ
Quoted 8 lines
-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Liu, Shaoyun
Sent: Tuesday, May 23, 2017 7:38 PM
To: Alex Deucher; StDenis, Tom
Cc: amd-gfx list
Subject: RE: [PATCH 0/5] GFX9 KIQ
Quoted 5 lines
I don't have any test for KCQ , but KFD use the KIQ to
invalidate_tlbs, I try to add some print message in the code to prove it go through the new code path , but seems I don't see any messages I added. I triedpr_info,pr_errand printk ,DRM_ERRORand nothing works , anything changed in amdgpu side to prevent the message print ?
Do you see the KIQ and compute ring and IB tests passing?
Alex
Quoted 44 lines
Regards
shaoyun.liu-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Alex Deucher
Sent: Tuesday, May 23, 2017 5:31 PM
To: StDenis, Tom
Cc: amd-gfx list
Subject: Re: [PATCH 0/5] GFX9 KIQQuoted 11 lines · Tom St Denis
Quoted 10 lines · Tom St Denis
Quoted 6 lines · Alex Deucher
These are the laste of the gfx9 KIQ patches that haven't landed yet. Can someone with gfx9 capable hw test this (vega10 or raven)? This is needed to enable powergating on gfx9.
Thanks,
Quoted 6 lines
Quoted 2 lines
If nobody gets to it by morning I'll try it out first thing on my vega10 though my VBIOS might need updating...
They don't apply on top of either 4.9 nor 4.11...
Odd. They applied for me (at least to the 4.11 tree I had checked out when I left town). Attached again just in case.
Alex
Quoted 7 lines
Tom
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 8 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx