net/bonding: fix MTU set for slaves
Subsystems (2)
PATCH 1/1 net/bonding: fix MTU set for slaves
ethdev requires device to be configured before setting MTU.
In bonding PMD, while configuring slaves, bonding first sets MTU later configures them, which causes failure if slaves are not configured in advance.
Fixing by changing the order in slave configure as requested in ethdev layer, configure first and set MTU later.
Bugzilla ID: 864
---
Cc: Andrew Rybchenko <[email protected]>
Cc: [email protected]
--- drivers/net/bonding/rte_eth_bond_pmd.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/net/bonding/rte_eth_bond_pmd.c +8 -8
@@ -1741,14 +1741,6 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, } } - errval =rte_eth_dev_set_mtu (slave_eth_dev->data->port_id, - bonded_eth_dev->data->mtu); -if (errval !=0 && errval != -ENOTSUP ) { -RTE_BOND_LOG (ERR ,"rte_eth_dev_set_mtu: port %u, err (%d)" , - slave_eth_dev->data->port_id, errval); -return errval; - } -/* Configure device */ errval = rte_eth_dev_configure(slave_eth_dev->data->port_id, nb_rx_queues, nb_tx_queues,
@@ -1759,6 +1751,14 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,return errval; } + errval =rte_eth_dev_set_mtu (slave_eth_dev->data->port_id, + bonded_eth_dev->data->mtu); +if (errval !=0 && errval != -ENOTSUP ) { +RTE_BOND_LOG (ERR ,"rte_eth_dev_set_mtu: port %u, err (%d)" , + slave_eth_dev->data->port_id, errval); +return errval; + } +/* Setup Rx Queues */ for (q_id =0 ; q_id < bonded_eth_dev->data->nb_rx_queues; q_id++) { bd_rx_q = (struct bond_rx_queue *)bonded_eth_dev->data->rx_queues[q_id];
Signature · 1 line
2.34.1
Quoted 19 lines
-----Original Message-----
From: Yigit, Ferruh <[email protected]>
Sent: Wednesday, January 26, 2022 9:11 PM
To: Chas Williams <[email protected]>; Min Hu (Connor) <[email protected]>; Ivan Ilchenko <[email protected]>; Andrew Rybchenko <[email protected]>
Cc: [email protected]; Yigit, Ferruh <[email protected]>; [email protected]; Andrew Rybchenko <[email protected]>; Jiang, YuX <[email protected]>
Subject: [PATCH] net/bonding: fix MTU set for slavesethdev requires device to be configured before setting MTU.
In bonding PMD, while configuring slaves, bonding first sets MTU later configures them, which causes failure if slaves are not configured in advance.
Fixing by changing the order in slave configure as requested in ethdev layer, configure first and set MTU later.
Quoted 6 lines
Bugzilla ID: 864
Fixes b26bee10ee37 ("ethdev: forbid MTU set before device configure")Signed-off-by Ferruh Yigit <[email protected]>---
Quoted 3 lines
Cc Andrew Rybchenko <[email protected]>---
Verified patchset https://patches.dpdk.org/project/dpdk/patch/[email protected]/ on baseline v22.03-rc0's 8a5a91401d . Tested pass on nic Ethernet Connection X722 for 10GbE SFP+ 37d0/Ubuntu21.10,5.13.0-19-generic
Quoted 56 lines · Ferruh Yigit
ethdev requires device to be configured before setting MTU.
In bonding PMD, while configuring slaves, bonding first sets MTU later configures them, which causes failure if slaves are not configured in advance.
Fixing by changing the order in slave configure as requested in ethdev layer, configure first and set MTU later.
Bugzilla ID: 864
Fixes b26bee10ee37 ("ethdev: forbid MTU set before device configure")Signed-off-by Ferruh Yigit <[email protected]>---
Cc: Andrew Rybchenko <[email protected]>
Cc: [email protected]--- drivers/net/bonding/rte_eth_bond_pmd.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)drivers/net/bonding/rte_eth_bond_pmd.c +8
-8@@ -1741,14 +1741,6 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, } } - errval =rte_eth_dev_set_mtu (slave_eth_dev->data->port_id, - bonded_eth_dev->data->mtu); -if (errval !=0 && errval != -ENOTSUP ) { -RTE_BOND_LOG (ERR ,"rte_eth_dev_set_mtu: port %u, err (%d)" , - slave_eth_dev->data->port_id, errval); -return errval; - } -/* Configure device */ errval = rte_eth_dev_configure(slave_eth_dev->data->port_id, nb_rx_queues, nb_tx_queues,@@ -1759,6 +1751,14 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,return errval; } + errval =rte_eth_dev_set_mtu (slave_eth_dev->data->port_id, + bonded_eth_dev->data->mtu); +if (errval !=0 && errval != -ENOTSUP ) { +RTE_BOND_LOG (ERR ,"rte_eth_dev_set_mtu: port %u, err (%d)" , + slave_eth_dev->data->port_id, errval); +return errval; + } +/* Setup Rx Queues */ for (q_id =0 ; q_id < bonded_eth_dev->data->nb_rx_queues; q_id++) { bd_rx_q = (struct bond_rx_queue *)bonded_eth_dev->data->rx_queues[q_id];
Ferruh Yigit
AppliedOn 1/27/2022 9:18 AM, Min Hu (Connor) wrote:
<...>
Quoted 14 lines · Ferruh Yigit
Quoted 13 lines
ethdev requires device to be configured before setting MTU.
In bonding PMD, while configuring slaves, bonding first sets MTU later configures them, which causes failure if slaves are not configured in advance.
Fixing by changing the order in slave configure as requested in ethdev layer, configure first and set MTU later.
Bugzilla ID: 864
Fixes b26bee10ee37 ("ethdev: forbid MTU set before device configure")
Quoted 6 lines
Quoted 1 line
Signed-off-by Ferruh Yigit <[email protected]>Tested-by Yu Jiang <[email protected]>Acked-by Min Hu (Connor) <[email protected]>
Applied to dpdk-next-net/main, thanks.