libbpf: add zlib as a dependency in pkg-config template
Subsystems (4)
PATCH 1/1 libbpf: add zlib as a dependency in pkg-config template
List zlib as another dependency of libbpf in pkg-config template. Verified it is correctly resolved to proper -lz flag:
$ make DESTDIR=/tmp/libbpf-install install $ pkg-config --libs /tmp/libbpf-install/usr/local/lib64/pkgconfig/libbpf.pc -L/usr/local/lib64 -lbpf $ pkg-config --libs --static /tmp/libbpf-install/usr/local/lib64/pkgconfig/libbpf.pc -L/usr/local/lib64 -lbpf -lelf -lz
--- tools/lib/bpf/libbpf.pc.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/lib/bpf/libbpf.pc.template +1 -1
@@ -8,5 +8,5 @@ Name: libbpf Description: BPF library Version: @VERSION@ Libs: -L${libdir} -lbpf -Requires.private: libelf +Requires.private: libelf zlib Cflags: -I${includedir}
Signature · 1 line
2.17.1
Quoted 8 lines · Andrii Nakryiko
List zlib as another dependency of libbpf in pkg-config template. Verified it is correctly resolved to proper -lz flag:
$ make DESTDIR=/tmp/libbpf-install install $ pkg-config --libs /tmp/libbpf-install/usr/local/lib64/pkgconfig/libbpf.pc -L/usr/local/lib64 -lbpf $ pkg-config --libs --static /tmp/libbpf-install/usr/local/lib64/pkgconfig/libbpf.pc -L/usr/local/lib64 -lbpf -lelf -lz
Even without this patch, I already got -lz for static link libraries:
-bash-4.4$ cat libbpf.pc.template
...
Requires.private: libelf
...
-bash-4.4$ pkg-config --libs --static /tmp/libbpf-install/usr/local/lib64/pkgconfig/libbpf.pc -L/usr/local/lib64 -lbpf -lelf -lz
libelf depending on zlib. Maybe -lz is introduced due to libelf.
But in any case, add explicit dependency to zlib from libbpf probably a good thing since libbpf directly uses its API functions.
[...]
Quoted 12 lines
tools/lib/bpf/libbpf.pc.template +1
-1@@ -8,5 +8,5 @@ Name: libbpf Description: BPF library Version: @VERSION@ Libs: -L${libdir} -lbpf -Requires.private: libelf +Requires.private: libelf zlib Cflags: -I${includedir}
Alexei Starovoitov
AppliedQuoted 23 lines · Yonghong Song
Quoted 8 lines · Andrii Nakryiko
List zlib as another dependency of libbpf in pkg-config template. Verified it is correctly resolved to proper -lz flag:
$ make DESTDIR=/tmp/libbpf-install install $ pkg-config --libs /tmp/libbpf-install/usr/local/lib64/pkgconfig/libbpf.pc -L/usr/local/lib64 -lbpf $ pkg-config --libs --static /tmp/libbpf-install/usr/local/lib64/pkgconfig/libbpf.pc -L/usr/local/lib64 -lbpf -lelf -lzEven without this patch, I already got -lz for static link libraries:
-bash-4.4$ cat libbpf.pc.template
...
Requires.private: libelf
...
-bash-4.4$ pkg-config --libs --static/tmp/libbpf-install/usr/local/lib64/pkgconfig/libbpf.pc-L/usr/local/lib64 -lbpf -lelf -lz
Quoted 6 lines
libelf depending on zlib. Maybe -lz is introduced due to libelf.
But in any case, add explicit dependency to zlib from libbpf probably a good thing since libbpf directly uses its API functions.
Acked-by Yonghong Song <[email protected]>
Applied. Thanks