Skip to contentSkip to conversation

ARM: bcm283x: Add missing interrupt for RNG block

PATCH New Stefan Wahren 2 participants 5 messages Nov 18, 2017 – Apr 13, 2018

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

cover ARM: bcm283x: Add missing interrupt for RNG block

Hi Florian,

i do not know your plans for V3 of your RNG consolidation series, but there is the wish of the FreeBSD guys to add the interrupt property to the DTS file [1].

There is no high prio, so feel free to squash it into your series or i could rebase on your next version.

[1] - https://github.com/raspberrypi/linux/issues/2195

Stefan Wahren (2):
dt-binding: rng: Add interrupt property for BCM2835
ARM: bcm283x: Add missing interrupt for RNG block

 Documentation/devicetree/bindings/rng/brcm,bcm2835.txt | 9 +++++++--
 arch/arm/boot/dts/bcm283x.dtsi                         | 1 +
 2 files changed, 8 insertions(+), 2 deletions(-)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/2 dt-binding: rng: Add interrupt property for BCM2835

As Sylvain Garrigues pointed out the BCM2835 RNG block has an interrupt. Also in preparation for Florian's upcoming patch series add this property to the binding. While we are at it fix the indenting of the example.

---
 Documentation/devicetree/bindings/rng/brcm,bcm2835.txt | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/rng/brcm,bcm2835.txt +7 -2
index 2654269..82ef4dd 100644
@@ -6,11 +6,16 @@ Required properties:
   "brcm,bcm5301x-rng"
 - reg : Specifies base physical address and size of the registers.
 
+Optional properties:
+
+- interrupts: specify the interrupt for the RNG block
+
 Example:
 
 rng {
-        compatible = "brcm,bcm2835-rng";
-        reg = <0x7e104000 0x10>;
+	compatible = "brcm,bcm2835-rng";
+	reg = <0x7e104000 0x10>;
+	interrupts = <2 29>;
 };
 
 rng at 18033000 {
Signature · 1 line
2.7.4
#2 lore raw

PATCH 1/2 dt-binding: rng: Add interrupt property for BCM2835

Quoted 8 lines · Stefan Wahren

As Sylvain Garrigues pointed out the BCM2835 RNG block has an interrupt. Also in preparation for Florian's upcoming patch series add this property to the binding. While we are at it fix the indenting of the example.

Applied to devicetree/next, thanks!

Signature · 1 line
Florian
#3 lore raw

PATCH 2/2 ARM: bcm283x: Add missing interrupt for RNG block

In reply to Stefan Wahren

This patch adds the missing interrupt property to the RNG block of BCM283x.

---
 arch/arm/boot/dts/bcm283x.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/bcm283x.dtsi +1 -0
index 013431e..0c17a81 100644
@@ -135,6 +135,7 @@
 		rng at 7e104000 {
 			compatible = "brcm,bcm2835-rng";
 			reg = <0x7e104000 0x10>;
+			interrupts = <2 29>;
 		};
 
 		mailbox: mailbox at 7e00b880 {
Signature · 1 line
2.7.4