Skip to contentSkip to conversation

package/bmap-tools: new package

PATCH New Nicolas Carrier 3 participants 9 messages Nov 5, 2019 – Sep 4, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/2 package/bmap-tools: new package

---

I need bmap-tools on the target since it's what our flashing / upgrade procudure uses to speed up the process (flashing ~8GB disk images full of zeroes).

Changes v3 -v4:
- added the upstream URL to the package's help

Changes v2 -> v3:
- double-checked that setuptools is required by bmap-tools at runtime too
- moved the "v" from BMAP_TOOLS_VERSION to BMAP_TOOLS_SITE (in the .hash too)
- changed license name from GPLv2 to GPL-2.0

Changes v1 -> v2:
- no change

---

---
 DEVELOPERS                         |  3 +++
 package/Config.in                  |  1 +
 package/bmap-tools/Config.in       | 15 +++++++++++++++
 package/bmap-tools/bmap-tools.hash |  2 ++
 package/bmap-tools/bmap-tools.mk   | 15 +++++++++++++++
 5 files changed, 36 insertions(+)
 create mode 100644 package/bmap-tools/Config.in
 create mode 100644 package/bmap-tools/bmap-tools.hash
 create mode 100644 package/bmap-tools/bmap-tools.mk
DEVELOPERS +3 -0
index 24c57b25f7..947722a8c7 100644
@@ -1728,6 +1728,9 @@ F:	package/libevdev/
 N:	Nicola Di Lieto <[email protected]>
 F:	package/uacme/
 
+N:	Nicolas Carrier <[email protected]>
+F:	package/bmap-tools/
+
 N:	Nicolas Cavallari <[email protected]>
 F:	package/libgit2/
 
package/Config.in +1 -0
index 1ad1d49a8a..52852ac2fc 100644
@@ -184,6 +184,7 @@ menu "Filesystem and flash utilities"
 	source "package/aufs/Config.in"
 	source "package/aufs-util/Config.in"
 	source "package/autofs/Config.in"
+	source "package/bmap-tools/Config.in"
 	source "package/btrfs-progs/Config.in"
 	source "package/cifs-utils/Config.in"
 	source "package/cpio/Config.in"
package/bmap-tools/Config.in new file +15 -0
new file mode 100644
index 0000000000..e582270c44
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_BMAP_TOOLS
+	bool "bmap-tools"
+	depends on BR2_PACKAGE_PYTHON3 || \
+		BR2_PACKAGE_PYTHON
+	select BR2_PACKAGE_PYTHON_SIX # runtime
+	select BR2_PACKAGE_PYTHON_SETUPTOOLS
+	help
+	  Tool to flash image files to block devices using the block map
+	  bmaptool is a generic tool for creating the block map (bmap)
+	  for a file, and copying files using the block map. The idea is
+	  that large file containing unused blocks, like raw system
+	  image files, can be copied or flashed a lot faster with
+	  bmaptool than with traditional tools like "dd" or "cp".
+
+	  https://github.com/intel/bmap-tools
package/bmap-tools/bmap-tools.hash new file +2 -0
new file mode 100644
index 0000000000..794765b633
@@ -0,0 +1,2 @@
+sha256  d410e2d97192d0fc2f88ef160a0bb6ed83fce99da97a606d7f6890cc654ec594  bmap-tools-3.5.tar.gz
+sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
package/bmap-tools/bmap-tools.mk new file +15 -0
new file mode 100644
index 0000000000..4c2465876e
@@ -0,0 +1,15 @@
+################################################################################
+#
+# bmap-tools
+#
+################################################################################
+
+BMAP_TOOLS_VERSION = 3.5
+BMAP_TOOLS_SITE = $(call github,intel,bmap-tools,v$(BMAP_TOOLS_VERSION))
+BMAP_TOOLS_LICENSE = GPL-2.0
+BMAP_TOOLS_LICENSE_FILES = COPYING
+BMAP_TOOLS_SETUP_TYPE = setuptools
+BMAP_TOOLS_DEPENDENCIES = \
+	python-setuptools
+
+$(eval $(python-package))
Signature · 1 line
2.20.1
#1 lore raw

PATCH v4 2/2 support/testing: add bmap_tools test

This patch implements a simple test in which a dummy file system image is created, then bmaptool create and bmaptool copy are used to copy it to another file.

---

Changes v3 -> v4:
- no change

Changes v2 -> v3:
- title changed to "support/testing: add bmap_tools test"
I followed Arnout's suggestion, but if there's a veto on that I can still change...
- added myself in the DEVELOPERS file for both test scripts
- implemented genericity following Thomas' comment, i.e. without ABC, which results in a simpler, cleaner and shorter code (thank you btw ^^)
- fixed all the defects reported by flake8
- increased timeout to 20s

I saw that most of the python tests duplicate code between tests for v2 and v3. I think we should factor that, even if only small portions of code are concerned and, of course, I'm willing to do that if it's considered a good idea.

---

---
 DEVELOPERS                                    |  2 +
 .../tests/package/sample_bmap_tools.sh        | 15 ++++++
 .../testing/tests/package/test_bmap_tools.py  | 47 +++++++++++++++++++
 3 files changed, 64 insertions(+)
 create mode 100755 support/testing/tests/package/sample_bmap_tools.sh
 create mode 100644 support/testing/tests/package/test_bmap_tools.py
DEVELOPERS +2 -0
index 947722a8c7..5a8888ab90 100644
@@ -1730,6 +1730,8 @@ F:	package/uacme/
 
 N:	Nicolas Carrier <[email protected]>
 F:	package/bmap-tools/
+F:	support/testing/tests/package/sample_bmap_tools.sh
+F:	support/testing/tests/package/test_bmap_tools.py
 
 N:	Nicolas Cavallari <[email protected]>
 F:	package/libgit2/
support/testing/tests/package/sample_bmap_tools.sh new file +15 -0
new file mode 100755
index 0000000000..7c90368c17
@@ -0,0 +1,15 @@
+#!/bin/sh
+# simple test which creates a dummy file system image, then use bmaptool create
+# and bmaptool copy to copy it to another file
+
+set -xeu
+
+# create the necessary test files
+dd if=/dev/zero of=disk.img bs=2M count=1
+mkfs.ext4 disk.img
+fallocate -d disk.img
+dd if=/dev/zero of=copy.img bs=2M count=1
+
+# do a test copy of the file system image
+bmaptool create -o disk.img.bmap disk.img
+bmaptool copy disk.img copy.img
support/testing/tests/package/test_bmap_tools.py new file +47 -0

47 lines not on this page · raw message

Signature · 1 line
2.20.1
#2 lore raw

PATCH v4 2/2 support/testing: add bmap_tools test

Le 05/11/2019 ? 13:51, Nicolas Carrier a ?crit?:

Quoted 58 lines

This patch implements a simple test in which a dummy file system image is created, then bmaptool create and bmaptool copy are used to copy it to another file.

---

Changes v3 -> v4:
- no change

Changes v2 -> v3:
- title changed to "support/testing: add bmap_tools test"
I followed Arnout's suggestion, but if there's a veto on that I can still change...
- added myself in the DEVELOPERS file for both test scripts
- implemented genericity following Thomas' comment, i.e. without ABC, which results in a simpler, cleaner and shorter code (thank you btw ^^)
- fixed all the defects reported by flake8
- increased timeout to 20s

I saw that most of the python tests duplicate code between tests for v2 and v3. I think we should factor that, even if only small portions of code are concerned and, of course, I'm willing to do that if it's considered a good idea.

---

---
 DEVELOPERS                                    |  2 +
 .../tests/package/sample_bmap_tools.sh        | 15 ++++++
 .../testing/tests/package/test_bmap_tools.py  | 47 +++++++++++++++++++
 3 files changed, 64 insertions(+)
 create mode 100755 support/testing/tests/package/sample_bmap_tools.sh
 create mode 100644 support/testing/tests/package/test_bmap_tools.py
DEVELOPERS +2 -0
index 947722a8c7..5a8888ab90 100644
@@ -1730,6 +1730,8 @@ F:	package/uacme/
 
 N:	Nicolas Carrier <[email protected]>
 F:	package/bmap-tools/
+F:	support/testing/tests/package/sample_bmap_tools.sh
+F:	support/testing/tests/package/test_bmap_tools.py
 
 N:	Nicolas Cavallari <[email protected]>
 F:	package/libgit2/
support/testing/tests/package/sample_bmap_tools.sh new file +5 -0
new file mode 100755
index 0000000000..7c90368c17
@@ -0,0 +1,15 @@
+#!/bin/sh
+# simple test which creates a dummy file system image, then use bmaptool create
+# and bmaptool copy to copy it to another file
+
+set -xeu

support/testing/tests/package/sample_bmap_tools.sh line 15

Quoted 10 lines
support/testing/tests/package/sample_bmap_tools.sh new file +10 -0
+
+# create the necessary test files
+dd if=/dev/zero of=disk.img bs=2M count=1
+mkfs.ext4 disk.img
+fallocate -d disk.img
+dd if=/dev/zero of=copy.img bs=2M count=1
+
+# do a test copy of the file system image
+bmaptool create -o disk.img.bmap disk.img
+bmaptool copy disk.img copy.img

bmaptool is able to use pbzip2, bzip2,
gzip, pigz, xz, lzop, lz4, tar and unzip system programs for decompressing.

Maybe we can extend the test using different compressed file format.

Note: bmaptool can use ssh program for remote file transfers.

Best regards,
Romain

Quoted 54 lines
support/testing/tests/package/test_bmap_tools.py new file +47 -0
new file mode 100644
index 0000000000..7ea4057aba
@@ -0,0 +1,47 @@
+import os
+import infra
+
+from infra.basetest import BRTest
+
+
+class TestBmapTools(BRTest):
+    __test__ = False
+    sample_script = "tests/package/sample_bmap_tools.sh"
+    copy_script = 'tests/package/copy-sample-script-to-target.sh'
+    config = f'''
+        {infra.basetest.BASIC_TOOLCHAIN_CONFIG}
+        BR2_TARGET_ROOTFS_CPIO=y
+        BR2_PACKAGE_BMAP_TOOLS=y
+        BR2_ROOTFS_POST_BUILD_SCRIPT="{infra.filepath(copy_script)}"
+        BR2_ROOTFS_POST_SCRIPT_ARGS="{infra.filepath(sample_script)}"
+        # BR2_TARGET_ROOTFS_TAR is not set
+        BR2_PACKAGE_UTIL_LINUX=y
+        BR2_PACKAGE_UTIL_LINUX_FALLOCATE=y
+        BR2_PACKAGE_E2FSPROGS=y
+        BR2_PACKAGE_UTIL_LINUX_LIBUUID=y
+        '''
+
+    def login(self):
+        cpio_file = os.path.join(self.builddir, "images", "rootfs.cpio")
+        self.emulator.boot(arch="armv5",
+                           kernel="builtin",
+                           options=["-initrd", cpio_file])
+        self.emulator.login()
+
+    def test_run(self):
+        self.login()
+        cmd = f"/root/{os.path.basename(self.sample_script)}"
+        _, exit_code = self.emulator.run(cmd, timeout=20)
+        self.assertEqual(exit_code, 0)
+
+
+class TestPy2BmapTools(TestBmapTools):
+    __test__ = True
+    config = f"""{TestBmapTools.config}
+    BR2_PACKAGE_PYTHON=y"""
+
+
+class TestPy3BmapTools(TestBmapTools):
+    __test__ = True
+    config = f"""{TestBmapTools.config}
+    BR2_PACKAGE_PYTHON3=y"""
#3 lore raw

PATCH v4 1/2 package/bmap-tools: new package

In reply to Nicolas Carrier

Hi Nicolas,

Le 05/11/2019 ? 13:51, Nicolas Carrier a ?crit?:

Quoted 94 lines

---

I need bmap-tools on the target since it's what our flashing / upgrade procudure uses to speed up the process (flashing ~8GB disk images full of zeroes).

Changes v3 -v4:
- added the upstream URL to the package's help

Changes v2 -> v3:
- double-checked that setuptools is required by bmap-tools at runtime too
- moved the "v" from BMAP_TOOLS_VERSION to BMAP_TOOLS_SITE (in the .hash too)
- changed license name from GPLv2 to GPL-2.0

Changes v1 -> v2:
- no change

---

---
 DEVELOPERS                         |  3 +++
 package/Config.in                  |  1 +
 package/bmap-tools/Config.in       | 15 +++++++++++++++
 package/bmap-tools/bmap-tools.hash |  2 ++
 package/bmap-tools/bmap-tools.mk   | 15 +++++++++++++++
 5 files changed, 36 insertions(+)
 create mode 100644 package/bmap-tools/Config.in
 create mode 100644 package/bmap-tools/bmap-tools.hash
 create mode 100644 package/bmap-tools/bmap-tools.mk
DEVELOPERS +3 -0
index 24c57b25f7..947722a8c7 100644
@@ -1728,6 +1728,9 @@ F:	package/libevdev/
 N:	Nicola Di Lieto <[email protected]>
 F:	package/uacme/
 
+N:	Nicolas Carrier <[email protected]>
+F:	package/bmap-tools/
+
 N:	Nicolas Cavallari <[email protected]>
 F:	package/libgit2/
 
package/Config.in +1 -0
index 1ad1d49a8a..52852ac2fc 100644
@@ -184,6 +184,7 @@ menu "Filesystem and flash utilities"
 	source "package/aufs/Config.in"
 	source "package/aufs-util/Config.in"
 	source "package/autofs/Config.in"
+	source "package/bmap-tools/Config.in"
 	source "package/btrfs-progs/Config.in"
 	source "package/cifs-utils/Config.in"
 	source "package/cpio/Config.in"
package/bmap-tools/Config.in new file +15 -0
new file mode 100644
index 0000000000..e582270c44
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_BMAP_TOOLS
+	bool "bmap-tools"
+	depends on BR2_PACKAGE_PYTHON3 || \
+		BR2_PACKAGE_PYTHON
+	select BR2_PACKAGE_PYTHON_SIX # runtime
+	select BR2_PACKAGE_PYTHON_SETUPTOOLS
+	help
+	  Tool to flash image files to block devices using the block map
+	  bmaptool is a generic tool for creating the block map (bmap)
+	  for a file, and copying files using the block map. The idea is
+	  that large file containing unused blocks, like raw system
+	  image files, can be copied or flashed a lot faster with
+	  bmaptool than with traditional tools like "dd" or "cp".
+
+	  https://github.com/intel/bmap-tools
package/bmap-tools/bmap-tools.hash new file +2 -0
new file mode 100644
index 0000000000..794765b633
@@ -0,0 +1,2 @@
+sha256  d410e2d97192d0fc2f88ef160a0bb6ed83fce99da97a606d7f6890cc654ec594  bmap-tools-3.5.tar.gz
+sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
package/bmap-tools/bmap-tools.mk new file +3 -0
new file mode 100644
index 0000000000..4c2465876e
@@ -0,0 +1,15 @@
+################################################################################
+#
+# bmap-tools

package/bmap-tools/bmap-tools.mk line 13

Quoted 10 lines
package/bmap-tools/bmap-tools.mk new file +10 -0
+#
+################################################################################
+
+BMAP_TOOLS_VERSION = 3.5
+BMAP_TOOLS_SITE = $(call github,intel,bmap-tools,v$(BMAP_TOOLS_VERSION))
+BMAP_TOOLS_LICENSE = GPL-2.0
+BMAP_TOOLS_LICENSE_FILES = COPYING
+BMAP_TOOLS_SETUP_TYPE = setuptools
+BMAP_TOOLS_DEPENDENCIES = \
+	python-setuptools

When you create a new package for a software in Buildroot, it can be useful to check how the software is packaged for other Linux distribution or build tool (Yocto).

For example, Fedora, ArchLinux and Debian

https://github.com/intel/bmap-tools/blob/master/packaging/bmap-tools.spec#L20
https://github.com/intel/bmap-tools/blob/master/debian/control#L13

         python-gpgme,
         ${misc:Depends},
         ${python:Depends},
         bzip2,
         pbzip2,
         gzip,
         pigz,
         lzop,
         liblz4-tool,
         xz-utils,
         tar,
         unzip

Some of theses (maybe optional) dependencies are missing in your patch. Can you check them?

Best regards,
Romain

Quoted 3 lines
package/bmap-tools/bmap-tools.mk new file +2 -0
+
+$(eval $(python-package))
#4 lore raw

PATCH v4 1/2 package/bmap-tools: new package

Le 19/11/2019 ? 21:36, Romain Naour a ?crit?:

Quoted 23 lines

Hi Nicolas,

Le 05/11/2019 ? 13:51, Nicolas Carrier a ?crit?:

Quoted 19 lines

---

I need bmap-tools on the target since it's what our flashing / upgrade procudure uses to speed up the process (flashing ~8GB disk images full of zeroes).

Changes v3 -v4:
- added the upstream URL to the package's help

Changes v2 -> v3:
- double-checked that setuptools is required by bmap-tools at runtime too
- moved the "v" from BMAP_TOOLS_VERSION to BMAP_TOOLS_SITE (in the .hash too)
- changed license name from GPLv2 to GPL-2.0

Changes v1 -> v2:
- no change

---

Your SoB line should be on top of "---" in the commit log. Otherwise it is dropped by git am when the patch is applied.

Quoted 107 lines
Quoted 75 lines
---
 DEVELOPERS                         |  3 +++
 package/Config.in                  |  1 +
 package/bmap-tools/Config.in       | 15 +++++++++++++++
 package/bmap-tools/bmap-tools.hash |  2 ++
 package/bmap-tools/bmap-tools.mk   | 15 +++++++++++++++
 5 files changed, 36 insertions(+)
 create mode 100644 package/bmap-tools/Config.in
 create mode 100644 package/bmap-tools/bmap-tools.hash
 create mode 100644 package/bmap-tools/bmap-tools.mk
DEVELOPERS +3 -0
index 24c57b25f7..947722a8c7 100644
@@ -1728,6 +1728,9 @@ F:	package/libevdev/
 N:	Nicola Di Lieto <[email protected]>
 F:	package/uacme/
 
+N:	Nicolas Carrier <[email protected]>
+F:	package/bmap-tools/
+
 N:	Nicolas Cavallari <[email protected]>
 F:	package/libgit2/
 
package/Config.in +1 -0
index 1ad1d49a8a..52852ac2fc 100644
@@ -184,6 +184,7 @@ menu "Filesystem and flash utilities"
 	source "package/aufs/Config.in"
 	source "package/aufs-util/Config.in"
 	source "package/autofs/Config.in"
+	source "package/bmap-tools/Config.in"
 	source "package/btrfs-progs/Config.in"
 	source "package/cifs-utils/Config.in"
 	source "package/cpio/Config.in"
package/bmap-tools/Config.in new file +15 -0
new file mode 100644
index 0000000000..e582270c44
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_BMAP_TOOLS
+	bool "bmap-tools"
+	depends on BR2_PACKAGE_PYTHON3 || \
+		BR2_PACKAGE_PYTHON
+	select BR2_PACKAGE_PYTHON_SIX # runtime
+	select BR2_PACKAGE_PYTHON_SETUPTOOLS
+	help
+	  Tool to flash image files to block devices using the block map
+	  bmaptool is a generic tool for creating the block map (bmap)
+	  for a file, and copying files using the block map. The idea is
+	  that large file containing unused blocks, like raw system
+	  image files, can be copied or flashed a lot faster with
+	  bmaptool than with traditional tools like "dd" or "cp".
+
+	  https://github.com/intel/bmap-tools
package/bmap-tools/bmap-tools.hash new file +2 -0
new file mode 100644
index 0000000000..794765b633
@@ -0,0 +1,2 @@
+sha256  d410e2d97192d0fc2f88ef160a0bb6ed83fce99da97a606d7f6890cc654ec594  bmap-tools-3.5.tar.gz
+sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
package/bmap-tools/bmap-tools.mk new file +3 -0
new file mode 100644
index 0000000000..4c2465876e
@@ -0,0 +1,15 @@
+################################################################################
+#
+# bmap-tools

package/bmap-tools/bmap-tools.mk line 13

Quoted 10 lines
package/bmap-tools/bmap-tools.mk new file +10 -0
+#
+################################################################################
+
+BMAP_TOOLS_VERSION = 3.5
+BMAP_TOOLS_SITE = $(call github,intel,bmap-tools,v$(BMAP_TOOLS_VERSION))
+BMAP_TOOLS_LICENSE = GPL-2.0
+BMAP_TOOLS_LICENSE_FILES = COPYING
+BMAP_TOOLS_SETUP_TYPE = setuptools
+BMAP_TOOLS_DEPENDENCIES = \
+	python-setuptools

When you create a new package for a software in Buildroot, it can be useful to check how the software is packaged for other Linux distribution or build tool (Yocto).

For example, Fedora, ArchLinux and Debian

https://github.com/intel/bmap-tools/blob/master/packaging/bmap-tools.spec#L20
https://github.com/intel/bmap-tools/blob/master/debian/control#L13

         python-gpgme,
         ${misc:Depends},
         ${python:Depends},
         bzip2,
         pbzip2,
         gzip,
         pigz,
         lzop,
         liblz4-tool,
         xz-utils,
         tar,
         unzip
Quoted 2 lines

Some of theses (maybe optional) dependencies are missing in your patch. Can you check them?

When python2 is used, BR2_PACKAGE_PYTHON_HASHLIB should be selected [1] (to be checked but I'm not sure it's worth the effort to test python2 case, maybe you can make this package python3 only)

[1] https://github.com/intel/bmap-tools/blob/master/bmaptools/BmapCopy.py#L62

For others dependencies, bmaptool is testing several command at runtime (ssh, pigz, pbzip2) but it can use an alternative tool for some of them. (grep for program_is_available in the code)

- ssh command is required for remote access.
- pbzip2 command can be replaced by bzip2 but in the system used for testing bzip2 is not installed.
- tar is used as archiver but it can be use with options that is not available from the busybox version.

Here is the output of tar --help from busybox:
Create, extract, or list files from a tar file

c Create
x Extract
t List
-f FILE Name of TARFILE ('-' for stdin/out)
-C DIR Change to DIR before operation
-v Verbose
-O Extract to stdout
-o Don't restore user:group
-k Don't replace existing files
-h Follow symlinks
-T FILE File with names to include
-X FILE File with glob patterns to exclude
--exclude PATTERN Glob pattern to exclude

By looking at the code [1] bmaptool is expecting the complete version of tar command. The one that provide -z option.

Note: you can also add -z option for busybox tar but it require to enable it from the busybox configuration.

There are other such unsupported options. I would suggest to select the tar package (don't forget to add tar's reverse dependencies)

[1] https://github.com/intel/bmap-tools/blob/master/bmaptools/TransRead.py#L336

Best regards,
Romain

Quoted 8 lines

Best regards,
Romain

Quoted 3 lines
package/bmap-tools/bmap-tools.mk new file +2 -0
+
+$(eval $(python-package))
#5 lore raw

PATCH v4 1/2 package/bmap-tools: new package

In reply to Nicolas Carrier

Hello Nicolas,

Quoted 11 lines · On Tue, 5 Nov 2019 12:51:09 +0000 Nicolas Carrier <[email protected]>…

I need bmap-tools on the target since it's what our flashing / upgrade procudure uses to speed up the process (flashing ~8GB disk images full of zeroes).

Changes v3 -v4:
- added the upstream URL to the package's help

Changes v2 -> v3:
- double-checked that setuptools is required by bmap-tools at runtime too
- moved the "v" from BMAP_TOOLS_VERSION to BMAP_TOOLS_SITE (in the .hash too)
- changed license name from GPLv2 to GPL-2.0

Quoted 6 lines

Changes v1 -> v2:
- no change

---

This patch series received some significant review and comments from Romain Naour, but you haven't posted a v5. I've marked the v4 as Changes Requested, which means that if you don't send a v5, we will unfortunately forget about this contribution.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#6 lore raw

PATCH v4 1/2 package/bmap-tools: new package

Hello Thomas,
Thank you very much for the notice, I'll take a look, this patch is starting to get quite old :)

I missed Romain's comments, because the mails for patches I have been working on, are drowned into the rest of the ML's messages. It's really by luck that I noticed this one :)

I'll try to configure some filtering in by email client, but is there some setup option to get only emails for patch series I'm working on? The Ml's volume is way to high for me to follow the pace :/

Quoted 43 lines · Thomas Petazzoni

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

Hello Nicolas,

Quoted 15 lines · On Tue, 5 Nov 2019 12:51:09 +0000 Nicolas Carrier <[email protected]>…

I need bmap-tools on the target since it's what our flashing / upgrade procudure
uses to speed up the process (flashing ~8GB disk images full of zeroes).

Changes v3 -v4:
- added the upstream URL to the package's help

Changes v2 -> v3:
- double-checked that setuptools is required by bmap-tools at
runtime too
- moved the "v" from BMAP_TOOLS_VERSION to BMAP_TOOLS_SITE (in
the .hash too)
- changed license name from GPLv2 to GPL-2.0

Quoted 6 lines

Changes v1 -> v2:
- no change

---

This patch series received some significant review and comments from Romain Naour, but you haven't posted a v5. I've marked the v4 as Changes Requested, which means that if you don't send a v5, we will unfortunately forget about this contribution.

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Signature · 2 lines
Nicolas CARRIER | SW Scrum Master |  
nicolas.carrier at orolia.com
#7 lore raw

PATCH v4 1/2 package/bmap-tools: new package

Hello,

Quoted 10 lines · On Fri, 04 Sep 2020 08:39:58 +0200 Nicolas Carrier…

Thank you very much for the notice, I'll take a look, this patch is starting to get quite old :)

I missed Romain's comments, because the mails for patches I have been working on, are drowned into the rest of the ML's messages. It's really by luck that I noticed this one :)

I'll try to configure some filtering in by email client, but is there some setup option to get only emails for patch series I'm working on? The Ml's volume is way to high for me to follow the pace :/

You're probably not filtering e-mails the correct way. To filter e-mails from the mailing list, you should filter them based on the "List-Id" header.

If you do that, all the mailing list traffic will go to your "buildroot" e-mail folder. But if you're explicitly Cc'ed on an e-mail (which is the case here), you will receive it in your Inbox. This allows to nicely split the "general mailing list traffic" from "the specific things on which your input is needed".

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#8 lore raw

PATCH v4 1/2 package/bmap-tools: new package

Hello,
Thank you Thomas for the nice trick, I'll test that right now :)

Quoted 41 lines · Thomas Petazzoni

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

Hello,

Quoted 8 lines · On Fri, 04 Sep 2020 08:39:58 +0200 Nicolas Carrier…

Thank you very much for the notice, I'll take a look, this patch is starting to get quite old :)

I missed Romain's comments, because the mails for patches I have been
working on, are drowned into the rest of the ML's messages. It's really by luck that I noticed this one :)

Quoted 5 lines

I'll try to configure some filtering in by email client, but is there
some setup option to get only emails for patch series I'm working on?
The Ml's volume is way to high for me to follow the pace :/

You're probably not filtering e-mails the correct way. To filter e-mails from the mailing list, you should filter them based on the "List-Id" header.

If you do that, all the mailing list traffic will go to your "buildroot" e-mail folder. But if you're explicitly Cc'ed on an e- mail
(which is the case here), you will receive it in your Inbox. This allows to nicely split the "general mailing list traffic" from "the specific things on which your input is needed".

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Signature · 2 lines
Nicolas CARRIER | SW Scrum Master |  
nicolas.carrier at orolia.com