Skip to contentSkip to conversation

ixgbevf: remove unused fields from struct ixgbevf_adapter

PATCH In review Yuto Ohnuki 4 participants 6 messages Jul 17, 2025 – Jul 21, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ixgbevf: remove unused fields from struct ixgbevf_adapter

Remove hw_rx_no_dma_resources and eitr_param fields from struct ixgbevf_adapter since these fields are never referenced in the driver.

Note that the interrupt throttle rate is controlled by the rx_itr_setting and tx_itr_setting variables.

This change simplifies the ixgbevf driver by removing unused fields, which improves maintainability.

---
 drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 3 ---
 1 file changed, 3 deletions(-)
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h +0 -3
index 4384e892f967..3a379e6a3a2a 100644
@@ -346,7 +346,6 @@ struct ixgbevf_adapter {
 	int num_rx_queues;
 	struct ixgbevf_ring *rx_ring[MAX_TX_QUEUES]; /* One per active queue */
 	u64 hw_csum_rx_error;
-	u64 hw_rx_no_dma_resources;
 	int num_msix_vectors;
 	u64 alloc_rx_page_failed;
 	u64 alloc_rx_buff_failed;
@@ -363,8 +362,6 @@ struct ixgbevf_adapter {
 	/* structs defined in ixgbe_vf.h */
 	struct ixgbe_hw hw;
 	u16 msg_enable;
-	/* Interrupt Throttle Rate */
-	u32 eitr_param;
 
 	struct ixgbevf_hw_stats stats;
 
Signature · 8 lines
2.47.1




Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284

Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705
Reviewed-by on v1 1/1
#1 lore raw
Quoted 27 lines · Yuto Ohnuki

Remove hw_rx_no_dma_resources and eitr_param fields from struct ixgbevf_adapter since these fields are never referenced in the driver.

Note that the interrupt throttle rate is controlled by the rx_itr_setting and tx_itr_setting variables.

This change simplifies the ixgbevf driver by removing unused fields, which improves maintainability.

---
  drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 3 ---
  1 file changed, 3 deletions(-)
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h +0 -1
index 4384e892f967..3a379e6a3a2a 100644
@@ -346,7 +346,6 @@ struct ixgbevf_adapter {
  	int num_rx_queues;
  	struct ixgbevf_ring *rx_ring[MAX_TX_QUEUES]; /* One per active queue */
  	u64 hw_csum_rx_error;
-	u64 hw_rx_no_dma_resources;
  	int num_msix_vectors;
  	u64 alloc_rx_page_failed;
  	u64 alloc_rx_buff_failed;

drivers/net/ethernet/intel/ixgbevf/ixgbevf.h struct ixgbevf_adapter { · line 367

Quoted 8 lines
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h +0 -2
@@ -363,8 +362,6 @@ struct ixgbevf_adapter {
  	/* structs defined in ixgbe_vf.h */
  	struct ixgbe_hw hw;
  	u16 msg_enable;
-	/* Interrupt Throttle Rate */
-	u32 eitr_param;
 
  	struct ixgbevf_hw_stats stats;
 

Thanks,
Dawid

#2 lore raw
In reply to Yuto Ohnuki
Quoted 19 lines

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Yuto Ohnuki
Sent: Thursday, July 17, 2025 10:46 AM
To: Nguyen, Anthony L <[email protected]>; Kitszel, Przemyslaw <[email protected]>
Cc: Andrew Lunn <[email protected]>; David S . Miller <[email protected]>; Eric Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; intel- [email protected]; [email protected]; linux- [email protected]; Yuto Ohnuki <[email protected]>
Subject: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove unused fields from struct ixgbevf_adapter

Remove hw_rx_no_dma_resources and eitr_param fields from struct ixgbevf_adapter since these fields are never referenced in the driver.

Quoted 7 lines

Note that the interrupt throttle rate is controlled by the rx_itr_setting and tx_itr_setting variables.

This change simplifies the ixgbevf driver by removing unused fields, which improves maintainability.

Can you add 'Fixes:' or 'Cleanup:' tag ?

Alex

Quoted 40 lines
---
 drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 3 ---
 1 file changed, 3 deletions(-)
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h +0 -0
index 4384e892f967..3a379e6a3a2a 100644
@@ -346,7 +346,6 @@ struct ixgbevf_adapter {
 	int num_rx_queues;
 	struct ixgbevf_ring *rx_ring[MAX_TX_QUEUES]; /* One per active

queue */

drivers/net/ethernet/intel/ixgbevf/ixgbevf.h +0 -4
 	u64 hw_csum_rx_error;
-	u64 hw_rx_no_dma_resources;
 	int num_msix_vectors;
 	u64 alloc_rx_page_failed;
 	u64 alloc_rx_buff_failed;
@@ -363,8 +362,6 @@ struct ixgbevf_adapter {
 	/* structs defined in ixgbe_vf.h */
 	struct ixgbe_hw hw;
 	u16 msg_enable;
-	/* Interrupt Throttle Rate */
-	u32 eitr_param;
 
 	struct ixgbevf_hw_stats stats;
 
--

2.47.1

Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284

Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705

maintainer
#3 lore raw
Quoted 19 lines · Aleksandr
Quoted 19 lines

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Yuto Ohnuki
Sent: Thursday, July 17, 2025 10:46 AM
To: Nguyen, Anthony L <[email protected]>; Kitszel, Przemyslaw <[email protected]>
Cc: Andrew Lunn <[email protected]>; David S . Miller <[email protected]>; Eric Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; intel- [email protected]; [email protected]; linux- [email protected]; Yuto Ohnuki <[email protected]>
Subject: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove unused fields from struct ixgbevf_adapter

Remove hw_rx_no_dma_resources and eitr_param fields from struct ixgbevf_adapter since these fields are never referenced in the driver.

Quoted 8 lines
Quoted 7 lines

Note that the interrupt throttle rate is controlled by the rx_itr_setting and tx_itr_setting variables.

This change simplifies the ixgbevf driver by removing unused fields, which improves maintainability.

Can you add 'Fixes:' or 'Cleanup:' tag ?

As there's no user bug, I don't believe this warrants a Fixes: tag.

I'm not familiar with a Cleanup: tag; on quick browse of git log, I'm not seeing one being used(?)

Thanks,
Tony

Quoted 43 lines

Alex

Quoted 40 lines
---
  drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 3 ---
  1 file changed, 3 deletions(-)
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h +0 -0
index 4384e892f967..3a379e6a3a2a 100644
@@ -346,7 +346,6 @@ struct ixgbevf_adapter {
  	int num_rx_queues;
  	struct ixgbevf_ring *rx_ring[MAX_TX_QUEUES]; /* One per active

queue */
u64 hw_csum_rx_error;

drivers/net/ethernet/intel/ixgbevf/ixgbevf.h +0 -4
-	u64 hw_rx_no_dma_resources;
  	int num_msix_vectors;
  	u64 alloc_rx_page_failed;
  	u64 alloc_rx_buff_failed;
@@ -363,8 +362,6 @@ struct ixgbevf_adapter {
  	/* structs defined in ixgbe_vf.h */
  	struct ixgbe_hw hw;
  	u16 msg_enable;
-	/* Interrupt Throttle Rate */
-	u32 eitr_param;
 
  	struct ixgbevf_hw_stats stats;
 
--

2.47.1

Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284

Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705

#4 lore raw
Quoted 51 lines

-----Original Message-----
From: Nguyen, Anthony L <[email protected]>
Sent: Thursday, July 17, 2025 10:08 PM
To: Loktionov, Aleksandr <[email protected]>; Yuto Ohnuki <[email protected]>; Kitszel, Przemyslaw <[email protected]>
Cc: Andrew Lunn <[email protected]>; David S . Miller <[email protected]>; Eric Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; intel- [email protected]; [email protected]; linux- [email protected]
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove unused fields from struct ixgbevf_adapter

Quoted 4 lines · Aleksandr
Quoted 4 lines

-----Original Message-----
From: Intel-wired-lan <[email protected]> On

Behalf

Quoted 10 lines
Quoted 10 lines

Of Yuto Ohnuki
Sent: Thursday, July 17, 2025 10:46 AM
To: Nguyen, Anthony L <[email protected]>; Kitszel, Przemyslaw <[email protected]>
Cc: Andrew Lunn <[email protected]>; David S . Miller <[email protected]>; Eric Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; intel- [email protected]; [email protected]; linux- [email protected]; Yuto Ohnuki <[email protected]>
Subject: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove

unused

Quoted 4 lines
Quoted 4 lines

fields from struct ixgbevf_adapter

Remove hw_rx_no_dma_resources and eitr_param fields from struct ixgbevf_adapter since these fields are never referenced in the

driver.

Quoted 5 lines
Quoted 5 lines

Note that the interrupt throttle rate is controlled by the rx_itr_setting and tx_itr_setting variables.

This change simplifies the ixgbevf driver by removing unused

fields,

Quoted 4 lines
Quoted 3 lines

which improves maintainability.

Can you add 'Fixes:' or 'Cleanup:' tag ?

Quoted 8 lines

As there's no user bug, I don't believe this warrants a Fixes: tag.

I'm not familiar with a Cleanup: tag; on quick browse of git log, I'm not seeing one being used(?)

Thanks,
Tony

Good day, Tony
Examples of the tag could be get: git log --grep="^Cleanup:" --oneline
ff9fb2e Merge tag 'samsung-soc-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux into arm/soc 15b5b76 Merge tag 'samsung-soc-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux into arm/drivers 566d336 mm: warn on deleting redirtied only if accounted
35189b8 kernel/acct.c: use #elif instead of #end and #elif
0bbe4ce iommu/amd: Fix the overwritten field in IVMD header
521ec1c Merge tag 'renesas-dt-bindings-for-v4.18' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt 878e917 Merge tag 'renesas-dt2-for-v4.13' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt c3acc32 Merge tag 'renesas-arm64-dt2-for-v4.12' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt64 8855e14 Merge tag 'renesas-dt-for-v4.12' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt 5344df6 Merge tag 'renesas-arm64-dt-for-v4.12' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt64 837a90e netfilter: ipset: Regroup ip_set_put_extensions and add extern
...

Quoted 44 lines
Quoted 35 lines

Alex

Quoted 33 lines
---
  drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 3 ---
  1 file changed, 3 deletions(-)
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h +0 -0
index 4384e892f967..3a379e6a3a2a 100644
@@ -346,7 +346,6 @@ struct ixgbevf_adapter {
  	int num_rx_queues;
  	struct ixgbevf_ring *rx_ring[MAX_TX_QUEUES]; /* One per active

queue */
u64 hw_csum_rx_error;

drivers/net/ethernet/intel/ixgbevf/ixgbevf.h +0 -4
-	u64 hw_rx_no_dma_resources;
  	int num_msix_vectors;
  	u64 alloc_rx_page_failed;
  	u64 alloc_rx_buff_failed;
@@ -363,8 +362,6 @@ struct ixgbevf_adapter {
  	/* structs defined in ixgbe_vf.h */
  	struct ixgbe_hw hw;
  	u16 msg_enable;
-	/* Interrupt Throttle Rate */
-	u32 eitr_param;
 
  	struct ixgbevf_hw_stats stats;
 
--

2.47.1

Quoted 5 lines
Quoted 5 lines

Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284

Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number

908705

Quoted 3 lines
Quoted 2 lines
maintainer
#5 lore raw
Quoted 59 lines · Aleksandr
Quoted 51 lines

-----Original Message-----
From: Nguyen, Anthony L <[email protected]>
Sent: Thursday, July 17, 2025 10:08 PM
To: Loktionov, Aleksandr <[email protected]>; Yuto Ohnuki <[email protected]>; Kitszel, Przemyslaw <[email protected]>
Cc: Andrew Lunn <[email protected]>; David S . Miller <[email protected]>; Eric Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; intel- [email protected]; [email protected]; linux- [email protected]
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove unused fields from struct ixgbevf_adapter

Quoted 4 lines · Aleksandr
Quoted 4 lines

-----Original Message-----
From: Intel-wired-lan <[email protected]> On

Behalf

Quoted 10 lines
Quoted 10 lines

Of Yuto Ohnuki
Sent: Thursday, July 17, 2025 10:46 AM
To: Nguyen, Anthony L <[email protected]>; Kitszel, Przemyslaw <[email protected]>
Cc: Andrew Lunn <[email protected]>; David S . Miller <[email protected]>; Eric Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; intel- [email protected]; [email protected]; linux- [email protected]; Yuto Ohnuki <[email protected]>
Subject: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove

unused

Quoted 4 lines
Quoted 4 lines

fields from struct ixgbevf_adapter

Remove hw_rx_no_dma_resources and eitr_param fields from struct ixgbevf_adapter since these fields are never referenced in the

driver.

Quoted 5 lines
Quoted 5 lines

Note that the interrupt throttle rate is controlled by the rx_itr_setting and tx_itr_setting variables.

This change simplifies the ixgbevf driver by removing unused

fields,

Quoted 4 lines
Quoted 3 lines

which improves maintainability.

Can you add 'Fixes:' or 'Cleanup:' tag ?

Quoted 8 lines

As there's no user bug, I don't believe this warrants a Fixes: tag.

I'm not familiar with a Cleanup: tag; on quick browse of git log, I'm not seeing one being used(?)

Thanks,
Tony

Quoted 14 lines

Good day, Tony
Examples of the tag could be get: git log --grep="^Cleanup:" --oneline
ff9fb2e Merge tag 'samsung-soc-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux into arm/soc 15b5b76 Merge tag 'samsung-soc-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux into arm/drivers 566d336 mm: warn on deleting redirtied only if accounted
35189b8 kernel/acct.c: use #elif instead of #end and #elif
0bbe4ce iommu/amd: Fix the overwritten field in IVMD header
521ec1c Merge tag 'renesas-dt-bindings-for-v4.18' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt 878e917 Merge tag 'renesas-dt2-for-v4.13' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt c3acc32 Merge tag 'renesas-arm64-dt2-for-v4.12' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt64 8855e14 Merge tag 'renesas-dt-for-v4.12' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt 5344df6 Merge tag 'renesas-arm64-dt-for-v4.12' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt64 837a90e netfilter: ipset: Regroup ip_set_put_extensions and add extern
...

From what I saw all the 'Merge tags' are using this as part of the pull request to categorize the 'Cleanup:' patches. The other patches are using this line in the commit message to explain the cleanup that is being done. I'm not opposed to the latter, but it seems the commit message gives a reasonable explanation already and I don't think it's worth respinning this to repeat, or reformat, what's already there.

Thanks,
Tony