Skip to contentSkip to conversation

virtio_input: Initialize multi-touch slots on ABS_MT_SLOT

PATCH In review Rudolf Streif 2 participants 3 messages Jan 2, 2020 – Apr 28, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio_input: Initialize multi-touch slots on ABS_MT_SLOT

For multi-touch devices the frontend needs to initialize the correct number of slots for touch tracking. Hardware drivers do this by calling input_mt_init_slots() on initialization. For virtio_input the function must be called when the backend sends ABS_MT_SLOT.

---
 drivers/virtio/virtio_input.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/virtio/virtio_input.c +4 -0
index 5ae529671b3d..582ba808b955 100644
@@ -3,6 +3,7 @@
 #include <linux/virtio.h>
 #include <linux/virtio_config.h>
 #include <linux/input.h>
+#include <linux/input/mt.h>
 
 #include <uapi/linux/virtio_ids.h>
 #include <uapi/linux/virtio_input.h>
@@ -164,6 +165,9 @@ static void virtinput_cfg_abs(struct virtio_input *vi, int abs)
        virtio_cread(vi->vdev, struct virtio_input_config, u.abs.flat, &fl);
        input_set_abs_params(vi->idev, abs, mi, ma, fu, fl);
        input_abs_set_res(vi->idev, abs, re);
+
+       if (abs == ABS_MT_SLOT)
+               input_mt_init_slots(vi->idev, ma + 1, INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED);
 }
 
 static int virtinput_init_vqs(struct virtio_input *vi)

--
2.17.1

----------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

#1 lore raw

Resubmit. Thank you.

________________________________
From: Virtualization <[email protected]> on behalf of Rudolf Streif <[email protected]>
Sent: Thursday, January 2, 2020 11:12 AM
To: [email protected]
Cc: [email protected]
Subject: [PATCH] virtio_input: Initialize multi-touch slots on ABS_MT_SLOT

For multi-touch devices the frontend needs to initialize the correct number of slots for touch tracking. Hardware drivers do this by calling input_mt_init_slots() on initialization. For virtio_input the function must be called when the backend sends ABS_MT_SLOT.

---
 drivers/virtio/virtio_input.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/virtio/virtio_input.c +4 -0
index 5ae529671b3d..582ba808b955 100644
@@ -3,6 +3,7 @@
 #include <linux/virtio.h>
 #include <linux/virtio_config.h>
 #include <linux/input.h>
+#include <linux/input/mt.h>
 
 #include <uapi/linux/virtio_ids.h>
 #include <uapi/linux/virtio_input.h>
@@ -164,6 +165,9 @@ static void virtinput_cfg_abs(struct virtio_input *vi, int abs)
        virtio_cread(vi->vdev, struct virtio_input_config, u.abs.flat, &fl);
        input_set_abs_params(vi->idev, abs, mi, ma, fu, fl);
        input_abs_set_res(vi->idev, abs, re);
+
+       if (abs == ABS_MT_SLOT)
+               input_mt_init_slots(vi->idev, ma + 1, INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED);
 }
 
 static int virtinput_init_vqs(struct virtio_input *vi)

--
2.17.1

________________________________
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

----------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

maintainer Reviewed-by
#2 lore raw
Quoted 1 line · Rudolf Streif

Resubmit. Thank you.

Better re-send with "git send-email" as new message. As reply in an existing thread it gets lost easily.

Quoted 31 lines

________________________________
From: Virtualization <[email protected]> on behalf of Rudolf Streif <[email protected]>
Sent: Thursday, January 2, 2020 11:12 AM
To: [email protected]
Cc: [email protected]
Subject: [PATCH] virtio_input: Initialize multi-touch slots on ABS_MT_SLOT

For multi-touch devices the frontend needs to initialize the correct number of slots for touch tracking. Hardware drivers do this by calling input_mt_init_slots() on initialization. For virtio_input the function must be called when the backend sends ABS_MT_SLOT.

---
 drivers/virtio/virtio_input.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/virtio/virtio_input.c +1 -0
index 5ae529671b3d..582ba808b955 100644
@@ -3,6 +3,7 @@
 #include <linux/virtio.h>
 #include <linux/virtio_config.h>
 #include <linux/input.h>
+#include <linux/input/mt.h>
 
 #include <uapi/linux/virtio_ids.h>
 #include <uapi/linux/virtio_input.h>

drivers/virtio/virtio_input.c static void virtinput_cfg_abs(struct virtio_input *vi, int abs) · line 170

Quoted 6 lines
drivers/virtio/virtio_input.c +3 -0
@@ -164,6 +165,9 @@ static void virtinput_cfg_abs(struct virtio_input *vi, int abs)
        virtio_cread(vi->vdev, struct virtio_input_config, u.abs.flat, &fl);
        input_set_abs_params(vi->idev, abs, mi, ma, fu, fl);
        input_abs_set_res(vi->idev, abs, re);
+
+       if (abs == ABS_MT_SLOT)
+               input_mt_init_slots(vi->idev, ma + 1, INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED);

mst, can you pick it up?

thanks,
Gerd