Skip to contentSkip to conversation

python3-can: Update runtime dependencies

PATCH In review Frieder Schrempf 3 participants 3 messages Aug 17, 2023 – Aug 22, 2023

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 python3-can: Update runtime dependencies

From: Frieder Schrempf <[email protected]>

According to the setup.py of v4.2.2 [1] the following runtime dependencies are currently missing. Add them.

* packaging
* setuptools

Also the aenum dependency was droppen in v4.0.0 [2], so let's remove it.

[1] https://github.com/hardbyte/python-can/blob/4.2.2/setup.py
[2] https://github.com/hardbyte/python-can/commit/13625ea2cc18e3283b8111bec7e139ed9b6c7f48

---
Changes in v2:
* Drop unused aenum dependency
* Update subject and commit message

---
 meta-python/recipes-devtools/python/python3-can_4.2.2.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-python/recipes-devtools/python/python3-can_4.2.2.bb +2 -1
index 7ecbf1207..32b5ad101 100644
@@ -10,7 +10,6 @@ PYPI_PACKAGE="python-can"
 inherit pypi setuptools3
 
 RDEPENDS:${PN} += " \
-    python3-aenum \
     python3-asyncio \
     python3-codecs \
     python3-compression \
@@ -20,7 +19,9 @@ RDEPENDS:${PN} += " \
     python3-logging \
     python3-misc \
     python3-netserver \
+    python3-packaging \
     python3-pkg-resources \
+    python3-setuptools \
     python3-sqlite3 \
     python3-typing-extensions \
     python3-wrapt \
Signature · 1 line
2.41.0
#1 lore raw

Hi Khem,

Quoted 14 lines · Frieder Schrempf

From: Frieder Schrempf <[email protected]>

According to the setup.py of v4.2.2 [1] the following runtime dependencies are currently missing. Add them.

* packaging
* setuptools

Also the aenum dependency was droppen in v4.0.0 [2], so let's remove it.

[1] https://github.com/hardbyte/python-can/blob/4.2.2/setup.py
[2] https://github.com/hardbyte/python-can/commit/13625ea2cc18e3283b8111bec7e139ed9b6c7f48

Quoted 6 lines

---
Changes in v2:
* Drop unused aenum dependency
* Update subject and commit message
---

I've sent this v2 a few minutes after the v1, but I see v1 was applied on master-next. It's not a big deal but I still want to ask if there is anything I can improve to avoid this in the future?

Thanks
Frieder

#2 lore raw
Quoted 25 lines · Frieder Schrempf

Hi Khem,

Quoted 14 lines · Frieder Schrempf

From: Frieder Schrempf <[email protected]>

According to the setup.py of v4.2.2 [1] the following runtime dependencies are currently missing. Add them.

* packaging
* setuptools

Also the aenum dependency was droppen in v4.0.0 [2], so let's remove it.

[1] https://github.com/hardbyte/python-can/blob/4.2.2/setup.py
[2] https://github.com/hardbyte/python-can/commit/13625ea2cc18e3283b8111bec7e139ed9b6c7f48

Quoted 6 lines

---
Changes in v2:
* Drop unused aenum dependency
* Update subject and commit message
---

Quoted 4 lines

I've sent this v2 a few minutes after the v1, but I see v1 was applied on master-next. It's not a big deal but I still want to ask if there is anything I can improve to avoid this in the future?

Usually, I look out for v2 intently if v1 has some issues if I have picked it and it might be timing that I missed it. please send the incremental changes as a separate patch so we can address issues that are still remaining.

Quoted 2 lines

Thanks
Frieder