Skip to contentSkip to conversation

drm/amd/display: Get NV14 specific ip params as needed

PATCH In review Zhan Liu 3 participants 3 messages Nov 26, 2019 – Nov 27, 2019 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

Zhan Liu

author
#0 lore raw

PATCH 1/1 drm/amd/display: Get NV14 specific ip params as needed

[Why]
NV14 is using its own ip params that's different from other DCN2.0 ASICs.

[How]
Add ASIC revision check to make sure NV14 gets correct ip params.

---
 drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c +3 -0
index dbc0a4a7c284..3dd2b2429ae2 100644
@@ -3245,6 +3245,9 @@ static struct _vcs_dpi_soc_bounding_box_st *get_asic_rev_soc_bb(
 static struct _vcs_dpi_ip_params_st *get_asic_rev_ip_params(
 	uint32_t hw_internal_rev)
 {
+	if (ASICREV_IS_NAVI14_M(hw_internal_rev))
+		return &dcn2_0_nv14_ip;
+
 	/* NV12 and NV10 */
 	return &dcn2_0_ip;
 }
Signature · 6 lines
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Zhan Liu <[email protected]>
Sent: Tuesday, November 26, 2019 4:32 PM
To: [email protected] <[email protected]>; Wu, Hersen <[email protected]>; Siqueira, Rodrigo <[email protected]>
Cc: Liu, Zhan <[email protected]>
Subject: [PATCH] drm/amd/display: Get NV14 specific ip params as needed

[Why]
NV14 is using its own ip params that's different from other DCN2.0 ASICs.

[How]
Add ASIC revision check to make sure NV14 gets correct ip params.

---
 drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c +3 -0
index dbc0a4a7c284..3dd2b2429ae2 100644
@@ -3245,6 +3245,9 @@ static struct _vcs_dpi_soc_bounding_box_st *get_asic_rev_soc_bb(
 static struct _vcs_dpi_ip_params_st *get_asic_rev_ip_params(
         uint32_t hw_internal_rev)
 {
+       if (ASICREV_IS_NAVI14_M(hw_internal_rev))
+               return &dcn2_0_nv14_ip;
+
         /* NV12 and NV10 */
         return &dcn2_0_ip;
 }

--
2.17.1

_______________________________________________
amd-gfx mailing list [email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Calexander.deucher%40amd.com%7Cbea3a51cb27f4ad9694e08d772b829b4%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637104007649236121&amp;sdata=p72lWgE%2FB63Exu9JFi7eQ86mk%2FbBB8%2BE5BkBR0SUwqY%3D&amp;reserved=0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by Nicholas Kazlauskas
#3 lore raw
In reply to a message not in the archive
Quoted 9 lines · Zhan Liu

[Why]
NV14 is using its own ip params that's different from other DCN2.0 ASICs.

[How]
Add ASIC revision check to make sure NV14 gets correct ip params.

Quoted 10 lines
---
  drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 3 +++
  1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c +0 -0
index dbc0a4a7c284..3dd2b2429ae2 100644

drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c static struct _vcs_dpi_soc_bounding_box_st *get_asic_rev_soc_bb( · line 3253

Quoted 9 lines
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c +3 -0
@@ -3245,6 +3245,9 @@ static struct _vcs_dpi_soc_bounding_box_st *get_asic_rev_soc_bb(
  static struct _vcs_dpi_ip_params_st *get_asic_rev_ip_params(
  	uint32_t hw_internal_rev)
  {
+	if (ASICREV_IS_NAVI14_M(hw_internal_rev))
+		return &dcn2_0_nv14_ip;
+
  	/* NV12 and NV10 */
  	return &dcn2_0_ip;
  }

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx