wifi: rtw89: use the correct bit in the R_AX_PLE_INI_STATUS register
PATCH 1/1 wifi: rtw89: use the correct bit in the R_AX_PLE_INI_STATUS register
Use the PLE_MGN_INI_RDY bit rather than WDE_MGN_INI_RDY to check if PLE cfg ready runs into a timeout.
---
drivers/net/wireless/realtek/rtw89/mac.c +1 -1
@@ -1814,7 +1814,7 @@ static int dle_init(struct rtw89_dev *rtwdev, enum rtw89_qta_mode mode, } ret =read_poll_timeout (rtw89_read32, ini, - (ini &WDE_MGN_INI_RDY ) ==WDE_MGN_INI_RDY ,1 , + (ini &PLE_MGN_INI_RDY ) ==PLE_MGN_INI_RDY ,1 ,2000 , false, rtwdev,R_AX_PLE_INI_STATUS );if (ret) {rtw89_err (rtwdev,"[ERR]PLE cfg ready\n" );
Quoted 9 lines
-----Original Message-----
From: Kevin Lo <[email protected]>
Sent: Friday, June 9, 2023 3:38 PM
To: Ping-Ke Shih <[email protected]>
Cc: [email protected]
Subject: [PATCH] wifi: rtw89: use the correct bit in theR_AX_PLE_INI_STATUSregister
Quoted 4 lines
Use the
PLE_MGN_INI_RDYbit rather thanWDE_MGN_INI_RDYto check if PLE cfg ready runs into a timeout.Signed-off-by Kevin Lo <[email protected]>
drivers/net/wireless/realtek/rtw89/mac.c static int dle_init(struct rtw89_dev *rtwdev, enum rtw89_qta_mode mode, · line 1817
Quoted 11 lines
---
drivers/net/wireless/realtek/rtw89/mac.c +1
-1@@ -1814,7 +1814,7 @@ static int dle_init(struct rtw89_dev *rtwdev, enum rtw89_qta_mode mode, } ret = read_poll_timeout(rtw89_read32, ini, - (ini & WDE_MGN_INI_RDY) == WDE_MGN_INI_RDY, 1, + (ini & PLE_MGN_INI_RDY) == PLE_MGN_INI_RDY, 1,
Luckily, definitions of WDE_MGN_INI_RDY and PLE_MGN_INI_RDY are the same, so I don't really need to verify it.
Quoted 6 lines
drivers/net/wireless/realtek/rtw89/mac.c +0
-12000, false, rtwdev, R_AX_PLE_INI_STATUS);if (ret) {rtw89_err (rtwdev,"[ERR]PLE cfg ready\n" ); ------Please consider the environment before printing this e-mail.
Quoted 5 lines · Kevin Lo
Use the
PLE_MGN_INI_RDYbit rather thanWDE_MGN_INI_RDYto check if PLE cfg ready runs into a timeout.Signed-off-by Kevin Lo <[email protected]>Acked-by Ping-Ke Shih <[email protected]>
Why? Does this improve anything or is it just a theoretical fix. The commit log should give answers to those.
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches