block: Return the real error code in bdrv_getlength
PATCH 1/1 block: Return the real error code in bdrv_getlength
The return code from bdrv_nb_sectors() should be checked before doing the following sanity check.
Signed-off-by Guoyi Tu <[email protected]>
--- block.c | 4 ++++ 1 file changed, 4 insertions(+)
block.c +4 -0
@@ -5082,6 +5082,10 @@ int64_t bdrv_getlength(BlockDriverState *bs) {int64_t ret =bdrv_nb_sectors (bs); +if (ret <0 ) { +return ret; + } + ret = ret >INT64_MAX /BDRV_SECTOR_SIZE ? -EFBIG : ret;return ret <0 ? ret : ret *BDRV_SECTOR_SIZE ; }
Signature · 6 lines
2.7.4 -- Best regards, Guoyi
Quoted 4 lines · Tuguoyi
The return code from
bdrv_nb_sectors()should be checked before doing the following sanity check.Signed-off-by Guoyi Tu <[email protected]>
It looks like you sent several variations on this patch. A
meta-observation: your mailer is attributing the patch to the spelling "Tuguoyi", while your S-o-b line is spelling "Guoyi Tu". It's worth being consistent between the two.
Signature · 3 lines
Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org