Skip to contentSkip to conversation

uboot-sign: fix concat_dtb arguments

PATCH In review Clayton Casciato 2 participants 4 messages Nov 7, 2024 – Nov 14, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 uboot-sign: fix concat_dtb arguments

Fixes [YOCTO #15642]

Ensure empty argument passed from do_uboot_assemble_fitimage is passed to concat_dtb

---
Sponsor: 21SoftWare LLC

 meta/classes-recipe/uboot-sign.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes-recipe/uboot-sign.bbclass +1 -1
index 3e5f5dcf66..a17be745ce 100644
@@ -338,7 +338,7 @@ uboot_assemble_fitimage_helper() {
 	binary="$2"
 
 	if [ "${UBOOT_SIGN_ENABLE}" = "1" -a -n "${UBOOT_DTB_BINARY}" ] ; then
-		concat_dtb $type $binary
+		concat_dtb "$type" "$binary"
 	fi
 
 	if [ "${UBOOT_FITIMAGE_ENABLE}" = "1" -a -n "${SPL_DTB_BINARY}" ]; then
Signature · 1 line
2.34.1
#1 lore raw

Hello!

I am looking for feedback and/or the status for this patch.

Thanks!

--
Clayton Casciato

Quoted 25 lines · Clayton Casciato

Fixes [YOCTO #15642]

Ensure empty argument passed from do_uboot_assemble_fitimage is passed to concat_dtb

---
Sponsor: 21SoftWare LLC

 meta/classes-recipe/uboot-sign.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes-recipe/uboot-sign.bbclass +1 -1
index 3e5f5dcf66..a17be745ce 100644
@@ -338,7 +338,7 @@ uboot_assemble_fitimage_helper() {
 	binary="$2"
 
 	if [ "${UBOOT_SIGN_ENABLE}" = "1" -a -n "${UBOOT_DTB_BINARY}" ] ; then
-		concat_dtb $type $binary
+		concat_dtb "$type" "$binary"
 	fi
 
 	if [ "${UBOOT_FITIMAGE_ENABLE}" = "1" -a -n "${SPL_DTB_BINARY}" ]; then