ACPI: tables: fixes the missed acpi_put_table() in acpi_init_fpdt()
PATCH 1/1 ACPI: tables: fixes the missed acpi_put_table() in acpi_init_fpdt()
acpi_init_fpdt() misses to call acpi_put_table() in an error path. Add the missed function call to fix it.
--- drivers/acpi/acpi_fpdt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/acpi/acpi_fpdt.c +3 -1
@@ -240,8 +240,10 @@ static int __init acpi_init_fpdt(void)return 0 ; fpdt_kobj =kobject_create_and_add ("fpdt" , acpi_kobj); -if (!fpdt_kobj) +if (!fpdt_kobj) { +acpi_put_table (header);return -ENOMEM ; + }while (offset < header->length) { subtable = (void *)header + offset;
Signature · 1 line
2.26.0.106.g9fadedd
Hi, Xiangfeng,
thanks for the patch.
Quoted 7 lines · Jing Xiangfeng
acpi_init_fpdt()misses to callacpi_put_table()in an error path. Add
the missed function call to fix it.Fixes d1eb86e59be0 ("ACPI: tables: introduce support for FPDTtable")
Signed-off-by Jing Xiangfeng <[email protected]>
thanks,
rui
Quoted 20 lines
--- drivers/acpi/acpi_fpdt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/acpi/acpi_fpdt.c +3
-1@@ -240,8 +240,10 @@ static int __init acpi_init_fpdt(void)return 0 ; fpdt_kobj =kobject_create_and_add ("fpdt" , acpi_kobj); -if (!fpdt_kobj) +if (!fpdt_kobj) { +acpi_put_table (header);return -ENOMEM ; + }while (offset < header->length) { subtable = (void *)header + offset;
The title of this patch is misleading, how about "ACPI: FPDT: Add the missed acpi_put_table() in acpi_init_fpdt()" ?
Quoted 14 lines · Jing Xiangfeng
acpi_init_fpdt()misses to callacpi_put_table()in an error path. Add the missed function call to fix it.Fixes d1eb86e59be0 ("ACPI: tables: introduce support for FPDT table")Signed-off-by Jing Xiangfeng <[email protected]>--- drivers/acpi/acpi_fpdt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/acpi/acpi_fpdt.c +0
-0
drivers/acpi/acpi_fpdt.c static int __init acpi_init_fpdt(void) · line 246
Quoted 8 lines
drivers/acpi/acpi_fpdt.c +3
-1@@ -240,8 +240,10 @@ static int __init acpi_init_fpdt(void)return 0 ; fpdt_kobj =kobject_create_and_add ("fpdt" , acpi_kobj); -if (!fpdt_kobj) +if (!fpdt_kobj) { +acpi_put_table (header);return -ENOMEM ; + }
The code looks good to me.
Thanks
Hanjun
Quoted 2 lines · Hanjun Guo
The title of this patch is misleading, how about "ACPI: FPDT: Add the missed
acpi_put_table()inacpi_init_fpdt()" ?
Thanks a lot for your comments! I'll send a v2 with this change.
Quoted 30 lines · Jing Xiangfeng
Quoted 14 lines
acpi_init_fpdt()misses to callacpi_put_table()in an error path. Add the missed function call to fix it.Fixes d1eb86e59be0 ("ACPI: tables: introduce support for FPDT table")Signed-off-by Jing Xiangfeng <[email protected]>--- drivers/acpi/acpi_fpdt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/acpi/acpi_fpdt.c +0
-0drivers/acpi/acpi_fpdt.c static int __init acpi_init_fpdt(void) · line 245
Quoted 7 lines
drivers/acpi/acpi_fpdt.c +3
-1@@ -240,8 +240,10 @@ static int __init acpi_init_fpdt(void)return 0 ; fpdt_kobj =kobject_create_and_add ("fpdt" , acpi_kobj); -if (!fpdt_kobj) +if (!fpdt_kobj) { +acpi_put_table (header);return -ENOMEM ; + }The code looks good to me.
Thanks
Hanjun
.