Fix CONFIG_HYPERV and vmbus related anamoly
Subsystems (15)
cover Fix CONFIG_HYPERV and vmbus related anamoly
At present, drivers/Makefile will subst =m to =y for CONFIG_HYPERV for hv subdir. Also, drivers/hv/Makefile replaces =m to =y to build in hv_common.c that is needed for the drivers. Moreover, vmbus driver is built if CONFIG_HYPER is set, either loadable or builtin.
This is not a good approach. CONFIG_HYPERV is really an umbrella config that encompasses builtin code and various other things and not a dedicated config option for VMBUS. Vmbus should really have a config option just like CONFIG_HYPERV_BALLOON etc. This small series introduces CONFIG_HYPERV_VMBUS to build VMBUS driver and make that distinction explicit. With that CONFIG_HYPERV could be changed to bool.
For now, hv_common.c is left as is to reduce conflicts for upcoming patches, but once merges are mostly done, that and some others should be moved to virt/hyperv directory.
Mukesh Rathor (2):
hyper-v: Add CONFIG_HYPERV_VMBUS option
hyper-v: Make CONFIG_HYPERV bool
drivers/Makefile | 2 +- drivers/gpu/drm/Kconfig | 2 +- drivers/hid/Kconfig | 2 +- drivers/hv/Kconfig | 14 ++++++++++---- drivers/hv/Makefile | 4 ++-- drivers/input/serio/Kconfig | 4 ++-- drivers/net/hyperv/Kconfig | 2 +- drivers/pci/Kconfig | 2 +- drivers/scsi/Kconfig | 2 +- drivers/uio/Kconfig | 2 +- drivers/video/fbdev/Kconfig | 2 +- include/asm-generic/mshyperv.h | 8 +++++--- net/vmw_vsock/Kconfig | 2 +- 13 files changed, 28 insertions(+), 20 deletions(-)
Signature · 1 line
2.36.1.vfs.0.0
PATCH 1/2 hyper-v: Add CONFIG_HYPERV_VMBUS option
Somehow vmbus driver is hinged on CONFIG_HYPERV. It appears this is initial code that did not get addressed when the scope of CONFIG_HYPERV went beyond vmbus. This commit creates a fine grained HYPERV_VMBUS option and updates drivers that depend on VMBUS.
--- drivers/gpu/drm/Kconfig | 2 +- drivers/hid/Kconfig | 2 +- drivers/hv/Kconfig | 12 +++++++++--- drivers/hv/Makefile | 2 +- drivers/input/serio/Kconfig | 4 ++-- drivers/net/hyperv/Kconfig | 2 +- drivers/pci/Kconfig | 2 +- drivers/scsi/Kconfig | 2 +- drivers/uio/Kconfig | 2 +- drivers/video/fbdev/Kconfig | 2 +- include/asm-generic/mshyperv.h | 8 +++++--- net/vmw_vsock/Kconfig | 2 +- 12 files changed, 25 insertions(+), 17 deletions(-)
drivers/gpu/drm/Kconfig +1 -1
@@ -398,7 +398,7 @@ source "drivers/gpu/drm/imagination/Kconfig" config DRM_HYPERV tristate "DRM Support for Hyper-V synthetic video device" - depends on DRM && PCI && HYPERV + depends on DRM && PCI && HYPERV_VMBUS select DRM_CLIENT_SELECTION select DRM_KMS_HELPER select DRM_GEM_SHMEM_HELPER
drivers/hid/Kconfig +1 -1
@@ -1162,7 +1162,7 @@ config GREENASIA_FF config HID_HYPERV_MOUSE tristate "Microsoft Hyper-V mouse driver" - depends on HYPERV + depends on HYPERV_VMBUS help Select this option to enable the Hyper-V mouse driver.
drivers/hv/Kconfig +9 -3
@@ -44,18 +44,24 @@ config HYPERV_TIMER config HYPERV_UTILS tristate "Microsoft Hyper-V Utilities driver" - depends on HYPERV && CONNECTOR && NLS + depends on HYPERV_VMBUS && CONNECTOR && NLS depends on PTP_1588_CLOCK_OPTIONAL help Select this option to enable the Hyper-V Utilities. config HYPERV_BALLOON tristate "Microsoft Hyper-V Balloon driver" - depends on HYPERV + depends on HYPERV_VMBUS select PAGE_REPORTING help Select this option to enable Hyper-V Balloon driver. +config HYPERV_VMBUS + tristate "Microsoft Hyper-V Vmbus driver" + depends on HYPERV + help + Select this option to enable Hyper-V Vmbus driver. + config MSHV_ROOT tristate "Microsoft Hyper-V root partition support" depends on HYPERV && (X86_64 || ARM64)
@@ -75,7 +81,7 @@ config MSHV_ROOT config MSHV_VTL tristate "Microsoft Hyper-V VTL driver" - depends on X86_64 && HYPERV_VTL_MODE + depends on X86_64 && HYPERV_VTL_MODE && HYPERV_VMBUS # Mapping VTL0 memory to a userspace process in VTL2 is supported in OpenHCL. # VTL2 for OpenHCL makes use of Huge Pages to improve performance on VMs, # specially with large memory requirements.
drivers/hv/Makefile +1 -1
@@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_HYPERV) += hv_vmbus.o +obj-$(CONFIG_HYPERV_VMBUS) += hv_vmbus.o obj-$(CONFIG_HYPERV_UTILS) += hv_utils.o obj-$(CONFIG_HYPERV_BALLOON) += hv_balloon.o obj-$(CONFIG_MSHV_ROOT) += mshv_root.o
drivers/input/serio/Kconfig +2 -2
@@ -276,8 +276,8 @@ config SERIO_OLPC_APSP config HYPERV_KEYBOARD tristate "Microsoft Synthetic Keyboard driver" - depends on HYPERV - default HYPERV + depends on HYPERV_VMBUS + default HYPERV_VMBUS help Select this option to enable the Hyper-V Keyboard driver.
drivers/net/hyperv/Kconfig +1 -1
@@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config HYPERV_NET tristate "Microsoft Hyper-V virtual network driver" - depends on HYPERV + depends on HYPERV_VMBUS select UCS2_STRING select NLS help
drivers/pci/Kconfig +1 -1
@@ -221,7 +221,7 @@ config PCI_LABEL config PCI_HYPERV tristate "Hyper-V PCI Frontend" - depends on ((X86 && X86_64) || ARM64) && HYPERV && PCI_MSI && SYSFS + depends on ((X86 && X86_64) || ARM64) && HYPERV_VMBUS && PCI_MSI && SYSFS select PCI_HYPERV_INTERFACE select IRQ_MSI_LIB help
drivers/scsi/Kconfig +1 -1
@@ -589,7 +589,7 @@ config XEN_SCSI_FRONTEND config HYPERV_STORAGE tristate "Microsoft Hyper-V virtual storage driver" - depends on SCSI && HYPERV + depends on SCSI && HYPERV_VMBUS depends on m || SCSI_FC_ATTRS != m default HYPERV help
drivers/uio/Kconfig +1 -1
@@ -140,7 +140,7 @@ config UIO_MF624 config UIO_HV_GENERIC tristate "Generic driver for Hyper-V VMBus" - depends on HYPERV + depends on HYPERV_VMBUS help Generic driver that you can bind, dynamically, to any Hyper-V VMBus device. It is useful to provide direct access
drivers/video/fbdev/Kconfig +1 -1
@@ -1774,7 +1774,7 @@ config FB_BROADSHEET config FB_HYPERV tristate "Microsoft Hyper-V Synthetic Video support" - depends on FB && HYPERV + depends on FB && HYPERV_VMBUS select DMA_CMA if HAVE_DMA_CONTIGUOUS && CMA select FB_IOMEM_HELPERS_DEFERRED help
include/asm-generic/mshyperv.h +5 -3
@@ -165,6 +165,7 @@ static inline u64 hv_generate_guest_id(u64 kernel_version)void __init hv_mark_resources (void ); +#if IS_ENABLED (CONFIG_HYPERV_VMBUS )/* Free the message slot and signal end-of-message if required */ static inline void vmbus_signal_eom (struct hv_message *msg,u32 old_msg_type) {
@@ -200,6 +201,10 @@ static inline void vmbus_signal_eom(struct hv_message *msg, u32 old_msg_type) } } +extern int vmbus_interrupt; +extern int vmbus_irq; +#endif /* CONFIG_HYPERV_VMBUS */ +int hv_get_hypervisor_version (union hv_hypervisor_version_info *info);void hv_setup_vmbus_handler (void (*handler)(void ));
@@ -213,9 +218,6 @@ void hv_setup_crash_handler(void (*handler)(struct pt_regs *regs));void hv_remove_crash_handler (void );void hv_setup_mshv_handler (void (*handler)(void )); -extern int vmbus_interrupt; -extern int vmbus_irq; -#if IS_ENABLED (CONFIG_HYPERV )/* * Hypervisor's notion of virtual processor ID is different from
net/vmw_vsock/Kconfig +1 -1
@@ -72,7 +72,7 @@ config VIRTIO_VSOCKETS_COMMON config HYPERV_VSOCKETS tristate "Hyper-V transport for Virtual Sockets" - depends on VSOCKETS && HYPERV + depends on VSOCKETS && HYPERV_VMBUS help This module implements a Hyper-V transport for Virtual Sockets.
Signature · 1 line
2.36.1.vfs.0.0
Re: [PATCH V0 1/2] hyper-v: Add CONFIG_HYPERV_VMBUS option
Quoted 5 lines · Mukesh Rathor
Somehow vmbus driver is hinged on
CONFIG_HYPERV. It appears this is initial code that did not get addressed when the scope ofCONFIG_HYPERVwent beyond vmbus. This commit creates a fine grainedHYPERV_VMBUSoption and updates drivers that depend on VMBUS.
The commit message can be improved. The docs are helpful here:
https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
In particular, some clearer reasons for the change.
e.g.
- CONFIG_HYPERV encompasses too much right now. It's not always clear what depends on builtin hyperv code and what depends on vmbus.
- Since there is so much builtin hyperv code, building CONFIG_HYPERV as a module doesn't make intuitive sense. Building vmbus support as a module does.
- There are actually some real scenarios someone may want to compile with CONFIG_HYPERV but without vmbus, like baremetal root partition.
FWIW I think it's a good idea, interested to hear what others think.
Nuno
Quoted 219 lines
Signed-off-by Mukesh Rathor <[email protected]>--- drivers/gpu/drm/Kconfig | 2 +- drivers/hid/Kconfig | 2 +- drivers/hv/Kconfig | 12 +++++++++--- drivers/hv/Makefile | 2 +- drivers/input/serio/Kconfig | 4 ++-- drivers/net/hyperv/Kconfig | 2 +- drivers/pci/Kconfig | 2 +- drivers/scsi/Kconfig | 2 +- drivers/uio/Kconfig | 2 +- drivers/video/fbdev/Kconfig | 2 +- include/asm-generic/mshyperv.h | 8 +++++--- net/vmw_vsock/Kconfig | 2 +- 12 files changed, 25 insertions(+), 17 deletions(-)drivers/gpu/drm/Kconfig +1
-1@@ -398,7 +398,7 @@ source "drivers/gpu/drm/imagination/Kconfig" config DRM_HYPERV tristate "DRM Support for Hyper-V synthetic video device" - depends on DRM && PCI && HYPERV + depends on DRM && PCI && HYPERV_VMBUS select DRM_CLIENT_SELECTION select DRM_KMS_HELPER select DRM_GEM_SHMEM_HELPERdrivers/hid/Kconfig +1
-1@@ -1162,7 +1162,7 @@ config GREENASIA_FF config HID_HYPERV_MOUSE tristate "Microsoft Hyper-V mouse driver" - depends on HYPERV + depends on HYPERV_VMBUS help Select this option to enable the Hyper-V mouse driver.drivers/hv/Kconfig +9
-3@@ -44,18 +44,24 @@ config HYPERV_TIMER config HYPERV_UTILS tristate "Microsoft Hyper-V Utilities driver" - depends on HYPERV && CONNECTOR && NLS + depends on HYPERV_VMBUS && CONNECTOR && NLS depends on PTP_1588_CLOCK_OPTIONAL help Select this option to enable the Hyper-V Utilities. config HYPERV_BALLOON tristate "Microsoft Hyper-V Balloon driver" - depends on HYPERV + depends on HYPERV_VMBUS select PAGE_REPORTING help Select this option to enable Hyper-V Balloon driver. +config HYPERV_VMBUS + tristate "Microsoft Hyper-V Vmbus driver" + depends on HYPERV + help + Select this option to enable Hyper-V Vmbus driver. + config MSHV_ROOT tristate "Microsoft Hyper-V root partition support" depends on HYPERV && (X86_64 || ARM64)@@ -75,7 +81,7 @@ config MSHV_ROOT config MSHV_VTL tristate "Microsoft Hyper-V VTL driver" - depends on X86_64 && HYPERV_VTL_MODE + depends on X86_64 && HYPERV_VTL_MODE && HYPERV_VMBUS # Mapping VTL0 memory to a userspace process in VTL2 is supported in OpenHCL. # VTL2 for OpenHCL makes use of Huge Pages to improve performance on VMs, # specially with large memory requirements.drivers/hv/Makefile +1
-1@@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_HYPERV) += hv_vmbus.o +obj-$(CONFIG_HYPERV_VMBUS) += hv_vmbus.o obj-$(CONFIG_HYPERV_UTILS) += hv_utils.o obj-$(CONFIG_HYPERV_BALLOON) += hv_balloon.o obj-$(CONFIG_MSHV_ROOT) += mshv_root.odrivers/input/serio/Kconfig +2
-2@@ -276,8 +276,8 @@ config SERIO_OLPC_APSP config HYPERV_KEYBOARD tristate "Microsoft Synthetic Keyboard driver" - depends on HYPERV - default HYPERV + depends on HYPERV_VMBUS + default HYPERV_VMBUS help Select this option to enable the Hyper-V Keyboard driver.drivers/net/hyperv/Kconfig +1
-1@@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config HYPERV_NET tristate "Microsoft Hyper-V virtual network driver" - depends on HYPERV + depends on HYPERV_VMBUS select UCS2_STRING select NLS helpdrivers/pci/Kconfig +1
-1@@ -221,7 +221,7 @@ config PCI_LABEL config PCI_HYPERV tristate "Hyper-V PCI Frontend" - depends on ((X86 && X86_64) || ARM64) && HYPERV && PCI_MSI && SYSFS + depends on ((X86 && X86_64) || ARM64) && HYPERV_VMBUS && PCI_MSI && SYSFS select PCI_HYPERV_INTERFACE select IRQ_MSI_LIB helpdrivers/scsi/Kconfig +1
-1@@ -589,7 +589,7 @@ config XEN_SCSI_FRONTEND config HYPERV_STORAGE tristate "Microsoft Hyper-V virtual storage driver" - depends on SCSI && HYPERV + depends on SCSI && HYPERV_VMBUS depends on m || SCSI_FC_ATTRS != m default HYPERV helpdrivers/uio/Kconfig +1
-1@@ -140,7 +140,7 @@ config UIO_MF624 config UIO_HV_GENERIC tristate "Generic driver for Hyper-V VMBus" - depends on HYPERV + depends on HYPERV_VMBUS help Generic driver that you can bind, dynamically, to any Hyper-V VMBus device. It is useful to provide direct accessdrivers/video/fbdev/Kconfig +1
-1@@ -1774,7 +1774,7 @@ config FB_BROADSHEET config FB_HYPERV tristate "Microsoft Hyper-V Synthetic Video support" - depends on FB && HYPERV + depends on FB && HYPERV_VMBUS select DMA_CMA if HAVE_DMA_CONTIGUOUS && CMA select FB_IOMEM_HELPERS_DEFERRED helpinclude/asm-generic/mshyperv.h +5
-3@@ -165,6 +165,7 @@ static inline u64 hv_generate_guest_id(u64 kernel_version)void __init hv_mark_resources (void ); +#if IS_ENABLED (CONFIG_HYPERV_VMBUS )/* Free the message slot and signal end-of-message if required */ static inline void vmbus_signal_eom (struct hv_message *msg,u32 old_msg_type) {@@ -200,6 +201,10 @@ static inline void vmbus_signal_eom(struct hv_message *msg, u32 old_msg_type) } } +extern int vmbus_interrupt; +extern int vmbus_irq; +#endif /* CONFIG_HYPERV_VMBUS */ +int hv_get_hypervisor_version (union hv_hypervisor_version_info *info);void hv_setup_vmbus_handler (void (*handler)(void ));@@ -213,9 +218,6 @@ void hv_setup_crash_handler(void (*handler)(struct pt_regs *regs));void hv_remove_crash_handler (void );void hv_setup_mshv_handler (void (*handler)(void )); -extern int vmbus_interrupt; -extern int vmbus_irq; -#if IS_ENABLED (CONFIG_HYPERV )/* * Hypervisor's notion of virtual processor ID is different from net/vmw_vsock/Kconfig +1
-1@@ -72,7 +72,7 @@ config VIRTIO_VSOCKETS_COMMON config HYPERV_VSOCKETS tristate "Hyper-V transport for Virtual Sockets" - depends on VSOCKETS && HYPERV + depends on VSOCKETS && HYPERV_VMBUS help This module implements a Hyper-V transport for Virtual Sockets.
Re: [PATCH V0 1/2] hyper-v: Add CONFIG_HYPERV_VMBUS option
Quoted 15 lines · Nuno Das Neves
Quoted 5 lines · Mukesh Rathor
Somehow vmbus driver is hinged on
CONFIG_HYPERV. It appears this is initial code that did not get addressed when the scope ofCONFIG_HYPERVwent beyond vmbus. This commit creates a fine grainedHYPERV_VMBUSoption and updates drivers that depend on VMBUS.The commit message can be improved. The docs are helpful here:
https://docs.kernel.org/process/submitting-patches.html#describe-your-changesIn particular, some clearer reasons for the change.
e.g.
-CONFIG_HYPERVencompasses too much right now. It's not always clear what depends on builtin hyperv code and what depends on vmbus.
Quoted 7 lines
- Since there is so much builtin hyperv code, building
CONFIG_HYPERVas a module doesn't make intuitive sense. Building vmbus support as a module does.- There are actually some real scenarios someone may want to compile with
CONFIG_HYPERVbut without vmbus, like baremetal root partition.FWIW I think it's a good idea, interested to hear what others think.
Sorry, you had mentioned it and I expanded the cover letter and forgot the commit message here. You said it better than I could above, so I can just use that in V1 next week if no other comments.
Thanks,
-Mukesh
Quoted 221 lines
Nuno
Quoted 219 lines
Signed-off-by Mukesh Rathor <[email protected]>--- drivers/gpu/drm/Kconfig | 2 +- drivers/hid/Kconfig | 2 +- drivers/hv/Kconfig | 12 +++++++++--- drivers/hv/Makefile | 2 +- drivers/input/serio/Kconfig | 4 ++-- drivers/net/hyperv/Kconfig | 2 +- drivers/pci/Kconfig | 2 +- drivers/scsi/Kconfig | 2 +- drivers/uio/Kconfig | 2 +- drivers/video/fbdev/Kconfig | 2 +- include/asm-generic/mshyperv.h | 8 +++++--- net/vmw_vsock/Kconfig | 2 +- 12 files changed, 25 insertions(+), 17 deletions(-)drivers/gpu/drm/Kconfig +1
-1@@ -398,7 +398,7 @@ source "drivers/gpu/drm/imagination/Kconfig" config DRM_HYPERV tristate "DRM Support for Hyper-V synthetic video device" - depends on DRM && PCI && HYPERV + depends on DRM && PCI && HYPERV_VMBUS select DRM_CLIENT_SELECTION select DRM_KMS_HELPER select DRM_GEM_SHMEM_HELPERdrivers/hid/Kconfig +1
-1@@ -1162,7 +1162,7 @@ config GREENASIA_FF config HID_HYPERV_MOUSE tristate "Microsoft Hyper-V mouse driver" - depends on HYPERV + depends on HYPERV_VMBUS help Select this option to enable the Hyper-V mouse driver.drivers/hv/Kconfig +9
-3@@ -44,18 +44,24 @@ config HYPERV_TIMER config HYPERV_UTILS tristate "Microsoft Hyper-V Utilities driver" - depends on HYPERV && CONNECTOR && NLS + depends on HYPERV_VMBUS && CONNECTOR && NLS depends on PTP_1588_CLOCK_OPTIONAL help Select this option to enable the Hyper-V Utilities. config HYPERV_BALLOON tristate "Microsoft Hyper-V Balloon driver" - depends on HYPERV + depends on HYPERV_VMBUS select PAGE_REPORTING help Select this option to enable Hyper-V Balloon driver. +config HYPERV_VMBUS + tristate "Microsoft Hyper-V Vmbus driver" + depends on HYPERV + help + Select this option to enable Hyper-V Vmbus driver. + config MSHV_ROOT tristate "Microsoft Hyper-V root partition support" depends on HYPERV && (X86_64 || ARM64)@@ -75,7 +81,7 @@ config MSHV_ROOT config MSHV_VTL tristate "Microsoft Hyper-V VTL driver" - depends on X86_64 && HYPERV_VTL_MODE + depends on X86_64 && HYPERV_VTL_MODE && HYPERV_VMBUS # Mapping VTL0 memory to a userspace process in VTL2 is supported in OpenHCL. # VTL2 for OpenHCL makes use of Huge Pages to improve performance on VMs, # specially with large memory requirements.drivers/hv/Makefile +1
-1@@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_HYPERV) += hv_vmbus.o +obj-$(CONFIG_HYPERV_VMBUS) += hv_vmbus.o obj-$(CONFIG_HYPERV_UTILS) += hv_utils.o obj-$(CONFIG_HYPERV_BALLOON) += hv_balloon.o obj-$(CONFIG_MSHV_ROOT) += mshv_root.odrivers/input/serio/Kconfig +2
-2@@ -276,8 +276,8 @@ config SERIO_OLPC_APSP config HYPERV_KEYBOARD tristate "Microsoft Synthetic Keyboard driver" - depends on HYPERV - default HYPERV + depends on HYPERV_VMBUS + default HYPERV_VMBUS help Select this option to enable the Hyper-V Keyboard driver.drivers/net/hyperv/Kconfig +1
-1@@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config HYPERV_NET tristate "Microsoft Hyper-V virtual network driver" - depends on HYPERV + depends on HYPERV_VMBUS select UCS2_STRING select NLS helpdrivers/pci/Kconfig +1
-1@@ -221,7 +221,7 @@ config PCI_LABEL config PCI_HYPERV tristate "Hyper-V PCI Frontend" - depends on ((X86 && X86_64) || ARM64) && HYPERV && PCI_MSI && SYSFS + depends on ((X86 && X86_64) || ARM64) && HYPERV_VMBUS && PCI_MSI && SYSFS select PCI_HYPERV_INTERFACE select IRQ_MSI_LIB helpdrivers/scsi/Kconfig +1
-1@@ -589,7 +589,7 @@ config XEN_SCSI_FRONTEND config HYPERV_STORAGE tristate "Microsoft Hyper-V virtual storage driver" - depends on SCSI && HYPERV + depends on SCSI && HYPERV_VMBUS depends on m || SCSI_FC_ATTRS != m default HYPERV helpdrivers/uio/Kconfig +1
-1@@ -140,7 +140,7 @@ config UIO_MF624 config UIO_HV_GENERIC tristate "Generic driver for Hyper-V VMBus" - depends on HYPERV + depends on HYPERV_VMBUS help Generic driver that you can bind, dynamically, to any Hyper-V VMBus device. It is useful to provide direct accessdrivers/video/fbdev/Kconfig +1
-1@@ -1774,7 +1774,7 @@ config FB_BROADSHEET config FB_HYPERV tristate "Microsoft Hyper-V Synthetic Video support" - depends on FB && HYPERV + depends on FB && HYPERV_VMBUS select DMA_CMA if HAVE_DMA_CONTIGUOUS && CMA select FB_IOMEM_HELPERS_DEFERRED helpinclude/asm-generic/mshyperv.h +5
-3@@ -165,6 +165,7 @@ static inline u64 hv_generate_guest_id(u64 kernel_version)void __init hv_mark_resources (void ); +#if IS_ENABLED (CONFIG_HYPERV_VMBUS )/* Free the message slot and signal end-of-message if required */ static inline void vmbus_signal_eom (struct hv_message *msg,u32 old_msg_type) {@@ -200,6 +201,10 @@ static inline void vmbus_signal_eom(struct hv_message *msg, u32 old_msg_type) } } +extern int vmbus_interrupt; +extern int vmbus_irq; +#endif /* CONFIG_HYPERV_VMBUS */ +int hv_get_hypervisor_version (union hv_hypervisor_version_info *info);void hv_setup_vmbus_handler (void (*handler)(void ));@@ -213,9 +218,6 @@ void hv_setup_crash_handler(void (*handler)(struct pt_regs *regs));void hv_remove_crash_handler (void );void hv_setup_mshv_handler (void (*handler)(void )); -extern int vmbus_interrupt; -extern int vmbus_irq; -#if IS_ENABLED (CONFIG_HYPERV )/* * Hypervisor's notion of virtual processor ID is different from net/vmw_vsock/Kconfig +1
-1@@ -72,7 +72,7 @@ config VIRTIO_VSOCKETS_COMMON config HYPERV_VSOCKETS tristate "Hyper-V transport for Virtual Sockets" - depends on VSOCKETS && HYPERV + depends on VSOCKETS && HYPERV_VMBUS help This module implements a Hyper-V transport for Virtual Sockets.
RE: [PATCH V0 1/2] hyper-v: Add CONFIG_HYPERV_VMBUS option
In reply to Mukesh RathorFrom: Mukesh Rathor <[email protected]> Sent: Wednesday, August 27, 2025 6:00 PM
Quoted 1 line
Even though this patch touches multiple subdirectories under "drivers", I'd suggest the patch "Subject:" prefix should be "Drivers: hv:" (not "hyper-v:") to be consistent with historical usage.
Quoted 1 line
Somehow vmbus driver is hinged on
CONFIG_HYPERV. It appears this is initial
In text, "vmbus" should be spelled as "VMBus". This includes patch Subjects, commit messages, code comments, kernel messages, and kernel documentation. Originally, the spelling was all over the map, but we've tried to be more consistent lately in matching Microsoft's public documentation on Hyper-V, which uses "VMBus". Of course, C language code variable and function names use all lowercase.
Quoted 60 lines
code that did not get addressed when the scope of
CONFIG_HYPERVwent beyond vmbus. This commit creates a fine grainedHYPERV_VMBUSoption and updates drivers that depend on VMBUS.Signed-off-by Mukesh Rathor <[email protected]>--- drivers/gpu/drm/Kconfig | 2 +- drivers/hid/Kconfig | 2 +- drivers/hv/Kconfig | 12 +++++++++--- drivers/hv/Makefile | 2 +- drivers/input/serio/Kconfig | 4 ++-- drivers/net/hyperv/Kconfig | 2 +- drivers/pci/Kconfig | 2 +- drivers/scsi/Kconfig | 2 +- drivers/uio/Kconfig | 2 +- drivers/video/fbdev/Kconfig | 2 +- include/asm-generic/mshyperv.h | 8 +++++--- net/vmw_vsock/Kconfig | 2 +- 12 files changed, 25 insertions(+), 17 deletions(-)drivers/gpu/drm/Kconfig +1
-1@@ -398,7 +398,7 @@ source "drivers/gpu/drm/imagination/Kconfig" config DRM_HYPERV tristate "DRM Support for Hyper-V synthetic video device" - depends on DRM && PCI && HYPERV + depends on DRM && PCI && HYPERV_VMBUS select DRM_CLIENT_SELECTION select DRM_KMS_HELPER select DRM_GEM_SHMEM_HELPERdrivers/hid/Kconfig +1
-1@@ -1162,7 +1162,7 @@ config GREENASIA_FF config HID_HYPERV_MOUSE tristate "Microsoft Hyper-V mouse driver" - depends on HYPERV + depends on HYPERV_VMBUS help Select this option to enable the Hyper-V mouse driver.drivers/hv/Kconfig +1
-1@@ -44,18 +44,24 @@ config HYPERV_TIMER config HYPERV_UTILS tristate "Microsoft Hyper-V Utilities driver" - depends on HYPERV && CONNECTOR && NLS + depends on HYPERV_VMBUS && CONNECTOR && NLS depends on PTP_1588_CLOCK_OPTIONAL help Select this option to enable the Hyper-V Utilities.
drivers/hv/Kconfig config HYPERV_TIMER · line 60
Quoted 10 lines
drivers/hv/Kconfig +3
-1config HYPERV_BALLOON tristate "Microsoft Hyper-V Balloon driver" - depends on HYPERV + depends on HYPERV_VMBUS select PAGE_REPORTING help Select this option to enable Hyper-V Balloon driver. +config HYPERV_VMBUS + tristate "Microsoft Hyper-V Vmbus driver"
As described above,
s/Vmbus/VMBus/
drivers/hv/Kconfig config HYPERV_TIMER · line 61
Quoted 1 line
drivers/hv/Kconfig +1
-0+ depends on HYPERV
Per my comments on the cover letter, could add "default HYPERV" here to help ease the transition.
drivers/hv/Kconfig config HYPERV_TIMER · line 63
Quoted 2 lines
drivers/hv/Kconfig +2
-0+ help + Select this option to enable Hyper-V Vmbus driver.
s/Vmbus/VMBus/
drivers/hv/Kconfig config MSHV_ROOT · line 84
Quoted 10 lines
drivers/hv/Kconfig +2
-1+ config MSHV_ROOT tristate "Microsoft Hyper-V root partition support" depends on HYPERV && (X86_64 || ARM64)@@ -75,7 +81,7 @@ config MSHV_ROOT config MSHV_VTL tristate "Microsoft Hyper-V VTL driver" - depends on X86_64 && HYPERV_VTL_MODE + depends on X86_64 && HYPERV_VTL_MODE && HYPERV_VMBUS
An observation: conceptually I would not expect this driver to depend on HYPERV_VMBUS because it is not a VMBus driver. But looking at the code, this is a place where VMBus interrupt handling bleeds into code that is otherwise just hypervisor functionality. So evidently the HYPERV_VMBUS dependency is needed for now. Getting better separation and avoiding the dependency could be done later.
Quoted 144 lines
drivers/hv/Kconfig +0
-0# Mapping VTL0 memory to a userspace process in VTL2 is supported in OpenHCL. # VTL2 for OpenHCL makes use of Huge Pages to improve performance on VMs, # specially with large memory requirements.drivers/hv/Makefile +1
-1@@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_HYPERV) += hv_vmbus.o +obj-$(CONFIG_HYPERV_VMBUS) += hv_vmbus.o obj-$(CONFIG_HYPERV_UTILS) += hv_utils.o obj-$(CONFIG_HYPERV_BALLOON) += hv_balloon.o obj-$(CONFIG_MSHV_ROOT) += mshv_root.odrivers/input/serio/Kconfig +2
-2@@ -276,8 +276,8 @@ config SERIO_OLPC_APSP config HYPERV_KEYBOARD tristate "Microsoft Synthetic Keyboard driver" - depends on HYPERV - default HYPERV + depends on HYPERV_VMBUS + default HYPERV_VMBUS help Select this option to enable the Hyper-V Keyboard driver.drivers/net/hyperv/Kconfig +1
-1@@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config HYPERV_NET tristate "Microsoft Hyper-V virtual network driver" - depends on HYPERV + depends on HYPERV_VMBUS select UCS2_STRING select NLS helpdrivers/pci/Kconfig +1
-1@@ -221,7 +221,7 @@ config PCI_LABEL config PCI_HYPERV tristate "Hyper-V PCI Frontend" - depends on ((X86 && X86_64) || ARM64) && HYPERV && PCI_MSI && SYSFS + depends on ((X86 && X86_64) || ARM64) && HYPERV_VMBUS && PCI_MSI&& SYSFS
drivers/pci/Kconfig +0
-0select PCI_HYPERV_INTERFACE select IRQ_MSI_LIB helpdrivers/scsi/Kconfig +1
-1@@ -589,7 +589,7 @@ config XEN_SCSI_FRONTEND config HYPERV_STORAGE tristate "Microsoft Hyper-V virtual storage driver" - depends on SCSI && HYPERV + depends on SCSI && HYPERV_VMBUS depends on m || SCSI_FC_ATTRS != m default HYPERV helpdrivers/uio/Kconfig +1
-1@@ -140,7 +140,7 @@ config UIO_MF624 config UIO_HV_GENERIC tristate "Generic driver for Hyper-V VMBus" - depends on HYPERV + depends on HYPERV_VMBUS help Generic driver that you can bind, dynamically, to any Hyper-V VMBus device. It is useful to provide direct accessdrivers/video/fbdev/Kconfig +1
-1@@ -1774,7 +1774,7 @@ config FB_BROADSHEET config FB_HYPERV tristate "Microsoft Hyper-V Synthetic Video support" - depends on FB && HYPERV + depends on FB && HYPERV_VMBUS select DMA_CMA if HAVE_DMA_CONTIGUOUS && CMA select FB_IOMEM_HELPERS_DEFERRED helpinclude/asm-generic/mshyperv.h +5
-3@@ -165,6 +165,7 @@ static inline u64 hv_generate_guest_id(u64 kernel_version)void __init hv_mark_resources (void ); +#if IS_ENABLED (CONFIG_HYPERV_VMBUS )/* Free the message slot and signal end-of-message if required */ static inline void vmbus_signal_eom (struct hv_message *msg,u32 old_msg_type) {@@ -200,6 +201,10 @@ static inline void vmbus_signal_eom(struct hv_message *msg, u32 old_msg_type) } } +extern int vmbus_interrupt; +extern int vmbus_irq; +#endif /* CONFIG_HYPERV_VMBUS */ +int hv_get_hypervisor_version (union hv_hypervisor_version_info *info);void hv_setup_vmbus_handler (void (*handler)(void ));@@ -213,9 +218,6 @@ void hv_setup_crash_handler(void (*handler)(struct pt_regs *regs));void hv_remove_crash_handler (void );void hv_setup_mshv_handler (void (*handler)(void )); -extern int vmbus_interrupt; -extern int vmbus_irq; -#if IS_ENABLED (CONFIG_HYPERV )/* * Hypervisor's notion of virtual processor ID is different from net/vmw_vsock/Kconfig +1
-2@@ -72,7 +72,7 @@ config VIRTIO_VSOCKETS_COMMON config HYPERV_VSOCKETS tristate "Hyper-V transport for Virtual Sockets" - depends on VSOCKETS && HYPERV + depends on VSOCKETS && HYPERV_VMBUS help This module implements a Hyper-V transport for Virtual Sockets. --2.36.1.vfs.0.0
PATCH 2/2 hyper-v: Make CONFIG_HYPERV bool
In reply to Mukesh RathorCONFIG_HYPERV is an umbrella config option involved in enabling hyperv support and build of modules like hyperv-balloon, hyperv-vmbus, etc.. As such it should be bool and the hack in Makefile be removed.
--- drivers/Makefile | 2 +- drivers/hv/Kconfig | 2 +- drivers/hv/Makefile | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/Makefile +1 -1
@@ -161,7 +161,7 @@ obj-$(CONFIG_SOUNDWIRE) += soundwire/ # Virtualization drivers obj-$(CONFIG_VIRT_DRIVERS) += virt/ -obj-$(subst m,y,$(CONFIG_HYPERV)) += hv/ +obj-$(CONFIG_HYPERV) += hv/ obj-$(CONFIG_PM_DEVFREQ) += devfreq/ obj-$(CONFIG_EXTCON) += extcon/
drivers/hv/Kconfig +1 -1
@@ -3,7 +3,7 @@ menu "Microsoft Hyper-V guest support" config HYPERV - tristate "Microsoft Hyper-V client drivers" + bool "Microsoft Hyper-V client drivers" depends on (X86 && X86_LOCAL_APIC && HYPERVISOR_GUEST) \ || (ARM64 && !CPU_BIG_ENDIAN) select PARAVIRT
drivers/hv/Makefile +1 -1
@@ -18,7 +18,7 @@ mshv_root-y := mshv_root_main.o mshv_synic.o mshv_eventfd.o mshv_irq.o \ mshv_vtl-y := mshv_vtl_main.o # Code that must be built-in -obj-$(subst m,y,$(CONFIG_HYPERV)) += hv_common.o +obj-$(CONFIG_HYPERV) += hv_common.o obj-$(subst m,y,$(CONFIG_MSHV_ROOT)) += hv_proc.o ifneq ($(CONFIG_MSHV_ROOT) $(CONFIG_MSHV_VTL),) obj-y += mshv_common.o
Signature · 1 line
2.36.1.vfs.0.0
RE: [PATCH V0 2/2] hyper-v: Make CONFIG_HYPERV bool
From: Mukesh Rathor <[email protected]> Sent: Wednesday, August 27, 2025 6:00 PM
Same comment about patch "Subject:" prefix.
Quoted 1 line
CONFIG_HYPERVis an umbrella config option involved in enabling hyperv
s/hyperv/Hyper-V/
Quoted 1 line
support and build of modules like hyperv-balloon, hyperv-vmbus, etc..
With CONFIG_HYPERV and CONFIG_HYPERV_VMBUS separated, I think of CONFIG_HYPERV as the core Hyper-V hypervisor support, such as hypercalls, clocks/timers, Confidential Computing setup, etc. that doesn't involve VMBus or VMBus devices.
Quoted 27 lines
As such it should be bool and the hack in
Makefilebe removed.Signed-off-by Mukesh Rathor <[email protected]>--- drivers/Makefile | 2 +- drivers/hv/Kconfig | 2 +- drivers/hv/Makefile | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)drivers/Makefile +1
-1@@ -161,7 +161,7 @@ obj-$(CONFIG_SOUNDWIRE) += soundwire/ # Virtualization drivers obj-$(CONFIG_VIRT_DRIVERS) += virt/ -obj-$(subst m,y,$(CONFIG_HYPERV)) += hv/ +obj-$(CONFIG_HYPERV) += hv/ obj-$(CONFIG_PM_DEVFREQ) += devfreq/ obj-$(CONFIG_EXTCON) += extcon/drivers/hv/Kconfig +0
-0
drivers/hv/Kconfig line 6
Quoted 5 lines
drivers/hv/Kconfig +1
-1@@ -3,7 +3,7 @@ menu "Microsoft Hyper-V guest support" config HYPERV - tristate "Microsoft Hyper-V client drivers" + bool "Microsoft Hyper-V client drivers"
I would want to change the prompt here to be more specific, such as:
bool "Microsoft Hyper-V core hypervisor support"
As noted in my comments on the cover letter, this change causes .config file compatibility problems. I can't immediately think of a way to deal with the compatibility problem and still change this from tristate to bool.
Quoted 20 lines
drivers/hv/Kconfig +0
-0depends on (X86 && X86_LOCAL_APIC && HYPERVISOR_GUEST) \ || (ARM64 && !CPU_BIG_ENDIAN) select PARAVIRTdrivers/hv/Makefile +1
-1@@ -18,7 +18,7 @@ mshv_root-y := mshv_root_main.o mshv_synic.o mshv_eventfd.o mshv_irq.o \ mshv_vtl-y := mshv_vtl_main.o # Code that must be built-in -obj-$(subst m,y,$(CONFIG_HYPERV)) += hv_common.o +obj-$(CONFIG_HYPERV) += hv_common.o obj-$(subst m,y,$(CONFIG_MSHV_ROOT)) += hv_proc.o ifneq ($(CONFIG_MSHV_ROOT) $(CONFIG_MSHV_VTL),)obj-y += mshv_common.o--
2.36.1.vfs.0.0
From: Mukesh Rathor <[email protected]> Sent: Wednesday, August 27, 2025 6:00 PM
Quoted 6 lines
At present,
drivers/Makefilewill subst =m to =y forCONFIG_HYPERVfor hv subdir. Also,drivers/hv/Makefilereplaces =m to =y to build inhv_common.cthat is needed for the drivers. Moreover, vmbus driver is built ifCONFIG_HYPERis set, either loadable or builtin.
Quoted 6 lines
This is not a good approach.
CONFIG_HYPERVis really an umbrella config that encompasses builtin code and various other things and not a dedicated config option for VMBUS. Vmbus should really have a config option just likeCONFIG_HYPERV_BALLOONetc. This small series introducesCONFIG_HYPERV_VMBUSto build VMBUS driver and make that distinction explicit. With thatCONFIG_HYPERVcould be changed to bool.
Separating the core hypervisor support (CONFIG_HYPERV) from the VMBus support (CONFIG_HYPERV_VMBUS) makes sense to me. Overall the code is already mostly in separate source files code, though there's some entanglement in the handling of VMBus interrupts, which could be improved later.
However, I have a compatibility concern. Consider this scenario:
1) Assume running in a Hyper-V VM with a current Linux kernel version built with CONFIG_HYPERV=m.
2) Grab a new version of kernel source code that contains this patch set.
3) Run 'make olddefconfig' to create the .config file for the new kernel.
4) Build the new kernel. This succeeds.
5) Install and run the new kernel in the Hyper-V VM. This fails.
The failure occurs because CONFIG_HYPERV=m is no longer legal, so the .config file created in Step 3 has CONFIG_HYPERV=n. The newly built kernel has no Hyper-V support and won't run in a Hyper-V VM.
As a second issue, if in Step 1 the current kernel was built with CONFIG_HYPERV=y, then the .config file for the new kernel will have CONFIG_HYPERV=y, which is better. But CONFIG_HYPERV_VMBUS defaults to 'n', so the new kernel doesn't have any VMBus drivers and won't run in a typical Hyper-V VM.
The second issue could be fixed by assigning CONFIG_HYPERV_VMBUS a default value, such as whatever CONFIG_HYPERV is set to. But I'm not sure how to fix the first issue, except by continuing to allow CONFIG_HYPERV=m.
See additional minor comments in Patches 1 and 2.
Michael
Quoted 27 lines
For now,
hv_common.cis left as is to reduce conflicts for upcoming patches, but once merges are mostly done, that and some others should be moved tovirt/hypervdirectory.Mukesh Rathor (2):
hyper-v: AddCONFIG_HYPERV_VMBUSoption
hyper-v: MakeCONFIG_HYPERVbooldrivers/Makefile | 2 +- drivers/gpu/drm/Kconfig | 2 +- drivers/hid/Kconfig | 2 +- drivers/hv/Kconfig | 14 ++++++++++---- drivers/hv/Makefile | 4 ++-- drivers/input/serio/Kconfig | 4 ++-- drivers/net/hyperv/Kconfig | 2 +- drivers/pci/Kconfig | 2 +- drivers/scsi/Kconfig | 2 +- drivers/uio/Kconfig | 2 +- drivers/video/fbdev/Kconfig | 2 +- include/asm-generic/mshyperv.h | 8 +++++--- net/vmw_vsock/Kconfig | 2 +- 13 files changed, 28 insertions(+), 20 deletions(-)--
2.36.1.vfs.0.0
Quoted 40 lines · Michael Kelley
From: Mukesh Rathor <[email protected]> Sent: Wednesday, August 27, 2025 6:00 PM
Quoted 6 lines
At present,
drivers/Makefilewill subst =m to =y forCONFIG_HYPERVfor hv subdir. Also,drivers/hv/Makefilereplaces =m to =y to build inhv_common.cthat is needed for the drivers. Moreover, vmbus driver is built ifCONFIG_HYPERis set, either loadable or builtin.Quoted 6 lines
This is not a good approach.
CONFIG_HYPERVis really an umbrella config that encompasses builtin code and various other things and not a dedicated config option for VMBUS. Vmbus should really have a config option just likeCONFIG_HYPERV_BALLOONetc. This small series introducesCONFIG_HYPERV_VMBUSto build VMBUS driver and make that distinction explicit. With thatCONFIG_HYPERVcould be changed to bool.Separating the core hypervisor support (
CONFIG_HYPERV) from the VMBus support (CONFIG_HYPERV_VMBUS) makes sense to me. Overall the code is already mostly in separate source files code, though there's some entanglement in the handling of VMBus interrupts, which could be improved later.However, I have a compatibility concern. Consider this scenario:
1) Assume running in a Hyper-V VM with a current Linux kernel version built with
CONFIG_HYPERV=m.
2) Grab a new version of kernel source code that contains this patch set.
3) Run 'make olddefconfig' to create the .config file for the new kernel.
4) Build the new kernel. This succeeds.
5) Install and run the new kernel in the Hyper-V VM. This fails.The failure occurs because
CONFIG_HYPERV=mis no longer legal, so the .config file created in Step 3 hasCONFIG_HYPERV=n. The newly built kernel has no Hyper-V support and won't run in a Hyper-V VM.As a second issue, if in Step 1 the current kernel was built with
CONFIG_HYPERV=y, then the .config file for the new kernel will haveCONFIG_HYPERV=y, which is better. ButCONFIG_HYPERV_VMBUSdefaults to 'n', so the new kernel doesn't have any VMBus drivers and won't run in a typical Hyper-V VM.
Quoted 4 lines
The second issue could be fixed by assigning
CONFIG_HYPERV_VMBUSa default value, such as whateverCONFIG_HYPERVis set to. But I'm not sure how to fix the first issue, except by continuing to allowCONFIG_HYPERV=m.
To certain extent, imo, users are expected to check config files for changes when moving to new versions/releases, so it would be a one time burden. CONFIG_HYPERV=m is just broken imo as one sees that in .config but magically symbols in drivers/hv are in kerenel.
Thanks,
-Mukesh
Quoted 31 lines
See additional minor comments in Patches 1 and 2.
Michael
Quoted 27 lines
For now,
hv_common.cis left as is to reduce conflicts for upcoming patches, but once merges are mostly done, that and some others should be moved tovirt/hypervdirectory.Mukesh Rathor (2):
hyper-v: AddCONFIG_HYPERV_VMBUSoption
hyper-v: MakeCONFIG_HYPERVbooldrivers/Makefile | 2 +- drivers/gpu/drm/Kconfig | 2 +- drivers/hid/Kconfig | 2 +- drivers/hv/Kconfig | 14 ++++++++++---- drivers/hv/Makefile | 4 ++-- drivers/input/serio/Kconfig | 4 ++-- drivers/net/hyperv/Kconfig | 2 +- drivers/pci/Kconfig | 2 +- drivers/scsi/Kconfig | 2 +- drivers/uio/Kconfig | 2 +- drivers/video/fbdev/Kconfig | 2 +- include/asm-generic/mshyperv.h | 8 +++++--- net/vmw_vsock/Kconfig | 2 +- 13 files changed, 28 insertions(+), 20 deletions(-)--
2.36.1.vfs.0.0
From: Mukesh R <[email protected]> Sent: Wednesday, September 3, 2025 7:17 PM
Quoted 42 lines · Michael Kelley
Quoted 40 lines
From: Mukesh Rathor <[email protected]> Sent: Wednesday, August 27, 2025 6:00 PM
Quoted 6 lines
At present,
drivers/Makefilewill subst =m to =y forCONFIG_HYPERVfor hv subdir. Also,drivers/hv/Makefilereplaces =m to =y to build inhv_common.cthat is needed for the drivers. Moreover, vmbus driver is built ifCONFIG_HYPERis set, either loadable or builtin.Quoted 6 lines
This is not a good approach.
CONFIG_HYPERVis really an umbrella config that encompasses builtin code and various other things and not a dedicated config option for VMBUS. Vmbus should really have a config option just likeCONFIG_HYPERV_BALLOONetc. This small series introducesCONFIG_HYPERV_VMBUSto build VMBUS driver and make that distinction explicit. With thatCONFIG_HYPERVcould be changed to bool.Separating the core hypervisor support (
CONFIG_HYPERV) from the VMBus support (CONFIG_HYPERV_VMBUS) makes sense to me. Overall the code is already mostly in separate source files code, though there's some entanglement in the handling of VMBus interrupts, which could be improved later.However, I have a compatibility concern. Consider this scenario:
1) Assume running in a Hyper-V VM with a current Linux kernel version built with
CONFIG_HYPERV=m.
2) Grab a new version of kernel source code that contains this patch set.
3) Run 'make olddefconfig' to create the .config file for the new kernel.
4) Build the new kernel. This succeeds.
5) Install and run the new kernel in the Hyper-V VM. This fails.The failure occurs because
CONFIG_HYPERV=mis no longer legal, so the .config file created in Step 3 hasCONFIG_HYPERV=n. The newly built kernel has no Hyper-V support and won't run in a Hyper-V VM.As a second issue, if in Step 1 the current kernel was built with
CONFIG_HYPERV=y, then the .config file for the new kernel will haveCONFIG_HYPERV=y, which is better. ButCONFIG_HYPERV_VMBUSdefaults to 'n', so the new kernel doesn't have any VMBus drivers and won't run in a typical Hyper-V VM.
Quoted 8 lines
Quoted 4 lines
The second issue could be fixed by assigning
CONFIG_HYPERV_VMBUSa default value, such as whateverCONFIG_HYPERVis set to. But I'm not sure how to fix the first issue, except by continuing to allowCONFIG_HYPERV=m.To certain extent, imo, users are expected to check config files for changes when moving to new versions/releases, so it would be a one time burden.
I'm not so sanguine about the impact. For those of us who work with Hyper-V frequently, yes, it's probably not that big of an issue -- we can figure it out. But a lot of Azure/Hyper-V users aren't that familiar with the details of how the Kconfig files are put together. And the issue occurs with no error messages that something has gone wrong in building the kernel, except that it won't boot. Just running "make olddefconfig" has worked in the past, so some users will be befuddled and end up generating Azure support incidents. I also wonder about breaking automated test suites for new kernels, as they are likely to be running "make olddefconfig" or something similar as part of the automation.
Quoted 3 lines
CONFIG_HYPERV=mis just broken imo as one sees that in .config but magically symbols indrivers/hvare in kerenel.
I agree that's not ideal. But note that some Hyper-V code and symbols like ms_hyperv_init_platform() and related functions show up when CONFIG_HYPERVISOR_GUEST=y, even if CONFIG_HYPERV=n. That's the code in arch/x86/kernel/cpu/mshyperv.c and it's because Hyper-V is one of the recognized and somewhat hardwired hypervisors (like VMware, for example).
Finally, there are about a dozen other places in the kernel that use the same Makefile construct to make some code built-in even though the CONFIG option is set to "m". That may not be enough occurrences to make it standard practice, but Hyper-V guests are certainly not the only case.
In my mind, this is judgment call with no absolute right answer. What do others think about the tradeoffs?
Michael
Quoted 74 lines · Michael Kelley
From: Mukesh R <[email protected]> Sent: Wednesday, September 3, 2025 7:17 PM
Quoted 42 lines · Michael Kelley
Quoted 40 lines
From: Mukesh Rathor <[email protected]> Sent: Wednesday, August 27, 2025 6:00 PM
Quoted 6 lines
At present,
drivers/Makefilewill subst =m to =y forCONFIG_HYPERVfor hv subdir. Also,drivers/hv/Makefilereplaces =m to =y to build inhv_common.cthat is needed for the drivers. Moreover, vmbus driver is built ifCONFIG_HYPERis set, either loadable or builtin.Quoted 6 lines
This is not a good approach.
CONFIG_HYPERVis really an umbrella config that encompasses builtin code and various other things and not a dedicated config option for VMBUS. Vmbus should really have a config option just likeCONFIG_HYPERV_BALLOONetc. This small series introducesCONFIG_HYPERV_VMBUSto build VMBUS driver and make that distinction explicit. With thatCONFIG_HYPERVcould be changed to bool.Separating the core hypervisor support (
CONFIG_HYPERV) from the VMBus support (CONFIG_HYPERV_VMBUS) makes sense to me. Overall the code is already mostly in separate source files code, though there's some entanglement in the handling of VMBus interrupts, which could be improved later.However, I have a compatibility concern. Consider this scenario:
1) Assume running in a Hyper-V VM with a current Linux kernel version built with
CONFIG_HYPERV=m.
2) Grab a new version of kernel source code that contains this patch set.
3) Run 'make olddefconfig' to create the .config file for the new kernel.
4) Build the new kernel. This succeeds.
5) Install and run the new kernel in the Hyper-V VM. This fails.The failure occurs because
CONFIG_HYPERV=mis no longer legal, so the .config file created in Step 3 hasCONFIG_HYPERV=n. The newly built kernel has no Hyper-V support and won't run in a Hyper-V VM.As a second issue, if in Step 1 the current kernel was built with
CONFIG_HYPERV=y, then the .config file for the new kernel will haveCONFIG_HYPERV=y, which is better. ButCONFIG_HYPERV_VMBUSdefaults to 'n', so the new kernel doesn't have any VMBus drivers and won't run in a typical Hyper-V VM.Quoted 8 lines
Quoted 4 lines
The second issue could be fixed by assigning
CONFIG_HYPERV_VMBUSa default value, such as whateverCONFIG_HYPERVis set to. But I'm not sure how to fix the first issue, except by continuing to allowCONFIG_HYPERV=m.To certain extent, imo, users are expected to check config files for changes when moving to new versions/releases, so it would be a one time burden.
I'm not so sanguine about the impact. For those of us who work with Hyper-V frequently, yes, it's probably not that big of an issue -- we can figure it out. But a lot of Azure/Hyper-V users aren't that familiar with the details of how the
Kconfigfiles are put together. And the issue occurs with no error messages that something has gone wrong in building the kernel, except that it won't boot. Just running "make olddefconfig" has worked in the past, so some users will be befuddled and end up generating Azure support incidents. I also wonder about breaking automated test suites for new kernels, as they are likely to be running "make olddefconfig" or something similar as part of the automation.Quoted 3 lines
CONFIG_HYPERV=mis just broken imo as one sees that in .config but magically symbols indrivers/hvare in kerenel.I agree that's not ideal. But note that some Hyper-V code and symbols like
ms_hyperv_init_platform()and related functions show up whenCONFIG_HYPERVISOR_GUEST=y, even ifCONFIG_HYPERV=n. That's the code inarch/x86/kernel/cpu/mshyperv.cand it's because Hyper-V is one of the recognized and somewhat hardwired hypervisors (like VMware, for example).
Quoted 8 lines
Finally, there are about a dozen other places in the kernel that use the same
Makefileconstruct to make some code built-in even though the CONFIG option is set to "m". That may not be enough occurrences to make it standard practice, but Hyper-V guests are certainly not the only case.In my mind, this is judgment call with no absolute right answer. What do others think about the tradeoffs?
Wei had said in private message that he agrees this is a good idea. Nuno said earlier above:
"FWIW I think it's a good idea, interested to hear what others think."
Thanks,
-Mukesh
Quoted 33 lines · Mukesh R
Quoted 32 lines · Michael Kelley
From: Mukesh R <[email protected]> Sent: Wednesday, September 3, 2025 7:17 PM
Quoted 31 lines · Michael Kelley
Quoted 29 lines
From: Mukesh Rathor <[email protected]> Sent: Wednesday, August 27, 2025 6:00 PM
Quoted 6 lines
At present,
drivers/Makefilewill subst =m to =y forCONFIG_HYPERVfor hv subdir. Also,drivers/hv/Makefilereplaces =m to =y to build inhv_common.cthat is needed for the drivers. Moreover, vmbus driver is built ifCONFIG_HYPERis set, either loadable or builtin.Quoted 6 lines
This is not a good approach.
CONFIG_HYPERVis really an umbrella config that encompasses builtin code and various other things and not a dedicated config option for VMBUS. Vmbus should really have a config option just likeCONFIG_HYPERV_BALLOONetc. This small series introducesCONFIG_HYPERV_VMBUSto build VMBUS driver and make that distinction explicit. With thatCONFIG_HYPERVcould be changed to bool.Separating the core hypervisor support (
CONFIG_HYPERV) from the VMBus support (CONFIG_HYPERV_VMBUS) makes sense to me. Overall the code is already mostly in separate source files code, though there's some entanglement in the handling of VMBus interrupts, which could be improved later.However, I have a compatibility concern. Consider this scenario:
1) Assume running in a Hyper-V VM with a current Linux kernel version built with
CONFIG_HYPERV=m.
2) Grab a new version of kernel source code that contains this patch set.
3) Run 'make olddefconfig' to create the .config file for the new kernel.
4) Build the new kernel. This succeeds.
5) Install and run the new kernel in the Hyper-V VM. This fails.
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
The failure occurs because
CONFIG_HYPERV=mis no longer legal, so the .config file created in Step 3 hasCONFIG_HYPERV=n. The newly built kernel has no Hyper-V support and won't run in a Hyper-V VM.
It surprises me a little that =m doesn't get 'fixed up' to =y in this case. I guess any invalid value turns to =n, which makes sense most of the time.
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
As a second issue, if in Step 1 the current kernel was built with
CONFIG_HYPERV=y, then the .config file for the new kernel will haveCONFIG_HYPERV=y, which is better. ButCONFIG_HYPERV_VMBUSdefaults to 'n', so the new kernel doesn't have any VMBus drivers and won't run in a typical Hyper-V VM.The second issue could be fixed by assigning
CONFIG_HYPERV_VMBUSa default value, such as whateverCONFIG_HYPERVis set to. But I'm not sure how to fix the first issue, except by continuing to allowCONFIG_HYPERV=m.
I'm wondering, is there a path for this change, then? Are there some intermediate step/s we could take to minimize the problem?
Quoted 33 lines
Quoted 33 lines
Quoted 4 lines
To certain extent, imo, users are expected to check config files for changes when moving to new versions/releases, so it would be a one time burden.
I'm not so sanguine about the impact. For those of us who work with Hyper-V frequently, yes, it's probably not that big of an issue -- we can figure it out. But a lot of Azure/Hyper-V users aren't that familiar with the details of how the
Kconfigfiles are put together. And the issue occurs with no error messages that something has gone wrong in building the kernel, except that it won't boot. Just running "make olddefconfig" has worked in the past, so some users will be befuddled and end up generating Azure support incidents. I also wonder about breaking automated test suites for new kernels, as they are likely to be running "make olddefconfig" or something similar as part of the automation.Quoted 3 lines
CONFIG_HYPERV=mis just broken imo as one sees that in .config but magically symbols indrivers/hvare in kerenel.I agree that's not ideal. But note that some Hyper-V code and symbols like
ms_hyperv_init_platform()and related functions show up whenCONFIG_HYPERVISOR_GUEST=y, even ifCONFIG_HYPERV=n. That's the code inarch/x86/kernel/cpu/mshyperv.cand it's because Hyper-V is one of the recognized and somewhat hardwired hypervisors (like VMware, for example).Finally, there are about a dozen other places in the kernel that use the same
Makefileconstruct to make some code built-in even though the CONFIG option is set to "m". That may not be enough occurrences to make it standard practice, but Hyper-V guests are certainly not the only case.
Quoted 8 lines
Quoted 2 lines
In my mind, this is judgment call with no absolute right answer. What do others think about the tradeoffs?
Wei had said in private message that he agrees this is a good idea. Nuno said earlier above:
"FWIW I think it's a good idea, interested to hear what others think."
That was before Michael pointed out the potential issues which I was unaware of. Let's see if there's a path that is smoother for all the downstream users who may be compiling with CONFIG_HYPERV=m.
Nuno
Quoted 3 lines
Thanks,> -Mukesh
Quoted 93 lines · Nuno Das Neves
Quoted 33 lines · Mukesh R
Quoted 32 lines · Michael Kelley
From: Mukesh R <[email protected]> Sent: Wednesday, September 3, 2025 7:17 PM
Quoted 31 lines · Michael Kelley
Quoted 29 lines
From: Mukesh Rathor <[email protected]> Sent: Wednesday, August 27, 2025 6:00 PM
Quoted 6 lines
At present,
drivers/Makefilewill subst =m to =y forCONFIG_HYPERVfor hv subdir. Also,drivers/hv/Makefilereplaces =m to =y to build inhv_common.cthat is needed for the drivers. Moreover, vmbus driver is built ifCONFIG_HYPERis set, either loadable or builtin.Quoted 6 lines
This is not a good approach.
CONFIG_HYPERVis really an umbrella config that encompasses builtin code and various other things and not a dedicated config option for VMBUS. Vmbus should really have a config option just likeCONFIG_HYPERV_BALLOONetc. This small series introducesCONFIG_HYPERV_VMBUSto build VMBUS driver and make that distinction explicit. With thatCONFIG_HYPERVcould be changed to bool.Separating the core hypervisor support (
CONFIG_HYPERV) from the VMBus support (CONFIG_HYPERV_VMBUS) makes sense to me. Overall the code is already mostly in separate source files code, though there's some entanglement in the handling of VMBus interrupts, which could be improved later.However, I have a compatibility concern. Consider this scenario:
1) Assume running in a Hyper-V VM with a current Linux kernel version built with
CONFIG_HYPERV=m.
2) Grab a new version of kernel source code that contains this patch set.
3) Run 'make olddefconfig' to create the .config file for the new kernel.
4) Build the new kernel. This succeeds.
5) Install and run the new kernel in the Hyper-V VM. This fails.Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
The failure occurs because
CONFIG_HYPERV=mis no longer legal, so the .config file created in Step 3 hasCONFIG_HYPERV=n. The newly built kernel has no Hyper-V support and won't run in a Hyper-V VM.It surprises me a little that =m doesn't get 'fixed up' to =y in this case. I guess any invalid value turns to =n, which makes sense most of the time.
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
As a second issue, if in Step 1 the current kernel was built with
CONFIG_HYPERV=y, then the .config file for the new kernel will haveCONFIG_HYPERV=y, which is better. ButCONFIG_HYPERV_VMBUSdefaults to 'n', so the new kernel doesn't have any VMBus drivers and won't run in a typical Hyper-V VM.The second issue could be fixed by assigning
CONFIG_HYPERV_VMBUSa default value, such as whateverCONFIG_HYPERVis set to. But I'm not sure how to fix the first issue, except by continuing to allowCONFIG_HYPERV=m.I'm wondering, is there a path for this change, then? Are there some intermediate step/s we could take to minimize the problem?
Quoted 36 lines
Quoted 35 lines
Quoted 4 lines
To certain extent, imo, users are expected to check config files for changes when moving to new versions/releases, so it would be a one time burden.
I'm not so sanguine about the impact. For those of us who work with Hyper-V frequently, yes, it's probably not that big of an issue -- we can figure it out. But a lot of Azure/Hyper-V users aren't that familiar with the details of how the
Kconfigfiles are put together. And the issue occurs with no error messages that something has gone wrong in building the kernel, except that it won't boot. Just running "make olddefconfig" has worked in the past, so some users will be befuddled and end up generating Azure support incidents. I also wonder about breaking automated test suites for new kernels, as they are likely to be running "make olddefconfig" or something similar as part of the automation.Quoted 3 lines
CONFIG_HYPERV=mis just broken imo as one sees that in .config but magically symbols indrivers/hvare in kerenel.I agree that's not ideal. But note that some Hyper-V code and symbols like
ms_hyperv_init_platform()and related functions show up whenCONFIG_HYPERVISOR_GUEST=y, even ifCONFIG_HYPERV=n. That's the code inarch/x86/kernel/cpu/mshyperv.cand it's because Hyper-V is one of the recognized and somewhat hardwired hypervisors (like VMware, for example).Finally, there are about a dozen other places in the kernel that use the same
Makefileconstruct to make some code built-in even though the CONFIG option is set to "m". That may not be enough occurrences to make it standard practice, but Hyper-V guests are certainly not the only case.In my mind, this is judgment call with no absolute right answer. What do others think about the tradeoffs?
Quoted 8 lines
Quoted 5 lines
Wei had said in private message that he agrees this is a good idea. Nuno said earlier above:
"FWIW I think it's a good idea, interested to hear what others think."
That was before Michael pointed out the potential issues which I was unaware of. Let's see if there's a path that is smoother for all the downstream users who may be compiling with
CONFIG_HYPERV=m.
Ok, we've already thought of it for sometime and not able to come up with any. IMO, it's a minor hickup, not major. This is stalling upcoming iommu and other patches which will use CONFIG_HYPERV and add more dependencies, and it would be much harder to straighten out then. So I hope you guys can come up with some solution sooner than later, I can't think of any.
Thanks,
-Mukesh
Quoted 103 lines · Mukesh R
Quoted 93 lines · Nuno Das Neves
Quoted 33 lines · Mukesh R
Quoted 32 lines · Michael Kelley
From: Mukesh R <[email protected]> Sent: Wednesday, September 3, 2025 7:17 PM
Quoted 31 lines · Michael Kelley
Quoted 29 lines
From: Mukesh Rathor <[email protected]> Sent: Wednesday, August 27, 2025 6:00 PM
Quoted 6 lines
At present,
drivers/Makefilewill subst =m to =y forCONFIG_HYPERVfor hv subdir. Also,drivers/hv/Makefilereplaces =m to =y to build inhv_common.cthat is needed for the drivers. Moreover, vmbus driver is built ifCONFIG_HYPERis set, either loadable or builtin.Quoted 6 lines
This is not a good approach.
CONFIG_HYPERVis really an umbrella config that encompasses builtin code and various other things and not a dedicated config option for VMBUS. Vmbus should really have a config option just likeCONFIG_HYPERV_BALLOONetc. This small series introducesCONFIG_HYPERV_VMBUSto build VMBUS driver and make that distinction explicit. With thatCONFIG_HYPERVcould be changed to bool.Separating the core hypervisor support (
CONFIG_HYPERV) from the VMBus support (CONFIG_HYPERV_VMBUS) makes sense to me. Overall the code is already mostly in separate source files code, though there's some entanglement in the handling of VMBus interrupts, which could be improved later.However, I have a compatibility concern. Consider this scenario:
1) Assume running in a Hyper-V VM with a current Linux kernel version built with
CONFIG_HYPERV=m.
2) Grab a new version of kernel source code that contains this patch set.
3) Run 'make olddefconfig' to create the .config file for the new kernel.
4) Build the new kernel. This succeeds.
5) Install and run the new kernel in the Hyper-V VM. This fails.Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
The failure occurs because
CONFIG_HYPERV=mis no longer legal, so the .config file created in Step 3 hasCONFIG_HYPERV=n. The newly built kernel has no Hyper-V support and won't run in a Hyper-V VM.It surprises me a little that =m doesn't get 'fixed up' to =y in this case. I guess any invalid value turns to =n, which makes sense most of the time.
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
As a second issue, if in Step 1 the current kernel was built with
CONFIG_HYPERV=y, then the .config file for the new kernel will haveCONFIG_HYPERV=y, which is better. ButCONFIG_HYPERV_VMBUSdefaults to 'n', so the new kernel doesn't have any VMBus drivers and won't run in a typical Hyper-V VM.The second issue could be fixed by assigning
CONFIG_HYPERV_VMBUSa default value, such as whateverCONFIG_HYPERVis set to. But I'm not sure how to fix the first issue, except by continuing to allowCONFIG_HYPERV=m.I'm wondering, is there a path for this change, then? Are there some intermediate step/s we could take to minimize the problem?
Quoted 36 lines
Quoted 35 lines
Quoted 4 lines
To certain extent, imo, users are expected to check config files for changes when moving to new versions/releases, so it would be a one time burden.
I'm not so sanguine about the impact. For those of us who work with Hyper-V frequently, yes, it's probably not that big of an issue -- we can figure it out. But a lot of Azure/Hyper-V users aren't that familiar with the details of how the
Kconfigfiles are put together. And the issue occurs with no error messages that something has gone wrong in building the kernel, except that it won't boot. Just running "make olddefconfig" has worked in the past, so some users will be befuddled and end up generating Azure support incidents. I also wonder about breaking automated test suites for new kernels, as they are likely to be running "make olddefconfig" or something similar as part of the automation.Quoted 3 lines
CONFIG_HYPERV=mis just broken imo as one sees that in .config but magically symbols indrivers/hvare in kerenel.I agree that's not ideal. But note that some Hyper-V code and symbols like
ms_hyperv_init_platform()and related functions show up whenCONFIG_HYPERVISOR_GUEST=y, even ifCONFIG_HYPERV=n. That's the code inarch/x86/kernel/cpu/mshyperv.cand it's because Hyper-V is one of the recognized and somewhat hardwired hypervisors (like VMware, for example).Finally, there are about a dozen other places in the kernel that use the same
Makefileconstruct to make some code built-in even though the CONFIG option is set to "m". That may not be enough occurrences to make it standard practice, but Hyper-V guests are certainly not the only case.In my mind, this is judgment call with no absolute right answer. What do others think about the tradeoffs?
Quoted 8 lines
Quoted 5 lines
Wei had said in private message that he agrees this is a good idea. Nuno said earlier above:
"FWIW I think it's a good idea, interested to hear what others think."
That was before Michael pointed out the potential issues which I was unaware of. Let's see if there's a path that is smoother for all the downstream users who may be compiling with
CONFIG_HYPERV=m.
Quoted 6 lines
Ok, we've already thought of it for sometime and not able to come up with any. IMO, it's a minor hickup, not major. This is stalling upcoming iommu and other patches which will use
CONFIG_HYPERVand add more dependencies, and it would be much harder to straighten out then. So I hope you guys can come up with some solution sooner than later, I can't think of any.
Played around a bit, setting it to "default HYPERV" like Michael suggested gives it a default value of y. I thought it fail if one is bool and other is tristate. So that should help with transition.
Thanks,
-Mukesh