Skip to contentSkip to conversation

Intel Platform Monitoring Technology

PATCH Superseded David E. Box 5 participants 20 messages Oct 3, 2020 – Nov 10, 2020

Subsystems (4)

v8 of 9 Superseded Latest is v9 →

lore
Share & tools
lore

David E. Box

author maintainer
#0 lore raw

v8 cover Intel Platform Monitoring Technology

Intel Platform Monitoring Technology (PMT) is an architecture for enumerating and accessing hardware monitoring capabilities on a device. With customers increasingly asking for hardware telemetry, engineers not only have to figure out how to measure and collect data, but also how to deliver it and make it discoverable. The latter may be through some device specific method requiring device specific tools to collect the data. This in turn requires customers to manage a suite of different tools in order to collect the differing assortment of monitoring data on their systems. Even when such information can be provided in kernel drivers, they may require constant maintenance to update register mappings as they change with firmware updates and new versions of hardware. PMT provides a solution for discovering and reading telemetry from a device through a hardware agnostic framework that allows for updates to systems without requiring patches to the kernel or software tools.

PMT defines several capabilities to support collecting monitoring data from hardware. All are discoverable as separate instances of the PCIE Designated Vendor extended capability (DVSEC) with the Intel vendor code. The DVSEC ID field uniquely identifies the capability. Each DVSEC also provides a BAR offset to a header that defines capability-specific attributes, including GUID, feature type, offset and length, as well as configuration settings where applicable. The GUID uniquely identifies the register space of any monitor data exposed by the capability. The GUID is associated with an XML file from the vendor that describes the mapping of the register space along with properties of the monitor data. This allows vendors to perform firmware updates that can change the mapping (e.g. add new metrics) without requiring any changes to drivers or software tools. The new mapping is confirmed by an updated GUID, read from the hardware, which software uses with a new XML.

The current capabilities defined by PMT are Telemetry, Watcher, and Crashlog. The Telemetry capability provides access to a continuous block of read only data. The Watcher capability provides access to hardware sampling and tracing features. Crashlog provides access to device crash dumps. While there is some relationship between capabilities (Watcher can be configured to sample from the Telemetry data set) each exists as stand alone features with no dependency on any other. The design therefore splits them into individual, capability specific drivers. MFD is used to create platform devices for each capability so that they may be managed by their own driver. The PMT architecture is (for the most part) agnostic to the type of device it can collect from. Software can determine which devices support a PMT feature by searching through each device node entry in the sysfs class folder. It can additionally determine if a particular device supports a PMT feature by checking for a PMT class folder in the device folder.

This patch set provides support for the PMT framework, along with support for Telemetry on Tiger Lake.

Changes from V7:

- Refactor to minimize code duplication by putting more setup code in the common intel_pmt_dev_create().
- Add and use a function pointer to handle capability specific header decoding.
- Add comment on usage of early_client_pci_ids list and add Alder Lake PCI ID to the list.
- Remove unneeded check on the count variable in intel_pmt_read().
- Add missing header functions.
- Specify module names in Kconfig.
- Fix spelling errors across patch set.

Changes from V6:
- Use NULL for OOBMSM driver data instead of an empty struct. Rewrite the code to check for NULL driver_data.
- Fix spelling and formatting in Kconfig.
- Use MKDEV(0,0) to prevent unneeded device node from being created.

Changes from V5:
- Add Alder Lake and the "Out of Band Management Services Module (OOBMSM)" ids to the MFD driver. Transferred to this patch set.
- Use a single class for all PMT capabilities as suggested by Hans.
- Add binary attribute for telemetry driver to allow read syscall as suggested by Hans.
- Use the class file to hold attributes and other common code used by all PMT drivers.
- Add the crashlog driver to the patch set and add a mutex to protect access to the enable control and trigger files as suggested by Hans.

Changes from V4:
- Replace MFD with PMT in driver title
- Fix commit tags in chronological order
- Fix includes in alphabetical order
- Use 'raw' string instead of defines for device names
- Add an error message when returning an error code for unrecognized capability id
- Use dev_err instead of dev_warn for messages when returning an error
- Change while loop to call pci_find_next_ext_capability once
- Add missing continue in while loop
- Keep PCI platform defines using PCI_DEVICE_DATA magic tied to the pci_device_id table
- Comment and kernel message cleanup

Changes from V3:
- Write out full acronym for DVSEC in PCI patch commit message and add 'Designated' to comments
- remove unused variable caught by kernel test robot <[email protected]>
- Add required Co-developed-by signoffs, noted by Andy
- Allow access using new CAP_PERFMON capability as suggested by Alexey Bundankov
- Fix spacing in Kconfig, noted by Randy
- Other style changes and fixups suggested by Andy

Changes from V2:
- In order to handle certain HW bugs from the telemetry capability driver, create a single platform device per capability instead of a device per entry. Add the entry data as device resources and let the capability driver manage them as a set allowing for cleaner HW bug resolution.
- Handle discovery table offset bug in intel_pmt.c
- Handle overlapping regions in intel_pmt_telemetry.c
- Add description of sysfs class to testing ABI.
- Don't check size and count until confirming support for the PMT capability to avoid bailing out when we need to skip it.
- Remove unneeded header file. Move code to the intel_pmt.c, the only place where it's needed.
- Remove now unused platform data.
- Add missing header files types.h, bits.h.
- Rename file name and build options from telem to telemetry.
- Code cleanup suggested by Andy S.
- x86 mailing list added.

Changes from V1:
- In the telemetry driver, set the device in device_create() to the parent PCI device (the monitoring device) for clear association in sysfs. Was set before to the platform device created by the PCI parent.
- Move telem struct into driver and delete unneeded header file.
- Start telem device numbering from 0 instead of 1. 1 was used due to anticipated changes, no longer needed.
- Use helper macros suggested by Andy S.
- Rename class to pmt_telemetry, spelling out full name
- Move monitor device name defines to common header
- Coding style, spelling, and Makefile/MAINTAINERS ordering fixes

Alexander Duyck (3):
platform/x86: Intel PMT class driver platform/x86: Intel PMT Telemetry capability driver platform/x86: Intel PMT Crashlog capability driver

David E. Box (2):
PCI: Add defines for Designated Vendor-Specific Extended Capability
mfd: Intel Platform Monitoring Technology support

 .../ABI/testing/sysfs-class-intel_pmt         | 119 +++++++
 MAINTAINERS                                   |   6 +
 drivers/mfd/Kconfig                           |  10 +
 drivers/mfd/Makefile                          |   1 +
 drivers/mfd/intel_pmt.c                       | 226 ++++++++++++
 drivers/platform/x86/Kconfig                  |  34 ++
 drivers/platform/x86/Makefile                 |   3 +
 drivers/platform/x86/intel_pmt_class.c        | 297 ++++++++++++++++
 drivers/platform/x86/intel_pmt_class.h        |  52 +++
 drivers/platform/x86/intel_pmt_crashlog.c     | 328 ++++++++++++++++++
 drivers/platform/x86/intel_pmt_telemetry.c    | 160 +++++++++
 include/uapi/linux/pci_regs.h                 |   5 +
 12 files changed, 1241 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-class-intel_pmt
 create mode 100644 drivers/mfd/intel_pmt.c
 create mode 100644 drivers/platform/x86/intel_pmt_class.c
 create mode 100644 drivers/platform/x86/intel_pmt_class.h
 create mode 100644 drivers/platform/x86/intel_pmt_crashlog.c
 create mode 100644 drivers/platform/x86/intel_pmt_telemetry.c
Signature · 1 line
2.20.1
author maintainer
#1 lore raw

PATCH v8 1/5 PCI: Add defines for Designated Vendor-Specific Extended Capability

Add PCIe Designated Vendor-Specific Extended Capability (DVSEC) and defines for the header offsets. Defined in PCIe r5.0, sec 7.9.6.

---
 include/uapi/linux/pci_regs.h | 5 +++++
 1 file changed, 5 insertions(+)
include/uapi/linux/pci_regs.h +5 -0
index f9701410d3b5..beafeee39e44 100644
@@ -720,6 +720,7 @@
 #define PCI_EXT_CAP_ID_DPC	0x1D	/* Downstream Port Containment */
 #define PCI_EXT_CAP_ID_L1SS	0x1E	/* L1 PM Substates */
 #define PCI_EXT_CAP_ID_PTM	0x1F	/* Precision Time Measurement */
+#define PCI_EXT_CAP_ID_DVSEC	0x23	/* Designated Vendor-Specific */
 #define PCI_EXT_CAP_ID_DLF	0x25	/* Data Link Feature */
 #define PCI_EXT_CAP_ID_PL_16GT	0x26	/* Physical Layer 16.0 GT/s */
 #define PCI_EXT_CAP_ID_MAX	PCI_EXT_CAP_ID_PL_16GT
@@ -1062,6 +1063,10 @@
 #define  PCI_L1SS_CTL1_LTR_L12_TH_SCALE	0xe0000000  /* LTR_L1.2_THRESHOLD_Scale */
 #define PCI_L1SS_CTL2		0x0c	/* Control 2 Register */
 
+/* Designated Vendor-Specific (DVSEC, PCI_EXT_CAP_ID_DVSEC) */
+#define PCI_DVSEC_HEADER1		0x4 /* Designated Vendor-Specific Header1 */
+#define PCI_DVSEC_HEADER2		0x8 /* Designated Vendor-Specific Header2 */
+
 /* Data Link Feature */
 #define PCI_DLF_CAP		0x04	/* Capabilities Register */
 #define  PCI_DLF_EXCHANGE_ENABLE	0x80000000  /* Data Link Feature Exchange Enable */
Signature · 1 line
2.20.1
author maintainer
#2 lore raw

Re: [PATCH V8 1/5] PCI: Add defines for Designated Vendor-Specific Extended Capability

Hi Bjorn,

This patch has been acked and unchanged for weeks. Is it possible to get this pulled into next? We have SIOV and CXL related work that is using these definitions. Thanks.

David

Quoted 44 lines · David E. Box

Add PCIe Designated Vendor-Specific Extended Capability (DVSEC) and defines
for the header offsets. Defined in PCIe r5.0, sec 7.9.6.

---
 include/uapi/linux/pci_regs.h | 5 +++++
 1 file changed, 5 insertions(+)
include/uapi/linux/pci_regs.h +0 -0
index f9701410d3b5..beafeee39e44 100644
@@ -720,6 +720,7 @@
 #define PCI_EXT_CAP_ID_DPC	0x1D	/* Downstream Port

Containment */
#define PCI_EXT_CAP_ID_L1SS 0x1E /* L1 PM Substates */
#define PCI_EXT_CAP_ID_PTM 0x1F /* Precision Time Measurement
*/
+#define PCI_EXT_CAP_ID_DVSEC 0x23 /* Designated Vendor-Specific
*/
#define PCI_EXT_CAP_ID_DLF 0x25 /* Data Link Feature */
#define PCI_EXT_CAP_ID_PL_16GT 0x26 /* Physical Layer
16.0 GT/s */
#define PCI_EXT_CAP_ID_MAX PCI_EXT_CAP_ID_PL_16GT

include/uapi/linux/pci_regs.h +0 -0
@@ -1062,6 +1063,10 @@
 #define  PCI_L1SS_CTL1_LTR_L12_TH_SCALE	0xe0000000  /*

LTR_L1.2_THRESHOLD_Scale */
#define PCI_L1SS_CTL2 0x0c /* Control 2 Register
*/

include/uapi/linux/pci_regs.h +2 -0
+/* Designated Vendor-Specific (DVSEC, PCI_EXT_CAP_ID_DVSEC) */
+#define PCI_DVSEC_HEADER1		0x4 /* Designated Vendor-

Specific Header1 */
+#define PCI_DVSEC_HEADER2 0x8 /* Designated Vendor-
Specific Header2 */
+
/* Data Link Feature */
#define PCI_DLF_CAP 0x04 /* Capabilities Register */
#define PCI_DLF_EXCHANGE_ENABLE 0x80000000 /* Data Link
Feature Exchange Enable */

#3 lore raw

Re: [PATCH V8 1/5] PCI: Add defines for Designated Vendor-Specific Extended Capability

Quoted 5 lines · David E. Box

Hi Bjorn,

This patch has been acked and unchanged for weeks. Is it possible to get this pulled into next? We have SIOV and CXL related work that is using these definitions. Thanks.

I acked it because I expected you to merge it along with the rest of the series.

I guess I could merge this patch via the PCI tree if you really want, but that ends up being a hassle because we have to worry about which order things get merged to Linus' tree. Better if the whole series is merged via the same tree.

Quoted 46 lines · David E. Box
Quoted 44 lines

Add PCIe Designated Vendor-Specific Extended Capability (DVSEC) and defines
for the header offsets. Defined in PCIe r5.0, sec 7.9.6.

---
 include/uapi/linux/pci_regs.h | 5 +++++
 1 file changed, 5 insertions(+)
include/uapi/linux/pci_regs.h +0 -0
index f9701410d3b5..beafeee39e44 100644
@@ -720,6 +720,7 @@
 #define PCI_EXT_CAP_ID_DPC	0x1D	/* Downstream Port

Containment */
#define PCI_EXT_CAP_ID_L1SS 0x1E /* L1 PM Substates */
#define PCI_EXT_CAP_ID_PTM 0x1F /* Precision Time Measurement
*/
+#define PCI_EXT_CAP_ID_DVSEC 0x23 /* Designated Vendor-Specific
*/
#define PCI_EXT_CAP_ID_DLF 0x25 /* Data Link Feature */
#define PCI_EXT_CAP_ID_PL_16GT 0x26 /* Physical Layer
16.0 GT/s */
#define PCI_EXT_CAP_ID_MAX PCI_EXT_CAP_ID_PL_16GT

include/uapi/linux/pci_regs.h +0 -0
@@ -1062,6 +1063,10 @@
 #define  PCI_L1SS_CTL1_LTR_L12_TH_SCALE	0xe0000000  /*

LTR_L1.2_THRESHOLD_Scale */
#define PCI_L1SS_CTL2 0x0c /* Control 2 Register
*/

include/uapi/linux/pci_regs.h +2 -0
+/* Designated Vendor-Specific (DVSEC, PCI_EXT_CAP_ID_DVSEC) */
+#define PCI_DVSEC_HEADER1		0x4 /* Designated Vendor-

Specific Header1 */
+#define PCI_DVSEC_HEADER2 0x8 /* Designated Vendor-
Specific Header2 */
+
/* Data Link Feature */
#define PCI_DLF_CAP 0x04 /* Capabilities Register */
#define PCI_DLF_EXCHANGE_ENABLE 0x80000000 /* Data Link
Feature Exchange Enable */

author maintainer
#4 lore raw

Re: [PATCH V8 1/5] PCI: Add defines for Designated Vendor-Specific Extended Capability

Quoted 9 lines · Bjorn Helgaas
Quoted 7 lines · David E. Box

Hi Bjorn,

This patch has been acked and unchanged for weeks. Is it possible to
get this pulled into next? We have SIOV and CXL related work that is
using these definitions. Thanks.

Quoted 8 lines

I acked it because I expected you to merge it along with the rest of the series.

I guess I could merge this patch via the PCI tree if you really want, but that ends up being a hassle because we have to worry about which order things get merged to Linus' tree. Better if the whole series is
merged via the same tree.

Agreed. The hope is that this series is ready for the next merge window but no ack yet on V8. And if the series does not make it I'd like this patch to at least get in.

#5 lore raw

Re: [PATCH V8 1/5] PCI: Add defines for Designated Vendor-Specific Extended Capability

Quoted 19 lines · David E. Box
Quoted 9 lines · Bjorn Helgaas
Quoted 7 lines · David E. Box

Hi Bjorn,

This patch has been acked and unchanged for weeks. Is it possible to
get this pulled into next? We have SIOV and CXL related work that is
using these definitions. Thanks.

Quoted 8 lines

I acked it because I expected you to merge it along with the rest of the series.

I guess I could merge this patch via the PCI tree if you really want, but that ends up being a hassle because we have to worry about which order things get merged to Linus' tree. Better if the whole series is
merged via the same tree.

Quoted 3 lines

Agreed. The hope is that this series is ready for the next merge window but no ack yet on V8. And if the series does not make it I'd like this patch to at least get in.

If Bjorn is happy to take this patch so late in the release cycle then please go ahead. The other patches are due for v5.11.

Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
#6 lore raw

Re: [PATCH V8 1/5] PCI: Add defines for Designated Vendor-Specific Extended Capability

Hi,

Quoted 21 lines · Lee Jones
Quoted 19 lines · David E. Box
Quoted 17 lines · Bjorn Helgaas
Quoted 7 lines · David E. Box

Hi Bjorn,

This patch has been acked and unchanged for weeks. Is it possible to
get this pulled into next? We have SIOV and CXL related work that is
using these definitions. Thanks.

I acked it because I expected you to merge it along with the rest of the series.

I guess I could merge this patch via the PCI tree if you really want, but that ends up being a hassle because we have to worry about which order things get merged to Linus' tree. Better if the whole series is
merged via the same tree.

Quoted 6 lines
Quoted 3 lines

Agreed. The hope is that this series is ready for the next merge window but no ack yet on V8. And if the series does not make it I'd like this patch to at least get in.

If Bjorn is happy to take this patch so late in the release cycle then please go ahead. The other patches are due for v5.11.

I agree (that the other patches are for 5.11) talking about merging this series patch 2 is a mfd patch and patches 3-5 are drivers/platform/x86 patches.

Lee, FYI I'm taking over drivers/platform/x86 maintainership from Andy.

I suggest that we merge the entire series through a single tree (with acks or reviewed-by-s from the other maintainer) either through the mfd tree or through the drivers/platform/x86 tree. Since most changes are in drivers/platform/x86 the latter probably makes more sense, but either way works for me. So how would you like to proceed with this series ?

Regards,

Hans

#7 lore raw

Re: [PATCH V8 1/5] PCI: Add defines for Designated Vendor-Specific Extended Capability

Quoted 28 lines · Hans de Goede

Hi,

Quoted 25 lines · Lee Jones
Quoted 22 lines · David E. Box
Quoted 9 lines · Bjorn Helgaas
Quoted 7 lines · David E. Box

Hi Bjorn,

This patch has been acked and unchanged for weeks. Is it possible to
get this pulled into next? We have SIOV and CXL related work that is
using these definitions. Thanks.

Quoted 8 lines

I acked it because I expected you to merge it along with the rest of the series.

I guess I could merge this patch via the PCI tree if you really want, but that ends up being a hassle because we have to worry about which order things get merged to Linus' tree. Better if the whole series is
merged via the same tree.

Agreed. The hope is that this series is ready for the next merge window but no ack yet on V8. And if the series does not make it I'd like this patch to at least get in.

Quoted 8 lines
Quoted 2 lines

If Bjorn is happy to take this patch so late in the release cycle then please go ahead. The other patches are due for v5.11.

I agree (that the other patches are for 5.11) talking about merging this series patch 2 is a mfd patch and patches 3-5 are drivers/platform/x86 patches.

Lee, FYI I'm taking over drivers/platform/x86 maintainership from Andy.

Congratulations, Hans.

Quoted 6 lines

I suggest that we merge the entire series through a single tree (with acks or reviewed-by-s from the other maintainer) either through the mfd tree or through the drivers/platform/x86 tree. Since most changes are in drivers/platform/x86 the latter probably makes more sense, but either way works for me. So how would you like to proceed with this series ?

I'm happy either way, but bear in mind that, due to the intrinsic heterogeneous nature of MFD, I already have infrastructure to easily apply (and send pull-requests for) cross-subsystem patch-sets.

If however, you decide that you'd really like to take the set, that's also fine but I will require a pull-request from an immutable branch.

Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
#8 lore raw

Re: [PATCH V8 1/5] PCI: Add defines for Designated Vendor-Specific Extended Capability

Hi,

Quoted 48 lines · Lee Jones
Quoted 28 lines · Hans de Goede

Hi,

Quoted 25 lines · Lee Jones
Quoted 22 lines · David E. Box
Quoted 9 lines · Bjorn Helgaas
Quoted 7 lines · David E. Box

Hi Bjorn,

This patch has been acked and unchanged for weeks. Is it possible to
get this pulled into next? We have SIOV and CXL related work that is
using these definitions. Thanks.

Quoted 8 lines

I acked it because I expected you to merge it along with the rest of the series.

I guess I could merge this patch via the PCI tree if you really want, but that ends up being a hassle because we have to worry about which order things get merged to Linus' tree. Better if the whole series is
merged via the same tree.

Agreed. The hope is that this series is ready for the next merge window but no ack yet on V8. And if the series does not make it I'd like this patch to at least get in.

Quoted 8 lines
Quoted 2 lines

If Bjorn is happy to take this patch so late in the release cycle then please go ahead. The other patches are due for v5.11.

I agree (that the other patches are for 5.11) talking about merging this series patch 2 is a mfd patch and patches 3-5 are drivers/platform/x86 patches.

Lee, FYI I'm taking over drivers/platform/x86 maintainership from Andy.

Congratulations, Hans.

Quoted 6 lines

I suggest that we merge the entire series through a single tree (with acks or reviewed-by-s from the other maintainer) either through the mfd tree or through the drivers/platform/x86 tree. Since most changes are in drivers/platform/x86 the latter probably makes more sense, but either way works for me. So how would you like to proceed with this series ?

Quoted 3 lines

I'm happy either way, but bear in mind that, due to the intrinsic heterogeneous nature of MFD, I already have infrastructure to easily apply (and send pull-requests for) cross-subsystem patch-sets.

Ok, you applying the entire series to the mfd tree is fine with me.

I'll try to review the entire series next week and then we'll see from there.

Regards,

Hans

author maintainer
#9 lore raw

PATCH v8 2/5 mfd: Intel Platform Monitoring Technology support

In reply to David E. Box

Intel Platform Monitoring Technology (PMT) is an architecture for enumerating and accessing hardware monitoring facilities. PMT supports multiple types of monitoring capabilities. This driver creates platform devices for each type so that they may be managed by capability specific drivers (to be introduced). Capabilities are discovered using PCIe DVSEC ids. Support is included for the 3 current capability types, Telemetry, Watcher, and Crashlog. The features are available on new Intel platforms starting from Tiger Lake for which support is added. This patch adds support for Tiger Lake (TGL), Alder Lake (ADL), and Out-of-Band Management Services Module (OOBMSM).

Also add a quirk mechanism for several early hardware differences and bugs. For Tiger Lake and Alder Lake, do not support Watcher and Crashlog capabilities since they will not be compatible with future product. Also, fix use a quirk to fix the discovery table offset.

---
 MAINTAINERS             |   5 +
 drivers/mfd/Kconfig     |  10 ++
 drivers/mfd/Makefile    |   1 +
 drivers/mfd/intel_pmt.c | 226 ++++++++++++++++++++++++++++++++++++++++
 4 files changed, 242 insertions(+)
 create mode 100644 drivers/mfd/intel_pmt.c
MAINTAINERS +5 -0
index 190c7fa2ea01..0f2663b1d376 100644
@@ -8946,6 +8946,11 @@ F:	drivers/mfd/intel_soc_pmic*
 F:	include/linux/mfd/intel_msic.h
 F:	include/linux/mfd/intel_soc_pmic*
 
+INTEL PMT DRIVER
+M:	"David E. Box" <[email protected]>
+S:	Maintained
+F:	drivers/mfd/intel_pmt.c
+
 INTEL PRO/WIRELESS 2100, 2200BG, 2915ABG NETWORK CONNECTION SUPPORT
 M:	Stanislav Yakovlev <[email protected]>
 L:	[email protected]
drivers/mfd/Kconfig +10 -0
index 33df0837ab41..f092db50e518 100644
@@ -670,6 +670,16 @@ config MFD_INTEL_PMC_BXT
 	  Register and P-unit access. In addition this creates devices
 	  for iTCO watchdog and telemetry that are part of the PMC.
 
+config MFD_INTEL_PMT
+	tristate "Intel Platform Monitoring Technology (PMT) support"
+	depends on PCI
+	select MFD_CORE
+	help
+	  The Intel Platform Monitoring Technology (PMT) is an interface that
+	  provides access to hardware monitor registers. This driver supports
+	  Telemetry, Watcher, and Crashlog PMT capabilities/devices for
+	  platforms starting from Tiger Lake.
+
 config MFD_IPAQ_MICRO
 	bool "Atmel Micro ASIC (iPAQ h3100/h3600/h3700) Support"
 	depends on SA1100_H3100 || SA1100_H3600
drivers/mfd/Makefile +1 -0
index a60e5f835283..b9565d98ab09 100644
@@ -215,6 +215,7 @@ obj-$(CONFIG_MFD_INTEL_LPSS_PCI)	+= intel-lpss-pci.o
 obj-$(CONFIG_MFD_INTEL_LPSS_ACPI)	+= intel-lpss-acpi.o
 obj-$(CONFIG_MFD_INTEL_MSIC)	+= intel_msic.o
 obj-$(CONFIG_MFD_INTEL_PMC_BXT)	+= intel_pmc_bxt.o
+obj-$(CONFIG_MFD_INTEL_PMT)	+= intel_pmt.o
 obj-$(CONFIG_MFD_PALMAS)	+= palmas.o
 obj-$(CONFIG_MFD_VIPERBOARD)    += viperboard.o
 obj-$(CONFIG_MFD_RC5T583)	+= rc5t583.o rc5t583-irq.o
drivers/mfd/intel_pmt.c new file +226 -0

226 lines not on this page · raw message

Signature · 1 line
2.20.1
#10 lore raw

Re: [PATCH V8 2/5] mfd: Intel Platform Monitoring Technology support

Quoted 20 lines · David E. Box

Intel Platform Monitoring Technology (PMT) is an architecture for enumerating and accessing hardware monitoring facilities. PMT supports multiple types of monitoring capabilities. This driver creates platform devices for each type so that they may be managed by capability specific drivers (to be introduced). Capabilities are discovered using PCIe DVSEC ids. Support is included for the 3 current capability types, Telemetry, Watcher, and Crashlog. The features are available on new Intel platforms starting from Tiger Lake for which support is added. This patch adds support for Tiger Lake (TGL), Alder Lake (ADL), and Out-of-Band Management Services Module (OOBMSM).

Also add a quirk mechanism for several early hardware differences and bugs. For Tiger Lake and Alder Lake, do not support Watcher and Crashlog capabilities since they will not be compatible with future product. Also, fix use a quirk to fix the discovery table offset.

Quoted 7 lines
---
 MAINTAINERS             |   5 +
 drivers/mfd/Kconfig     |  10 ++
 drivers/mfd/Makefile    |   1 +
 drivers/mfd/intel_pmt.c | 226 ++++++++++++++++++++++++++++++++++++++++
 4 files changed, 242 insertions(+)
 create mode 100644 drivers/mfd/intel_pmt.c

I Acked this back in August.

Any reason why you didn't carry it forward?

Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
author maintainer
#11 lore raw

Re: [PATCH V8 2/5] mfd: Intel Platform Monitoring Technology support

Quoted 42 lines · Lee Jones
Quoted 31 lines · David E. Box

Intel Platform Monitoring Technology (PMT) is an architecture for enumerating and accessing hardware monitoring facilities. PMT supports
multiple types of monitoring capabilities. This driver creates platform
devices for each type so that they may be managed by capability specific
drivers (to be introduced). Capabilities are discovered using PCIe DVSEC
ids. Support is included for the 3 current capability types, Telemetry,
Watcher, and Crashlog. The features are available on new Intel platforms
starting from Tiger Lake for which support is added. This patch adds
support for Tiger Lake (TGL), Alder Lake (ADL), and Out-of-Band Management
Services Module (OOBMSM).

Also add a quirk mechanism for several early hardware differences and bugs.
For Tiger Lake and Alder Lake, do not support Watcher and Crashlog capabilities since they will not be compatible with future product. Also,
fix use a quirk to fix the discovery table offset.

Quoted 1 line
Quoted 8 lines
---
 MAINTAINERS             |   5 +
 drivers/mfd/Kconfig     |  10 ++
 drivers/mfd/Makefile    |   1 +
 drivers/mfd/intel_pmt.c | 226
++++++++++++++++++++++++++++++++++++++++
 4 files changed, 242 insertions(+)
 create mode 100644 drivers/mfd/intel_pmt.c
Quoted 3 lines

I Acked this back in August.

Any reason why you didn't carry it forward?

So that you could review changes made after the Ack. You did and you requested fixups which were made. Please let me know if this is not preferred. Thanks.

David

#12 lore raw

Re: [PATCH V8 2/5] mfd: Intel Platform Monitoring Technology support

Quoted 43 lines · David E. Box
Quoted 42 lines · Lee Jones
Quoted 39 lines · David E. Box

Intel Platform Monitoring Technology (PMT) is an architecture for enumerating and accessing hardware monitoring facilities. PMT supports
multiple types of monitoring capabilities. This driver creates platform
devices for each type so that they may be managed by capability specific
drivers (to be introduced). Capabilities are discovered using PCIe DVSEC
ids. Support is included for the 3 current capability types, Telemetry,
Watcher, and Crashlog. The features are available on new Intel platforms
starting from Tiger Lake for which support is added. This patch adds
support for Tiger Lake (TGL), Alder Lake (ADL), and Out-of-Band Management
Services Module (OOBMSM).

Also add a quirk mechanism for several early hardware differences and bugs.
For Tiger Lake and Alder Lake, do not support Watcher and Crashlog capabilities since they will not be compatible with future product. Also,
fix use a quirk to fix the discovery table offset.

Quoted 1 line
---
 MAINTAINERS             |   5 +
 drivers/mfd/Kconfig     |  10 ++
 drivers/mfd/Makefile    |   1 +
 drivers/mfd/intel_pmt.c | 226
++++++++++++++++++++++++++++++++++++++++
 4 files changed, 242 insertions(+)
 create mode 100644 drivers/mfd/intel_pmt.c
Quoted 6 lines
Quoted 3 lines

I Acked this back in August.

Any reason why you didn't carry it forward?

So that you could review changes made after the Ack. Please let me know if this is not preferred. Thanks.

No, that is the correct way to do things (see below).

Quoted 1 line

You did and you requested fixups which were made.

Keeping the status of each and every patch-set currently in my inbox would be a very difficult task.

This is why I recommend patch-level changelogs (just below the '---' marker).

Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
#13 lore raw

Re: [PATCH V8 2/5] mfd: Intel Platform Monitoring Technology support

In reply to David E. Box

Hi David,

Quoted 16 lines · David E. Box

Intel Platform Monitoring Technology (PMT) is an architecture for enumerating and accessing hardware monitoring facilities. PMT supports multiple types of monitoring capabilities. This driver creates platform devices for each type so that they may be managed by capability specific drivers (to be introduced). Capabilities are discovered using PCIe DVSEC ids. Support is included for the 3 current capability types, Telemetry, Watcher, and Crashlog. The features are available on new Intel platforms starting from Tiger Lake for which support is added. This patch adds support for Tiger Lake (TGL), Alder Lake (ADL), and Out-of-Band Management Services Module (OOBMSM).

Also add a quirk mechanism for several early hardware differences and bugs. For Tiger Lake and Alder Lake, do not support Watcher and Crashlog capabilities since they will not be compatible with future product. Also, fix use a quirk to fix the discovery table offset.

Quoted 4 lines

Thanks for your patch, which is now commit 4f8217d5b0ca8ace ("mfd: Intel Platform Monitoring Technology support") in the mfd/for-mfd-next.

drivers/mfd/Kconfig config MFD_INTEL_PMC_BXT · line 675

Quoted 9 lines
drivers/mfd/Kconfig +3 -0
@@ -670,6 +670,16 @@ config MFD_INTEL_PMC_BXT
          Register and P-unit access. In addition this creates devices
          for iTCO watchdog and telemetry that are part of the PMC.
 
+config MFD_INTEL_PMT
+       tristate "Intel Platform Monitoring Technology (PMT) support"
+       depends on PCI

Does this need a "depend on X86 || COMPILE_TEST", to prevent the question from showing up on platforms where the PMT cannot be present?

I see the TGL and ADL PCI IDs are also referenced from drivers/platform/x86/intel_pmt_telemetry.c, which suggests this is X86-only. Perhaps the OOBMSM is a PCI device that can be used on non-X86 platforms?

drivers/mfd/Kconfig config MFD_INTEL_PMC_BXT · line 682

Quoted 7 lines
drivers/mfd/Kconfig +7 -0
+       select MFD_CORE
+       help
+         The Intel Platform Monitoring Technology (PMT) is an interface that
+         provides access to hardware monitor registers. This driver supports
+         Telemetry, Watcher, and Crashlog PMT capabilities/devices for
+         platforms starting from Tiger Lake.
+

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
author maintainer
#14 lore raw

Re: [PATCH V8 2/5] mfd: Intel Platform Monitoring Technology support

Hi Geert,

Quoted 47 lines · Geert Uytterhoeven

Hi David,

Quoted 26 lines · David E. Box

Intel Platform Monitoring Technology (PMT) is an architecture for enumerating and accessing hardware monitoring facilities. PMT supports
multiple types of monitoring capabilities. This driver creates platform
devices for each type so that they may be managed by capability specific
drivers (to be introduced). Capabilities are discovered using PCIe DVSEC
ids. Support is included for the 3 current capability types, Telemetry,
Watcher, and Crashlog. The features are available on new Intel platforms
starting from Tiger Lake for which support is added. This patch adds
support for Tiger Lake (TGL), Alder Lake (ADL), and Out-of-Band Management
Services Module (OOBMSM).

Also add a quirk mechanism for several early hardware differences and bugs.
For Tiger Lake and Alder Lake, do not support Watcher and Crashlog capabilities since they will not be compatible with future product. Also,
fix use a quirk to fix the discovery table offset.

Quoted 5 lines
Quoted 1 line

Thanks for your patch, which is now commit 4f8217d5b0ca8ace ("mfd:
Intel
Platform Monitoring Technology support") in the mfd/for-mfd-next.

Quoted 7 lines
drivers/mfd/Kconfig +0 -0
@@ -670,6 +670,16 @@ config MFD_INTEL_PMC_BXT
          Register and P-unit access. In addition this creates

devices
for iTCO watchdog and telemetry that are part of the PMC.

Quoted 8 lines
Quoted 4 lines
drivers/mfd/Kconfig +2 -0
+config MFD_INTEL_PMT
+       tristate "Intel Platform Monitoring Technology (PMT)

support"
+ depends on PCI

Does this need a "depend on X86 || COMPILE_TEST", to prevent the question from showing up on platforms where the PMT cannot be present?

Though not currently available on non X86 hardware it is not restricted. The use of PCIE Designated Vendor Specific Capability (DVSEC) was to specifically allow use of this IP by other vendors.

Quoted 6 lines

I see the TGL and ADL PCI IDs are also referenced from drivers/platform/x86/intel_pmt_telemetry.c, which suggests this is X86-only.
Perhaps the OOBMSM is a PCI device that can be used on non-X86 platforms?

TGL and AGL are only referenced in this driver because they require quirks.

Thanks

David

author maintainer
#15 lore raw

PATCH v8 3/5 platform/x86: Intel PMT class driver

In reply to David E. Box

From: Alexander Duyck <[email protected]>

Intel Platform Monitoring Technology is meant to provide a common way to access telemetry and system metrics.

Register mappings are not provided by the driver. Instead, a GUID is read from a header for each endpoint. The GUID identifies the device and is to be used with an XML, provided by the vendor, to discover the available set of metrics and their register mapping. This allows firmware updates to modify the register space without needing to update the driver every time with new mappings. Firmware writes a new GUID in this case to specify the new mapping. Software tools with access to the associated XML file can then interpret the changes.

The module manages access to all Intel PMT endpoints on a system, independent of the device exporting them. It creates an intel_pmt class to manage the devices. For each telemetry endpoint, sysfs files provide GUID and size information as well as a pointer to the parent device the telemetry came from. Software may discover the association between endpoints and devices by iterating through the list in sysfs, or by looking for the existence of the class folder under the device of interest. A binary sysfs attribute of the same name allows software to then read or map the telemetry space for direct access.

---
 .../ABI/testing/sysfs-class-intel_pmt         |  54 ++++
 MAINTAINERS                                   |   1 +
 drivers/platform/x86/Kconfig                  |  12 +
 drivers/platform/x86/Makefile                 |   1 +
 drivers/platform/x86/intel_pmt_class.c        | 297 ++++++++++++++++++
 drivers/platform/x86/intel_pmt_class.h        |  52 +++
 6 files changed, 417 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-class-intel_pmt
 create mode 100644 drivers/platform/x86/intel_pmt_class.c
 create mode 100644 drivers/platform/x86/intel_pmt_class.h
Documentation/ABI/testing/sysfs-class-intel_pmt new file +54 -0
new file mode 100644
index 000000000000..926b5cf95fd1
@@ -0,0 +1,54 @@
+What:		/sys/class/intel_pmt/
+Date:		October 2020
+KernelVersion:	5.10
+Contact:	David Box <[email protected]>
+Description:
+		The intel_pmt/ class directory contains information for
+		devices that expose hardware telemetry using Intel Platform
+		Monitoring Technology (PMT)
+
+What:		/sys/class/intel_pmt/telem<x>
+Date:		October 2020
+KernelVersion:	5.10
+Contact:	David Box <[email protected]>
+Description:
+		The telem<x> directory contains files describing an instance of
+		a PMT telemetry device that exposes hardware telemetry. Each
+		telem<x> directory has an associated telem file. This file
+		may be opened and mapped or read to access the telemetry space
+		of the device. The register layout of the telemetry space is
+		determined from an XML file that matches the PCI device id and
+		GUID for the device.
+
+What:		/sys/class/intel_pmt/telem<x>/telem
+Date:		October 2020
+KernelVersion:	5.10
+Contact:	David Box <[email protected]>
+Description:
+		(RO) The telemetry data for this telemetry device. This file
+		may be mapped or read to obtain the data.
+
+What:		/sys/class/intel_pmt/telem<x>/guid
+Date:		October 2020
+KernelVersion:	5.10
+Contact:	David Box <[email protected]>
+Description:
+		(RO) The GUID for this telemetry device. The GUID identifies
+		the version of the XML file for the parent device that is to
+		be used to get the register layout.
+
+What:		/sys/class/intel_pmt/telem<x>/size
+Date:		October 2020
+KernelVersion:	5.10
+Contact:	David Box <[email protected]>
+Description:
+		(RO) The size of telemetry region in bytes that corresponds to
+		the mapping size for the telem file.
+
+What:		/sys/class/intel_pmt/telem<x>/offset
+Date:		October 2020
+KernelVersion:	5.10
+Contact:	David Box <[email protected]>
+Description:
+		(RO) The offset of telemetry region in bytes that corresponds to
+		the mapping for the telem file.
MAINTAINERS +1 -0
index 0f2663b1d376..47fdb8a6e151 100644
@@ -8950,6 +8950,7 @@ INTEL PMT DRIVER
 M:	"David E. Box" <[email protected]>
 S:	Maintained
 F:	drivers/mfd/intel_pmt.c
+F:	drivers/platform/x86/intel_pmt_*
 
 INTEL PRO/WIRELESS 2100, 2200BG, 2915ABG NETWORK CONNECTION SUPPORT
 M:	Stanislav Yakovlev <[email protected]>
drivers/platform/x86/Kconfig +12 -0
index 40219bba6801..12431e0e974d 100644
@@ -1360,6 +1360,18 @@ config INTEL_PMC_CORE
 		- LTR Ignore
 		- MPHY/PLL gating status (Sunrisepoint PCH only)
 
+config INTEL_PMT_CLASS
+	tristate "Intel Platform Monitoring Technology (PMT) Class driver"
+	help
+	  The Intel Platform Monitoring Technology (PMT) class driver provides
+	  the basic sysfs interface and file hierarchy uses by PMT devices.
+
+	  For more information, see:
+	  <file:Documentation/ABI/testing/sysfs-class-intel_pmt>
+
+	  To compile this driver as a module, choose M here: the module
+	  will be called intel_pmt_class.
+
 config INTEL_PUNIT_IPC
 	tristate "Intel P-Unit IPC Driver"
 	help
drivers/platform/x86/Makefile +1 -0
index 5f823f7eff45..f4b1f87f2401 100644
@@ -140,6 +140,7 @@ obj-$(CONFIG_INTEL_MFLD_THERMAL)	+= intel_mid_thermal.o
 obj-$(CONFIG_INTEL_MID_POWER_BUTTON)	+= intel_mid_powerbtn.o
 obj-$(CONFIG_INTEL_MRFLD_PWRBTN)	+= intel_mrfld_pwrbtn.o
 obj-$(CONFIG_INTEL_PMC_CORE)		+= intel_pmc_core.o intel_pmc_core_pltdrv.o
+obj-$(CONFIG_INTEL_PMT_CLASS)		+= intel_pmt_class.o
 obj-$(CONFIG_INTEL_PUNIT_IPC)		+= intel_punit_ipc.o
 obj-$(CONFIG_INTEL_SCU_IPC)		+= intel_scu_ipc.o
 obj-$(CONFIG_INTEL_SCU_PCI)		+= intel_scu_pcidrv.o
drivers/platform/x86/intel_pmt_class.c new file +297 -0

297 lines not on this page · raw message

drivers/platform/x86/intel_pmt_class.h new file +52 -0

52 lines not on this page · raw message

Signature · 1 line
2.20.1
author maintainer
#16 lore raw

PATCH v8 4/5 platform/x86: Intel PMT Telemetry capability driver

In reply to David E. Box

From: Alexander Duyck <[email protected]>

PMT Telemetry is a capability of the Intel Platform Monitoring Technology. The Telemetry capability provides access to device telemetry metrics that provide hardware performance data to users from read-only register spaces.

With this driver present the intel_pmt directory can be populated with telem<x> devices. These devices will contain the standard intel_pmt sysfs data and a "telem" binary sysfs attribute which can be used to access the telemetry data.

Also create a PCI device id list for early telemetry hardware that require workarounds for known issues.

---
 drivers/platform/x86/Kconfig               |  11 ++
 drivers/platform/x86/Makefile              |   1 +
 drivers/platform/x86/intel_pmt_telemetry.c | 160 +++++++++++++++++++++
 3 files changed, 172 insertions(+)
 create mode 100644 drivers/platform/x86/intel_pmt_telemetry.c
drivers/platform/x86/Kconfig +11 -0
index 12431e0e974d..90b4c1bd9532 100644
@@ -1372,6 +1372,17 @@ config INTEL_PMT_CLASS
 	  To compile this driver as a module, choose M here: the module
 	  will be called intel_pmt_class.
 
+config INTEL_PMT_TELEMETRY
+	tristate "Intel Platform Monitoring Technology (PMT) Telemetry driver"
+	select INTEL_PMT_CLASS
+	help
+	  The Intel Platform Monitory Technology (PMT) Telemetry driver provides
+	  access to hardware telemetry metrics on devices that support the
+	  feature.
+
+	  To compile this driver as a module, choose M here: the module
+	  will be called intel_pmt_telemetry.
+
 config INTEL_PUNIT_IPC
 	tristate "Intel P-Unit IPC Driver"
 	help
drivers/platform/x86/Makefile +1 -0
index f4b1f87f2401..6a7b61f59ea8 100644
@@ -141,6 +141,7 @@ obj-$(CONFIG_INTEL_MID_POWER_BUTTON)	+= intel_mid_powerbtn.o
 obj-$(CONFIG_INTEL_MRFLD_PWRBTN)	+= intel_mrfld_pwrbtn.o
 obj-$(CONFIG_INTEL_PMC_CORE)		+= intel_pmc_core.o intel_pmc_core_pltdrv.o
 obj-$(CONFIG_INTEL_PMT_CLASS)		+= intel_pmt_class.o
+obj-$(CONFIG_INTEL_PMT_TELEMETRY)	+= intel_pmt_telemetry.o
 obj-$(CONFIG_INTEL_PUNIT_IPC)		+= intel_punit_ipc.o
 obj-$(CONFIG_INTEL_SCU_IPC)		+= intel_scu_ipc.o
 obj-$(CONFIG_INTEL_SCU_PCI)		+= intel_scu_pcidrv.o
drivers/platform/x86/intel_pmt_telemetry.c new file +160 -0

160 lines not on this page · raw message

Signature · 1 line
2.20.1
author maintainer
#17 lore raw

PATCH v8 5/5 platform/x86: Intel PMT Crashlog capability driver

In reply to David E. Box

From: Alexander Duyck <[email protected]>

Add support for the Intel Platform Monitoring Technology crashlog interface. This interface provides a few sysfs values to allow for controlling the crashlog telemetry interface as well as a character driver to allow for mapping the crashlog memory region so that it can be accessed after a crashlog has been recorded.

This driver is meant to only support the server version of the crashlog which is identified as crash_type 1 with a version of zero. Currently no other types are supported.

---
 .../ABI/testing/sysfs-class-intel_pmt         |  65 ++++
 drivers/platform/x86/Kconfig                  |  11 +
 drivers/platform/x86/Makefile                 |   1 +
 drivers/platform/x86/intel_pmt_crashlog.c     | 328 ++++++++++++++++++
 4 files changed, 405 insertions(+)
 create mode 100644 drivers/platform/x86/intel_pmt_crashlog.c
Documentation/ABI/testing/sysfs-class-intel_pmt +65 -0
index 926b5cf95fd1..ed4c886a21b1 100644
@@ -52,3 +52,68 @@ Contact:	David Box <[email protected]>
 Description:
 		(RO) The offset of telemetry region in bytes that corresponds to
 		the mapping for the telem file.
+
+What:		/sys/class/intel_pmt/crashlog<x>
+Date:		October 2020
+KernelVersion:	5.10
+Contact:	Alexander Duyck <[email protected]>
+Description:
+		The crashlog<x> directory contains files for configuring an
+		instance of a PMT crashlog device that can perform crash data
+		recording. Each crashlog<x> device has an associated crashlog
+		file. This file can be opened and mapped or read to access the
+		resulting crashlog buffer. The register layout for the buffer
+		can be determined from an XML file of specified GUID for the
+		parent device.
+
+What:		/sys/class/intel_pmt/crashlog<x>/crashlog
+Date:		October 2020
+KernelVersion:	5.10
+Contact:	David Box <[email protected]>
+Description:
+		(RO) The crashlog buffer for this crashlog device. This file
+		may be mapped or read to obtain the data.
+
+What:		/sys/class/intel_pmt/crashlog<x>/guid
+Date:		October 2020
+KernelVersion:	5.10
+Contact:	Alexander Duyck <[email protected]>
+Description:
+		(RO) The GUID for this crashlog device. The GUID identifies the
+		version of the XML file for the parent device that should be
+		used to determine the register layout.
+
+What:		/sys/class/intel_pmt/crashlog<x>/size
+Date:		October 2020
+KernelVersion:	5.10
+Contact:	Alexander Duyck <[email protected]>
+Description:
+		(RO) The length of the result buffer in bytes that corresponds
+		to the size for the crashlog buffer.
+
+What:		/sys/class/intel_pmt/crashlog<x>/offset
+Date:		October 2020
+KernelVersion:	5.10
+Contact:	Alexander Duyck <[email protected]>
+Description:
+		(RO) The offset of the buffer in bytes that corresponds
+		to the mapping for the crashlog device.
+
+What:		/sys/class/intel_pmt/crashlog<x>/enable
+Date:		October 2020
+KernelVersion:	5.10
+Contact:	Alexander Duyck <[email protected]>
+Description:
+		(RW) Boolean value controlling if the crashlog functionality
+		is enabled for the crashlog device.
+
+What:		/sys/class/intel_pmt/crashlog<x>/trigger
+Date:		October 2020
+KernelVersion:	5.10
+Contact:	Alexander Duyck <[email protected]>
+Description:
+		(RW) Boolean value controlling the triggering of the crashlog
+		device node. When read it provides data on if the crashlog has
+		been triggered. When written to it can be used to either clear
+		the current trigger by writing false, or to trigger a new
+		event if the trigger is not currently set.
drivers/platform/x86/Kconfig +11 -0
index 90b4c1bd9532..4ac555a9916b 100644
@@ -1383,6 +1383,17 @@ config INTEL_PMT_TELEMETRY
 	  To compile this driver as a module, choose M here: the module
 	  will be called intel_pmt_telemetry.
 
+config INTEL_PMT_CRASHLOG
+	tristate "Intel Platform Monitoring Technology (PMT) Crashlog driver"
+	select INTEL_PMT_CLASS
+	help
+	  The Intel Platform Monitoring Technology (PMT) crashlog driver provides
+	  access to hardware crashlog capabilities on devices that support the
+	  feature.
+
+	  To compile this driver as a module, choose M here: the module
+	  will be called intel_pmt_crashlog.
+
 config INTEL_PUNIT_IPC
 	tristate "Intel P-Unit IPC Driver"
 	help
drivers/platform/x86/Makefile +1 -0
index 6a7b61f59ea8..ca82c1344977 100644
@@ -142,6 +142,7 @@ obj-$(CONFIG_INTEL_MRFLD_PWRBTN)	+= intel_mrfld_pwrbtn.o
 obj-$(CONFIG_INTEL_PMC_CORE)		+= intel_pmc_core.o intel_pmc_core_pltdrv.o
 obj-$(CONFIG_INTEL_PMT_CLASS)		+= intel_pmt_class.o
 obj-$(CONFIG_INTEL_PMT_TELEMETRY)	+= intel_pmt_telemetry.o
+obj-$(CONFIG_INTEL_PMT_CRASHLOG)	+= intel_pmt_crashlog.o
 obj-$(CONFIG_INTEL_PUNIT_IPC)		+= intel_punit_ipc.o
 obj-$(CONFIG_INTEL_SCU_IPC)		+= intel_scu_ipc.o
 obj-$(CONFIG_INTEL_SCU_PCI)		+= intel_scu_pcidrv.o
drivers/platform/x86/intel_pmt_crashlog.c new file +328 -0

328 lines not on this page · raw message

Signature · 1 line
2.20.1
Reviewed-by on the v8 series
#18 lore raw
In reply to David E. Box

Hi,

Quoted 46 lines · David E. Box

Intel Platform Monitoring Technology (PMT) is an architecture for enumerating and accessing hardware monitoring capabilities on a device. With customers increasingly asking for hardware telemetry, engineers not only have to figure out how to measure and collect data, but also how to deliver it and make it discoverable. The latter may be through some device specific method requiring device specific tools to collect the data. This in turn requires customers to manage a suite of different tools in order to collect the differing assortment of monitoring data on their systems. Even when such information can be provided in kernel drivers, they may require constant maintenance to update register mappings as they change with firmware updates and new versions of hardware. PMT provides a solution for discovering and reading telemetry from a device through a hardware agnostic framework that allows for updates to systems without requiring patches to the kernel or software tools.

PMT defines several capabilities to support collecting monitoring data from hardware. All are discoverable as separate instances of the PCIE Designated Vendor extended capability (DVSEC) with the Intel vendor code. The DVSEC ID field uniquely identifies the capability. Each DVSEC also provides a BAR offset to a header that defines capability-specific attributes, including GUID, feature type, offset and length, as well as configuration settings where applicable. The GUID uniquely identifies the register space of any monitor data exposed by the capability. The GUID is associated with an XML file from the vendor that describes the mapping of the register space along with properties of the monitor data. This allows vendors to perform firmware updates that can change the mapping (e.g. add new metrics) without requiring any changes to drivers or software tools. The new mapping is confirmed by an updated GUID, read from the hardware, which software uses with a new XML.

The current capabilities defined by PMT are Telemetry, Watcher, and Crashlog. The Telemetry capability provides access to a continuous block of read only data. The Watcher capability provides access to hardware sampling and tracing features. Crashlog provides access to device crash dumps. While there is some relationship between capabilities (Watcher can be configured to sample from the Telemetry data set) each exists as stand alone features with no dependency on any other. The design therefore splits them into individual, capability specific drivers. MFD is used to create platform devices for each capability so that they may be managed by their own driver. The PMT architecture is (for the most part) agnostic to the type of device it can collect from. Software can determine which devices support a PMT feature by searching through each device node entry in the sysfs class folder. It can additionally determine if a particular device supports a PMT feature by checking for a PMT class folder in the device folder.

Quoted 2 lines

This patch set provides support for the PMT framework, along with support for Telemetry on Tiger Lake.

The entire series looks good to me, so you may add my:

To the entire series.

Lee, in the discussion about previous versions you indicated that you would be happy to merge the entire series through the MFD tree.

From my pov this is ready for merging, so if you can pick up the entire series and then provide me with an immutable branch to merge into the pdx86 tree that would be great.

Regards,

Hans

author maintainer
#19 lore raw
Quoted 86 lines · Hans de Goede

Hi,

Quoted 83 lines · David E. Box

Intel Platform Monitoring Technology (PMT) is an architecture for enumerating and accessing hardware monitoring capabilities on a device.
With customers increasingly asking for hardware telemetry, engineers not
only have to figure out how to measure and collect data, but also how to
deliver it and make it discoverable. The latter may be through some device
specific method requiring device specific tools to collect the data. This
in turn requires customers to manage a suite of different tools in order to
collect the differing assortment of monitoring data on their systems. Even
when such information can be provided in kernel drivers, they may require
constant maintenance to update register mappings as they change with
firmware updates and new versions of hardware. PMT provides a solution for
discovering and reading telemetry from a device through a hardware agnostic
framework that allows for updates to systems without requiring patches to
the kernel or software tools.

PMT defines several capabilities to support collecting monitoring data from
hardware. All are discoverable as separate instances of the PCIE Designated
Vendor extended capability (DVSEC) with the Intel vendor code. The DVSEC ID
field uniquely identifies the capability. Each DVSEC also provides a BAR
offset to a header that defines capability-specific attributes, including
GUID, feature type, offset and length, as well as configuration settings
where applicable. The GUID uniquely identifies the register space of any
monitor data exposed by the capability. The GUID is associated with an XML
file from the vendor that describes the mapping of the register space along
with properties of the monitor data. This allows vendors to perform firmware updates that can change the mapping (e.g. add new metrics) without
requiring any changes to drivers or software tools. The new mapping is
confirmed by an updated GUID, read from the hardware, which software uses
with a new XML.

The current capabilities defined by PMT are Telemetry, Watcher, and Crashlog. The Telemetry capability provides access to a continuous block
of read only data. The Watcher capability provides access to hardware
sampling and tracing features. Crashlog provides access to device crash
dumps. While there is some relationship between capabilities (Watcher can
be configured to sample from the Telemetry data set) each exists as stand
alone features with no dependency on any other. The design therefore splits
them into individual, capability specific drivers. MFD is used to create
platform devices for each capability so that they may be managed by their
own driver. The PMT architecture is (for the most part) agnostic to the
type of device it can collect from. Software can determine which devices
support a PMT feature by searching through each device node entry in the
sysfs class folder. It can additionally determine if a particular device
supports a PMT feature by checking for a PMT class folder in the device
folder.

Quoted 7 lines
Quoted 3 lines

This patch set provides support for the PMT framework, along with support
for Telemetry on Tiger Lake.

The entire series looks good to me, so you may add my:

Thanks. I did send out a V9 after rebasing and noticing that I accidentally dropped a change in the MFD driver between V7 and V8. This was added back. I also took the opportunity to get rid of a nuisance dev_warn.

David