Skip to contentSkip to conversation

tools: ipxe: update for fixing build with GCC11

PATCH Superseded Olaf Hering 4 participants 6 messages Jun 15, 2021 – Jun 17, 2021

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools: ipxe: update for fixing build with GCC11

Use a snapshot which includes commit f3f568e382a5f19824b3bfc6081cde39eee661e8 ("[crypto] Add memory output constraints for big-integer inline assembly"), which fixes build with gcc11.

---
 tools/firmware/etherboot/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/firmware/etherboot/Makefile +2 -1
index ed9e11305f..23b3f6ca9d 100644
@@ -10,7 +10,8 @@ else
 IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git
 endif
 
-IPXE_GIT_TAG := 988d2c13cdf0f0b4140685af35ced70ac5b3283c
+# put an updated tar.gz on xenbits after changes to this variable
+IPXE_GIT_TAG := bf4ccd4265ac614fbfa38bf168b6eeaf4c17d51e
 
 IPXE_TARBALL_URL ?= $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz
 
#1 lore raw
Quoted 15 lines · Olaf Hering

Use a snapshot which includes commit f3f568e382a5f19824b3bfc6081cde39eee661e8 ("[crypto] Add memory output constraints for big-integer inline assembly"), which fixes build with gcc11.

---
 tools/firmware/etherboot/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/firmware/etherboot/Makefile +0 -0
index ed9e11305f..23b3f6ca9d 100644

tools/firmware/etherboot/Makefile else · line 14

Quoted 6 lines
tools/firmware/etherboot/Makefile +2 -1
@@ -10,7 +10,8 @@ else
 IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git
 endif
 
-IPXE_GIT_TAG := 988d2c13cdf0f0b4140685af35ced70ac5b3283c
+# put an updated tar.gz on xenbits after changes to this variable
+IPXE_GIT_TAG := bf4ccd4265ac614fbfa38bf168b6eeaf4c17d51e

CI says no.

Gitlab CI is currently fairly red because of a clang build fix which hasn't made its way into master yet, but this job:

  https://gitlab.com/xen-project/patchew/xen/-/jobs/1349871230

shows a real failure on CentOS 7.

...
  [VERSION] bin/version.rtl8139.rom.o
  [AR] bin/blib.a
ar: creating bin/blib.a
objcopy: invalid option -- 'D'
Usage: objcopy [option(s)] in-file [out-file]
...

~Andrew

#2 lore raw

Please revert bf4ccd4265ac614fbfa38bf168b6eeaf4c17d51e in ipxe.git, CentOS 7 apparently fails to handle '-D'.

It worked in my testing with SLE12SP5 and SLE15SP3 as a base system.

See below.

I guess for xen.git, updating to just bf4ccd4265ac614fbfa38bf168b6eeaf4c17d51e^ will be good enough.

Olaf

Am Wed, 16 Jun 2021 13:33:52 +0100
schrieb Andrew Cooper <[email protected]>:

Quoted 41 lines · Olaf Hering
Quoted 15 lines

Use a snapshot which includes commit f3f568e382a5f19824b3bfc6081cde39eee661e8 ("[crypto] Add memory output constraints for big-integer inline assembly"), which fixes build with gcc11.

---
 tools/firmware/etherboot/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/firmware/etherboot/Makefile +0 -0
index ed9e11305f..23b3f6ca9d 100644

tools/firmware/etherboot/Makefile else · line 14

Quoted 6 lines
tools/firmware/etherboot/Makefile +2 -1
@@ -10,7 +10,8 @@ else
 IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git
 endif
 
-IPXE_GIT_TAG := 988d2c13cdf0f0b4140685af35ced70ac5b3283c
+# put an updated tar.gz on xenbits after changes to this variable
+IPXE_GIT_TAG := bf4ccd4265ac614fbfa38bf168b6eeaf4c17d51e

CI says no.

Gitlab CI is currently fairly red because of a clang build fix which hasn't made its way into master yet, but this job:

  https://gitlab.com/xen-project/patchew/xen/-/jobs/1349871230

shows a real failure on CentOS 7.

...
  [VERSION] bin/version.rtl8139.rom.o
  [AR] bin/blib.a
ar: creating bin/blib.a
objcopy: invalid option -- 'D'
Usage: objcopy [option(s)] in-file [out-file]
...

~Andrew

#3 lore raw

So this means, CentOS7 binutils has 9cb80f72d8b from 2011-12-21
but not
git blame binutils/objcopy.c|grep enable-determini
955d0b3bd75 (Roland McGrath 2013-01-07 17:40:59 +0000 549) -D
--enable-deterministic-archives\n\
2e30cb575a1 (Cary Coutant 2012-04-25 17:50:14 +0000 555) -D
--enable-deterministic-archives\n\

one way out could be to call objcopy -D $PARAMS || objcopy $PARAMS

Quoted 56 lines · Olaf Hering

Please revert bf4ccd4265ac614fbfa38bf168b6eeaf4c17d51e in ipxe.git, CentOS 7 apparently fails to handle '-D'.

It worked in my testing with SLE12SP5 and SLE15SP3 as a base system.

See below.

I guess for xen.git, updating to just bf4ccd4265ac614fbfa38bf168b6eeaf4c17d51e^ will be good enough.

Olaf

Am Wed, 16 Jun 2021 13:33:52 +0100
schrieb Andrew Cooper <[email protected]>:

Quoted 41 lines · Olaf Hering
Quoted 15 lines

Use a snapshot which includes commit f3f568e382a5f19824b3bfc6081cde39eee661e8 ("[crypto] Add memory output constraints for big-integer inline assembly"), which fixes build with gcc11.

---
 tools/firmware/etherboot/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/firmware/etherboot/Makefile +0 -0
index ed9e11305f..23b3f6ca9d 100644

tools/firmware/etherboot/Makefile else · line 14

Quoted 6 lines
tools/firmware/etherboot/Makefile +2 -1
@@ -10,7 +10,8 @@ else
 IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git
 endif
 
-IPXE_GIT_TAG := 988d2c13cdf0f0b4140685af35ced70ac5b3283c
+# put an updated tar.gz on xenbits after changes to this variable
+IPXE_GIT_TAG := bf4ccd4265ac614fbfa38bf168b6eeaf4c17d51e

CI says no.

Gitlab CI is currently fairly red because of a clang build fix which hasn't made its way into master yet, but this job:

  https://gitlab.com/xen-project/patchew/xen/-/jobs/1349871230

shows a real failure on CentOS 7.

...
  [VERSION] bin/version.rtl8139.rom.o
  [AR] bin/blib.a
ar: creating bin/blib.a
objcopy: invalid option -- 'D'
Usage: objcopy [option(s)] in-file [out-file]
...

~Andrew

#4 lore raw
Quoted 10 lines · Bernhard M. Wiedemann

So this means, CentOS7 binutils has 9cb80f72d8b from 2011-12-21
but not
git blame binutils/objcopy.c|grep enable-determini
955d0b3bd75 (Roland McGrath 2013-01-07 17:40:59 +0000 549) -D
--enable-deterministic-archives\n\
2e30cb575a1 (Cary Coutant 2012-04-25 17:50:14 +0000 555) -D
--enable-deterministic-archives\n\

one way out could be to call objcopy -D $PARAMS || objcopy $PARAMS

Testing on a clean "centos:7" container shows that "objcopy -D" works as expected (and "objcopy --help" shows the option as existing).

This container environment has /etc/centos-release showing:

CentOS Linux release 7.6.1810 (Core)

Could you provide a simple environment in which to reproduce the problem?

Thanks,

Michael

#5 lore raw
Quoted 9 lines · Michael Brown
Quoted 1 line

one way out could be to call objcopy -D $PARAMS || objcopy $PARAMS

Testing on a clean "centos:7" container shows that "objcopy -D" works as expected (and "objcopy --help" shows the option as existing).

This container environment has /etc/centos-release showing:

  CentOS Linux release 7.6.1810 (Core)

Could you provide a simple environment in which to reproduce the problem?

I've managed to reproduce it using "centos:7.0.1406". It should be fixed in commit

https://github.com/ipxe/ipxe/commit/51c88a4a6

Thanks for the report!

Michael