Skip to contentSkip to conversation

KVM: fix error handling in svm_cpu_init

PATCH RESEND Applied linmiaohe 2 participants 2 messages Feb 20, 2020 – Feb 21, 2020 KVM

lore
Share & tools
lore

linmiaohe

author
#0 lore raw
Quoted 10 lines · Li,Rongqing
Quoted 9 lines

Hi,

Quoted 2 lines · Li RongQing

sd->save_area should be freed in error path

Oh, it's strange. This is already fixed in my previous patch : [PATCH v2] KVM:
SVM: Fix potential memory leak in svm_cpu_init().
And Vitaly and Liran gave me Reviewed-by tags and Paolo queued it one month ago. But I can't found it in master or queue branch. There might be something wrong. :(

Quoted 8 lines

In fact, I send this patch 2019/02/, and get Reviewed-by, but did not queue

https://patchwork.kernel.org/patch/10853973/

and resend it 2019/07

https://patchwork.kernel.org/patch/11032081/

Oh, it's really a pit. And in this case, we can get rid of the var r as '-ENOMEM' is actually the only possible outcome here, as suggested by Vitaly, which looks like this: https://lkml.org/lkml/2020/1/15/933
Thanks. :)

maintainer Applied
#1 lore raw
Quoted 15 lines · linmiaohe
Quoted 14 lines · Li,Rongqing
Quoted 9 lines

Hi,

Quoted 2 lines · Li RongQing

sd->save_area should be freed in error path

Oh, it's strange. This is already fixed in my previous patch : [PATCH v2] KVM:
SVM: Fix potential memory leak in svm_cpu_init().
And Vitaly and Liran gave me Reviewed-by tags and Paolo queued it one month ago. But I can't found it in master or queue branch. There might be something wrong. :(

In fact, I send this patch 2019/02/, and get Reviewed-by, but did not queue

https://patchwork.kernel.org/patch/10853973/

Quoted 7 lines
Quoted 4 lines

and resend it 2019/07

https://patchwork.kernel.org/patch/11032081/

Oh, it's really a pit. And in this case, we can get rid of the var r as '-ENOMEM' is actually the only possible outcome here, as suggested by Vitaly, which looks like this: https://lkml.org/lkml/2020/1/15/933

I queued your patch again, sorry to both of you.

Paolo