Skip to contentSkip to conversation

dt-bindings: PCI: ti,j721e-pci-*: resolve unexpected property warnings

PATCH Superseded Matt Ranostay 3 participants 8 messages Sep 24, 2022 – Sep 29, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v2 cover dt-bindings: PCI: ti,j721e-pci-*: resolve unexpected property warnings

Resolve unexpected property warnings related to interrupts in both J721E PCI EP and host yaml files.

Changes from v1:
* Fix typo in commit message
* Add missing Cc to maintainers

Matt Ranostay (2):
dt-bindings: PCI: ti,j721e-pci-host: add interrupt controller
definition
dt-bindings: PCI: ti,j721e-pci-*: Add missing interrupt properties

 .../bindings/pci/ti,j721e-pci-ep.yaml         |  7 +++++++
 .../bindings/pci/ti,j721e-pci-host.yaml       | 20 +++++++++++++++++++
 2 files changed, 27 insertions(+)
Signature · 1 line
2.38.0.rc0.52.gdda7228a83
#1 lore raw

PATCH v2 1/2 dt-bindings: PCI: ti,j721e-pci-host: add interrupt controller definition

Add missing 'interrupt-controller' property and related subnodes to resolve the following warning:

arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: pcie@2910000: Unevaluated properties are not allowed ('interrupt-controller' was unexpected)
From schema: Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml

---
 .../devicetree/bindings/pci/ti,j721e-pci-host.yaml  | 13 +++++++++++++
 1 file changed, 13 insertions(+)
Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml +13 -0
index 2115d5a3f0e1..0f5914a22c14 100644
@@ -76,6 +76,19 @@ properties:
 
   msi-map: true
 
+  interrupt-controller:
+    type: object
+    additionalProperties: false
+
+    properties:
+      interrupt-controller: true
+
+      '#interrupt-cells':
+        const: 1
+
+      interrupts:
+        maxItems: 1
+
 required:
   - compatible
   - reg
Signature · 1 line
2.38.0.rc0.52.gdda7228a83
maintainer Acked-by on v2 1/2
#2 lore raw

Re: [PATCH v2 1/2] dt-bindings: PCI: ti,j721e-pci-host: add interrupt controller definition

Quoted 11 lines · Matt Ranostay

Add missing 'interrupt-controller' property and related subnodes to resolve the following warning:

arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: pcie@2910000: Unevaluated properties are not allowed ('interrupt-controller' was unexpected)
From schema: Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml

---
 .../devicetree/bindings/pci/ti,j721e-pci-host.yaml  | 13 +++++++++++++
 1 file changed, 13 insertions(+)
#3 lore raw

PATCH v2 2/2 dt-bindings: PCI: ti,j721e-pci-*: Add missing interrupt properties

In reply to Matt Ranostay

Both interrupts, and interrupt names weren't defined in both EP and host yaml. Also define the only possible interrupt-name as link_state, and maxItems of interrupts to one.

This patch resolves the following warning:

arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: pcie-ep@2910000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected)
From schema Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml

---
 Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml | 7 +++++++
 .../devicetree/bindings/pci/ti,j721e-pci-host.yaml         | 7 +++++++
 2 files changed, 14 insertions(+)
Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml +7 -0
index aed437dac363..10e6eabdff53 100644
@@ -58,6 +58,13 @@ properties:
   dma-coherent:
     description: Indicates that the PCIe IP block can ensure the coherency
 
+  interrupts:
+    maxItems: 1
+
+  interrupt-names:
+    items:
+      - const: link_state
+
 required:
   - compatible
   - reg
Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml +7 -0
index 0f5914a22c14..d9df7cd922f1 100644
@@ -76,6 +76,13 @@ properties:
 
   msi-map: true
 
+  interrupts:
+    maxItems: 1
+
+  interrupt-names:
+    items:
+      - const: link_state
+
   interrupt-controller:
     type: object
     additionalProperties: false
Signature · 1 line
2.38.0.rc0.52.gdda7228a83
maintainer Acked-by on v2 2/2
#4 lore raw

Re: [PATCH v2 2/2] dt-bindings: PCI: ti,j721e-pci-*: Add missing interrupt properties

Quoted 6 lines · Matt Ranostay

Both interrupts, and interrupt names weren't defined in both EP and host yaml. Also define the only possible interrupt-name as link_state, and maxItems of interrupts to one.

This patch resolves the following warning:

Quoted 9 lines

arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: pcie-ep@2910000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected)
From schema Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml

---
 Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml | 7 +++++++
 .../devicetree/bindings/pci/ti,j721e-pci-host.yaml         | 7 +++++++
 2 files changed, 14 insertions(+)
#5 lore raw
In reply to Matt Ranostay
Quoted 3 lines · Matt Ranostay

Resolve unexpected property warnings related to interrupts in both J721E PCI EP and host yaml files.

Thanks for cc-ing. On what tree do you base your patch? Looks like something old. If so, you need to rebase to some recent kernel.

Best regards,
Krzysztof

#6 lore raw
Quoted 8 lines · Krzysztof Kozlowski
Quoted 3 lines · Matt Ranostay

Resolve unexpected property warnings related to interrupts in both J721E PCI EP and host yaml files.

Thanks for cc-ing. On what tree do you base your patch? Looks like something old. If so, you need to rebase to some recent kernel.

It was on linux-next from Sep 23rd. So would seem odd if the rebasing seems from an older tree.

- Matt

Quoted 3 lines

Best regards,
Krzysztof

#7 lore raw
Quoted 6 lines · Matt Ranostay
Quoted 5 lines · Krzysztof Kozlowski
Quoted 3 lines · Matt Ranostay

Resolve unexpected property warnings related to interrupts in both J721E PCI EP and host yaml files.

Quoted 6 lines
Quoted 3 lines

Thanks for cc-ing. On what tree do you base your patch? Looks like something old. If so, you need to rebase to some recent kernel.

It was on linux-next from Sep 23rd. So would seem odd if the rebasing seems from an older tree.

That's good, but then why you did not use scripts/get_maintainers.pl as I asked...

Best regards,
Krzysztof