Skip to contentSkip to conversation

system: Enable the device aliases for or1k, too

PATCH In review Thomas Huth 2 participants 3 messages Jul 5, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 system: Enable the device aliases for or1k, too

Now that we've got a "virt" machine for or1k that supports PCI, too, we can also enable the virtio device aliases like we do on other similar platforms. This will e.g. help to run the iotests with qemu-system-or1k later.

While we're at it, sort QEMU_ARCH_LOONGARCH alphabetically into the list.

---
 system/qdev-monitor.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
system/qdev-monitor.c +3 -3
index 6af6ef7d66..60c3b6ad96 100644
@@ -57,10 +57,10 @@ typedef struct QDevAlias
 /* default virtio transport per architecture */
 #define QEMU_ARCH_VIRTIO_PCI (QEMU_ARCH_ALPHA | QEMU_ARCH_ARM | \
                               QEMU_ARCH_HPPA | QEMU_ARCH_I386 | \
-                              QEMU_ARCH_MIPS | QEMU_ARCH_PPC |  \
+                              QEMU_ARCH_LOONGARCH | QEMU_ARCH_MIPS | \
+                              QEMU_ARCH_OPENRISC | QEMU_ARCH_PPC | \
                               QEMU_ARCH_RISCV | QEMU_ARCH_SH4 | \
-                              QEMU_ARCH_SPARC | QEMU_ARCH_XTENSA | \
-                              QEMU_ARCH_LOONGARCH)
+                              QEMU_ARCH_SPARC | QEMU_ARCH_XTENSA)
 #define QEMU_ARCH_VIRTIO_CCW (QEMU_ARCH_S390X)
 #define QEMU_ARCH_VIRTIO_MMIO (QEMU_ARCH_M68K)
 
Signature · 1 line
2.45.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Thomas Huth

Now that we've got a "virt" machine for or1k that supports PCI, too, we can also enable the virtio device aliases like we do on other similar platforms. This will e.g. help to run the iotests with qemu-system-or1k later.

Indeed, since 2022 in commit 40fef82c4e ("hw/openrisc:
Add PCI bus support to virt").

Quoted 3 lines

While we're at it, sort QEMU_ARCH_LOONGARCH alphabetically into the list.

Suggestion: a preliminary patch sorting 1 arch per line ;)

Quoted 4 lines
---
  system/qdev-monitor.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
#2 lore raw
Quoted 6 lines · Philippe Mathieu-Daudé
Quoted 4 lines · Thomas Huth

Now that we've got a "virt" machine for or1k that supports PCI, too, we can also enable the virtio device aliases like we do on other similar platforms. This will e.g. help to run the iotests with qemu-system-or1k later.

Quoted 8 lines

Indeed, since 2022 in commit 40fef82c4e ("hw/openrisc:
Add PCI bus support to virt").

Quoted 3 lines

While we're at it, sort QEMU_ARCH_LOONGARCH alphabetically into the list.

Suggestion: a preliminary patch sorting 1 arch per line ;)

Done here:
https://lore.kernel.org/qemu-devel/[email protected]/

Quoted 8 lines
Quoted 5 lines

---
  system/qdev-monitor.c | 6 +++---

  1 file changed, 3 insertions(+), 3 deletions(-)