Skip to contentSkip to conversation

Documentation: fix spelling mistake "Minumum" -> "Minimum"

PATCH In review Ninad Naik 4 participants 5 messages Apr 19 – Apr 20

Subsystems (4)
lore
Share & tools
lore

Ninad Naik

author
#0 lore raw

PATCH 1/1 Documentation: fix spelling mistake "Minumum" -> "Minimum"

There is a spelling mistake in Documentation/wmi/devices/lenovo-wmi-other.rst. Fixing it.

---
 Documentation/wmi/devices/lenovo-wmi-other.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/wmi/devices/lenovo-wmi-other.rst +1 -1
index 01d471156738..1d0410500d3f 100644
@@ -144,5 +144,5 @@ data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility:
     [WmiDataId(1), read, Description("Mode.")] uint32 NumOfFans;
     [WmiDataId(2), read, Description("Fan ID."), WmiSizeIs("NumOfFans")] uint32 FanId[];
     [WmiDataId(3), read, Description("Maximum Fan Speed."), WmiSizeIs("NumOfFans")] uint32 FanMaxSpeed[];
-    [WmiDataId(4), read, Description("Minumum Fan Speed."), WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
+    [WmiDataId(4), read, Description("Minimum Fan Speed."), WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
   };
Signature · 1 line
2.53.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines · Ninad Naik

There is a spelling mistake in Documentation/wmi/devices/lenovo-wmi-other.rst. Fixing it.

---
 Documentation/wmi/devices/lenovo-wmi-other.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/wmi/devices/lenovo-wmi-other.rst +0 -0
index 01d471156738..1d0410500d3f 100644
@@ -144,5 +144,5 @@ data using the `bmfdec 

<https://github.com/pali/bmfdec>`_ utility:

     [WmiDataId(1), read, Description("Mode.")] uint32 NumOfFans;
     [WmiDataId(2), read, Description("Fan ID."), 
Quoted 10 lines

WmiSizeIs("NumOfFans")] uint32 FanId[];
[WmiDataId(3), read, Description("Maximum Fan Speed."),
WmiSizeIs("NumOfFans")] uint32 FanMaxSpeed[];
- [WmiDataId(4), read, Description("Minumum Fan Speed."),
WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
+ [WmiDataId(4), read, Description("Minimum Fan Speed."),

WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
   };
Signature · 1 line
2.53.0

Looks good.

maintainer
#2 lore raw
Quoted 31 lines · Mark Pearson
Quoted 17 lines · Ninad Naik

There is a spelling mistake in Documentation/wmi/devices/lenovo-wmi-other.rst. Fixing it.

---
 Documentation/wmi/devices/lenovo-wmi-other.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/wmi/devices/lenovo-wmi-other.rst +0 -0
index 01d471156738..1d0410500d3f 100644
@@ -144,5 +144,5 @@ data using the `bmfdec 

<https://github.com/pali/bmfdec>`_ utility:

     [WmiDataId(1), read, Description("Mode.")] uint32 NumOfFans;
     [WmiDataId(2), read, Description("Fan ID."), 
Quoted 10 lines

WmiSizeIs("NumOfFans")] uint32 FanId[];
[WmiDataId(3), read, Description("Maximum Fan Speed."),
WmiSizeIs("NumOfFans")] uint32 FanMaxSpeed[];
- [WmiDataId(4), read, Description("Minumum Fan Speed."),
WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
+ [WmiDataId(4), read, Description("Minimum Fan Speed."),

WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
   };
Signature · 1 line
2.53.0

Looks good.

Quoted 1 line

Hi gents,

The MOF spelling mistakes are well known. We've left them is as to ensure match with what the hardware actually reports.

See: https://lore.kernel.org/platform-driver-x86/[email protected]

I suppose if we're going to continue getting these types or PR I should add a note to the documentation. I'll add that soon.

Thanks,
Derek

maintainer
#3 lore raw
Quoted 7 lines · Derek J. Clark

The MOF spelling mistakes are well known. We've left them is as to ensure match with what the hardware actually reports.

See: https://lore.kernel.org/platform-driver-x86/[email protected]

I suppose if we're going to continue getting these types or PR I should add a note to the documentation. I'll add that soon.

Perhaps worth adding, but I'm not sure I would expect it to help. The people generating these patches aren't putting much attention into the context surrounding them.

Thanks,

jon

maintainer
#4 lore raw
Quoted 5 lines · Jonathan Corbet
Quoted 3 lines · Derek J. Clark

The MOF spelling mistakes are well known. We've left them is as to ensure match with what the hardware actually reports.

Quoted 9 lines
Quoted 4 lines

See: https://lore.kernel.org/platform-driver-x86/[email protected]

I suppose if we're going to continue getting these types or PR I should add a note to the documentation. I'll add that soon.

Perhaps worth adding, but I'm not sure I would expect it to help. The people generating these patches aren't putting much attention into the context surrounding them.

I'd forgotten that previous discussion - sorry.

Part of the problem (I know I had this many years ago when I got started) is being told the best way to get involved in kernel development and learn the process is to find small things to fix (spelling mistakes, documentation, comments etc). I suspect that's accelerated with AI identifying them too :)

What if we fix the typo, and add a comment highlighting that the vendor documentation/MOF/whatever is wrong? Then everybody is 'happy'? (or at least we'll get less emails about it)

Mark