Skip to contentSkip to conversation

tmpfs: support for file creation time

PATCH Superseded Xavier Roche 4 participants 6 messages Feb 11, 2022 – Mar 14, 2022

Subsystems (2)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tmpfs: support for file creation time

Various filesystems (including ext4) now support file creation time. This patch adds such support for tmpfs-based filesystems.

---
 include/linux/shmem_fs.h |  1 +
 mm/shmem.c               | 11 +++++++++++
 2 files changed, 12 insertions(+)
include/linux/shmem_fs.h +1 -0
index e65b80ed09e7..29787767c3b9 100644
@@ -25,6 +25,7 @@ struct shmem_inode_info {
 	struct simple_xattrs	xattrs;		/* list of xattrs */
 	atomic_t		stop_eviction;	/* hold when working on inode */
 	struct inode		vfs_inode;
+	struct timespec64	i_crtime;	/* file creation time */
 };
 
 struct shmem_sb_info {
mm/shmem.c +11 -0
index a09b29ec2b45..5a3907712c4f 100644
@@ -1061,6 +1061,12 @@ static int shmem_getattr(struct user_namespace *mnt_userns,
 	if (shmem_is_huge(NULL, inode, 0))
 		stat->blksize = HPAGE_PMD_SIZE;
 
+	if ((request_mask & STATX_BTIME)) {
+		stat->result_mask |= STATX_BTIME;
+		stat->btime.tv_sec = info->i_crtime.tv_sec;
+		stat->btime.tv_nsec = info->i_crtime.tv_nsec;
+	}
+
 	return 0;
 }
 
@@ -2265,6 +2271,7 @@ static struct inode *shmem_get_inode(struct super_block *sb, const struct inode
 		atomic_set(&info->stop_eviction, 0);
 		info->seals = F_SEAL_SEAL;
 		info->flags = flags & VM_NORESERVE;
+		info->i_crtime = inode->i_mtime;
 		INIT_LIST_HEAD(&info->shrinklist);
 		INIT_LIST_HEAD(&info->swaplist);
 		simple_xattrs_init(&info->xattrs);
@@ -3196,6 +3203,7 @@ static ssize_t shmem_listxattr(struct dentry *dentry, char *buffer, size_t size)
 #endif /* CONFIG_TMPFS_XATTR */
 
 static const struct inode_operations shmem_short_symlink_operations = {
+	.getattr	= shmem_getattr,
 	.get_link	= simple_get_link,
 #ifdef CONFIG_TMPFS_XATTR
 	.listxattr	= shmem_listxattr,
@@ -3203,6 +3211,7 @@ static const struct inode_operations shmem_short_symlink_operations = {
 };
 
 static const struct inode_operations shmem_symlink_inode_operations = {
+	.getattr	= shmem_getattr,
 	.get_link	= shmem_get_link,
 #ifdef CONFIG_TMPFS_XATTR
 	.listxattr	= shmem_listxattr,
@@ -3790,6 +3799,7 @@ static const struct inode_operations shmem_inode_operations = {
 
 static const struct inode_operations shmem_dir_inode_operations = {
 #ifdef CONFIG_TMPFS
+	.getattr	= shmem_getattr,
 	.create		= shmem_create,
 	.lookup		= simple_lookup,
 	.link		= shmem_link,
@@ -3811,6 +3821,7 @@ static const struct inode_operations shmem_dir_inode_operations = {
 };
 
 static const struct inode_operations shmem_special_inode_operations = {
+	.getattr	= shmem_getattr,
 #ifdef CONFIG_TMPFS_XATTR
 	.listxattr	= shmem_listxattr,
 #endif
Signature · 1 line
2.25.1
maintainer
#1 lore raw

PATCH 1/1 tmpfs: three tweaks to creation time patch

Thank you to Xavier Roche for his tmpfs file creation time patch. Please apply these 3 tweaks on top (and fold in when sending to Linus):

1. Move vfs_inode back to being last element of shmem_inode_info.
2. Remove unnecessary parentheses from condition in shmem_getattr().
3. Using shmem_getattr() on other file types than regular requires that shmem_is_huge() check type, to stop incorrect HPAGE_PMD_SIZE blksize.

---
Cleanups and fix to tmpfs-support-for-file-creation-time.patch

 include/linux/shmem_fs.h |    2 +-
 mm/shmem.c               |    7 +++----
 2 files changed, 4 insertions(+), 5 deletions(-)
include/linux/shmem_fs.h +1 -1
@@ -24,8 +24,8 @@ struct shmem_inode_info {
 	struct shared_policy	policy;		/* NUMA memory alloc policy */
 	struct simple_xattrs	xattrs;		/* list of xattrs */
 	atomic_t		stop_eviction;	/* hold when working on inode */
-	struct inode		vfs_inode;
 	struct timespec64	i_crtime;	/* file creation time */
+	struct inode		vfs_inode;
 };
 
 struct shmem_sb_info {
mm/shmem.c +3 -4
@@ -476,6 +476,8 @@ bool shmem_is_huge(struct vm_area_struct
 {
 	loff_t i_size;
 
+	if (!S_ISREG(inode->i_mode))
+		return false;
 	if (shmem_huge == SHMEM_HUGE_DENY)
 		return false;
 	if (vma && ((vma->vm_flags & VM_NOHUGEPAGE) ||
@@ -1061,7 +1063,7 @@ static int shmem_getattr(struct user_nam
 	if (shmem_is_huge(NULL, inode, 0))
 		stat->blksize = HPAGE_PMD_SIZE;
 
-	if ((request_mask & STATX_BTIME)) {
+	if (request_mask & STATX_BTIME) {
 		stat->result_mask |= STATX_BTIME;
 		stat->btime.tv_sec = info->i_crtime.tv_sec;
 		stat->btime.tv_nsec = info->i_crtime.tv_nsec;
@@ -1860,9 +1862,6 @@ repeat:
 		return 0;
 	}
 
-	/* Never use a huge page for shmem_symlink() */
-	if (S_ISLNK(inode->i_mode))
-		goto alloc_nohuge;
 	if (!shmem_is_huge(vma, inode, index))
 		goto alloc_nohuge;
 
#2 lore raw
In reply to Xavier Roche
Quoted 3 lines · Xavier Roche

Various filesystems (including ext4) now support file creation time. This patch adds such support for tmpfs-based filesystems.

What's the odd huge-page noise in this patch?

Other oddities:

    Reply-To: [email protected]

WHAT?

And finally - if we really want to treat btime as a first-class entity and expect things like tmpfs to support it, then we should just bite the bullet and put it in 'struct inode' along with the other times.

Linus

maintainer
#3 lore raw
Quoted 6 lines · On Wed, 2 Mar 2022 11:43:02 -0800 Linus Torvalds…
Quoted 3 lines · Xavier Roche

Various filesystems (including ext4) now support file creation time. This patch adds such support for tmpfs-based filesystems.

What's the odd huge-page noise in this patch?

I can't see such changes?

This v3 patch is the v2 patch plus Hugh's changes
(https://lkml.kernel.org/r/[email protected]).

I won't be merging v3 because this changelog lacks appropriate decription of Hugh's changes and lacks a Link: tag to Hugh's change.

maintainer
#4 lore raw
In reply to Linus Torvalds
Quoted 4 lines · Linus Torvalds
Quoted 3 lines · Xavier Roche

Various filesystems (including ext4) now support file creation time. This patch adds such support for tmpfs-based filesystems.

Please ignore this patch for now: I presume Xavier did not understand the "from akpm to Linus in next merge window" flow, and thought he had to resend the patch to you.

Quoted 2 lines

What's the odd huge-page noise in this patch?

That was one of the fixups I added, which akpm is holding in a -fix patch to be merged in, and maybe he'll include my comment from it:

3. Using shmem_getattr() on other file types than regular requires that shmem_is_huge() check type, to stop incorrect HPAGE_PMD_SIZE blksize.

(shmem_getattr() was only on regular files before: Xavier's patch added it to directories etc, to provide btime for them too; but shmem_getattr() can also include a dubious adjustment to blksize.)

Quoted 6 lines

Other oddities:

    Reply-To: [email protected]

WHAT?

No comment from me.

Quoted 4 lines

And finally - if we really want to treat btime as a first-class entity and expect things like tmpfs to support it, then we should just bite the bullet and put it in 'struct inode' along with the other times.

I've no objection if someone does that later. I've no investment in btime myself (my instinctive reaction was, is this thing worth another 16 bytes of inode space?), but Xavier thought it worth doing, and Andrew worth taking, so go with the flow.

Ah, Andrew has replied meanwhile, I hope I'm not contradicting!

Hugh

#5 lore raw
Quoted 3 lines · Hugh Dickins

Please ignore this patch for now: I presume Xavier did not understand the "from akpm to Linus in next merge window" flow, and thought he had to resend the patch to you.

I will resend a fixed v4 version in a moment, sorry for the noise (and I indeed did not fully understand the flow).

Quoted 4 lines
Quoted 3 lines

And finally - if we really want to treat btime as a first-class entity and expect things like tmpfs to support it, then we should just bite the bullet and put it in 'struct inode' along with the other times.

I've no objection if someone does that later.

I might give it a try if this is something that can be of interest.

The idea of having btime in 'struct inode' would make the btime a first-class citizen, allowing to have more consistent (w.r.t filesystem types) behavior.

This would also mean allowing to _change_ it, typically to allow archivers to set the creation time as they do for {a,c,m}time.

Currently, birth time semantic is bound to the current filesystem's life cycle and as such is irrelevant after a restore, or a 'tar xf'.

The only gray area to me is whether or not we "can" always change this property without unforeseen consequences, typically for ext4.