Skip to contentSkip to conversation

Disable frame buffer compression on ironlake

PATCH Applied Alex,Shi 3 participants 4 messages Nov 19, 2010

Subsystems (2)
lore
Share & tools
lore

Alex,Shi

author
#0 lore raw

PATCH 1/1 Disable frame buffer compression on ironlake

Open fbc will cause about 1 Watts power increase on ironlake for bltk-office/player benchmark. So just disable it and left code here to waiting for better solution.

---
 drivers/gpu/drm/i915/i915_drv.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/i915/i915_drv.c +1 -1
index 80745f8..029af7a 100644
@@ -150,7 +150,7 @@ static const struct intel_device_info intel_ironlake_d_info = {
 
 static const struct intel_device_info intel_ironlake_m_info = {
 	.gen = 5, .is_mobile = 1,
-	.need_gfx_hws = 1, .has_fbc = 1, .has_rc6 = 1, .has_hotplug = 1,
+	.need_gfx_hws = 1, .has_fbc = 0, .has_rc6 = 1, .has_hotplug = 1,
 	.has_bsd_ring = 1,
 };
 
Signature · 1 line
1.7.0
#1 lore raw
Quoted 3 lines · Alex,Shi

Open fbc will cause about 1 Watts power increase on ironlake for bltk-office/player benchmark. So just disable it and left code here to waiting for better solution.

FBC is disabled through the chicken bits, so I am really curious to know where the power saving is coming from. I just want to verify that we have not made a fundamental mistake in our FBC logic that is consuming more power than is necessary across all platforms.

In terms of code clarity, we should leave a note as to why we explicitly disable fbc, e.g.: .has_fbc = 0, /* hardware support is buggy */ -Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#2 lore raw
Quoted 5 lines · On Fri, 19 Nov 2010 08:47:27 +0000 Chris Wilson <[email protected]>…
Quoted 3 lines · Alex,Shi

Open fbc will cause about 1 Watts power increase on ironlake for bltk-office/player benchmark. So just disable it and left code here to waiting for better solution.

Quoted 7 lines

FBC is disabled through the chicken bits, so I am really curious to know where the power saving is coming from. I just want to verify that we have not made a fundamental mistake in our FBC logic that is consuming more power than is necessary across all platforms.

In terms of code clarity, we should leave a note as to why we explicitly disable fbc, e.g.: .has_fbc = 0, /* hardware support is buggy */

Did we disable the whole thing with chicken bits? I thought we only disabled some aspects of FBC that were known buggy. AFAIK it should generally work on ILK. You can assign the bug to me, I'll take a look.

Thanks,

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
Applied
#3 lore raw
In reply to Alex,Shi
Quoted 3 lines · Alex,Shi

Open fbc will cause about 1 Watts power increase on ironlake for bltk-office/player benchmark. So just disable it and left code here to waiting for better solution.

I applied a slightly modified patch to -fixes, thanks. -Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre