Skip to contentSkip to conversation

kbd-state: don't block auto-repeat events

PATCH In review Gerd Hoffmann 3 participants 3 messages Feb 20, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbd-state: don't block auto-repeat events

---
 ui/kbd-state.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)
ui/kbd-state.c +10 -6
index ac14add70e..09e3cfedfc 100644
@@ -42,14 +42,18 @@ void qkbd_state_key_event(QKbdState *kbd, QKeyCode qcode, bool down)
 {
     bool state = test_bit(qcode, kbd->keys);
 
-    if (state == down) {
+    if (down == false  /* got key-up event   */ &&
+        state == false /* key is not pressed */) {
         /*
-         * Filter out events which don't change the keyboard state.
+         * Filter out suspious key-up events.
          *
-         * Most notably this allows to simply send along all key-up
-         * events, and this function will filter out everything where
-         * the corresponding key-down event wasn't send to the guest,
-         * for example due to being a host hotkey.
+         * This allows to simply send along all key-up events, and
+         * this function will filter out everything where the
+         * corresponding key-down event wasn't send to the guest, for
+         * example due to being a host hotkey.
+         *
+         * Note that key-down events on already pressed keys are *not*
+         * suspious, those are keyboard autorepeat events.
          */
         return;
     }
Signature · 1 line
2.9.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Gerd Hoffmann
---
 ui/kbd-state.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#2 lore raw
In reply to Gerd Hoffmann
Quoted 10 lines · Gerd Hoffmann
---
 ui/kbd-state.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)
ui/kbd-state.c +0 -0
index ac14add70e..09e3cfedfc 100644

ui/kbd-state.c void qkbd_state_key_event(QKbdState *kbd, QKeyCode qcode, bool down) · line 48

Quoted 9 lines
ui/kbd-state.c +3 -2
@@ -42,14 +42,18 @@ void qkbd_state_key_event(QKbdState *kbd, QKeyCode qcode, bool down)
 {
     bool state = test_bit(qcode, kbd->keys);
 
-    if (state == down) {
+    if (down == false  /* got key-up event   */ &&
+        state == false /* key is not pressed */) {
         /*
-         * Filter out events which don't change the keyboard state.
+         * Filter out suspious key-up events.

s/suspious/suspicious/

ui/kbd-state.c void qkbd_state_key_event(QKbdState *kbd, QKeyCode qcode, bool down) · line 50

Quoted 6 lines
ui/kbd-state.c +1 -4
          *
-         * Most notably this allows to simply send along all key-up
-         * events, and this function will filter out everything where
-         * the corresponding key-down event wasn't send to the guest,
-         * for example due to being a host hotkey.
+         * This allows to simply send along all key-up events, and

"allows to ${VERB}" is not idiomatic; it should either be "allows ${SUBJECT} to ${VERB}" or "allows ${VERB}ing". In this case, I'd go with:

Most notably, this allows simply sneding along all key-up events

ui/kbd-state.c void qkbd_state_key_event(QKbdState *kbd, QKeyCode qcode, bool down) · line 52

Quoted 2 lines
ui/kbd-state.c +2 -0
+         * this function will filter out everything where the
+         * corresponding key-down event wasn't send to the guest, for

s/send/sent/

ui/kbd-state.c void qkbd_state_key_event(QKbdState *kbd, QKeyCode qcode, bool down) · line 56

Quoted 4 lines
ui/kbd-state.c +4 -0
+         * example due to being a host hotkey.
+         *
+         * Note that key-down events on already pressed keys are *not*
+         * suspious, those are keyboard autorepeat events.

s/suspious/suspicious/

Quoted 4 lines
ui/kbd-state.c +0 -0
          */
         return;
     }
Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org